189148 2018-08-29 23:38:23 -0700 WKNavigation.ProcessCrashDuringCallback is failing on iOS 2018-11-16 19:36:12 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=191783 InRadar P2 Normal --- 189037 1 sihui_liu sihui_liu cdumez commit-queue lforschler webkit-bug-importer oldest_to_newest 1455171 0 sihui_liu 2018-08-29 23:38:23 -0700 From https://bugs.webkit.org/show_bug.cgi?id=189037, we know: 1. Errors can occur in completion handler of [webView _getContentsAsStringWithCompletionHandler] because web processes are killed. So we should just keep the change of expectation in 189037. 2. webView can be destroyed before web process exits, as we receive an error WKErrorWebViewInvalidated instead of WKErrorWebContentProcessTerminated. So we need to remove "webView = nullptr;". 1455174 1 348488 sihui_liu 2018-08-29 23:50:11 -0700 Created attachment 348488 Patch 1455254 2 348488 commit-queue 2018-08-30 10:03:09 -0700 Comment on attachment 348488 Patch Clearing flags on attachment: 348488 Committed r235509: <https://trac.webkit.org/changeset/235509> 1455255 3 commit-queue 2018-08-30 10:03:10 -0700 All reviewed patches have been landed. Closing bug. 1455708 4 webkit-bug-importer 2018-08-31 08:56:58 -0700 <rdar://problem/43941972> 348488 2018-08-29 23:50:11 -0700 2018-08-30 10:03:09 -0700 Patch bug-189148-20180829235010.patch text/plain 1587 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1NDkwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggM2FkNjc3MmE4YTA3YjVlYTY4MTllN2JiNTBiZjZlN2Jh NjZlZmQ5OS4uODUwNjA1NzI3ZWQxMDVlYzFlNjU4MDZkNDQzZDExZDkxNWQ0MWZiNSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE4LTA4LTI5ICBTaWh1aSBMaXUgIDxzaWh1aV9saXVAYXBwbGUuY29tPgorCisgICAg ICAgIFdLTmF2aWdhdGlvbi5Qcm9jZXNzQ3Jhc2hEdXJpbmdDYWxsYmFjayBpcyBmYWlsaW5nIG9u IGlPUworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg5 MTQ4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2Ug c2hvdWxkIG5vdCBkZWZlcmVuY2UgV2ViVmlldyBvciB3ZSBtYXkgZ2V0IFdLRXJyb3JXZWJWaWV3 SW52YWxpZGF0ZWQgZXJyb3IsIGJlY2F1c2UgCisgICAgICAgIFdlYlZpZXcgY291bGQgYmUgZGVz dHJveWVkIGJlZm9yZSBXZWIgUHJvY2VzcyB0ZXJtaW5hdGlvbiBpcyBub3RpY2VkLgorCisgICAg ICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9XZWJDb250ZW50UHJvY2Vzc0Rp ZFRlcm1pbmF0ZS5tbToKKyAgICAgICAgKFRFU1QpOgorCiAyMDE4LTA4LTI5ICBKZXIgTm9ibGUg IDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgdGVzdCBnYXJkZW5p bmc7IE5vd1BsYXlpbmdUZXN0IEFQSSB0ZXN0cyByZXF1aXJlIEhpZ2ggU2llcnJhLgpkaWZmIC0t Z2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9XZWJDb250ZW50UHJv Y2Vzc0RpZFRlcm1pbmF0ZS5tbSBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29j b2EvV2ViQ29udGVudFByb2Nlc3NEaWRUZXJtaW5hdGUubW0KaW5kZXggNmJkZDUzMjY2NDg1OWM4 NTRjZjQ0ZjJjYTU0ZTI1MzVjOTMxNDFiMy4uY2Q4YmFiOGJiMzhhNWFhN2VlNTQ0NzNlMTRhOTJh MTFjYzA1Y2E1OCAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRD b2NvYS9XZWJDb250ZW50UHJvY2Vzc0RpZFRlcm1pbmF0ZS5tbQorKysgYi9Ub29scy9UZXN0V2Vi S2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1dlYkNvbnRlbnRQcm9jZXNzRGlkVGVybWluYXRlLm1t CkBAIC0yNzUsOCArMjc1LDYgQEAgVEVTVChXS05hdmlnYXRpb24sIFByb2Nlc3NDcmFzaER1cmlu Z0NhbGxiYWNrKQogICAgIC8vIFNpbXVsYXRlIGEgY3Jhc2gsIHdoaWNoIHNob3VsZCBpbnZhbGlk YXRlIGFsbCBwZW5kaW5nIGNhbGxiYWNrcy4KICAgICBbd2ViVmlldyBfa2lsbFdlYkNvbnRlbnRQ cm9jZXNzXTsKIAotICAgIHdlYlZpZXcgPSBudWxscHRyOwotCiAgICAgVGVzdFdlYktpdEFQSTo6 VXRpbDo6cnVuKCZjYWxsZWRBbGxDYWxsYmFja3MpOwogICAgIFRlc3RXZWJLaXRBUEk6OlV0aWw6 OnNsZWVwKDAuNSk7CiAgICAgRVhQRUNUX0VRKDZVLCBjYWxsYmFja0NvdW50KTsK