189132 2018-08-29 17:15:43 -0700 Add some missing exception checks in JSRopeString::resolveRopeToAtomicString(). 2018-08-29 18:21:32 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller msaboff saam webkit-bug-importer oldest_to_newest 1455049 0 mark.lam 2018-08-29 17:15:43 -0700 <rdar://problem/42513068> 1455067 1 348454 mark.lam 2018-08-29 17:26:30 -0700 Created attachment 348454 proposed patch. 1455088 2 mark.lam 2018-08-29 18:21:32 -0700 Thanks for the review. Landed in r235491: <http://trac.webkit.org/r235491>. 348454 2018-08-29 17:26:30 -0700 2018-08-29 17:28:04 -0700 proposed patch. bug-189132.patch text/plain 3436 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMzU0ODgpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE4LTA4LTI5ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBBZGQgc29tZSBtaXNzaW5nIGV4Y2VwdGlvbiBjaGVja3MgaW4gSlNSb3Bl U3RyaW5nOjpyZXNvbHZlUm9wZVRvQXRvbWljU3RyaW5nKCkuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODkxMzIKKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzQyNTEzMDY4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogc3RyZXNzL3JlZ3Jlc3MtMTg5MTMyLmpzOiBBZGRlZC4KKwogMjAxOC0wOC0yNyAg WXVzdWtlIFN1enVraSAgPHl1c3VrZXN1enVraUBzbG93c3RhcnQub3JnPgogCiAgICAgICAgIFtX ZWJBc3NlbWJseV0gUGFyc2Ugd2FzbSBtb2R1bGVzIGluIGEgc3RyZWFtaW5nIGZhc2hpb24KSW5k ZXg6IEpTVGVzdHMvc3RyZXNzL3JlZ3Jlc3MtMTg5MTMyLmpzCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVz dHMvc3RyZXNzL3JlZ3Jlc3MtMTg5MTMyLmpzCShub25leGlzdGVudCkKKysrIEpTVGVzdHMvc3Ry ZXNzL3JlZ3Jlc3MtMTg5MTMyLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMTIgQEAKK3Ry eSB7CisgICAgdmFyIGEwID0gJ1x1ZDgwMSc7CisgICAgdmFyIGExID0gW107CisgICAgYTIgPSBh MC5wYWRFbmQoMjE0NzQ4MzY0NCwneCcpOworICAgIGExW2EyXTsKK30gY2F0Y2ggKGUpIHsKKyAg ICBleGNlcHRpb24gPSBlOworfQorCitpZiAoZXhjZXB0aW9uICE9ICJFcnJvcjogT3V0IG9mIG1l bW9yeSIpCisgICAgdGhyb3cgIkZBSUxFRCI7CisKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxv ZwkocmV2aXNpb24gMjM1NDg4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwko d29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE4LTA4LTI5ICBNYXJrIExhbSAgPG1h cmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgc29tZSBtaXNzaW5nIGV4Y2VwdGlvbiBj aGVja3MgaW4gSlNSb3BlU3RyaW5nOjpyZXNvbHZlUm9wZVRvQXRvbWljU3RyaW5nKCkuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODkxMzIKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzQyNTEzMDY4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogcnVudGltZS9KU0NKU1ZhbHVlSW5saW5lcy5oOgorICAg ICAgICAoSlNDOjpKU1ZhbHVlOjp0b1Byb3BlcnR5S2V5IGNvbnN0KToKKyAgICAgICAgKiBydW50 aW1lL0pTU3RyaW5nLmNwcDoKKyAgICAgICAgKEpTQzo6SlNSb3BlU3RyaW5nOjpyZXNvbHZlUm9w ZVRvQXRvbWljU3RyaW5nIGNvbnN0KToKKwogMjAxOC0wOC0yOSAgQ29tbWl0IFF1ZXVlICA8Y29t bWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQg cjIzNTQzMiBhbmQgcjIzNTQzNi4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L0pTQ0pTVmFsdWVJbmxpbmVzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvSlNDSlNWYWx1ZUlubGluZXMuaAkocmV2aXNpb24gMjM1NDQ5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNDSlNWYWx1ZUlubGluZXMuaAkod29ya2luZyBjb3B5 KQpAQCAtNjQ5LDEzICs2NDksMTcgQEAgQUxXQVlTX0lOTElORSBJZGVudGlmaWVyIEpTVmFsdWU6 OnRvUHJvcAogICAgIFZNJiB2bSA9IGV4ZWMtPnZtKCk7CiAgICAgYXV0byBzY29wZSA9IERFQ0xB UkVfVEhST1dfU0NPUEUodm0pOwogCi0gICAgaWYgKGlzU3RyaW5nKCkpCisgICAgaWYgKGlzU3Ry aW5nKCkpIHsKKyAgICAgICAgc2NvcGUucmVsZWFzZSgpOwogICAgICAgICByZXR1cm4gYXNTdHJp bmcoKnRoaXMpLT50b0lkZW50aWZpZXIoZXhlYyk7CisgICAgfQogCiAgICAgSlNWYWx1ZSBwcmlt aXRpdmUgPSB0b1ByaW1pdGl2ZShleGVjLCBQcmVmZXJTdHJpbmcpOwogICAgIFJFVFVSTl9JRl9F WENFUFRJT04oc2NvcGUsIHZtLnByb3BlcnR5TmFtZXMtPmVtcHR5SWRlbnRpZmllcik7Ci0gICAg aWYgKHByaW1pdGl2ZS5pc1N5bWJvbCgpKQorICAgIGlmIChwcmltaXRpdmUuaXNTeW1ib2woKSkg eworICAgICAgICBzY29wZS5yZWxlYXNlKCk7CiAgICAgICAgIHJldHVybiBJZGVudGlmaWVyOjpm cm9tVWlkKGFzU3ltYm9sKHByaW1pdGl2ZSktPnByaXZhdGVOYW1lKCkpOworICAgIH0KICAgICBz Y29wZS5yZWxlYXNlKCk7CiAgICAgcmV0dXJuIHByaW1pdGl2ZS50b1N0cmluZyhleGVjKS0+dG9J ZGVudGlmaWVyKGV4ZWMpOwogfQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv SlNTdHJpbmcuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L0pTU3RyaW5nLmNwcAkocmV2aXNpb24gMjM1NDQ5KQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvSlNTdHJpbmcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNzgsOCArMTc4LDEyIEBA IHZvaWQgSlNSb3BlU3RyaW5nOjpyZXNvbHZlUm9wZUludGVybmFsMTYKIAogdm9pZCBKU1JvcGVT dHJpbmc6OnJlc29sdmVSb3BlVG9BdG9taWNTdHJpbmcoRXhlY1N0YXRlKiBleGVjKSBjb25zdAog eworICAgIFZNJiB2bSA9IGV4ZWMtPnZtKCk7CisgICAgYXV0byBzY29wZSA9IERFQ0xBUkVfVEhS T1dfU0NPUEUodm0pOworCiAgICAgaWYgKGxlbmd0aCgpID4gbWF4TGVuZ3RoRm9yT25TdGFja1Jl c29sdmUpIHsKICAgICAgICAgcmVzb2x2ZVJvcGUoZXhlYyk7CisgICAgICAgIFJFVFVSTl9JRl9F WENFUFRJT04oc2NvcGUsIHZvaWQoKSk7CiAgICAgICAgIG1fdmFsdWUgPSBBdG9taWNTdHJpbmco bV92YWx1ZSk7CiAgICAgICAgIHNldElzOEJpdChtX3ZhbHVlLmltcGwoKS0+aXM4Qml0KCkpOwog ICAgICAgICByZXR1cm47Cg==