189117 2018-08-29 16:25:27 -0700 [macOS] Color picker layout is broken if suggested colors are specified 2018-08-31 08:56:52 -0700 1 1 1 Unclassified WebKit Forms WebKit Nightly Build Mac macOS 10.13 RESOLVED FIXED InRadar P2 Normal --- 1 pxlcoder webkit-unassigned cdumez commit-queue thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1454991 0 pxlcoder 2018-08-29 16:25:27 -0700 Due to a change in NSPopoverColorWell's implementation, the layout of the color picker when suggested colors are specified is broken on 10.13. 1454994 1 348446 pxlcoder 2018-08-29 16:29:05 -0700 Created attachment 348446 Patch 1455246 2 348446 commit-queue 2018-08-30 09:35:53 -0700 Comment on attachment 348446 Patch Clearing flags on attachment: 348446 Committed r235507: <https://trac.webkit.org/changeset/235507> 1455247 3 commit-queue 2018-08-30 09:35:54 -0700 All reviewed patches have been landed. Closing bug. 1455705 4 webkit-bug-importer 2018-08-31 08:56:52 -0700 <rdar://problem/43941959> 348446 2018-08-29 16:29:05 -0700 2018-08-30 09:35:53 -0700 Patch bug-189117-20180829162904.patch text/plain 2142 pxlcoder U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1NDcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGJmMmE4YmFlMTAzZDhjYjAx MzE1YWQxYTc4ODlhNTRlNDU1ZThhNjEuLjg5NzQ1YWM2MzFjODgyODg0N2E2NjhmNGZmNTliNzBi NWRmMWM4YzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTgtMDgtMjkgIEFkaXR5YSBL ZWVydGhpICA8YWtlZXJ0aGlAYXBwbGUuY29tPgorCisgICAgICAgIFttYWNPU10gQ29sb3IgcGlj a2VyIGxheW91dCBpcyBicm9rZW4gaWYgc3VnZ2VzdGVkIGNvbG9ycyBhcmUgc3BlY2lmaWVkCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODkxMTcKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBOU1BvcG92ZXJD b2xvcldlbGwgcmVjZW50bHkgY2hhbmdlZCB0aGUgc2l6ZSBvZiBpdHMgc3dhdGNoZXMuIFdlIG5l ZWQgdG8gdXBkYXRlCisgICAgICAgIHRoZSB3aWR0aCBvZiB0aGUgc3dhdGNoZXMgd2UgcHJvdmlk ZSB0byBtYXRjaCB0aGUgd2lkdGggb2YgdGhlIG90aGVyIHN3YXRjaGVzLAorICAgICAgICBpbiBv cmRlciB0byBhdm9pZCBicmVha2luZyB0aGUgbGF5b3V0LgorCisgICAgICAgIFdoaWxlIHN1Y2gg YSBzb2x1dGlvbiBpcyBub3QgYSBnb29kIHByZWNlZGVudCwgd2UgZG8gbm90IGhhdmUgZnVsbHkt ZnVuY3Rpb25hbCBTUEkKKyAgICAgICAgdG8gY3VzdG9taXplIHRoZSBzdWdnZXN0ZWQgY29sb3Jz LiBBIEZJWE1FIGhhcyBiZWVuIGFkZGVkIGZvciB0aGlzIHJlYXNvbi4KKyAgICAgICAgSG93ZXZl ciwgZXZlbiBvbmNlIHdlIG9idGFpbiBTUEksIHdlIHdpbGwgbmVlZCB0byBmaW5kIGEgd2F5IHRv IHN1cHBvcnQgb2xkZXIKKyAgICAgICAgY2xpZW50cywgbWFraW5nIGNvbmRpdGlvbmFsIGNvbXBp bGF0aW9uIGEgcG90ZW50aWFsIG5lY2Vzc2l0eS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9tYWMv V2ViQ29sb3JQaWNrZXJNYWMubW06CisKIDIwMTgtMDgtMjggIERvbiBPbG1zdGVhZCAgPGRvbi5v bG1zdGVhZEBzb255LmNvbT4KIAogICAgICAgICBbQ01ha2VdIFVzZSBDTWFrZSdzIEZpbmRGcmVl dHlwZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvbWFjL1dlYkNvbG9yUGlj a2VyTWFjLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvbWFjL1dlYkNvbG9yUGlja2VyTWFj Lm1tCmluZGV4IGY3YWEzNzI1MDAxMTUwMGNmYWUwYjQ0MTEyZjRlYmMyOGI2NjNmZGEuLjM0YTM2 MGI5MWVmOTNkM2ViMzdjYjIzMTE5MzM5NmEzNDA3NjBiMjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL21hYy9XZWJDb2xvclBpY2tlck1hYy5tbQorKysgYi9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9tYWMvV2ViQ29sb3JQaWNrZXJNYWMubW0KQEAgLTQ0LDkgKzQ0LDE1IEBA CiAKIHN0YXRpYyBjb25zdCBzaXplX3QgbWF4Q29sb3JTdWdnZXN0aW9ucyA9IDEyOwogc3RhdGlj IGNvbnN0IENHRmxvYXQgY29sb3JQaWNrZXJNYXRyaXhOdW1Db2x1bW5zID0gMTIuMDsKLXN0YXRp YyBjb25zdCBDR0Zsb2F0IGNvbG9yUGlja2VyTWF0cml4U3dhdGNoV2lkdGggPSAxMi4wOwogc3Rh dGljIGNvbnN0IENHRmxvYXQgY29sb3JQaWNrZXJNYXRyaXhCb3JkZXJXaWR0aCA9IDEuMDsKIAor Ly8gRklYTUU6IDxyZGFyOi8vcHJvYmxlbS80MTE3MzUyNT4gV2Ugc2hvdWxkIG5vdCBoYXZlIHRv IHRyYWNrIGNoYW5nZXMgaW4gTlNQb3BvdmVyQ29sb3JXZWxsJ3MgaW1wbGVtZW50YXRpb24uCisj aWYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDEzMDAKK3N0YXRpYyBjb25z dCBDR0Zsb2F0IGNvbG9yUGlja2VyTWF0cml4U3dhdGNoV2lkdGggPSAxMy4wOworI2Vsc2UKK3N0 YXRpYyBjb25zdCBDR0Zsb2F0IGNvbG9yUGlja2VyTWF0cml4U3dhdGNoV2lkdGggPSAxMi4wOwor I2VuZGlmCisKIEBwcm90b2NvbCBXS1BvcG92ZXJDb2xvcldlbGxEZWxlZ2F0ZSA8TlNPYmplY3Q+ CiAtICh2b2lkKWRpZENsb3NlUG9wb3ZlcjsKIEBlbmQK