189095 2018-08-29 13:14:26 -0700 Followup (r235427): Use the null string instead of std::nullopt when no suggestion is selected 2018-08-29 14:10:16 -0700 1 1 1 Unclassified WebKit Forms WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pxlcoder webkit-unassigned cdumez commit-queue darin thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1454901 0 pxlcoder 2018-08-29 13:14:26 -0700 Code cleanup. 1454904 1 348425 pxlcoder 2018-08-29 13:22:35 -0700 Created attachment 348425 Patch 1454921 2 348425 commit-queue 2018-08-29 14:09:50 -0700 Comment on attachment 348425 Patch Clearing flags on attachment: 348425 Committed r235478: <https://trac.webkit.org/changeset/235478> 1454923 3 commit-queue 2018-08-29 14:09:51 -0700 All reviewed patches have been landed. Closing bug. 1454924 4 webkit-bug-importer 2018-08-29 14:10:16 -0700 <rdar://problem/43856941> 348425 2018-08-29 13:22:35 -0700 2018-08-29 14:09:50 -0700 Patch bug-189095-20180829132235.patch text/plain 2704 pxlcoder U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1NDcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGJmMmE4YmFlMTAzZDhjYjAx MzE1YWQxYTc4ODlhNTRlNDU1ZThhNjEuLjI0MjE4M2YwZTVkYmE2M2U0NzM0NWRkNDgxMjRmMmUw MTg5MDA4ODkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTgtMDgtMjkgIEFkaXR5YSBL ZWVydGhpICA8YWtlZXJ0aGlAYXBwbGUuY29tPgorCisgICAgICAgIEZvbGxvd3VwIChyMjM1NDI3 KTogVXNlIHRoZSBudWxsIHN0cmluZyBpbnN0ZWFkIG9mIHN0ZDo6bnVsbG9wdCB3aGVuIG5vIHN1 Z2dlc3Rpb24gaXMgc2VsZWN0ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE4OTA5NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEZvbGxvd3VwIHRvIHIyMzU0MjcgYXMgcGVyIERhcmluJ3MgY29tbWVudC4K KworICAgICAgICBXZSBjYW4gYXZvaWQgdW5uZWNlc3NhcnkgdXNlIG9mIHN0ZDo6b3B0aW9uYWwg YnkgdGFraW5nIGFkdmFudGFnZSBvZiB0aGUgZmFjdCB0aGF0CisgICAgICAgIFdURjo6U3RyaW5n IGFscmVhZHkgaGFzIGEgbnVsbCB2YWx1ZSBkaXN0aW5jdCBmcm9tIHRoZSBlbXB0eSB2YWx1ZS4K KworICAgICAgICBObyBjaGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv bWFjL1dlYkRhdGFMaXN0U3VnZ2VzdGlvbnNEcm9wZG93bk1hYy5tbToKKyAgICAgICAgKFdlYktp dDo6V2ViRGF0YUxpc3RTdWdnZXN0aW9uc0Ryb3Bkb3duTWFjOjpzZWxlY3RPcHRpb24pOgorICAg ICAgICAoLVtXS0RhdGFMaXN0U3VnZ2VzdGlvbnNWaWV3IGN1cnJlbnRTZWxlY3RlZFN0cmluZ10p OgorCiAyMDE4LTA4LTI4ICBEb24gT2xtc3RlYWQgIDxkb24ub2xtc3RlYWRAc29ueS5jb20+CiAK ICAgICAgICAgW0NNYWtlXSBVc2UgQ01ha2UncyBGaW5kRnJlZXR5cGUKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL21hYy9XZWJEYXRhTGlzdFN1Z2dlc3Rpb25zRHJvcGRvd25N YWMubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9tYWMvV2ViRGF0YUxpc3RTdWdnZXN0aW9u c0Ryb3Bkb3duTWFjLm1tCmluZGV4IDMxNDgxZDBkYWQ1OTM4Nzc4MjQ1NTgwYTliODQ2ZjE2MDc4 MWQwNTcuLjRlODYxOTEwMWJhZTllZTU0YjEzODRhNWIwNDUwMjBmY2E4NDA5M2MgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL21hYy9XZWJEYXRhTGlzdFN1Z2dlc3Rpb25zRHJv cGRvd25NYWMubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvbWFjL1dlYkRhdGFMaXN0 U3VnZ2VzdGlvbnNEcm9wZG93bk1hYy5tbQpAQCAtNzcsNyArNzcsNyBAQCBzdGF0aWMgTlNTdHJp bmcgKiBjb25zdCBzdWdnZXN0aW9uQ2VsbFJldXNlSWRlbnRpZmllciA9IEAiV0tEYXRhTGlzdFN1 Z2dlc3Rpb25DZQogLSAodm9pZCltb3ZlU2VsZWN0aW9uQnlEaXJlY3Rpb246KGNvbnN0IFN0cmlu ZyYpZGlyZWN0aW9uOwogLSAodm9pZClpbnZhbGlkYXRlOwogCi0tIChzdGQ6Om9wdGlvbmFsPFN0 cmluZz4pY3VycmVudFNlbGVjdGVkU3RyaW5nOworLSAoU3RyaW5nKWN1cnJlbnRTZWxlY3RlZFN0 cmluZzsKIEBlbmQKIAogbmFtZXNwYWNlIFdlYktpdCB7CkBAIC0xMjAsOSArMTIwLDkgQEAgdm9p ZCBXZWJEYXRhTGlzdFN1Z2dlc3Rpb25zRHJvcGRvd25NYWM6OnNlbGVjdE9wdGlvbigpCiAgICAg aWYgKCFtX2NsaWVudCkKICAgICAgICAgcmV0dXJuOwogCi0gICAgc3RkOjpvcHRpb25hbDxTdHJp bmc+IHNlbGVjdGVkT3B0aW9uID0gW21fZHJvcGRvd25VSSBjdXJyZW50U2VsZWN0ZWRTdHJpbmdd OwotICAgIGlmIChzZWxlY3RlZE9wdGlvbikKLSAgICAgICAgbV9jbGllbnQtPmRpZFNlbGVjdE9w dGlvbihzZWxlY3RlZE9wdGlvbi52YWx1ZSgpKTsKKyAgICBTdHJpbmcgc2VsZWN0ZWRPcHRpb24g PSBbbV9kcm9wZG93blVJIGN1cnJlbnRTZWxlY3RlZFN0cmluZ107CisgICAgaWYgKCFzZWxlY3Rl ZE9wdGlvbi5pc051bGwoKSkKKyAgICAgICAgbV9jbGllbnQtPmRpZFNlbGVjdE9wdGlvbihzZWxl Y3RlZE9wdGlvbik7CiAKICAgICBjbG9zZSgpOwogfQpAQCAtMzI5LDEzICszMjksMTMgQEAgdm9p ZCBXZWJEYXRhTGlzdFN1Z2dlc3Rpb25zRHJvcGRvd25NYWM6OmNsb3NlKCkKICAgICByZXR1cm4g c2VsZjsKIH0KIAotLSAoc3RkOjpvcHRpb25hbDxTdHJpbmc+KWN1cnJlbnRTZWxlY3RlZFN0cmlu ZworLSAoU3RyaW5nKWN1cnJlbnRTZWxlY3RlZFN0cmluZwogewogICAgIHN0ZDo6b3B0aW9uYWw8 c2l6ZV90PiBzZWxlY3RlZFJvdyA9IFtfdGFibGUgY3VycmVudEFjdGl2ZVJvd107CiAgICAgaWYg KHNlbGVjdGVkUm93ICYmIHNlbGVjdGVkUm93LnZhbHVlKCkgPCBfc3VnZ2VzdGlvbnMuc2l6ZSgp KQogICAgICAgICByZXR1cm4gX3N1Z2dlc3Rpb25zLmF0KHNlbGVjdGVkUm93LnZhbHVlKCkpOwog Ci0gICAgcmV0dXJuIHN0ZDo6bnVsbG9wdDsKKyAgICByZXR1cm4gU3RyaW5nKCk7CiB9CiAKIC0g KHZvaWQpdXBkYXRlV2l0aEluZm9ybWF0aW9uOihXZWJDb3JlOjpEYXRhTGlzdFN1Z2dlc3Rpb25J bmZvcm1hdGlvbiYmKWluZm9ybWF0aW9uCg==