189073 2018-08-28 20:32:36 -0700 IDBDatabase should not return true to hasPendingActivity after being stopped 2018-08-28 21:53:24 -0700 1 1 1 Unclassified WebKit Page Loading WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf alecflett beidson commit-queue darin ews-watchlist jsbell webkit-bug-importer oldest_to_newest 1454685 0 youennf 2018-08-28 20:32:36 -0700 IDBDatabase should not return true to hasPendingActivity after being stopped 1454687 1 348384 youennf 2018-08-28 20:36:53 -0700 Created attachment 348384 Patch 1454690 2 348384 darin 2018-08-28 20:39:23 -0700 Comment on attachment 348384 Patch No way to make a regression test? 1454709 3 youennf 2018-08-28 21:26:01 -0700 (In reply to Darin Adler from comment #2) > Comment on attachment 348384 [details] > Patch > > No way to make a regression test? AFAIUI, IDBDatabase::hasPendingActivity will stop returning true once transactions are finalized which will happen ultimately, but not always before GC calls IDBDatabase::hasPendingActivity for the first time. This patch makes IDBDatabase GC-collectable sooner but I do not think it makes some leaked IDBDatabase no longer leaking, so there is no easy way to add a test for that change. This will be captured with bug 189018, which asserts that a stopped ActiveDOMObject hasPendingActivity to return false. Without this patch, some IDB tests would crash. 1454718 4 348384 commit-queue 2018-08-28 21:52:52 -0700 Comment on attachment 348384 Patch Clearing flags on attachment: 348384 Committed r235456: <https://trac.webkit.org/changeset/235456> 1454719 5 commit-queue 2018-08-28 21:52:54 -0700 All reviewed patches have been landed. Closing bug. 1454720 6 webkit-bug-importer 2018-08-28 21:53:24 -0700 <rdar://problem/43828788> 348384 2018-08-28 20:36:53 -0700 2018-08-28 21:52:52 -0700 Patch bug-189073-20180828203652.patch text/plain 2014 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1NDUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTIxNWRkOTcwNTE2N2U1 NmNkZDlmODUxN2Q2ZjcwOTU3YzYzYTlkMS4uYzc0YzE2OWEzNDc0YmJjMmExNTY1YjFlZjM4Nzc0 ZThlMWU1NWY5MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE4LTA4LTI4ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBJREJEYXRhYmFzZSBzaG91 bGQgbm90IHJldHVybiB0cnVlIHRvIGhhc1BlbmRpbmdBY3Rpdml0eSBhZnRlciBiZWluZyBzdG9w cGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODkw NzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGVy ZSBpcyBhIGNoYW5jZSB0aGF0IElEQkRhdGFiYXNlOjpoYXNQZW5kaW5nQWN0aXZpdHkgcmV0dXJu cyB0cnVlLgorICAgICAgICBUaGUgY2FzZSB0aGF0IG1pZ2h0IGhhcHBlbiBpcyB3aGVuIHN0b3Ao KSBpcyBjYWxsZWQgYnV0IHRoZXJlIGFyZSBzdGlsbCBzb21lIGFjdGl2ZS9iZWluZyBjb21taXR0 ZWQgdHJhbnNhY3Rpb25zLgorICAgICAgICBJbiB0aGF0IGNhc2UsIGhhc1BlbmRpbmdBY3Rpdml0 eSB3aWxsIHJldHVybiB0cnVlIHVudGlsIHRoZXNlIHRyYW5zYWN0aW9ucyBnZXQgZmluYWxpemVk LgorICAgICAgICBXaGlsZSB0aGVzZSB0cmFuc2FjdGlvbnMgd2lsbCBwcm9iYWJseSBiZSBmaW5h bGl6ZWQgYXQgc29tZSBwb2ludCwgaXQgZGVsYXlzIEdDIGZvciBubyBnb29kIHJlYXNvbi4KKyAg ICAgICAgQW5kIHdlIG1pZ2h0IHdhbnQgaW4gYSBmb2xsb3ctdXAgcGF0Y2ggdG8gYXNzZXJ0IHRo YXQgQWN0aXZlRE9NT2JqZWN0IGFyZSBHQy1hYmxlIHdoZW5ldmVyIHRoZWlyIGNvbnRleHQgaXMg c3RvcHBlZC4KKyAgICAgICAgRm9yIHRoYXQgcHVycG9zZSwgbWFrZSBzdXJlIGhhc1BlbmRpbmdB Y3Rpdml0eSByZXR1cm5zIGZhbHNlIHdoZW4gY29udGV4dCBpcyBzdG9wcGVkLgorCisgICAgICAg ICogTW9kdWxlcy9pbmRleGVkZGIvSURCRGF0YWJhc2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 SURCRGF0YWJhc2U6Omhhc1BlbmRpbmdBY3Rpdml0eSBjb25zdCk6CisKIDIwMTgtMDgtMjcgIFlv dWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBXZWJSVEMg bGVnYWN5IEFQSSBpbXBsZW1lbnRhdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9k dWxlcy9pbmRleGVkZGIvSURCRGF0YWJhc2UuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9p bmRleGVkZGIvSURCRGF0YWJhc2UuY3BwCmluZGV4IDMzOTE4NTViYWVlNTVkMDU5Nzg0YzkyMGU5 YzI0MjhiMjcxYjkyNDUuLjI1OGQ4OWE1YWRhYmNhNTg4YTE5YTQ4ZDk3OGY2ZWUyMjFmOGRlN2Ug MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQkRhdGFiYXNl LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJEYXRhYmFzZS5j cHAKQEAgLTc2LDcgKzc2LDcgQEAgYm9vbCBJREJEYXRhYmFzZTo6aGFzUGVuZGluZ0FjdGl2aXR5 KCkgY29uc3QKIHsKICAgICBBU1NFUlQoJm9yaWdpblRocmVhZCgpID09ICZUaHJlYWQ6OmN1cnJl bnQoKSB8fCBtYXlCZUdDVGhyZWFkKCkpOwogCi0gICAgaWYgKG1fY2xvc2VkSW5TZXJ2ZXIpCisg ICAgaWYgKG1fY2xvc2VkSW5TZXJ2ZXIgfHwgaXNDb250ZXh0U3RvcHBlZCgpKQogICAgICAgICBy ZXR1cm4gZmFsc2U7CiAKICAgICBpZiAoIW1fYWN0aXZlVHJhbnNhY3Rpb25zLmlzRW1wdHkoKSB8 fCAhbV9jb21taXR0aW5nVHJhbnNhY3Rpb25zLmlzRW1wdHkoKSB8fCAhbV9hYm9ydGluZ1RyYW5z YWN0aW9ucy5pc0VtcHR5KCkpCg==