189061 2018-08-28 15:14:37 -0700 Web Inspector: REGRESSION: CanvasSidebarPanel is empty for imported recordings 2018-08-28 17:07:15 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi bburg commit-queue inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1454575 0 hi 2018-08-28 15:14:37 -0700 STEPS TO REPRODUCE: 1. Go to <https://acko.net> 2. Record the main canvas that is attached to the DOM 3. Save the recording 4. Reload the page 5. Import the saved recording => The CanvasSidebarPanel has no content, even though the RecordingContentView has a preview and scrubber, both of which work as expected 1454587 1 348353 hi 2018-08-28 15:34:45 -0700 Created attachment 348353 Patch 1454603 2 348353 bburg 2018-08-28 15:55:04 -0700 Comment on attachment 348353 Patch r=me 1454631 3 348353 commit-queue 2018-08-28 17:06:48 -0700 Comment on attachment 348353 Patch Clearing flags on attachment: 348353 Committed r235451: <https://trac.webkit.org/changeset/235451> 1454632 4 commit-queue 2018-08-28 17:06:50 -0700 All reviewed patches have been landed. Closing bug. 1454633 5 webkit-bug-importer 2018-08-28 17:07:15 -0700 <rdar://problem/43821202> 348353 2018-08-28 15:34:45 -0700 2018-08-28 17:06:48 -0700 Patch bug-189061-20180828153444.patch text/plain 4105 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGFjYTgxZTUwNjA1ZmQxN2YxODRiYmE2Yzk1NTE4 ZWFiMjljNTNhZDAuLmYxNzA5NGNiOWQ5NzRiMjY0ZTQyZTVjOTNjZTg0ZDE4ODE3MjBjYzUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE4LTA4LTI4ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBS RUdSRVNTSU9OOiBDYW52YXNTaWRlYmFyUGFuZWwgaXMgZW1wdHkgZm9yIGltcG9ydGVkIHJlY29y ZGluZ3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4 OTA2MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdo ZW4gcmVjb3JkaW5ncyBhcmUgaW1wb3J0ZWQsIHRoZXkgZG9uJ3QgaGF2ZSBhbiBhc3NvY2lhdGVk IGBXSS5DYW52YXNgLCBtZWFuaW5nIHRoYXQgdGhlCisgICAgICAgIGBXSS5SZWNvcmRpbmdgIGlz IG5ldmVyIGFkZGVkIHRvIHRoZSBjYW52YXMnIGBXSS5SZWNvcmRpbmdDb2xsZWN0aW9uYC4gUHJl dmlvdXNseSwgdGhlCisgICAgICAgIGNhbnZhcyBzaWRlYmFyIHJlbGllZCB1cG9uIHRoZSBgSXRl bUFkZGVkYCBldmVudCB0byB1cGRhdGUgdGhlIHJlY29yZGluZyBgV0kuU2NvcGVCYXJgLgorICAg ICAgICBTaW5jZSB0aGUgaW1wb3J0ZWQgcmVjb3JkaW5nIGlzbid0IGV2ZXIgYWRkZWQgdG8gdGhl IGNvbGxlY3Rpb24sIHRoaXMgaXMgbmV2ZXIgZmlyZWQuCisKKyAgICAgICAgVGhpcyBwYXRjaCBt b3ZlcyB0aGUgZnVuY3Rpb24gY2FsbCB0aGF0IHVwZGF0ZXMgdGhlIGBXSS5TY29wZUJhcmAgdG8g YSBtb3JlIHVuaXZlcnNhbCBwYXRoLAorICAgICAgICBlbnN1cmluZyB0aGF0IG5vIG1hdHRlciBo b3cgYSBgV0kuUmVjb3JkaW5nYCBpcyBzZXQgZm9yIHRoZSBzaWRlYmFyLCBpdCB3aWxsIGJlIHNo b3duLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9DYW52YXNTaWRlYmFyUGFuZWwu anM6CisgICAgICAgIChXSS5DYW52YXNTaWRlYmFyUGFuZWwucHJvdG90eXBlLnNldCByZWNvcmRp bmcpOgorICAgICAgICAoV0kuQ2FudmFzU2lkZWJhclBhbmVsLnByb3RvdHlwZS5fcmVjb3JkaW5n QWRkZWQpOgorICAgICAgICAoV0kuQ2FudmFzU2lkZWJhclBhbmVsLnByb3RvdHlwZS5fdXBkYXRl UmVjb3JkaW5nU2NvcGVCYXIpOgorCiAyMDE4LTA4LTI3ICBLZWl0aCBSb2xsaW4gIDxrcm9sbGlu QGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkIGJ1aWxkIGZpeCAtLSBkaXNhYmxlIExU TyBmb3IgcHJvZHVjdGlvbiBidWlsZHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NhbnZhc1NpZGViYXJQYW5lbC5qcyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NhbnZhc1NpZGViYXJQYW5lbC5qcwppbmRl eCAzNDY1M2RhZjJkYmQ0MWMwYjBlMmI1MzcyYWVlZDRlYWFhYzk0MDgxLi5hYzJiOWIxM2VkNzZm MGU2MjNlMTk3ZmFmOGFlYWUxYTEyMGJjZWI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9DYW52YXNTaWRlYmFyUGFuZWwuanMKKysrIGIvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ2FudmFzU2lkZWJhclBhbmVs LmpzCkBAIC0xMTksNiArMTE5LDggQEAgV0kuQ2FudmFzU2lkZWJhclBhbmVsID0gY2xhc3MgQ2Fu dmFzU2lkZWJhclBhbmVsIGV4dGVuZHMgV0kuTmF2aWdhdGlvblNpZGViYXJQYW4KICAgICAgICAg ICAgIHRoaXMuX3JlY29yZGluZy5hZGRFdmVudExpc3RlbmVyKFdJLlJlY29yZGluZy5FdmVudC5T dGFydFByb2Nlc3NpbmdGcmFtZSwgdGhpcy5faGFuZGxlUmVjb3JkaW5nU3RhcnRQcm9jZXNzaW5n RnJhbWUsIHRoaXMpOwogICAgICAgICB9CiAKKyAgICAgICAgdGhpcy5fdXBkYXRlUmVjb3JkTmF2 aWdhdGlvbkl0ZW0oKTsKKyAgICAgICAgdGhpcy5fdXBkYXRlUmVjb3JkaW5nU2NvcGVCYXIoKTsK ICAgICAgICAgdGhpcy5fcmVjb3JkaW5nQ2hhbmdlZCgpOwogICAgIH0KIApAQCAtMjIxLDkgKzIy Myw2IEBAIFdJLkNhbnZhc1NpZGViYXJQYW5lbCA9IGNsYXNzIENhbnZhc1NpZGViYXJQYW5lbCBl eHRlbmRzIFdJLk5hdmlnYXRpb25TaWRlYmFyUGFuCiAKICAgICBfcmVjb3JkaW5nQWRkZWQoZXZl bnQpCiAgICAgewotICAgICAgICB0aGlzLl91cGRhdGVSZWNvcmROYXZpZ2F0aW9uSXRlbSgpOwot ICAgICAgICB0aGlzLl91cGRhdGVSZWNvcmRpbmdTY29wZUJhcigpOwotCiAgICAgICAgIHRoaXMu cmVjb3JkaW5nID0gZXZlbnQuZGF0YS5pdGVtOwogICAgIH0KIApAQCAtNDU4LDE0ICs0NTcsMTUg QEAgV0kuQ2FudmFzU2lkZWJhclBhbmVsID0gY2xhc3MgQ2FudmFzU2lkZWJhclBhbmVsIGV4dGVu ZHMgV0kuTmF2aWdhdGlvblNpZGViYXJQYW4KIAogICAgICAgICB0aGlzLl9yZWNvcmRpbmdOYXZp Z2F0aW9uQmFyLmVsZW1lbnQuY2xhc3NMaXN0LnRvZ2dsZSgiaGlkZGVuIiwgIXRoaXMuX2NhbnZh cyk7CiAKLSAgICAgICAgbGV0IGhhc1JlY29yZGluZ3MgPSB0aGlzLl9jYW52YXMgJiYgdGhpcy5f Y2FudmFzLnJlY29yZGluZ0NvbGxlY3Rpb24uc2l6ZTsKKyAgICAgICAgbGV0IGhhc1JlY29yZGlu Z3MgPSB0aGlzLl9yZWNvcmRpbmcgfHwgKHRoaXMuX2NhbnZhcyAmJiB0aGlzLl9jYW52YXMucmVj b3JkaW5nQ29sbGVjdGlvbi5zaXplKTsKICAgICAgICAgdGhpcy5lbGVtZW50LmNsYXNzTGlzdC50 b2dnbGUoImhhcy1yZWNvcmRpbmdzIiwgaGFzUmVjb3JkaW5ncyk7CiAgICAgICAgIGlmICghaGFz UmVjb3JkaW5ncykKICAgICAgICAgICAgIHJldHVybjsKIAogICAgICAgICBsZXQgc2NvcGVCYXJJ dGVtcyA9IFtdOwogICAgICAgICBsZXQgc2VsZWN0ZWRTY29wZUJhckl0ZW0gPSBudWxsOwotICAg ICAgICBmb3IgKGxldCByZWNvcmRpbmcgb2YgdGhpcy5fY2FudmFzLnJlY29yZGluZ0NvbGxlY3Rp b24pIHsKKworICAgICAgICBsZXQgY3JlYXRlU2NvcGVCYXJJdGVtID0gKHJlY29yZGluZykgPT4g ewogICAgICAgICAgICAgbGV0IHNjb3BlQmFySXRlbSA9IG5ldyBXSS5TY29wZUJhckl0ZW0ocmVj b3JkaW5nLmRpc3BsYXlOYW1lLCByZWNvcmRpbmcuZGlzcGxheU5hbWUpOwogICAgICAgICAgICAg aWYgKHJlY29yZGluZyA9PT0gdGhpcy5fcmVjb3JkaW5nKQogICAgICAgICAgICAgICAgIHNlbGVj dGVkU2NvcGVCYXJJdGVtID0gc2NvcGVCYXJJdGVtOwpAQCAtNDczLDggKzQ3MywxNiBAQCBXSS5D YW52YXNTaWRlYmFyUGFuZWwgPSBjbGFzcyBDYW52YXNTaWRlYmFyUGFuZWwgZXh0ZW5kcyBXSS5O YXZpZ2F0aW9uU2lkZWJhclBhbgogICAgICAgICAgICAgICAgIHNjb3BlQmFySXRlbS5zZWxlY3Rl ZCA9IGZhbHNlOwogICAgICAgICAgICAgc2NvcGVCYXJJdGVtLl9fcmVjb3JkaW5nID0gcmVjb3Jk aW5nOwogICAgICAgICAgICAgc2NvcGVCYXJJdGVtcy5wdXNoKHNjb3BlQmFySXRlbSk7CisgICAg ICAgIH07CisKKyAgICAgICAgaWYgKHRoaXMuX2NhbnZhcyAmJiB0aGlzLl9jYW52YXMucmVjb3Jk aW5nQ29sbGVjdGlvbikgeworICAgICAgICAgICAgZm9yIChsZXQgcmVjb3JkaW5nIG9mIHRoaXMu X2NhbnZhcy5yZWNvcmRpbmdDb2xsZWN0aW9uKQorICAgICAgICAgICAgICAgIGNyZWF0ZVNjb3Bl QmFySXRlbShyZWNvcmRpbmcpOwogICAgICAgICB9CiAKKyAgICAgICAgaWYgKHRoaXMuX3JlY29y ZGluZyAmJiAoIXRoaXMuX2NhbnZhcyB8fCAhdGhpcy5fY2FudmFzLnJlY29yZGluZ0NvbGxlY3Rp b24uaGFzKHRoaXMuX3JlY29yZGluZykpKQorICAgICAgICAgICAgY3JlYXRlU2NvcGVCYXJJdGVt KHRoaXMuX3JlY29yZGluZyk7CisKICAgICAgICAgaWYgKCFzZWxlY3RlZFNjb3BlQmFySXRlbSkg ewogICAgICAgICAgICAgc2VsZWN0ZWRTY29wZUJhckl0ZW0gPSBzY29wZUJhckl0ZW1zWzBdOwog Cg==