189056 2018-08-28 13:38:50 -0700 [Curl][WebKit] Bugfix on redirect. 2018-08-30 11:14:02 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 basuke basuke achristensen basuke commit-queue don.olmstead fujii webkit-bug-importer youennf oldest_to_newest 1454525 0 basuke 2018-08-28 13:38:50 -0700 Forget to call request update method. 1454528 1 348335 basuke 2018-08-28 13:43:07 -0700 Created attachment 348335 PATCH 1454902 2 348335 don.olmstead 2018-08-29 13:15:08 -0700 Comment on attachment 348335 PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=348335&action=review LGTM from my informal review. > Source/WebKit/NetworkProcess/NetworkLoad.cpp:154 > +#elif USE(SOUP) || USE(CURL) Minor nit. Should this just be an #else? 1455105 3 348335 achristensen 2018-08-29 18:55:51 -0700 Comment on attachment 348335 PATCH Yep 1455269 4 348504 basuke 2018-08-30 10:34:59 -0700 Created attachment 348504 fix 1455271 5 basuke 2018-08-30 10:36:34 -0700 Thanks. I forgot we can forget about AppleWin in this component. 1455300 6 348504 commit-queue 2018-08-30 11:13:09 -0700 Comment on attachment 348504 fix Clearing flags on attachment: 348504 Committed r235510: <https://trac.webkit.org/changeset/235510> 1455301 7 commit-queue 2018-08-30 11:13:10 -0700 All reviewed patches have been landed. Closing bug. 348335 2018-08-28 13:43:07 -0700 2018-08-30 10:34:59 -0700 PATCH 189056.dif text/plain 1499 basuke ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggZjZiODcyMjIyOGEuLjlkZTFhYjJjMmU0IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDE1IEBACisyMDE4LTA4LTI4ICBCYXN1a2UgU3V6dWtpICA8QmFzdWtlLlN1enVraUBzb255LmNv bT4KKworICAgICAgICBbQ3VybF1bV2ViS2l0XSBCdWdmaXggb24gcmVkaXJlY3QuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODkwNTYKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGb3JnZXQgdG8gY2FsbCB1 cGRhdGVGcm9tRGVsZWdhdGVQcmVzZXJ2aW5nT2xkUHJvcGVydGllcyBpbiBjb250aW51ZVdpbGxT ZW5kUmVxdWVzdCBsaWtlIG90aGVyIHBvcnRzIGRvLgorCisgICAgICAgICogTmV0d29ya1Byb2Nl c3MvTmV0d29ya0xvYWQuY3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrTG9hZDo6Y29udGlu dWVXaWxsU2VuZFJlcXVlc3QpOgorCiAyMDE4LTA4LTI0ICBCYXN1a2UgU3V6dWtpICA8QmFzdWtl LlN1enVraUBzb255LmNvbT4KIAogICAgICAgICBbQ3VybF0gTWF0Y2ggdGhlIGludGVyZmFjZSB1 c2VkIGluIE5ldHdvcmtEYXRhVGFzayBhbmQgUmVzb3VyY2VIYW5kbGUuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtMb2FkLmNwcCBiL1NvdXJjZS9XZWJL aXQvTmV0d29ya1Byb2Nlc3MvTmV0d29ya0xvYWQuY3BwCmluZGV4IDM3OGE1NDg0NDFkLi5hOGMz NmNkYjE2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3Jr TG9hZC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrTG9hZC5j cHAKQEAgLTE1MSw3ICsxNTEsNyBAQCB2b2lkIE5ldHdvcmtMb2FkOjpjb250aW51ZVdpbGxTZW5k UmVxdWVzdChXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3QmJiBuZXdSZXF1ZXN0KQogewogI2lmIFBM QVRGT1JNKENPQ09BKQogICAgIG1fY3VycmVudFJlcXVlc3QudXBkYXRlRnJvbURlbGVnYXRlUHJl c2VydmluZ09sZFByb3BlcnRpZXMobmV3UmVxdWVzdC5uc1VSTFJlcXVlc3QoSFRUUEJvZHlVcGRh dGVQb2xpY3k6OkRvTm90VXBkYXRlSFRUUEJvZHkpKTsKLSNlbGlmIFVTRShTT1VQKQorI2VsaWYg VVNFKFNPVVApIHx8IFVTRShDVVJMKQogICAgIC8vIEZJWE1FOiBJbXBsZW1lbnQgUmVzb3VyY2VS ZXF1ZXN0Ojp1cGRhdGVGcm9tRGVsZWdhdGVQcmVzZXJ2aW5nT2xkUHJvcGVydGllcy4gU2VlIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjYxMjcuCiAgICAgbV9jdXJy ZW50UmVxdWVzdC51cGRhdGVGcm9tRGVsZWdhdGVQcmVzZXJ2aW5nT2xkUHJvcGVydGllcyhuZXdS ZXF1ZXN0KTsKICNlbmRpZgo= 348504 2018-08-30 10:34:59 -0700 2018-08-30 11:13:09 -0700 fix 189056.diff text/plain 1476 basuke ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggZjZiODcyMjIyOGEuLjlkZTFhYjJjMmU0IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDE1IEBACisyMDE4LTA4LTI4ICBCYXN1a2UgU3V6dWtpICA8QmFzdWtlLlN1enVraUBzb255LmNv bT4KKworICAgICAgICBbQ3VybF1bV2ViS2l0XSBCdWdmaXggb24gcmVkaXJlY3QuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODkwNTYKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGb3JnZXQgdG8gY2FsbCB1 cGRhdGVGcm9tRGVsZWdhdGVQcmVzZXJ2aW5nT2xkUHJvcGVydGllcyBpbiBjb250aW51ZVdpbGxT ZW5kUmVxdWVzdCBsaWtlIG90aGVyIHBvcnRzIGRvLgorCisgICAgICAgICogTmV0d29ya1Byb2Nl c3MvTmV0d29ya0xvYWQuY3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrTG9hZDo6Y29udGlu dWVXaWxsU2VuZFJlcXVlc3QpOgorCiAyMDE4LTA4LTI0ICBCYXN1a2UgU3V6dWtpICA8QmFzdWtl LlN1enVraUBzb255LmNvbT4KIAogICAgICAgICBbQ3VybF0gTWF0Y2ggdGhlIGludGVyZmFjZSB1 c2VkIGluIE5ldHdvcmtEYXRhVGFzayBhbmQgUmVzb3VyY2VIYW5kbGUuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtMb2FkLmNwcCBiL1NvdXJjZS9XZWJL aXQvTmV0d29ya1Byb2Nlc3MvTmV0d29ya0xvYWQuY3BwCmluZGV4IDM3OGE1NDg0NDFkLi4xZjAw YWQ3N2MzNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3Jr TG9hZC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrTG9hZC5j cHAKQEAgLTE1MSw3ICsxNTEsNyBAQCB2b2lkIE5ldHdvcmtMb2FkOjpjb250aW51ZVdpbGxTZW5k UmVxdWVzdChXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3QmJiBuZXdSZXF1ZXN0KQogewogI2lmIFBM QVRGT1JNKENPQ09BKQogICAgIG1fY3VycmVudFJlcXVlc3QudXBkYXRlRnJvbURlbGVnYXRlUHJl c2VydmluZ09sZFByb3BlcnRpZXMobmV3UmVxdWVzdC5uc1VSTFJlcXVlc3QoSFRUUEJvZHlVcGRh dGVQb2xpY3k6OkRvTm90VXBkYXRlSFRUUEJvZHkpKTsKLSNlbGlmIFVTRShTT1VQKQorI2Vsc2UK ICAgICAvLyBGSVhNRTogSW1wbGVtZW50IFJlc291cmNlUmVxdWVzdDo6dXBkYXRlRnJvbURlbGVn YXRlUHJlc2VydmluZ09sZFByb3BlcnRpZXMuIFNlZSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTI2MTI3LgogICAgIG1fY3VycmVudFJlcXVlc3QudXBkYXRlRnJvbURl bGVnYXRlUHJlc2VydmluZ09sZFByb3BlcnRpZXMobmV3UmVxdWVzdCk7CiAjZW5kaWYK