18905 2008-05-06 03:58:18 -0700 [GTK] Fix build with older pango (1.14.8) 2008-09-26 23:48:44 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 gb.devel webkit-unassigned oldest_to_newest 79729 0 gb.devel 2008-05-06 03:58:18 -0700 WebKit doesn't build with older pango, e.g. 1.14.8 from Debian/etch. Please either require pango >= 1.15.2 or apply a patch similar to the attachment. 79730 1 20981 gb.devel 2008-05-06 04:04:18 -0700 Created attachment 20981 Fix build with older pango This is a literal copy for pango sources. Note that the PANGO_VERSION_CHECK() macro appeared along with the missing functions pango_layout_get_line_readonly() and pango_language_get_default(). i.e. I am not testing for !PANGO_VERSION_CHECK(1,15,2). An alternative could be to AC_CHECK_FUNCS(pango_layout_get_line_readonly) and dependent on the generated HAVE_FUNCTION thing. 86990 2 jmalonzo 2008-07-25 20:24:55 -0700 Hi Gwenole. Is your patch for review? If so, please set the review flag to '+' so reviewers will notice your patch. 87156 3 pierre-luc.beaudoin 2008-07-28 07:56:52 -0700 Actually, if the patch is ready to be reviewed, you should set the review flag to "?". Then, once it has been reviewed, the reviewer will set the flag to '+' or '-' depending on the outcome. 92416 4 20981 jmalonzo 2008-09-23 15:48:47 -0700 Comment on attachment 20981 Fix build with older pango setting the patch for review... 92487 5 20981 eric 2008-09-24 01:28:46 -0700 Comment on attachment 20981 Fix build with older pango I think it's cleaner to pull in code from other libraries in separate headers/cpp files. That makes it much easier (in my mind) to justify the WebKit style violation, if the whole file is of that separate style. 92611 6 20981 eric 2008-09-24 15:38:46 -0700 Comment on attachment 20981 Fix build with older pango Tis fine though. 93035 7 jmalonzo 2008-09-26 23:48:44 -0700 Landed in r36990. Thanks! 20981 2008-05-06 04:04:18 -0700 2008-09-24 15:38:46 -0700 Fix build with older pango webkit.pango.old-api.patch text/plain 1709 gb.devel MjAwOC0wNS0wNiAgR3dlbm9sZSBCZWF1Y2hlc25lICA8Z2JlYXVjaGVzbmVAc3BsaXR0ZWQtZGVz a3RvcC5vcmc+CgoJUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgoJKiBwbGF0Zm9ybS9ncmFw aGljcy9ndGsvRm9udEd0ay5jcHA6CgkqIHBsYXRmb3JtL2d0ay9MYW5ndWFnZS5jcHA6CgkoX3Bh bmdvX2dldF9sY19jdHlwZSk6CgkocGFuZ29fbGFuZ3VhZ2VfZ2V0X2RlZmF1bHQpOgoKSW5kZXg6 IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL0ZvbnRHdGsuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL0ZvbnRHdGsuY3BwCShyZXZpc2lvbiAzMjkw MSkKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL0ZvbnRHdGsuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC00MCw2ICs0MCwxMSBAQAogI2luY2x1ZGUgPHBhbmdvL3BhbmdvLmg+CiAjaW5j bHVkZSA8cGFuZ28vcGFuZ29jYWlyby5oPgogCisjaWYgIWRlZmluZWQoUEFOR09fVkVSU0lPTl9D SEVDSykKKy8vIFBBTkdPX1ZFUlNJT05fQ0hFQ0soKSBhbmQgcGFuZ29fbGF5b3V0X2dldF9saW5l X3JlYWRvbmx5KCkgYXBwZWFyZWQgaW4gMS41LjIKKyNkZWZpbmUgcGFuZ29fbGF5b3V0X2dldF9s aW5lX3JlYWRvbmx5IHBhbmdvX2xheW91dF9nZXRfbGluZQorI2VuZGlmCisKIG5hbWVzcGFjZSBX ZWJDb3JlIHsKIAogI2RlZmluZSBJU19ISUdIX1NVUlJPR0FURSh1KSAgKChVQ2hhcikodSkgPj0g KFVDaGFyKTB4ZDgwMCAmJiAoVUNoYXIpKHUpIDw9IChVQ2hhcikweGRiZmYpCkluZGV4OiBXZWJD b3JlL3BsYXRmb3JtL2d0ay9MYW5ndWFnZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0 Zm9ybS9ndGsvTGFuZ3VhZ2UuY3BwCShyZXZpc2lvbiAzMjkwMSkKKysrIFdlYkNvcmUvcGxhdGZv cm0vZ3RrL0xhbmd1YWdlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjYsNiArMjYsMzAgQEAKICNp bmNsdWRlIDxndGsvZ3RrLmg+CiAjaW5jbHVkZSA8cGFuZ28vcGFuZ28uaD4KIAorI2lmICFkZWZp bmVkKFBBTkdPX1ZFUlNJT05fQ0hFQ0spCisvLyBQQU5HT19WRVJTSU9OX0NIRUNLKCkgYW5kIHBh bmdvX2xhbmd1YWdlX2dldF9kZWZhdWx0KCkgYXBwZWFyZWQgaW4gMS41LjIKKyNpbmNsdWRlIDxs b2NhbGUuaD4KKworc3RhdGljIGdjaGFyICoKK19wYW5nb19nZXRfbGNfY3R5cGUgKHZvaWQpCit7 CisgIHJldHVybiBnX3N0cmR1cCAoc2V0bG9jYWxlIChMQ19DVFlQRSwgTlVMTCkpOworfQorCitz dGF0aWMgUGFuZ29MYW5ndWFnZSAqCitwYW5nb19sYW5ndWFnZV9nZXRfZGVmYXVsdCAodm9pZCkK K3sKKyAgc3RhdGljIFBhbmdvTGFuZ3VhZ2UgKnJlc3VsdCA9IE5VTEw7CisgIGlmIChHX1VOTElL RUxZICghcmVzdWx0KSkKKyAgICB7CisgICAgICBnY2hhciAqbGFuZyA9IF9wYW5nb19nZXRfbGNf Y3R5cGUgKCk7CisgICAgICByZXN1bHQgPSBwYW5nb19sYW5ndWFnZV9mcm9tX3N0cmluZyAobGFu Zyk7CisgICAgICBnX2ZyZWUgKGxhbmcpOworICAgIH0KKyAgcmV0dXJuIHJlc3VsdDsKK30KKyNl bmRpZgorCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIFN0cmluZyBkZWZhdWx0TGFuZ3VhZ2UoKQo=