189046 2018-08-28 05:48:58 -0700 Revert changes to RealtimeMediaSource.cpp made in r235086 2018-08-28 06:29:45 -0700 1 1 1 Unclassified WebKit WebRTC Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson commit-queue webkit-bug-importer youennf oldest_to_newest 1454350 0 eric.carlson 2018-08-28 05:48:58 -0700 Revert changes to RealtimeMediaSource.cpp accidentally made in r235086. 1454351 1 webkit-bug-importer 2018-08-28 05:49:30 -0700 <rdar://problem/43794875> 1454352 2 348288 eric.carlson 2018-08-28 05:50:53 -0700 Created attachment 348288 Patch 1454353 3 348289 eric.carlson 2018-08-28 05:51:52 -0700 Created attachment 348289 Patch 1454359 4 348289 commit-queue 2018-08-28 06:29:44 -0700 Comment on attachment 348289 Patch Clearing flags on attachment: 348289 Committed r235422: <https://trac.webkit.org/changeset/235422> 1454360 5 commit-queue 2018-08-28 06:29:45 -0700 All reviewed patches have been landed. Closing bug. 348288 2018-08-28 05:50:53 -0700 2018-08-28 05:51:51 -0700 Patch bug-189046-20180828055052.patch text/plain 3322 eric.carlson U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1NDIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWExNjAzNmUyODMyM2U4 Y2FkYTFjNmUyYzg1MWQzZDFlZjY5Nzg4Yi4uY2IxYzljMzViMWQyMzE1ZmJkMDkyNmE4YzA1YzQ0 Yzg4Zjc3YjY4MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE4LTA4LTI4ICBFcmlj IENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFJldmVydCBjaGFu Z2VzIHRvIFJlYWx0aW1lTWVkaWFTb3VyY2UuY3BwIG1hZGUgaW4gcjIzNTA4NgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg5MDQ2CisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS80Mzc5NDg3NT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL21lZGlhc3RyZWFtL1JlYWx0aW1lTWVkaWFTb3Vy Y2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVhbHRpbWVNZWRpYVNvdXJjZTo6c3VwcG9ydHNT aXplQW5kRnJhbWVSYXRlKTogCisKIDIwMTgtMDgtMjggIEFsZWphbmRybyBHLiBDYXN0cm8gIDxh bGV4QGlnYWxpYS5jb20+CiAKICAgICAgICAgRml4IGdjYyBjb21waWxhdGlvbiB3YXJuaW5ncyBh ZnRlciByMjM1MjMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0 cmVhbS9SZWFsdGltZU1lZGlhU291cmNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21l ZGlhc3RyZWFtL1JlYWx0aW1lTWVkaWFTb3VyY2UuY3BwCmluZGV4IGJmZTRkNmRlMWM4MzQwNjgy YTFmN2VlMjllOGM5NDU4NWZlMGJjZTguLmNhZGFmNzVlMmE5NDZiMTU1NmNlZGRmMmVlMTdlMzQz NmVlYTExNjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFt L1JlYWx0aW1lTWVkaWFTb3VyY2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21l ZGlhc3RyZWFtL1JlYWx0aW1lTWVkaWFTb3VyY2UuY3BwCkBAIC0yNDYsOCArMjQ2LDEwIEBAIGJv b2wgUmVhbHRpbWVNZWRpYVNvdXJjZTo6c3VwcG9ydHNTaXplQW5kRnJhbWVSYXRlKHN0ZDo6b3B0 aW9uYWw8SW50Q29uc3RyYWludD4KICAgICAgICAgfQogCiAgICAgICAgIGRpc3RhbmNlID0gc3Rk OjptaW4oZGlzdGFuY2UsIGNvbnN0cmFpbnREaXN0YW5jZSk7Ci0gICAgICAgIGF1dG8gcmFuZ2Ug PSBjYXBhYmlsaXRpZXMud2lkdGgoKTsKLSAgICAgICAgd2lkdGggPSB3aWR0aENvbnN0cmFpbnQt PnZhbHVlRm9yQ2FwYWJpbGl0eVJhbmdlKHNpemUoKS53aWR0aCgpLCByYW5nZS5yYW5nZU1pbigp LmFzSW50LCByYW5nZS5yYW5nZU1heCgpLmFzSW50KTsKKyAgICAgICAgaWYgKHdpZHRoQ29uc3Ry YWludC0+aXNNYW5kYXRvcnkoKSkgeworICAgICAgICAgICAgYXV0byByYW5nZSA9IGNhcGFiaWxp dGllcy53aWR0aCgpOworICAgICAgICAgICAgd2lkdGggPSB3aWR0aENvbnN0cmFpbnQtPnZhbHVl Rm9yQ2FwYWJpbGl0eVJhbmdlKHNpemUoKS53aWR0aCgpLCByYW5nZS5yYW5nZU1pbigpLmFzSW50 LCByYW5nZS5yYW5nZU1heCgpLmFzSW50KTsKKyAgICAgICAgfQogICAgIH0KIAogICAgIHN0ZDo6 b3B0aW9uYWw8aW50PiBoZWlnaHQ7CkBAIC0yNTksOCArMjYxLDEwIEBAIGJvb2wgUmVhbHRpbWVN ZWRpYVNvdXJjZTo6c3VwcG9ydHNTaXplQW5kRnJhbWVSYXRlKHN0ZDo6b3B0aW9uYWw8SW50Q29u c3RyYWludD4KICAgICAgICAgfQogCiAgICAgICAgIGRpc3RhbmNlID0gc3RkOjptaW4oZGlzdGFu Y2UsIGNvbnN0cmFpbnREaXN0YW5jZSk7Ci0gICAgICAgIGF1dG8gcmFuZ2UgPSBjYXBhYmlsaXRp ZXMuaGVpZ2h0KCk7Ci0gICAgICAgIGhlaWdodCA9IGhlaWdodENvbnN0cmFpbnQtPnZhbHVlRm9y Q2FwYWJpbGl0eVJhbmdlKHNpemUoKS5oZWlnaHQoKSwgcmFuZ2UucmFuZ2VNaW4oKS5hc0ludCwg cmFuZ2UucmFuZ2VNYXgoKS5hc0ludCk7CisgICAgICAgIGlmIChoZWlnaHRDb25zdHJhaW50LT5p c01hbmRhdG9yeSgpKSB7CisgICAgICAgICAgICBhdXRvIHJhbmdlID0gY2FwYWJpbGl0aWVzLmhl aWdodCgpOworICAgICAgICAgICAgaGVpZ2h0ID0gaGVpZ2h0Q29uc3RyYWludC0+dmFsdWVGb3JD YXBhYmlsaXR5UmFuZ2Uoc2l6ZSgpLmhlaWdodCgpLCByYW5nZS5yYW5nZU1pbigpLmFzSW50LCBy YW5nZS5yYW5nZU1heCgpLmFzSW50KTsKKyAgICAgICAgfQogICAgIH0KIAogICAgIHN0ZDo6b3B0 aW9uYWw8ZG91YmxlPiBmcmFtZVJhdGU7CkBAIC0yNzIsOCArMjc2LDEwIEBAIGJvb2wgUmVhbHRp bWVNZWRpYVNvdXJjZTo6c3VwcG9ydHNTaXplQW5kRnJhbWVSYXRlKHN0ZDo6b3B0aW9uYWw8SW50 Q29uc3RyYWludD4KICAgICAgICAgfQogCiAgICAgICAgIGRpc3RhbmNlID0gc3RkOjptaW4oZGlz dGFuY2UsIGNvbnN0cmFpbnREaXN0YW5jZSk7Ci0gICAgICAgIGF1dG8gcmFuZ2UgPSBjYXBhYmls aXRpZXMuZnJhbWVSYXRlKCk7Ci0gICAgICAgIGZyYW1lUmF0ZSA9IGZyYW1lUmF0ZUNvbnN0cmFp bnQtPnZhbHVlRm9yQ2FwYWJpbGl0eVJhbmdlKHRoaXMtPmZyYW1lUmF0ZSgpLCByYW5nZS5yYW5n ZU1pbigpLmFzRG91YmxlLCByYW5nZS5yYW5nZU1heCgpLmFzRG91YmxlKTsKKyAgICAgICAgaWYg KGZyYW1lUmF0ZUNvbnN0cmFpbnQtPmlzTWFuZGF0b3J5KCkpIHsKKyAgICAgICAgICAgIGF1dG8g cmFuZ2UgPSBjYXBhYmlsaXRpZXMuZnJhbWVSYXRlKCk7CisgICAgICAgICAgICBmcmFtZVJhdGUg PSBmcmFtZVJhdGVDb25zdHJhaW50LT52YWx1ZUZvckNhcGFiaWxpdHlSYW5nZSh0aGlzLT5mcmFt ZVJhdGUoKSwgcmFuZ2UucmFuZ2VNaW4oKS5hc0RvdWJsZSwgcmFuZ2UucmFuZ2VNYXgoKS5hc0Rv dWJsZSk7CisgICAgICAgIH0KICAgICB9CiAKICAgICAvLyBFYWNoIG9mIHRoZSBub24tbnVsbCB2 YWx1ZXMgaXMgc3VwcG9ydGVkIGluZGl2aWR1YWxseSwgc2VlIGlmIHRoZXkgYWxsIGNhbiBiZSBh cHBsaWVkIGF0IHRoZSBzYW1lIHRpbWUuCkBAIC0yODYsNyArMjkyLDcgQEAgYm9vbCBSZWFsdGlt ZU1lZGlhU291cmNlOjpzdXBwb3J0c1NpemVBbmRGcmFtZVJhdGUoc3RkOjpvcHRpb25hbDxJbnRD b25zdHJhaW50PgogICAgICAgICAgICAgYmFkQ29uc3RyYWludCA9IGZyYW1lUmF0ZUNvbnN0cmFp bnQtPm5hbWUoKTsKICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIH0KLSAgICAKKwogICAgIHJl dHVybiB0cnVlOwogfQogCg== 348289 2018-08-28 05:51:52 -0700 2018-08-28 06:29:44 -0700 Patch bug-189046-20180828055152.patch text/plain 3338 eric.carlson U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1NDIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWExNjAzNmUyODMyM2U4 Y2FkYTFjNmUyYzg1MWQzZDFlZjY5Nzg4Yi4uY2I0M2MzZjkwNjMyNGM1Mjk5OTYyNWQxMjIyNzgw N2I3ODJhMTQ4ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE4LTA4LTI4ICBFcmlj IENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFJldmVydCBjaGFu Z2VzIHRvIFJlYWx0aW1lTWVkaWFTb3VyY2UuY3BwIG1hZGUgaW4gcjIzNTA4NgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg5MDQ2CisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS80Mzc5NDg3NT4KKworICAgICAgICBVbnJldmlld2VkLCByZXZlcnRpbmcg YW4gYWNjaWRlbnRhbCBjaGFuZ2UuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tZWRpYXN0cmVhbS9S ZWFsdGltZU1lZGlhU291cmNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlYWx0aW1lTWVkaWFT b3VyY2U6OnN1cHBvcnRzU2l6ZUFuZEZyYW1lUmF0ZSk6IAorCiAyMDE4LTA4LTI4ICBBbGVqYW5k cm8gRy4gQ2FzdHJvICA8YWxleEBpZ2FsaWEuY29tPgogCiAgICAgICAgIEZpeCBnY2MgY29tcGls YXRpb24gd2FybmluZ3MgYWZ0ZXIgcjIzNTIzMApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vbWVkaWFzdHJlYW0vUmVhbHRpbWVNZWRpYVNvdXJjZS5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9SZWFsdGltZU1lZGlhU291cmNlLmNwcAppbmRleCBi ZmU0ZDZkZTFjODM0MDY4MmExZjdlZTI5ZThjOTQ1ODVmZTBiY2U4Li5jYWRhZjc1ZTJhOTQ2YjE1 NTZjZWRkZjJlZTE3ZTM0MzZlZWExMTY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9tZWRpYXN0cmVhbS9SZWFsdGltZU1lZGlhU291cmNlLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9SZWFsdGltZU1lZGlhU291cmNlLmNwcApAQCAtMjQ2 LDggKzI0NiwxMCBAQCBib29sIFJlYWx0aW1lTWVkaWFTb3VyY2U6OnN1cHBvcnRzU2l6ZUFuZEZy YW1lUmF0ZShzdGQ6Om9wdGlvbmFsPEludENvbnN0cmFpbnQ+CiAgICAgICAgIH0KIAogICAgICAg ICBkaXN0YW5jZSA9IHN0ZDo6bWluKGRpc3RhbmNlLCBjb25zdHJhaW50RGlzdGFuY2UpOwotICAg ICAgICBhdXRvIHJhbmdlID0gY2FwYWJpbGl0aWVzLndpZHRoKCk7Ci0gICAgICAgIHdpZHRoID0g d2lkdGhDb25zdHJhaW50LT52YWx1ZUZvckNhcGFiaWxpdHlSYW5nZShzaXplKCkud2lkdGgoKSwg cmFuZ2UucmFuZ2VNaW4oKS5hc0ludCwgcmFuZ2UucmFuZ2VNYXgoKS5hc0ludCk7CisgICAgICAg IGlmICh3aWR0aENvbnN0cmFpbnQtPmlzTWFuZGF0b3J5KCkpIHsKKyAgICAgICAgICAgIGF1dG8g cmFuZ2UgPSBjYXBhYmlsaXRpZXMud2lkdGgoKTsKKyAgICAgICAgICAgIHdpZHRoID0gd2lkdGhD b25zdHJhaW50LT52YWx1ZUZvckNhcGFiaWxpdHlSYW5nZShzaXplKCkud2lkdGgoKSwgcmFuZ2Uu cmFuZ2VNaW4oKS5hc0ludCwgcmFuZ2UucmFuZ2VNYXgoKS5hc0ludCk7CisgICAgICAgIH0KICAg ICB9CiAKICAgICBzdGQ6Om9wdGlvbmFsPGludD4gaGVpZ2h0OwpAQCAtMjU5LDggKzI2MSwxMCBA QCBib29sIFJlYWx0aW1lTWVkaWFTb3VyY2U6OnN1cHBvcnRzU2l6ZUFuZEZyYW1lUmF0ZShzdGQ6 Om9wdGlvbmFsPEludENvbnN0cmFpbnQ+CiAgICAgICAgIH0KIAogICAgICAgICBkaXN0YW5jZSA9 IHN0ZDo6bWluKGRpc3RhbmNlLCBjb25zdHJhaW50RGlzdGFuY2UpOwotICAgICAgICBhdXRvIHJh bmdlID0gY2FwYWJpbGl0aWVzLmhlaWdodCgpOwotICAgICAgICBoZWlnaHQgPSBoZWlnaHRDb25z dHJhaW50LT52YWx1ZUZvckNhcGFiaWxpdHlSYW5nZShzaXplKCkuaGVpZ2h0KCksIHJhbmdlLnJh bmdlTWluKCkuYXNJbnQsIHJhbmdlLnJhbmdlTWF4KCkuYXNJbnQpOworICAgICAgICBpZiAoaGVp Z2h0Q29uc3RyYWludC0+aXNNYW5kYXRvcnkoKSkgeworICAgICAgICAgICAgYXV0byByYW5nZSA9 IGNhcGFiaWxpdGllcy5oZWlnaHQoKTsKKyAgICAgICAgICAgIGhlaWdodCA9IGhlaWdodENvbnN0 cmFpbnQtPnZhbHVlRm9yQ2FwYWJpbGl0eVJhbmdlKHNpemUoKS5oZWlnaHQoKSwgcmFuZ2UucmFu Z2VNaW4oKS5hc0ludCwgcmFuZ2UucmFuZ2VNYXgoKS5hc0ludCk7CisgICAgICAgIH0KICAgICB9 CiAKICAgICBzdGQ6Om9wdGlvbmFsPGRvdWJsZT4gZnJhbWVSYXRlOwpAQCAtMjcyLDggKzI3Niwx MCBAQCBib29sIFJlYWx0aW1lTWVkaWFTb3VyY2U6OnN1cHBvcnRzU2l6ZUFuZEZyYW1lUmF0ZShz dGQ6Om9wdGlvbmFsPEludENvbnN0cmFpbnQ+CiAgICAgICAgIH0KIAogICAgICAgICBkaXN0YW5j ZSA9IHN0ZDo6bWluKGRpc3RhbmNlLCBjb25zdHJhaW50RGlzdGFuY2UpOwotICAgICAgICBhdXRv IHJhbmdlID0gY2FwYWJpbGl0aWVzLmZyYW1lUmF0ZSgpOwotICAgICAgICBmcmFtZVJhdGUgPSBm cmFtZVJhdGVDb25zdHJhaW50LT52YWx1ZUZvckNhcGFiaWxpdHlSYW5nZSh0aGlzLT5mcmFtZVJh dGUoKSwgcmFuZ2UucmFuZ2VNaW4oKS5hc0RvdWJsZSwgcmFuZ2UucmFuZ2VNYXgoKS5hc0RvdWJs ZSk7CisgICAgICAgIGlmIChmcmFtZVJhdGVDb25zdHJhaW50LT5pc01hbmRhdG9yeSgpKSB7Cisg ICAgICAgICAgICBhdXRvIHJhbmdlID0gY2FwYWJpbGl0aWVzLmZyYW1lUmF0ZSgpOworICAgICAg ICAgICAgZnJhbWVSYXRlID0gZnJhbWVSYXRlQ29uc3RyYWludC0+dmFsdWVGb3JDYXBhYmlsaXR5 UmFuZ2UodGhpcy0+ZnJhbWVSYXRlKCksIHJhbmdlLnJhbmdlTWluKCkuYXNEb3VibGUsIHJhbmdl LnJhbmdlTWF4KCkuYXNEb3VibGUpOworICAgICAgICB9CiAgICAgfQogCiAgICAgLy8gRWFjaCBv ZiB0aGUgbm9uLW51bGwgdmFsdWVzIGlzIHN1cHBvcnRlZCBpbmRpdmlkdWFsbHksIHNlZSBpZiB0 aGV5IGFsbCBjYW4gYmUgYXBwbGllZCBhdCB0aGUgc2FtZSB0aW1lLgpAQCAtMjg2LDcgKzI5Miw3 IEBAIGJvb2wgUmVhbHRpbWVNZWRpYVNvdXJjZTo6c3VwcG9ydHNTaXplQW5kRnJhbWVSYXRlKHN0 ZDo6b3B0aW9uYWw8SW50Q29uc3RyYWludD4KICAgICAgICAgICAgIGJhZENvbnN0cmFpbnQgPSBm cmFtZVJhdGVDb25zdHJhaW50LT5uYW1lKCk7CiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICB9 Ci0gICAgCisKICAgICByZXR1cm4gdHJ1ZTsKIH0KIAo=