189010 2018-08-27 14:58:24 -0700 [Datalist] Pressing enter without a selected option shouldn't change the input 2018-08-28 22:35:35 -0700 1 1 1 Unclassified WebKit Forms WebKit Nightly Build Mac Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pxlcoder webkit-unassigned cdumez commit-queue darin thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1454112 0 pxlcoder 2018-08-27 14:58:24 -0700 Currently, the value of an input field gets cleared if there is no selected datalist suggestion when the enter key is pressed. The correct behavior is to leave the value of the input as-is. 1454144 1 348216 pxlcoder 2018-08-27 15:33:03 -0700 Created attachment 348216 Patch 1454411 2 348216 commit-queue 2018-08-28 10:03:03 -0700 Comment on attachment 348216 Patch Clearing flags on attachment: 348216 Committed r235427: <https://trac.webkit.org/changeset/235427> 1454412 3 commit-queue 2018-08-28 10:03:05 -0700 All reviewed patches have been landed. Closing bug. 1454415 4 webkit-bug-importer 2018-08-28 10:04:19 -0700 <rdar://problem/43802050> 1454679 5 darin 2018-08-28 19:55:42 -0700 Seems unnecessary to use std::optional<String> since WTF::String already has a null value (distinct from the empty string). Typically we can use null string to mean no string, and we don’t have to involve std::optional. Unless we also need to use null string for some other valid value. 1454730 6 pxlcoder 2018-08-28 22:35:35 -0700 (In reply to Darin Adler from comment #5) > Seems unnecessary to use std::optional<String> since WTF::String already has > a null value (distinct from the empty string). Typically we can use null > string to mean no string, and we don’t have to involve std::optional. Unless > we also need to use null string for some other valid value. I will address this in a follow-up patch. I can't think of a case where we'd want to use the null string for a valid value. 348216 2018-08-27 15:33:03 -0700 2018-08-28 10:03:03 -0700 Patch bug-189010-20180827153302.patch text/plain 6328 pxlcoder U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1NDAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDYzYWRhNzY0Y2YwNjJiMjky YTg5ZmEwNmJhNTE2MWU2MTQxNDA0MTguLmU3MTg4ZDU0MWI1N2MyNDY1Y2I2NTZjOTcxOGUwY2Iz OGM0YmU0OGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjkgQEAKKzIwMTgtMDgtMjcgIEFkaXR5YSBL ZWVydGhpICA8YWtlZXJ0aGlAYXBwbGUuY29tPgorCisgICAgICAgIFtEYXRhbGlzdF0gUHJlc3Np bmcgZW50ZXIgd2l0aG91dCBhIHNlbGVjdGVkIG9wdGlvbiBzaG91bGRuJ3QgY2hhbmdlIHRoZSBp bnB1dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg5 MDEwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ3Vy cmVudGx5LCB0aGUgdmFsdWUgb2YgYW4gaW5wdXQgZmllbGQgZ2V0cyBjbGVhcmVkIGlmIHRoZXJl IGlzIG5vIHNlbGVjdGVkCisgICAgICAgIGRhdGFsaXN0IHN1Z2dlc3Rpb24gd2hlbiB0aGUgZW50 ZXIga2V5IGlzIHByZXNzZWQuIFRoZSBjb3JyZWN0IGJlaGF2aW9yIGlzIHRvCisgICAgICAgIGxl YXZlIHRoZSB2YWx1ZSBvZiB0aGUgaW5wdXQgYXMtaXMuCisKKyAgICAgICAgVGhlIGluY29ycmVj dCBiZWhhdmlvciBpcyBhIGNvbnNlcXVlbmNlIG9mIHRoZSBmYWN0IHRoYXQgYW4gZW1wdHkgc3Ry aW5nIGlzCisgICAgICAgIHJldHVybmVkIGJ5IFtXS0RhdGFMaXN0U3VnZ2VzdGlvbnNWaWV3IGN1 cnJlbnRTZWxlY3RlZFN0cmluZ10gaWYgdGhlcmUgaXMgbm8KKyAgICAgICAgc2VsZWN0aW9uLiBU byBmaXggdGhlIGJlaGF2aW9yLCB0aGUgbWV0aG9kIG5vdyByZXR1cm5zIGFuIHN0ZDo6b3B0aW9u YWwgaW5zdGVhZAorICAgICAgICBvZiBhbiBlbXB0eSBzdHJpbmcuIElmIHN0ZDo6bnVsbG9wdCBp cyByZXR1cm5lZCwgd2UgZG8gbm90IG1ha2UgYW55IG1vZGlmaWNhdGlvbgorICAgICAgICB0byB0 aGUgdmFsdWUgb2YgdGhlIGlucHV0LiBUaGlzIGVuc3VyZXMgdGhhdCB3ZSBjYW4gc3RpbGwgY2hh bmdlIHRoZSB2YWx1ZSBvZgorICAgICAgICBhbiBpbnB1dCBmaWVsZCB0byBhbiBlbXB0eSBzdHJp bmcgaW4gdGhlIGNhc2UgdGhhdCBhbiBlbXB0eSBzdHJpbmcgaXMgcGFydCBvZgorICAgICAgICB0 aGUgc3VnZ2VzdGlvbnMuCisKKyAgICAgICAgQXVnbWVudGVkIHRlc3Q6IGZhc3QvZm9ybXMvZGF0 YWxpc3QvZGF0YWxpc3QtdGV4dGlucHV0LWtleWRvd24uaHRtbAorCisgICAgICAgICogVUlQcm9j ZXNzL21hYy9XZWJEYXRhTGlzdFN1Z2dlc3Rpb25zRHJvcGRvd25NYWMubW06CisgICAgICAgIChX ZWJLaXQ6OldlYkRhdGFMaXN0U3VnZ2VzdGlvbnNEcm9wZG93bk1hYzo6c2VsZWN0T3B0aW9uKToK KyAgICAgICAgKC1bV0tEYXRhTGlzdFN1Z2dlc3Rpb25DZWxsIGRyYXdSZWN0Ol0pOiBRdWljayBm aXguIFRoZSBtb3VzZW92ZXIgY29sb3Igd2FzIGluY29ycmVjdC4KKyAgICAgICAgKC1bV0tEYXRh TGlzdFN1Z2dlc3Rpb25zVmlldyBjdXJyZW50U2VsZWN0ZWRTdHJpbmddKToKKwogMjAxOC0wOC0y NyAgQWRpdHlhIEtlZXJ0aGkgIDxha2VlcnRoaUBhcHBsZS5jb20+CiAKICAgICAgICAgQ29uc29s aWRhdGUgRU5BQkxFX0lOUFVUX1RZUEVfQ09MT1IgYW5kIEVOQUJMRV9JTlBVVF9UWVBFX0NPTE9S X1BPUE9WRVIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL21hYy9XZWJEYXRh TGlzdFN1Z2dlc3Rpb25zRHJvcGRvd25NYWMubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9t YWMvV2ViRGF0YUxpc3RTdWdnZXN0aW9uc0Ryb3Bkb3duTWFjLm1tCmluZGV4IDFhNGY2MGFmNTMx ZGQwMDMxNmVjNGE1ZWFkNDQxMzMyZjlkMzE2ZjEuLjMxNDgxZDBkYWQ1OTM4Nzc4MjQ1NTgwYTli ODQ2ZjE2MDc4MWQwNTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL21hYy9X ZWJEYXRhTGlzdFN1Z2dlc3Rpb25zRHJvcGRvd25NYWMubW0KKysrIGIvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvbWFjL1dlYkRhdGFMaXN0U3VnZ2VzdGlvbnNEcm9wZG93bk1hYy5tbQpAQCAtNzcs NyArNzcsNyBAQCBzdGF0aWMgTlNTdHJpbmcgKiBjb25zdCBzdWdnZXN0aW9uQ2VsbFJldXNlSWRl bnRpZmllciA9IEAiV0tEYXRhTGlzdFN1Z2dlc3Rpb25DZQogLSAodm9pZCltb3ZlU2VsZWN0aW9u QnlEaXJlY3Rpb246KGNvbnN0IFN0cmluZyYpZGlyZWN0aW9uOwogLSAodm9pZClpbnZhbGlkYXRl OwogCi0tIChTdHJpbmcpY3VycmVudFNlbGVjdGVkU3RyaW5nOworLSAoc3RkOjpvcHRpb25hbDxT dHJpbmc+KWN1cnJlbnRTZWxlY3RlZFN0cmluZzsKIEBlbmQKIAogbmFtZXNwYWNlIFdlYktpdCB7 CkBAIC0xMjAsOCArMTIwLDEwIEBAIHZvaWQgV2ViRGF0YUxpc3RTdWdnZXN0aW9uc0Ryb3Bkb3du TWFjOjpzZWxlY3RPcHRpb24oKQogICAgIGlmICghbV9jbGllbnQpCiAgICAgICAgIHJldHVybjsK IAotICAgIFN0cmluZyBzZWxlY3RlZE9wdGlvbiA9IFttX2Ryb3Bkb3duVUkgY3VycmVudFNlbGVj dGVkU3RyaW5nXTsKLSAgICBtX2NsaWVudC0+ZGlkU2VsZWN0T3B0aW9uKHNlbGVjdGVkT3B0aW9u KTsKKyAgICBzdGQ6Om9wdGlvbmFsPFN0cmluZz4gc2VsZWN0ZWRPcHRpb24gPSBbbV9kcm9wZG93 blVJIGN1cnJlbnRTZWxlY3RlZFN0cmluZ107CisgICAgaWYgKHNlbGVjdGVkT3B0aW9uKQorICAg ICAgICBtX2NsaWVudC0+ZGlkU2VsZWN0T3B0aW9uKHNlbGVjdGVkT3B0aW9uLnZhbHVlKCkpOwor CiAgICAgY2xvc2UoKTsKIH0KIApAQCAtMTg5LDcgKzE5MSw3IEBAIHZvaWQgV2ViRGF0YUxpc3RT dWdnZXN0aW9uc0Ryb3Bkb3duTWFjOjpjbG9zZSgpCiAgICAgICAgIFtbTlNDb2xvciBhbHRlcm5h dGVTZWxlY3RlZENvbnRyb2xDb2xvcl0gc2V0RmlsbF07CiAgICAgICAgIFtfdGV4dEZpZWxkIHNl dFRleHRDb2xvcjpbTlNDb2xvciBhbHRlcm5hdGVTZWxlY3RlZENvbnRyb2xUZXh0Q29sb3JdXTsK ICAgICB9IGVsc2UgaWYgKF9tb3VzZUlzT3ZlcikgewotICAgICAgICBbW05TQ29sb3IgY29udHJv bENvbG9yXSBzZXRGaWxsXTsKKyAgICAgICAgW1tOU0NvbG9yIHF1YXRlcm5hcnlMYWJlbENvbG9y XSBzZXRGaWxsXTsKICAgICAgICAgW190ZXh0RmllbGQgc2V0VGV4dENvbG9yOltOU0NvbG9yIHRl eHRDb2xvcl1dOwogICAgIH0gZWxzZSB7CiAgICAgICAgIFtbTlNDb2xvciBjb250cm9sQmFja2dy b3VuZENvbG9yXSBzZXRGaWxsXTsKQEAgLTMyNywxMyArMzI5LDEzIEBAIHZvaWQgV2ViRGF0YUxp c3RTdWdnZXN0aW9uc0Ryb3Bkb3duTWFjOjpjbG9zZSgpCiAgICAgcmV0dXJuIHNlbGY7CiB9CiAK LS0gKFN0cmluZyljdXJyZW50U2VsZWN0ZWRTdHJpbmcKKy0gKHN0ZDo6b3B0aW9uYWw8U3RyaW5n PiljdXJyZW50U2VsZWN0ZWRTdHJpbmcKIHsKICAgICBzdGQ6Om9wdGlvbmFsPHNpemVfdD4gc2Vs ZWN0ZWRSb3cgPSBbX3RhYmxlIGN1cnJlbnRBY3RpdmVSb3ddOwogICAgIGlmIChzZWxlY3RlZFJv dyAmJiBzZWxlY3RlZFJvdy52YWx1ZSgpIDwgX3N1Z2dlc3Rpb25zLnNpemUoKSkKICAgICAgICAg cmV0dXJuIF9zdWdnZXN0aW9ucy5hdChzZWxlY3RlZFJvdy52YWx1ZSgpKTsKIAotICAgIHJldHVy biBlbXB0eVN0cmluZygpOworICAgIHJldHVybiBzdGQ6Om51bGxvcHQ7CiB9CiAKIC0gKHZvaWQp dXBkYXRlV2l0aEluZm9ybWF0aW9uOihXZWJDb3JlOjpEYXRhTGlzdFN1Z2dlc3Rpb25JbmZvcm1h dGlvbiYmKWluZm9ybWF0aW9uCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggY2M0YWRlZTkyYjk5MDMyMDdkYjQ0YWI3ZmYwNjRk MTcxMDg3NDJhMC4uMGE5NzBkZmQ3OTkwZmIwODJiODU5NjdkY2Q2MTA3NWVmNzQ1NmFmZSAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTA4LTI3ICBBZGl0eWEgS2VlcnRoaSAgPGFrZWVydGhp QGFwcGxlLmNvbT4KKworICAgICAgICBbRGF0YWxpc3RdIFByZXNzaW5nIGVudGVyIHdpdGhvdXQg YSBzZWxlY3RlZCBvcHRpb24gc2hvdWxkbid0IGNoYW5nZSB0aGUgaW5wdXQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4OTAxMAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEF1Z21lbnRlZCB0ZXN0IHRvIHZl cmlmeSB0aGF0IHByZXNzaW5nIGVudGVyIHdoZW4gdGhlcmUgaXMgbm8gc2VsZWN0ZWQgZGF0YWxp c3QKKyAgICAgICAgc3VnZ2VzdGlvbiBkb2VzIG5vdCBjaGFuZ2UgdGhlIHZhbHVlIG9mIHRoZSBp bnB1dCBmaWVsZC4KKworICAgICAgICAqIGZhc3QvZm9ybXMvZGF0YWxpc3QvZGF0YWxpc3QtdGV4 dGlucHV0LWtleWRvd24tZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGZhc3QvZm9ybXMvZGF0YWxp c3QvZGF0YWxpc3QtdGV4dGlucHV0LWtleWRvd24uaHRtbDoKKwogMjAxOC0wOC0yNyAgQW5keSBF c3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CiAKICAgICAgICAgW1BheW1lbnQgUmVxdWVzdF0gVXBk YXRlIHBheW1lbnQtcmVxdWVzdCB3ZWIgcGxhdGZvcm0gdGVzdHMKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL2Zhc3QvZm9ybXMvZGF0YWxpc3QvZGF0YWxpc3QtdGV4dGlucHV0LWtleWRvd24tZXhw ZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9kYXRhbGlzdC9kYXRhbGlzdC10ZXh0 aW5wdXQta2V5ZG93bi1leHBlY3RlZC50eHQKaW5kZXggNGFjNTBkNmFiOWI3ODJkNTc1ODRiYjY3 MDNkNTk2NDI5YWY3ZTg4Zi4uODg2YWQ2MWFjMzNhMTZjYmJhN2JiOGE0ZDUwZmM4ZGNhYjMwNDBk ZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9kYXRhbGlzdC9kYXRhbGlzdC10 ZXh0aW5wdXQta2V5ZG93bi1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jt cy9kYXRhbGlzdC9kYXRhbGlzdC10ZXh0aW5wdXQta2V5ZG93bi1leHBlY3RlZC50eHQKQEAgLTUs NiArNSw3IEBAIE9uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVz c2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFCiAKIFBBU1MgaW5wdXQudmFsdWUgaXMg IkFwcGxlIgogUEFTUyBpbnB1dC52YWx1ZSBpcyAiUGVhciIKK1BBU1MgaW5wdXQudmFsdWUgaXMg IkFwcGwiCiBQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCiAKIFRFU1QgQ09NUExFVEUK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvZGF0YWxpc3QvZGF0YWxpc3QtdGV4 dGlucHV0LWtleWRvd24uaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvZGF0YWxpc3QvZGF0 YWxpc3QtdGV4dGlucHV0LWtleWRvd24uaHRtbAppbmRleCAzMzQ2ODkyNjY3OGFiNThhNmFlNDU3 YTliM2IxNWM2OWI3MTA4NDA3Li4yMmM0ODhkZmU5YjkyOTMyN2RmMjhmNTI1MDI1YmNjNmY2OWYw Y2ZiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2RhdGFsaXN0L2RhdGFsaXN0 LXRleHRpbnB1dC1rZXlkb3duLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9kYXRh bGlzdC9kYXRhbGlzdC10ZXh0aW5wdXQta2V5ZG93bi5odG1sCkBAIC0yMiw3ICsyMiw2IEBAIHZh ciBpbnB1dCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJmcnVpdCIpOwogVUlIZWxwZXIuYWN0 aXZhdGVFbGVtZW50KGlucHV0KTsKIGV2ZW50U2VuZGVyLmtleURvd24oImRvd25BcnJvdyIpOwog ZXZlbnRTZW5kZXIua2V5RG93bigiXHIiKTsKLQogc2hvdWxkQmUoJ2lucHV0LnZhbHVlJywgJyJB cHBsZSInKTsKIAogaW5wdXQudmFsdWUgPSAiIjsKQEAgLTMwLDkgKzI5LDE0IEBAIGlucHV0LnZh bHVlID0gIiI7CiBVSUhlbHBlci5hY3RpdmF0ZUVsZW1lbnQoaW5wdXQpOwogZXZlbnRTZW5kZXIu a2V5RG93bigidXBBcnJvdyIpOwogZXZlbnRTZW5kZXIua2V5RG93bigiXHIiKTsKLQogc2hvdWxk QmUoJ2lucHV0LnZhbHVlJywgJyJQZWFyIicpOwogCitpbnB1dC52YWx1ZSA9ICJBcHBsIjsKKwor VUlIZWxwZXIuYWN0aXZhdGVFbGVtZW50KGlucHV0KTsKK2V2ZW50U2VuZGVyLmtleURvd24oIlxy Iik7CitzaG91bGRCZSgnaW5wdXQudmFsdWUnLCAnIkFwcGwiJyk7CisKIDwvc2NyaXB0PgogCiA8 c2NyaXB0IHNyYz0iLi4vLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+ Cg==