18900 2008-05-05 16:18:45 -0700 Password field has focus but can't type text (i.rememberthemilk.com) 2008-05-24 17:35:23 -0700 1 1 1 Unclassified WebKit Forms 523.x (Safari 3) Mac OS X 10.5 RESOLVED FIXED http://i.rememberthemilk.com/ HasReduction, InRadar P2 Normal --- 1 ddkilzer webkit-unassigned adele aegolden oldest_to_newest 79711 0 ddkilzer 2008-05-05 16:18:45 -0700 * SUMMARY The password field on i.rememberthemilk.com gets focus, but the user can't type any text until they click in the field again. * STEPS TO REPRODUCE 1. Launch Safari/WebKit. 2. Go to URL: http://i.rememberthemilk.com/ 3. Hit Tab. 4. Type a dummy username. 5. Hit Tab. 6. Type a dummy password. * EXPECTED RESULTS Typing in Step 6 should appear in the password field. * ACTUAL RESULTS Typing in Step 6 does nothing (even though the password field appears to have focus). * REGRESSION Unknown. Only tested with Safari 3.1.1 on Mac OS X 10.5.x Leopard. * NOTES <rdar://problem/5912383> 79744 1 20985 gamander 2008-05-06 06:44:47 -0700 Created attachment 20985 possible reduction 79745 2 ddkilzer 2008-05-06 06:53:22 -0700 (In reply to comment #0) > * REGRESSION > Unknown. Only tested with Safari 3.1.1 on Mac OS X 10.5.x Leopard. This is not a regression. Safari 2.0.4 with original WebKit on Mac OS X 10.4.11 exhibits similar behavior. WebKit nightly build r11976 exhibits the same behavior as ToT WebKit today (r32901). 79747 3 ddkilzer 2008-05-06 06:55:54 -0700 (In reply to comment #1) > Created an attachment (id=20985) [edit] > possible reduction Great reduction, Marcus! Thanks! 79777 4 20991 aegolden 2008-05-06 17:21:20 -0700 Created attachment 20991 Proposed patch, minus new layout test The patch makes HTMLInputElement handle the edge case where the document is changing the type of the focused node. The node needs to update its selection range after reattaching. 79782 5 20991 adele 2008-05-06 17:49:49 -0700 Comment on attachment 20991 Proposed patch, minus new layout test instead of setting the selection range directly, it might be better to call updateFocusAppearance with the right value for restorePreviousSelection 79809 6 21000 ddkilzer 2008-05-07 04:02:30 -0700 Created attachment 21000 Patch v2 Patch with layout test and changelogs. All existing layout tests pass with this change. 79822 7 ddkilzer 2008-05-07 10:15:47 -0700 Committed revision 32959. 81389 8 ddkilzer 2008-05-24 17:35:23 -0700 In the original page, the <input> element that held the password would change from type="text" to type="password" using an onfocus event. This bug is fixed for the original page. The new page uses two <input> tags, and changes their CSS class to make then hidden or visible. It works with mouse clicks, but fails with tabs. This seems to be a server-side issue that it doesn't do the same thing with tabbed focus as with mouse clicks. 20985 2008-05-06 06:44:47 -0700 2008-05-06 06:44:47 -0700 possible reduction test.html text/html 245 gamander PGh0bWw+CjxoZWFkPiAgICAKPHNjcmlwdD4KZnVuY3Rpb24gZih0ZXh0RmllbGQpewoJdGV4dEZp ZWxkLnNldEF0dHJpYnV0ZSgidHlwZSIsICJwYXNzd29yZCIpOwp9Cjwvc2NyaXB0Pgo8L2hlYWQ+ Cjxib2R5Pgo8cD4xLiBIaXQgVGFiIGtleSB0byBmb2N1cyBpbnB1dCBmaWVsZC48YnIgLz4yLiBU eXBlIHNvbWUgdGV4dC48L3A+CjxpbnB1dCB0eXBlPSJ0ZXh0IiBvbmZvY3VzPSJmKHRoaXMpIiAv Pgo8L2JvZHk+CjwvaHRtbD4= 20991 2008-05-06 17:21:20 -0700 2008-05-07 04:02:30 -0700 Proposed patch, minus new layout test 18900Patch.txt text/plain 693 aegolden SW5kZXg6IGh0bWwvSFRNTElucHV0RWxlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gaHRtbC9IVE1M SW5wdXRFbGVtZW50LmNwcAkocmV2aXNpb24gNTIyNjMpCisrKyBodG1sL0hUTUxJbnB1dEVsZW1l bnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMzksOSArMzM5LDE1IEBACiAgICAgICAgICAgICAg ICAgICAgIGF0dHJpYnV0ZUNoYW5nZWQoYWxpZ24sIGZhbHNlKTsKICAgICAgICAgICAgIH0KIAot ICAgICAgICAgICAgaWYgKHdhc0F0dGFjaGVkKQorICAgICAgICAgICAgaWYgKHdhc0F0dGFjaGVk KSB7CiAgICAgICAgICAgICAgICAgYXR0YWNoKCk7Ci0KKyAgICAgICAgICAgICAgICAKKyAgICAg ICAgICAgICAgICBpZiAoZG9jdW1lbnQoKS0+Zm9jdXNlZE5vZGUoKSA9PSB0aGlzKSB7CisgICAg ICAgICAgICAgICAgICAgIHVuc2lnbmVkIG1heCA9IG1fdmFsdWUubGVuZ3RoKCk7CisgICAgICAg ICAgICAgICAgICAgIHNldFNlbGVjdGlvblJhbmdlKG1heCwgbWF4KTsKKyAgICAgICAgICAgICAg ICB9CisgICAgICAgICAgICB9CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgCiAgICAgICAg ICAgICBjaGVja2VkUmFkaW9CdXR0b25zKHRoaXMpLmFkZEJ1dHRvbih0aGlzKTsKICAgICAgICAg fQogICAgIH0K 21000 2008-05-07 04:02:30 -0700 2008-05-07 09:46:19 -0700 Patch v2 bug-18900-v2.diff text/plain 4513 ddkilzer SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzMjkzNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDgtMDUtMDcgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxl LmNvbT4KKworICAgICAgICBCdWcgMTg5MDA6IFBhc3N3b3JkIGZpZWxkIGhhcyBmb2N1cyBidXQg Y2FuJ3QgdHlwZSB0ZXh0IChpLnJlbWVtYmVydGhlbWlsay5jb20pCisgICAgICAgIDxodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg5MDA+CisKKyAgICAgICAgT3JpZ2lu YWwgcGF0Y2ggYnkgQWFyb24gR29sZGVuIGFuZCBUaW0gT21lcm5pY2suICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0OiBmYXN0L2Zvcm1zL3RleHRmaWVsZC10by1w YXNzd29yZC1vbi1mb2N1cy5odG1sCisKKyAgICAgICAgKiBodG1sL0hUTUxJbnB1dEVsZW1lbnQu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTElucHV0RWxlbWVudDo6c2V0SW5wdXRUeXBlKTog SWYgdGhlIGN1cnJlbnQgbm9kZSBoYXMKKyAgICAgICAgZm9jdXMsIGNhbGwgdXBkYXRlRm9jdXNB cHBlYXJhbmNlKCkgdG8gbWFrZSBzdXJlIGl0cyBzdGF0ZSBpcyBjb3JyZWN0CisgICAgICAgIGFm dGVyIGNoYW5naW5nIGl0cyB0eXBlLgorCiAyMDA4LTA1LTA2ICBBbHAgVG9rZXIgIDxhbHBAbnVh bnRpLmNvbT4KIAogICAgICAgICBHVEsrIGJ1aWxkIGZpeC4gQWRkIGVtcHR5IHN0dWIgdG8ga2Vl cCBub24tYWNjZXNzaWJsZSBwb3J0cyBidWlsZGluZy4KSW5kZXg6IFdlYkNvcmUvaHRtbC9IVE1M SW5wdXRFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2h0bWwvSFRNTElucHV0RWxl bWVudC5jcHAJKHJldmlzaW9uIDMyNzc0KQorKysgV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1l bnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMzUsOCArMzM1LDExIEBAIHZvaWQgSFRNTElucHV0 RWxlbWVudDo6c2V0SW5wdXRUeXBlKGNvbnMKICAgICAgICAgICAgICAgICAgICAgYXR0cmlidXRl Q2hhbmdlZChhbGlnbiwgZmFsc2UpOwogICAgICAgICAgICAgfQogCi0gICAgICAgICAgICBpZiAo d2FzQXR0YWNoZWQpCisgICAgICAgICAgICBpZiAod2FzQXR0YWNoZWQpIHsKICAgICAgICAgICAg ICAgICBhdHRhY2goKTsKKyAgICAgICAgICAgICAgICBpZiAoZG9jdW1lbnQoKS0+Zm9jdXNlZE5v ZGUoKSA9PSB0aGlzKQorICAgICAgICAgICAgICAgICAgICB1cGRhdGVGb2N1c0FwcGVhcmFuY2Uo dHJ1ZSk7CisgICAgICAgICAgICB9CiAKICAgICAgICAgICAgIGNoZWNrZWRSYWRpb0J1dHRvbnMo dGhpcykuYWRkQnV0dG9uKHRoaXMpOwogICAgICAgICB9CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFu Z2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAzMjk1 MSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEz IEBACisyMDA4LTA1LTA3ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAg ICAgICAgQnVnIDE4OTAwOiBQYXNzd29yZCBmaWVsZCBoYXMgZm9jdXMgYnV0IGNhbid0IHR5cGUg dGV4dCAoaS5yZW1lbWJlcnRoZW1pbGsuY29tKQorICAgICAgICA8aHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE4OTAwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogZmFzdC9mb3Jtcy90ZXh0ZmllbGQtdG8tcGFzc3dvcmQt b24tZm9jdXMtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Zvcm1zL3RleHRm aWVsZC10by1wYXNzd29yZC1vbi1mb2N1cy5odG1sOiBBZGRlZC4KKwogMjAwOC0wNS0wNiAgRGFu IEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmlu IEFkbGVyLgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy90ZXh0ZmllbGQtdG8tcGFzc3dv cmQtb24tZm9jdXMtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3Qv Zm9ybXMvdGV4dGZpZWxkLXRvLXBhc3N3b3JkLW9uLWZvY3VzLWV4cGVjdGVkLnR4dAkocmV2aXNp b24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZm9ybXMvdGV4dGZpZWxkLXRvLXBhc3N3b3JkLW9u LWZvY3VzLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxMyBAQAorSGl0IFRh YiBrZXkgdG8gZm9jdXMgaW5wdXQgZmllbGQuCitUeXBlIHNvbWUgdGV4dC4KKworVGVzdCBmb3Ig QnVnIDE4OTAwOiBQYXNzd29yZCBmaWVsZCBoYXMgZm9jdXMgYnV0IGNhbid0IHR5cGUgdGV4dCAo aS5yZW1lbWJlcnRoZW1pbGsuY29tKQorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJp ZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKwor UEFTUyBmaWVsZC52YWx1ZSBpcyAncGFzcycKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRy dWUKKworVEVTVCBDT01QTEVURQorCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3RleHRm aWVsZC10by1wYXNzd29yZC1vbi1mb2N1cy5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz L2Zhc3QvZm9ybXMvdGV4dGZpZWxkLXRvLXBhc3N3b3JkLW9uLWZvY3VzLmh0bWwJKHJldmlzaW9u IDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3RleHRmaWVsZC10by1wYXNzd29yZC1vbi1m b2N1cy5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDQ3IEBACis8IURPQ1RZUEUgSFRNTCBQ VUJMSUMgIi0vL0lFVEYvL0RURCBIVE1MLy9FTiI+Cis8aHRtbD4KKzxoZWFkPiAgICAKKzxsaW5r IHJlbD0ic3R5bGVzaGVldCIgaHJlZj0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3Qtc3R5bGUuY3Nz Ij4KKzxzY3JpcHQgc3JjPSIuLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0 PgorPHNjcmlwdD4KK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKKyAgICB3aW5k b3cubGF5b3V0VGVzdENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOworICAgIHdpbmRvdy5sYXlv dXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7Cit9CisKK2Z1bmN0aW9uIGNoYW5nZVRvUGFz c3dvcmRGaWVsZCh0ZXh0RmllbGQpCit7CisgICAgdGV4dEZpZWxkLnNldEF0dHJpYnV0ZSgidHlw ZSIsICJwYXNzd29yZCIpOworfQorCitmdW5jdGlvbiB0ZXN0KCkKK3sKKyAgICBpZiAod2luZG93 LmxheW91dFRlc3RDb250cm9sbGVyKSB7CisgICAgICAgIHZhciBmaWVsZCA9IGRvY3VtZW50Lmdl dEVsZW1lbnRCeUlkKCJmaWVsZCIpLmZvY3VzKCk7CisKKyAgICAgICAgZXZlbnRTZW5kZXIua2V5 RG93bigicCIpOworICAgICAgICBldmVudFNlbmRlci5rZXlEb3duKCJhIik7CisgICAgICAgIGV2 ZW50U2VuZGVyLmtleURvd24oInMiKTsKKyAgICAgICAgZXZlbnRTZW5kZXIua2V5RG93bigicyIp OworCisgICAgICAgIHNob3VsZEJlKCdmaWVsZC52YWx1ZScsICIncGFzcyciKTsKKyAgICAgICAg aXNTdWNjZXNzZnVsbHlQYXJzZWQoKTsKKworICAgICAgICB3aW5kb3cubGF5b3V0VGVzdENvbnRy b2xsZXIubm90aWZ5RG9uZSgpOworICAgIH0KK30KKzwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHkg b25sb2FkPSJ0ZXN0KCkiPgorPG9sPjxsaT5IaXQgVGFiIGtleSB0byBmb2N1cyBpbnB1dCBmaWVs ZC48L2xpPjxsaT5UeXBlIHNvbWUgdGV4dC48L2xpPjwvb2w+Cis8aW5wdXQgdHlwZT0idGV4dCIg aWQ9ImZpZWxkIiBvbmZvY3VzPSJjaGFuZ2VUb1Bhc3N3b3JkRmllbGQodGhpcykiPgorPGhyPgor PHAgaWQ9ImRlc2NyaXB0aW9uIj48L3A+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKzxzY3Jp cHQ+CitkZXNjcmlwdGlvbigiVGVzdCBmb3IgPGEgaHJlZj1cImh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xODkwMFwiPkJ1ZyAxODkwMDogUGFzc3dvcmQgZmllbGQgaGFz IGZvY3VzIGJ1dCBjYW4ndCB0eXBlIHRleHQgKGkucmVtZW1iZXJ0aGVtaWxrLmNvbSk8L2E+Iik7 CitzdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOworPC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4v anMvcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC1mdW5jdGlvbi5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+ Cis8L2h0bWw+Cg==