188954 2018-08-26 11:52:50 -0700 [Apple Pay] PaymentRequest.show() should reject when an unsupported ApplePayRequest version is specified 2018-08-29 19:27:18 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aestes aestes achristensen andersca commit-queue darin mitz sam webkit-bug-importer youennf oldest_to_newest 1453722 0 aestes 2018-08-26 11:52:50 -0700 [Apple Pay] PaymentRequest.show() should reject when an unsupported ApplePayRequest version is specified 1453723 1 348098 aestes 2018-08-26 11:58:46 -0700 Created attachment 348098 Patch 1453727 2 348098 darin 2018-08-26 13:58:18 -0700 Comment on attachment 348098 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348098&action=review > Source/WebCore/Modules/applepay/ApplePayRequestBase.cpp:55 > + return Exception { InvalidAccessError, makeString("\"", String::number(version), "\" is not a supported version.") }; We should not need the String::number here as long as we include the StringConcatenateNumbers.h header. Doing it with an explicit call to String::number makes slower, larger code so we shouldn’t do it. I realize now you are just moving this code, but consider fixing it while moving it. 1453742 3 348106 aestes 2018-08-26 17:55:12 -0700 Created attachment 348106 Patch 1453755 4 348106 commit-queue 2018-08-26 18:39:58 -0700 Comment on attachment 348106 Patch Clearing flags on attachment: 348106 Committed r235342: <https://trac.webkit.org/changeset/235342> 1453756 5 commit-queue 2018-08-26 18:39:59 -0700 All reviewed patches have been landed. Closing bug. 1453757 6 webkit-bug-importer 2018-08-26 18:40:16 -0700 <rdar://problem/43739375> 1454688 7 348106 darin 2018-08-28 20:38:09 -0700 Comment on attachment 348106 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348106&action=review > Source/WebCore/Modules/applepay/ApplePayRequestBase.cpp:56 > + return Exception { InvalidAccessError, makeString("\"", version, "\" is not a supported version.") }; Missed another opportunity to slightly improve the makeString call. We could use '"' instead of "\"" for the first argument and it’s possibly going to be ever so slightly more efficient. 1455118 8 aestes 2018-08-29 19:27:18 -0700 (In reply to Darin Adler from comment #7) > Missed another opportunity to slightly improve the makeString call. We could > use '"' instead of "\"" for the first argument and it’s possibly going to be > ever so slightly more efficient. Fixed in r235494: <https://trac.webkit.org/changeset/235494>. 348098 2018-08-26 11:58:46 -0700 2018-08-26 17:55:10 -0700 Patch bug-188954-20180826115845.patch text/plain 6690 aestes U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1MzM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzAyYzk0MmE4Y2I3ZTQz ZDVkZmM0NmQ1Y2JiMTg5NWU3OWI0YjE3Ni4uZjYxMDdhYzMxYjc0NTRjMGYzOTFkNjNmMzlhM2Vj NzAxMDM3MGY4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE4LTA4LTI2ICBBbmR5 IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBbQXBwbGUgUGF5XSBQYXltZW50 UmVxdWVzdC5zaG93KCkgc2hvdWxkIHJlamVjdCB3aGVuIGFuIHVuc3VwcG9ydGVkIEFwcGxlUGF5 UmVxdWVzdCB2ZXJzaW9uIGlzIHNwZWNpZmllZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg4OTU0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgSW4gQXBwbGUgUGF5IEpTLCBjYWxsaW5nIHRoZSBBcHBsZVBh eVNlc3Npb24gY29uc3RydWN0b3Igd2l0aCBhbiB1bnN1cHBvcnRlZCB2ZXJzaW9uIHJlc3VsdHMK KyAgICAgICAgaW4gYW4gZXhjZXB0aW9uIGJlaW5nIHRocm93bi4gV2UgbmVlZCB0byBkbyBzb21l dGhpbmcgc2ltaWxhciBmb3IgUGF5bWVudCBSZXF1ZXN0LgorCisgICAgICAgIFRoaXMgcGF0Y2gg bW92ZXMgdGhlIGxvZ2ljIGZvciB2YWxpZGF0aW5nIHRoZSB2ZXJzaW9uIGZyb20gQXBwbGVQYXlT ZXNzaW9uIHRvIGEgY29tbW9uCisgICAgICAgIHJvdXRpbmUgaW4gQXBwbGVQYXlSZXF1ZXN0QmFz ZSB0aGF0IGJvdGggQVBJcyBjYWxsIHRvIGNvbnZlcnQgcmVxdWVzdHMgaW50byBhIGNvbW1vbiBm b3JtYXQuCisKKyAgICAgICAgSW4gQXBwbGUgUGF5IEpTLCBhbiBleGNlcHRpb24gd2lsbCBzdGls bCBiZSB0aHJvd24gd2hlbiBjb25zdHJ1Y3RpbmcgYW4gQXBwbGVQYXlTZXNzaW9uLiBJbgorICAg ICAgICBQYXltZW50IFJlcXVlc3QsIHRoZSBwcm9taXNlIHJldHVybmVkIGJ5IHNob3coKSB3aWxs IGJlIHJlamVjdGVkLgorCisgICAgICAgIEFkZGVkIHRlc3QgY2FzZXMgdG8gaHR0cC90ZXN0cy9z c2wvYXBwbGVwYXkvUGF5bWVudFJlcXVlc3QuaHR0cHMuaHRtbC4KKworICAgICAgICAqIE1vZHVs ZXMvYXBwbGVwYXkvQXBwbGVQYXlSZXF1ZXN0QmFzZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpj b252ZXJ0QW5kVmFsaWRhdGUpOgorICAgICAgICAqIE1vZHVsZXMvYXBwbGVwYXkvQXBwbGVQYXlT ZXNzaW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFwcGxlUGF5U2Vzc2lvbjo6Y3JlYXRlKToK KwogMjAxOC0wOC0yNCAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAg ICBDbGljayBldmVudCBmcm9tIGNsaWNrKCkgaXMgbm90IGNvbXBvc2VkCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2FwcGxlcGF5L0FwcGxlUGF5UmVxdWVzdEJhc2UuY3BwIGIv U291cmNlL1dlYkNvcmUvTW9kdWxlcy9hcHBsZXBheS9BcHBsZVBheVJlcXVlc3RCYXNlLmNwcApp bmRleCAwZWM4ZDEyMjQyZDFiZTFjMzBhZjdhYzE4NmEwNGM0NzAwODQxMjZjLi4xYjE1NWQ3ODAy MGFlMTE0ODMzYjhhZjllODE3NzA5OGVhY2Y1ZjE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9Nb2R1bGVzL2FwcGxlcGF5L0FwcGxlUGF5UmVxdWVzdEJhc2UuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvYXBwbGVwYXkvQXBwbGVQYXlSZXF1ZXN0QmFzZS5jcHAKQEAgLTUxLDYg KzUxLDkgQEAgc3RhdGljIEV4Y2VwdGlvbk9yPFZlY3RvcjxTdHJpbmc+PiBjb252ZXJ0QW5kVmFs aWRhdGUodW5zaWduZWQgdmVyc2lvbiwgY29uc3QgVmUKIAogRXhjZXB0aW9uT3I8QXBwbGVQYXlT ZXNzaW9uUGF5bWVudFJlcXVlc3Q+IGNvbnZlcnRBbmRWYWxpZGF0ZSh1bnNpZ25lZCB2ZXJzaW9u LCBBcHBsZVBheVJlcXVlc3RCYXNlJiByZXF1ZXN0LCBjb25zdCBQYXltZW50Q29vcmRpbmF0b3Im IHBheW1lbnRDb29yZGluYXRvcikKIHsKKyAgICBpZiAoIXZlcnNpb24gfHwgIXBheW1lbnRDb29y ZGluYXRvci5zdXBwb3J0c1ZlcnNpb24odmVyc2lvbikpCisgICAgICAgIHJldHVybiBFeGNlcHRp b24geyBJbnZhbGlkQWNjZXNzRXJyb3IsIG1ha2VTdHJpbmcoIlwiIiwgU3RyaW5nOjpudW1iZXIo dmVyc2lvbiksICJcIiBpcyBub3QgYSBzdXBwb3J0ZWQgdmVyc2lvbi4iKSB9OworCiAgICAgQXBw bGVQYXlTZXNzaW9uUGF5bWVudFJlcXVlc3QgcmVzdWx0OwogICAgIHJlc3VsdC5zZXRWZXJzaW9u KHZlcnNpb24pOwogICAgIHJlc3VsdC5zZXRDb3VudHJ5Q29kZShyZXF1ZXN0LmNvdW50cnlDb2Rl KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvYXBwbGVwYXkvQXBwbGVQYXlT ZXNzaW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvYXBwbGVwYXkvQXBwbGVQYXlTZXNz aW9uLmNwcAppbmRleCA0NmRmYWM5NTliNmNhOWE3NDM1YjY0MjIyN2Q1MjdiOGFhNTEzOWIzLi5i YmI3YzhiMDE2NTNlZWMxMDhlZWUxY2M3YjMwNDU0NTU0MmMyMzQ1IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL2FwcGxlcGF5L0FwcGxlUGF5U2Vzc2lvbi5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvTW9kdWxlcy9hcHBsZXBheS9BcHBsZVBheVNlc3Npb24uY3BwCkBAIC00MDYs MTIgKzQwNiw3IEBAIEV4Y2VwdGlvbk9yPFJlZjxBcHBsZVBheVNlc3Npb24+PiBBcHBsZVBheVNl c3Npb246OmNyZWF0ZShEb2N1bWVudCYgZG9jdW1lbnQsIHVuCiAgICAgaWYgKCFkb2N1bWVudC5w YWdlKCkpCiAgICAgICAgIHJldHVybiBFeGNlcHRpb24geyBJbnZhbGlkQWNjZXNzRXJyb3IsICJG cmFtZSBpcyBkZXRhY2hlZCIgfTsKIAotICAgIGF1dG8mIHBheW1lbnRDb29yZGluYXRvciA9IGRv Y3VtZW50LnBhZ2UoKS0+cGF5bWVudENvb3JkaW5hdG9yKCk7Ci0KLSAgICBpZiAoIXZlcnNpb24g fHwgIXBheW1lbnRDb29yZGluYXRvci5zdXBwb3J0c1ZlcnNpb24odmVyc2lvbikpCi0gICAgICAg IHJldHVybiBFeGNlcHRpb24geyBJbnZhbGlkQWNjZXNzRXJyb3IsIG1ha2VTdHJpbmcoIlwiIiAr IFN0cmluZzo6bnVtYmVyKHZlcnNpb24pLCAiXCIgaXMgbm90IGEgc3VwcG9ydGVkIHZlcnNpb24u IikgfTsKLQotICAgIGF1dG8gY29udmVydGVkUGF5bWVudFJlcXVlc3QgPSBjb252ZXJ0QW5kVmFs aWRhdGUodmVyc2lvbiwgV1RGTW92ZShwYXltZW50UmVxdWVzdCksIHBheW1lbnRDb29yZGluYXRv cik7CisgICAgYXV0byBjb252ZXJ0ZWRQYXltZW50UmVxdWVzdCA9IGNvbnZlcnRBbmRWYWxpZGF0 ZSh2ZXJzaW9uLCBXVEZNb3ZlKHBheW1lbnRSZXF1ZXN0KSwgZG9jdW1lbnQucGFnZSgpLT5wYXlt ZW50Q29vcmRpbmF0b3IoKSk7CiAgICAgaWYgKGNvbnZlcnRlZFBheW1lbnRSZXF1ZXN0Lmhhc0V4 Y2VwdGlvbigpKQogICAgICAgICByZXR1cm4gY29udmVydGVkUGF5bWVudFJlcXVlc3QucmVsZWFz ZUV4Y2VwdGlvbigpOwogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZmY1MTkwNjhhMjk3YmQ1OGQxODBiMGY3MGRkMWRkYTlj NWI2OWM4OS4uNTE5NzZjZTc4Y2Y5YTM0ODkwMmEyMTFkZjk2NGJiOTI2NDM4NTYwOSAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpA QCAtMSwzICsxLDEzIEBACisyMDE4LTA4LTI2ICBBbmR5IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNv bT4KKworICAgICAgICBbQXBwbGUgUGF5XSBQYXltZW50UmVxdWVzdC5zaG93KCkgc2hvdWxkIHJl amVjdCB3aGVuIGFuIHVuc3VwcG9ydGVkIEFwcGxlUGF5UmVxdWVzdCB2ZXJzaW9uIGlzIHNwZWNp ZmllZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg4 OTU0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBo dHRwL3Rlc3RzL3NzbC9hcHBsZXBheS9QYXltZW50UmVxdWVzdC5odHRwcy1leHBlY3RlZC50eHQ6 CisgICAgICAgICogaHR0cC90ZXN0cy9zc2wvYXBwbGVwYXkvUGF5bWVudFJlcXVlc3QuaHR0cHMu aHRtbDoKKwogMjAxOC0wOC0yNCAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAog ICAgICAgICBVc2luZyBUb3VjaCBCYXIgdG8gc2NydWIgdmlkZW8gb24gWW91dHViZSByZXN1bHRz IGluIHZpZGVvIHBsYXliYWNrIGZyZWV6ZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90 ZXN0cy9zc2wvYXBwbGVwYXkvUGF5bWVudFJlcXVlc3QuaHR0cHMtZXhwZWN0ZWQudHh0IGIvTGF5 b3V0VGVzdHMvaHR0cC90ZXN0cy9zc2wvYXBwbGVwYXkvUGF5bWVudFJlcXVlc3QuaHR0cHMtZXhw ZWN0ZWQudHh0CmluZGV4IDkxZmViMmI0ZTRjOWQ5MmJlMzljMTk4MDY0NDQ2MjBjM2ZhZmFkNmYu LmYyNmM4Njg1MWEwM2QzYTJjZjQ5ZDc4ZGQ5MjY2NzRlN2Y2ZTZmYjQgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL2h0dHAvdGVzdHMvc3NsL2FwcGxlcGF5L1BheW1lbnRSZXF1ZXN0Lmh0dHBzLWV4 cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3NzbC9hcHBsZXBheS9QYXlt ZW50UmVxdWVzdC5odHRwcy1leHBlY3RlZC50eHQKQEAgLTgsNiArOCwxMyBAQCBUZXN0aW5nIFBh eW1lbnRSZXF1ZXN0CiBQQVNTIG5ldyBQYXltZW50UmVxdWVzdChudWxsLCBudWxsKSB0aHJldyBl eGNlcHRpb24gVHlwZUVycm9yOiBWYWx1ZSBpcyBub3QgYSBzZXF1ZW5jZS4KIFBBU1MgbmV3IFBh eW1lbnRSZXF1ZXN0KFt2YWxpZFBheW1lbnRNZXRob2QoKV0sIHZhbGlkUGF5bWVudERldGFpbHMo KSkgZGlkIG5vdCB0aHJvdyBleGNlcHRpb24uCiAKK1Rlc3RpbmcgQXBwbGVQYXlSZXF1ZXN0LnZl cnNpb24KKworU0VUVVA6IHBheW1lbnRNZXRob2QgPSB2YWxpZFBheW1lbnRNZXRob2QoKTsgcGF5 bWVudE1ldGhvZC5kYXRhLnZlcnNpb24gPSAwOworUEFTUyByZXF1ZXN0ID0gbmV3IFBheW1lbnRS ZXF1ZXN0KFtwYXltZW50TWV0aG9kXSwgdmFsaWRQYXltZW50RGV0YWlscygpKTsgcmVxdWVzdC5z aG93KCkgcmVqZWN0ZWQgcHJvbWlzZSAgd2l0aCBJbnZhbGlkQWNjZXNzRXJyb3I6ICIwIiBpcyBu b3QgYSBzdXBwb3J0ZWQgdmVyc2lvbi4uCitTRVRVUDogcGF5bWVudE1ldGhvZCA9IHZhbGlkUGF5 bWVudE1ldGhvZCgpOyBwYXltZW50TWV0aG9kLmRhdGEudmVyc2lvbiA9IDEwMDA7CitQQVNTIHJl cXVlc3QgPSBuZXcgUGF5bWVudFJlcXVlc3QoW3BheW1lbnRNZXRob2RdLCB2YWxpZFBheW1lbnRE ZXRhaWxzKCkpOyByZXF1ZXN0LnNob3coKSByZWplY3RlZCBwcm9taXNlICB3aXRoIEludmFsaWRB Y2Nlc3NFcnJvcjogIjEwMDAiIGlzIG5vdCBhIHN1cHBvcnRlZCB2ZXJzaW9uLi4KKwogVGVzdGlu ZyBBcHBsZVBheVJlcXVlc3QuY291bnRyeUNvZGUKIAogU0VUVVA6IHBheW1lbnRNZXRob2QgPSB2 YWxpZFBheW1lbnRNZXRob2QoKTsgZGVsZXRlIHBheW1lbnRNZXRob2QuZGF0YS5jb3VudHJ5Q29k ZTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvc3NsL2FwcGxlcGF5L1BheW1l bnRSZXF1ZXN0Lmh0dHBzLmh0bWwgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3NzbC9hcHBsZXBh eS9QYXltZW50UmVxdWVzdC5odHRwcy5odG1sCmluZGV4IGNkMmFiOTg0ZTE3NjVkYjdhMDkzNWEx MmIwODBjOTZkYjEwNWJmNWIuLjk0ODI1MjMzYTEyMGQ0NDViYWQ1OGU4NGE1YmMwNWM4NThmNTYy OGIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvc3NsL2FwcGxlcGF5L1BheW1l bnRSZXF1ZXN0Lmh0dHBzLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9zc2wvYXBw bGVwYXkvUGF5bWVudFJlcXVlc3QuaHR0cHMuaHRtbApAQCAtNTUsNiArNTUsMTIgQEAgYXN5bmMg ZnVuY3Rpb24gZ28oKSB7CiAgICAgc2hvdWxkVGhyb3coIm5ldyBQYXltZW50UmVxdWVzdChudWxs LCBudWxsKSIpCiAgICAgc2hvdWxkTm90VGhyb3coIm5ldyBQYXltZW50UmVxdWVzdChbdmFsaWRQ YXltZW50TWV0aG9kKCldLCB2YWxpZFBheW1lbnREZXRhaWxzKCkpIikKICAgICBkZWJ1ZygiIikK KyAgICAKKyAgICBkZWJ1ZygiVGVzdGluZyBBcHBsZVBheVJlcXVlc3QudmVyc2lvbiIpCisgICAg ZGVidWcoIiIpCisgICAgYXdhaXQgbG9nQW5kU2hvdWxkUmVqZWN0KCJwYXltZW50TWV0aG9kID0g dmFsaWRQYXltZW50TWV0aG9kKCk7IHBheW1lbnRNZXRob2QuZGF0YS52ZXJzaW9uID0gMDsiLCAi cmVxdWVzdCA9IG5ldyBQYXltZW50UmVxdWVzdChbcGF5bWVudE1ldGhvZF0sIHZhbGlkUGF5bWVu dERldGFpbHMoKSk7IHJlcXVlc3Quc2hvdygpIikKKyAgICBhd2FpdCBsb2dBbmRTaG91bGRSZWpl Y3QoInBheW1lbnRNZXRob2QgPSB2YWxpZFBheW1lbnRNZXRob2QoKTsgcGF5bWVudE1ldGhvZC5k YXRhLnZlcnNpb24gPSAxMDAwOyIsICJyZXF1ZXN0ID0gbmV3IFBheW1lbnRSZXF1ZXN0KFtwYXlt ZW50TWV0aG9kXSwgdmFsaWRQYXltZW50RGV0YWlscygpKTsgcmVxdWVzdC5zaG93KCkiKQorICAg IGRlYnVnKCIiKQogCiAgICAgZGVidWcoIlRlc3RpbmcgQXBwbGVQYXlSZXF1ZXN0LmNvdW50cnlD b2RlIikKICAgICBkZWJ1ZygiIikK 348106 2018-08-26 17:55:12 -0700 2018-08-26 18:39:58 -0700 Patch bug-188954-20180826175511.patch text/plain 6817 aestes U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1MzM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzAyYzk0MmE4Y2I3ZTQz ZDVkZmM0NmQ1Y2JiMTg5NWU3OWI0YjE3Ni4uOTJkZjRmN2FjMmQ2NTU0YjVmMTM3Y2NhNTI2MDAy ODNjZDMyYTZjZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE4LTA4LTI2ICBBbmR5 IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBbQXBwbGUgUGF5XSBQYXltZW50 UmVxdWVzdC5zaG93KCkgc2hvdWxkIHJlamVjdCB3aGVuIGFuIHVuc3VwcG9ydGVkIEFwcGxlUGF5 UmVxdWVzdCB2ZXJzaW9uIGlzIHNwZWNpZmllZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg4OTU0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4g QWRsZXIuCisKKyAgICAgICAgSW4gQXBwbGUgUGF5IEpTLCBjYWxsaW5nIHRoZSBBcHBsZVBheVNl c3Npb24gY29uc3RydWN0b3Igd2l0aCBhbiB1bnN1cHBvcnRlZCB2ZXJzaW9uIHJlc3VsdHMKKyAg ICAgICAgaW4gYW4gZXhjZXB0aW9uIGJlaW5nIHRocm93bi4gV2UgbmVlZCB0byBkbyBzb21ldGhp bmcgc2ltaWxhciBmb3IgUGF5bWVudCBSZXF1ZXN0LgorCisgICAgICAgIFRoaXMgcGF0Y2ggbW92 ZXMgdGhlIGxvZ2ljIGZvciB2YWxpZGF0aW5nIHRoZSB2ZXJzaW9uIGZyb20gQXBwbGVQYXlTZXNz aW9uIHRvIGEgY29tbW9uCisgICAgICAgIHJvdXRpbmUgaW4gQXBwbGVQYXlSZXF1ZXN0QmFzZSB0 aGF0IGJvdGggQVBJcyBjYWxsIHRvIGNvbnZlcnQgcmVxdWVzdHMgaW50byBhIGNvbW1vbiBmb3Jt YXQuCisKKyAgICAgICAgSW4gQXBwbGUgUGF5IEpTLCBhbiBleGNlcHRpb24gd2lsbCBzdGlsbCBi ZSB0aHJvd24gd2hlbiBjb25zdHJ1Y3RpbmcgYW4gQXBwbGVQYXlTZXNzaW9uLiBJbgorICAgICAg ICBQYXltZW50IFJlcXVlc3QsIHRoZSBwcm9taXNlIHJldHVybmVkIGJ5IHNob3coKSB3aWxsIGJl IHJlamVjdGVkLgorCisgICAgICAgIEFkZGVkIHRlc3QgY2FzZXMgdG8gaHR0cC90ZXN0cy9zc2wv YXBwbGVwYXkvUGF5bWVudFJlcXVlc3QuaHR0cHMuaHRtbC4KKworICAgICAgICAqIE1vZHVsZXMv YXBwbGVwYXkvQXBwbGVQYXlSZXF1ZXN0QmFzZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjb252 ZXJ0QW5kVmFsaWRhdGUpOgorICAgICAgICAqIE1vZHVsZXMvYXBwbGVwYXkvQXBwbGVQYXlTZXNz aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFwcGxlUGF5U2Vzc2lvbjo6Y3JlYXRlKToKKwog MjAxOC0wOC0yNCAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBD bGljayBldmVudCBmcm9tIGNsaWNrKCkgaXMgbm90IGNvbXBvc2VkCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL2FwcGxlcGF5L0FwcGxlUGF5UmVxdWVzdEJhc2UuY3BwIGIvU291 cmNlL1dlYkNvcmUvTW9kdWxlcy9hcHBsZXBheS9BcHBsZVBheVJlcXVlc3RCYXNlLmNwcAppbmRl eCAwZWM4ZDEyMjQyZDFiZTFjMzBhZjdhYzE4NmEwNGM0NzAwODQxMjZjLi4xOThlY2U3Y2RkYThj ZGE2ZmNlMWQxNjFmZTNmZjBhNDQ2NjFkNDQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL2FwcGxlcGF5L0FwcGxlUGF5UmVxdWVzdEJhc2UuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL01vZHVsZXMvYXBwbGVwYXkvQXBwbGVQYXlSZXF1ZXN0QmFzZS5jcHAKQEAgLTI5LDYgKzI5 LDcgQEAKICNpZiBFTkFCTEUoQVBQTEVfUEFZKQogCiAjaW5jbHVkZSAiUGF5bWVudENvb3JkaW5h dG9yLmgiCisjaW5jbHVkZSA8d3RmL3RleHQvU3RyaW5nQ29uY2F0ZW5hdGVOdW1iZXJzLmg+CiAK IG5hbWVzcGFjZSBXZWJDb3JlIHsKIApAQCAtNTEsNiArNTIsOSBAQCBzdGF0aWMgRXhjZXB0aW9u T3I8VmVjdG9yPFN0cmluZz4+IGNvbnZlcnRBbmRWYWxpZGF0ZSh1bnNpZ25lZCB2ZXJzaW9uLCBj b25zdCBWZQogCiBFeGNlcHRpb25PcjxBcHBsZVBheVNlc3Npb25QYXltZW50UmVxdWVzdD4gY29u dmVydEFuZFZhbGlkYXRlKHVuc2lnbmVkIHZlcnNpb24sIEFwcGxlUGF5UmVxdWVzdEJhc2UmIHJl cXVlc3QsIGNvbnN0IFBheW1lbnRDb29yZGluYXRvciYgcGF5bWVudENvb3JkaW5hdG9yKQogewor ICAgIGlmICghdmVyc2lvbiB8fCAhcGF5bWVudENvb3JkaW5hdG9yLnN1cHBvcnRzVmVyc2lvbih2 ZXJzaW9uKSkKKyAgICAgICAgcmV0dXJuIEV4Y2VwdGlvbiB7IEludmFsaWRBY2Nlc3NFcnJvciwg bWFrZVN0cmluZygiXCIiLCB2ZXJzaW9uLCAiXCIgaXMgbm90IGEgc3VwcG9ydGVkIHZlcnNpb24u IikgfTsKKwogICAgIEFwcGxlUGF5U2Vzc2lvblBheW1lbnRSZXF1ZXN0IHJlc3VsdDsKICAgICBy ZXN1bHQuc2V0VmVyc2lvbih2ZXJzaW9uKTsKICAgICByZXN1bHQuc2V0Q291bnRyeUNvZGUocmVx dWVzdC5jb3VudHJ5Q29kZSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2Fw cGxlcGF5L0FwcGxlUGF5U2Vzc2lvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2FwcGxl cGF5L0FwcGxlUGF5U2Vzc2lvbi5jcHAKaW5kZXggNDZkZmFjOTU5YjZjYTlhNzQzNWI2NDIyMjdk NTI3YjhhYTUxMzliMy4uYmJiN2M4YjAxNjUzZWVjMTA4ZWVlMWNjN2IzMDQ1NDU1NDJjMjM0NSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9hcHBsZXBheS9BcHBsZVBheVNlc3Np b24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvYXBwbGVwYXkvQXBwbGVQYXlTZXNz aW9uLmNwcApAQCAtNDA2LDEyICs0MDYsNyBAQCBFeGNlcHRpb25PcjxSZWY8QXBwbGVQYXlTZXNz aW9uPj4gQXBwbGVQYXlTZXNzaW9uOjpjcmVhdGUoRG9jdW1lbnQmIGRvY3VtZW50LCB1bgogICAg IGlmICghZG9jdW1lbnQucGFnZSgpKQogICAgICAgICByZXR1cm4gRXhjZXB0aW9uIHsgSW52YWxp ZEFjY2Vzc0Vycm9yLCAiRnJhbWUgaXMgZGV0YWNoZWQiIH07CiAKLSAgICBhdXRvJiBwYXltZW50 Q29vcmRpbmF0b3IgPSBkb2N1bWVudC5wYWdlKCktPnBheW1lbnRDb29yZGluYXRvcigpOwotCi0g ICAgaWYgKCF2ZXJzaW9uIHx8ICFwYXltZW50Q29vcmRpbmF0b3Iuc3VwcG9ydHNWZXJzaW9uKHZl cnNpb24pKQotICAgICAgICByZXR1cm4gRXhjZXB0aW9uIHsgSW52YWxpZEFjY2Vzc0Vycm9yLCBt YWtlU3RyaW5nKCJcIiIgKyBTdHJpbmc6Om51bWJlcih2ZXJzaW9uKSwgIlwiIGlzIG5vdCBhIHN1 cHBvcnRlZCB2ZXJzaW9uLiIpIH07Ci0KLSAgICBhdXRvIGNvbnZlcnRlZFBheW1lbnRSZXF1ZXN0 ID0gY29udmVydEFuZFZhbGlkYXRlKHZlcnNpb24sIFdURk1vdmUocGF5bWVudFJlcXVlc3QpLCBw YXltZW50Q29vcmRpbmF0b3IpOworICAgIGF1dG8gY29udmVydGVkUGF5bWVudFJlcXVlc3QgPSBj b252ZXJ0QW5kVmFsaWRhdGUodmVyc2lvbiwgV1RGTW92ZShwYXltZW50UmVxdWVzdCksIGRvY3Vt ZW50LnBhZ2UoKS0+cGF5bWVudENvb3JkaW5hdG9yKCkpOwogICAgIGlmIChjb252ZXJ0ZWRQYXlt ZW50UmVxdWVzdC5oYXNFeGNlcHRpb24oKSkKICAgICAgICAgcmV0dXJuIGNvbnZlcnRlZFBheW1l bnRSZXF1ZXN0LnJlbGVhc2VFeGNlcHRpb24oKTsKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGZmNTE5MDY4YTI5N2JkNThk MTgwYjBmNzBkZDFkZGE5YzViNjljODkuLjQyNjI1MDJkZTM1ZGNkMzM3MjFkNDYwZTkxMjc3MThm MjBlNzBmNDcgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxOC0wOC0yNiAgQW5keSBFc3RlcyAg PGFlc3Rlc0BhcHBsZS5jb20+CisKKyAgICAgICAgW0FwcGxlIFBheV0gUGF5bWVudFJlcXVlc3Qu c2hvdygpIHNob3VsZCByZWplY3Qgd2hlbiBhbiB1bnN1cHBvcnRlZCBBcHBsZVBheVJlcXVlc3Qg dmVyc2lvbiBpcyBzcGVjaWZpZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE4ODk1NAorCisgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgor CisgICAgICAgICogaHR0cC90ZXN0cy9zc2wvYXBwbGVwYXkvUGF5bWVudFJlcXVlc3QuaHR0cHMt ZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGh0dHAvdGVzdHMvc3NsL2FwcGxlcGF5L1BheW1lbnRS ZXF1ZXN0Lmh0dHBzLmh0bWw6CisKIDIwMTgtMDgtMjQgIEplciBOb2JsZSAgPGplci5ub2JsZUBh cHBsZS5jb20+CiAKICAgICAgICAgVXNpbmcgVG91Y2ggQmFyIHRvIHNjcnViIHZpZGVvIG9uIFlv dXR1YmUgcmVzdWx0cyBpbiB2aWRlbyBwbGF5YmFjayBmcmVlemUKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL2h0dHAvdGVzdHMvc3NsL2FwcGxlcGF5L1BheW1lbnRSZXF1ZXN0Lmh0dHBzLWV4cGVj dGVkLnR4dCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvc3NsL2FwcGxlcGF5L1BheW1lbnRSZXF1 ZXN0Lmh0dHBzLWV4cGVjdGVkLnR4dAppbmRleCA5MWZlYjJiNGU0YzlkOTJiZTM5YzE5ODA2NDQ0 NjIwYzNmYWZhZDZmLi5mMjZjODY4NTFhMDNkM2EyY2Y0OWQ3OGRkOTI2Njc0ZTdmNmU2ZmI0IDEw MDY0NAotLS0gYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3NzbC9hcHBsZXBheS9QYXltZW50UmVx dWVzdC5odHRwcy1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9zc2wv YXBwbGVwYXkvUGF5bWVudFJlcXVlc3QuaHR0cHMtZXhwZWN0ZWQudHh0CkBAIC04LDYgKzgsMTMg QEAgVGVzdGluZyBQYXltZW50UmVxdWVzdAogUEFTUyBuZXcgUGF5bWVudFJlcXVlc3QobnVsbCwg bnVsbCkgdGhyZXcgZXhjZXB0aW9uIFR5cGVFcnJvcjogVmFsdWUgaXMgbm90IGEgc2VxdWVuY2Uu CiBQQVNTIG5ldyBQYXltZW50UmVxdWVzdChbdmFsaWRQYXltZW50TWV0aG9kKCldLCB2YWxpZFBh eW1lbnREZXRhaWxzKCkpIGRpZCBub3QgdGhyb3cgZXhjZXB0aW9uLgogCitUZXN0aW5nIEFwcGxl UGF5UmVxdWVzdC52ZXJzaW9uCisKK1NFVFVQOiBwYXltZW50TWV0aG9kID0gdmFsaWRQYXltZW50 TWV0aG9kKCk7IHBheW1lbnRNZXRob2QuZGF0YS52ZXJzaW9uID0gMDsKK1BBU1MgcmVxdWVzdCA9 IG5ldyBQYXltZW50UmVxdWVzdChbcGF5bWVudE1ldGhvZF0sIHZhbGlkUGF5bWVudERldGFpbHMo KSk7IHJlcXVlc3Quc2hvdygpIHJlamVjdGVkIHByb21pc2UgIHdpdGggSW52YWxpZEFjY2Vzc0Vy cm9yOiAiMCIgaXMgbm90IGEgc3VwcG9ydGVkIHZlcnNpb24uLgorU0VUVVA6IHBheW1lbnRNZXRo b2QgPSB2YWxpZFBheW1lbnRNZXRob2QoKTsgcGF5bWVudE1ldGhvZC5kYXRhLnZlcnNpb24gPSAx MDAwOworUEFTUyByZXF1ZXN0ID0gbmV3IFBheW1lbnRSZXF1ZXN0KFtwYXltZW50TWV0aG9kXSwg dmFsaWRQYXltZW50RGV0YWlscygpKTsgcmVxdWVzdC5zaG93KCkgcmVqZWN0ZWQgcHJvbWlzZSAg d2l0aCBJbnZhbGlkQWNjZXNzRXJyb3I6ICIxMDAwIiBpcyBub3QgYSBzdXBwb3J0ZWQgdmVyc2lv bi4uCisKIFRlc3RpbmcgQXBwbGVQYXlSZXF1ZXN0LmNvdW50cnlDb2RlCiAKIFNFVFVQOiBwYXlt ZW50TWV0aG9kID0gdmFsaWRQYXltZW50TWV0aG9kKCk7IGRlbGV0ZSBwYXltZW50TWV0aG9kLmRh dGEuY291bnRyeUNvZGU7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3NzbC9h cHBsZXBheS9QYXltZW50UmVxdWVzdC5odHRwcy5odG1sIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0 cy9zc2wvYXBwbGVwYXkvUGF5bWVudFJlcXVlc3QuaHR0cHMuaHRtbAppbmRleCBjZDJhYjk4NGUx NzY1ZGI3YTA5MzVhMTJiMDgwYzk2ZGIxMDViZjViLi45NDgyNTIzM2ExMjBkNDQ1YmFkNThlODRh NWJjMDVjODU4ZjU2MjhiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3NzbC9h cHBsZXBheS9QYXltZW50UmVxdWVzdC5odHRwcy5odG1sCisrKyBiL0xheW91dFRlc3RzL2h0dHAv dGVzdHMvc3NsL2FwcGxlcGF5L1BheW1lbnRSZXF1ZXN0Lmh0dHBzLmh0bWwKQEAgLTU1LDYgKzU1 LDEyIEBAIGFzeW5jIGZ1bmN0aW9uIGdvKCkgewogICAgIHNob3VsZFRocm93KCJuZXcgUGF5bWVu dFJlcXVlc3QobnVsbCwgbnVsbCkiKQogICAgIHNob3VsZE5vdFRocm93KCJuZXcgUGF5bWVudFJl cXVlc3QoW3ZhbGlkUGF5bWVudE1ldGhvZCgpXSwgdmFsaWRQYXltZW50RGV0YWlscygpKSIpCiAg ICAgZGVidWcoIiIpCisgICAgCisgICAgZGVidWcoIlRlc3RpbmcgQXBwbGVQYXlSZXF1ZXN0LnZl cnNpb24iKQorICAgIGRlYnVnKCIiKQorICAgIGF3YWl0IGxvZ0FuZFNob3VsZFJlamVjdCgicGF5 bWVudE1ldGhvZCA9IHZhbGlkUGF5bWVudE1ldGhvZCgpOyBwYXltZW50TWV0aG9kLmRhdGEudmVy c2lvbiA9IDA7IiwgInJlcXVlc3QgPSBuZXcgUGF5bWVudFJlcXVlc3QoW3BheW1lbnRNZXRob2Rd LCB2YWxpZFBheW1lbnREZXRhaWxzKCkpOyByZXF1ZXN0LnNob3coKSIpCisgICAgYXdhaXQgbG9n QW5kU2hvdWxkUmVqZWN0KCJwYXltZW50TWV0aG9kID0gdmFsaWRQYXltZW50TWV0aG9kKCk7IHBh eW1lbnRNZXRob2QuZGF0YS52ZXJzaW9uID0gMTAwMDsiLCAicmVxdWVzdCA9IG5ldyBQYXltZW50 UmVxdWVzdChbcGF5bWVudE1ldGhvZF0sIHZhbGlkUGF5bWVudERldGFpbHMoKSk7IHJlcXVlc3Qu c2hvdygpIikKKyAgICBkZWJ1ZygiIikKIAogICAgIGRlYnVnKCJUZXN0aW5nIEFwcGxlUGF5UmVx dWVzdC5jb3VudHJ5Q29kZSIpCiAgICAgZGVidWcoIiIpCg==