188935 2018-08-24 15:46:06 -0700 Check for null renderer in canBeScrolledIntoView 2018-08-28 22:06:14 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 don.olmstead don.olmstead cdumez commit-queue darin mcatanzaro simon.fraser webkit-bug-importer oldest_to_newest 1453602 0 don.olmstead 2018-08-24 15:46:06 -0700 There's no check on parentNode->renderer() before its used within canBeScrolledIntoView. Associated Chromium fix with layout test https://chromium-review.googlesource.com/c/chromium/src/+/550255 1453604 1 don.olmstead 2018-08-24 15:47:50 -0700 Adding the following in the for loop fixes the problem. + if (UNLIKELY(!parentNode->renderer())) + continue; Its EOD here so if nobody gets to this by Monday I'll just throw together a patch with the layout test in it. 1454634 2 348361 don.olmstead 2018-08-28 17:09:42 -0700 Created attachment 348361 Patch Port of the chromium fix 1454641 3 348361 simon.fraser 2018-08-28 17:29:10 -0700 Comment on attachment 348361 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348361&action=review > Source/WebCore/page/SpatialNavigation.cpp:708 > + if (UNLIKELY(!parentNode->renderer())) The UNLIKELY() seems unnecessary. 1454653 4 348371 don.olmstead 2018-08-28 18:15:39 -0700 Created attachment 348371 Patch Address review comments 1454721 5 348371 commit-queue 2018-08-28 22:05:32 -0700 Comment on attachment 348371 Patch Clearing flags on attachment: 348371 Committed r235457: <https://trac.webkit.org/changeset/235457> 1454722 6 commit-queue 2018-08-28 22:05:34 -0700 All reviewed patches have been landed. Closing bug. 1454723 7 webkit-bug-importer 2018-08-28 22:06:14 -0700 <rdar://problem/43829010> 348361 2018-08-28 17:09:42 -0700 2018-08-28 18:15:39 -0700 Patch bug-188935.diff text/plain 3311 don.olmstead ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA3OTdmYTRjMDYzYi4uNzBmOWIzZWI3YjggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAor MjAxOC0wOC0yOCAgRG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0ZWFkQHNvbnkuY29tPgorCisgICAg ICAgIENoZWNrIGZvciBudWxsIHJlbmRlcmVyIGluIGNhbkJlU2Nyb2xsZWRJbnRvVmlldworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg4OTM1CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L3NwYXRp YWwtbmF2aWdhdGlvbi9zbmF2LWRpc3BsYXktY29udGVudHMtY3Jhc2gtZXhwZWN0ZWQudHh0OiBB ZGRlZC4KKyAgICAgICAgKiBmYXN0L3NwYXRpYWwtbmF2aWdhdGlvbi9zbmF2LWRpc3BsYXktY29u dGVudHMtY3Jhc2guaHRtbDogQWRkZWQuCisKIDIwMTgtMDgtMjggIEFkaXR5YSBLZWVydGhpICA8 YWtlZXJ0aGlAYXBwbGUuY29tPgogCiAgICAgICAgIFttYWNPU10gQ29sb3Igd2VsbHMgc2hvdWxk IGFwcGVhciByb3VuZGVkIGFuZCB0ZXh0dXJlZApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFz dC9zcGF0aWFsLW5hdmlnYXRpb24vc25hdi1kaXNwbGF5LWNvbnRlbnRzLWNyYXNoLWV4cGVjdGVk LnR4dCBiL0xheW91dFRlc3RzL2Zhc3Qvc3BhdGlhbC1uYXZpZ2F0aW9uL3NuYXYtZGlzcGxheS1j b250ZW50cy1jcmFzaC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAw MDAwMDAwMDAuLjg4ZTUzMzU3NWVkCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFz dC9zcGF0aWFsLW5hdmlnYXRpb24vc25hdi1kaXNwbGF5LWNvbnRlbnRzLWNyYXNoLWV4cGVjdGVk LnR4dApAQCAtMCwwICsxIEBACitTaG91bGRuJ3QgY3Jhc2guCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9mYXN0L3NwYXRpYWwtbmF2aWdhdGlvbi9zbmF2LWRpc3BsYXktY29udGVudHMtY3Jhc2gu aHRtbCBiL0xheW91dFRlc3RzL2Zhc3Qvc3BhdGlhbC1uYXZpZ2F0aW9uL3NuYXYtZGlzcGxheS1j b250ZW50cy1jcmFzaC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAw Li42ODc1NzEwNGI3YwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3Qvc3BhdGlh bC1uYXZpZ2F0aW9uL3NuYXYtZGlzcGxheS1jb250ZW50cy1jcmFzaC5odG1sCkBAIC0wLDAgKzEs MTYgQEAKKzxkaXYgc3R5bGU9ImRpc3BsYXk6IGNvbnRlbnRzIj48YSBocmVmPSIjIj48L2E+PC9k aXY+CitTaG91bGRuJ3QgY3Jhc2guCis8c2NyaXB0PgoraWYgKHdpbmRvdy50ZXN0UnVubmVyKSB7 CisgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7CisgICAgdGVzdFJ1bm5lci5vdmVycmlkZVBy ZWZlcmVuY2UoIldlYktpdFRhYlRvTGlua3NQcmVmZXJlbmNlS2V5IiwgMSk7CisgICAgdGVzdFJ1 bm5lci5zZXRTcGF0aWFsTmF2aWdhdGlvbkVuYWJsZWQodHJ1ZSk7Cit9CitmdW5jdGlvbiBydW5U ZXN0KCkgeworICAgIGlmICh3aW5kb3cuZXZlbnRTZW5kZXIpIHsKKyAgICAgICAgZXZlbnRTZW5k ZXIua2V5RG93bigicmlnaHRBcnJvdyIpOworICAgIH0KK30KKword2luZG93Lm9ubG9hZCA9IHJ1 blRlc3Q7Cis8L3NjcmlwdD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBi L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhZjIxZmZmM2RhZi4uOTE2ZGQ5ZDY0Mjcg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxOC0wOC0yOCAgRG9uIE9sbXN0ZWFkICA8 ZG9uLm9sbXN0ZWFkQHNvbnkuY29tPgorCisgICAgICAgIENoZWNrIGZvciBudWxsIHJlbmRlcmVy IGluIGNhbkJlU2Nyb2xsZWRJbnRvVmlldworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTg4OTM1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVGVzdDogZmFzdC9zcGF0aWFsLW5hdmlnYXRpb24vc25hdi1kaXNw bGF5LWNvbnRlbnRzLWNyYXNoLmh0bWwKKworICAgICAgICAqIHBhZ2UvU3BhdGlhbE5hdmlnYXRp b24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6Y2FuQmVTY3JvbGxlZEludG9WaWV3KToKKwogMjAx OC0wOC0yOCAgQWRpdHlhIEtlZXJ0aGkgIDxha2VlcnRoaUBhcHBsZS5jb20+CiAKICAgICAgICAg W21hY09TXSBDb2xvciB3ZWxscyBzaG91bGQgYXBwZWFyIHJvdW5kZWQgYW5kIHRleHR1cmVkCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1NwYXRpYWxOYXZpZ2F0aW9uLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvU3BhdGlhbE5hdmlnYXRpb24uY3BwCmluZGV4IDc2M2FlYTU4M2Iw Li41N2I0NzUzNjhlMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9TcGF0aWFsTmF2 aWdhdGlvbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9TcGF0aWFsTmF2aWdhdGlvbi5j cHAKQEAgLTcwNSw2ICs3MDUsOCBAQCBib29sIGNhbkJlU2Nyb2xsZWRJbnRvVmlldyhGb2N1c0Rp cmVjdGlvbiBkaXJlY3Rpb24sIGNvbnN0IEZvY3VzQ2FuZGlkYXRlJiBjYW5kaQogICAgIEFTU0VS VChjYW5kaWRhdGUudmlzaWJsZU5vZGUgJiYgY2FuZGlkYXRlLmlzT2Zmc2NyZWVuKTsKICAgICBM YXlvdXRSZWN0IGNhbmRpZGF0ZVJlY3QgPSBjYW5kaWRhdGUucmVjdDsKICAgICBmb3IgKE5vZGUq IHBhcmVudE5vZGUgPSBjYW5kaWRhdGUudmlzaWJsZU5vZGUtPnBhcmVudE5vZGUoKTsgcGFyZW50 Tm9kZTsgcGFyZW50Tm9kZSA9IHBhcmVudE5vZGUtPnBhcmVudE5vZGUoKSkgeworICAgICAgICBp ZiAoVU5MSUtFTFkoIXBhcmVudE5vZGUtPnJlbmRlcmVyKCkpKQorICAgICAgICAgICAgY29udGlu dWU7CiAgICAgICAgIExheW91dFJlY3QgcGFyZW50UmVjdCA9IG5vZGVSZWN0SW5BYnNvbHV0ZUNv b3JkaW5hdGVzKHBhcmVudE5vZGUpOwogICAgICAgICBpZiAoIWNhbmRpZGF0ZVJlY3QuaW50ZXJz ZWN0cyhwYXJlbnRSZWN0KSkgewogICAgICAgICAgICAgaWYgKCgoZGlyZWN0aW9uID09IEZvY3Vz RGlyZWN0aW9uTGVmdCB8fCBkaXJlY3Rpb24gPT0gRm9jdXNEaXJlY3Rpb25SaWdodCkgJiYgcGFy ZW50Tm9kZS0+cmVuZGVyZXIoKS0+c3R5bGUoKS5vdmVyZmxvd1goKSA9PSBPdmVyZmxvdzo6SGlk ZGVuKQo= 348371 2018-08-28 18:15:39 -0700 2018-08-28 22:05:32 -0700 Patch bug-188935.diff text/plain 3297 don.olmstead ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA3OTdmYTRjMDYzYi4uNzBmOWIzZWI3YjggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAor MjAxOC0wOC0yOCAgRG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0ZWFkQHNvbnkuY29tPgorCisgICAg ICAgIENoZWNrIGZvciBudWxsIHJlbmRlcmVyIGluIGNhbkJlU2Nyb2xsZWRJbnRvVmlldworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg4OTM1CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gRnJhc2VyLgorCisgICAgICAgICogZmFzdC9zcGF0aWFs LW5hdmlnYXRpb24vc25hdi1kaXNwbGF5LWNvbnRlbnRzLWNyYXNoLWV4cGVjdGVkLnR4dDogQWRk ZWQuCisgICAgICAgICogZmFzdC9zcGF0aWFsLW5hdmlnYXRpb24vc25hdi1kaXNwbGF5LWNvbnRl bnRzLWNyYXNoLmh0bWw6IEFkZGVkLgorCiAyMDE4LTA4LTI4ICBBZGl0eWEgS2VlcnRoaSAgPGFr ZWVydGhpQGFwcGxlLmNvbT4KIAogICAgICAgICBbbWFjT1NdIENvbG9yIHdlbGxzIHNob3VsZCBh cHBlYXIgcm91bmRlZCBhbmQgdGV4dHVyZWQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qv c3BhdGlhbC1uYXZpZ2F0aW9uL3NuYXYtZGlzcGxheS1jb250ZW50cy1jcmFzaC1leHBlY3RlZC50 eHQgYi9MYXlvdXRUZXN0cy9mYXN0L3NwYXRpYWwtbmF2aWdhdGlvbi9zbmF2LWRpc3BsYXktY29u dGVudHMtY3Jhc2gtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAw MDAwMDAwLi44OGU1MzM1NzVlZAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3Qv c3BhdGlhbC1uYXZpZ2F0aW9uL3NuYXYtZGlzcGxheS1jb250ZW50cy1jcmFzaC1leHBlY3RlZC50 eHQKQEAgLTAsMCArMSBAQAorU2hvdWxkbid0IGNyYXNoLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvZmFzdC9zcGF0aWFsLW5hdmlnYXRpb24vc25hdi1kaXNwbGF5LWNvbnRlbnRzLWNyYXNoLmh0 bWwgYi9MYXlvdXRUZXN0cy9mYXN0L3NwYXRpYWwtbmF2aWdhdGlvbi9zbmF2LWRpc3BsYXktY29u dGVudHMtY3Jhc2guaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMC4u Njg3NTcxMDRiN2MKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L3NwYXRpYWwt bmF2aWdhdGlvbi9zbmF2LWRpc3BsYXktY29udGVudHMtY3Jhc2guaHRtbApAQCAtMCwwICsxLDE2 IEBACis8ZGl2IHN0eWxlPSJkaXNwbGF5OiBjb250ZW50cyI+PGEgaHJlZj0iIyI+PC9hPjwvZGl2 PgorU2hvdWxkbid0IGNyYXNoLgorPHNjcmlwdD4KK2lmICh3aW5kb3cudGVzdFJ1bm5lcikgewor ICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOworICAgIHRlc3RSdW5uZXIub3ZlcnJpZGVQcmVm ZXJlbmNlKCJXZWJLaXRUYWJUb0xpbmtzUHJlZmVyZW5jZUtleSIsIDEpOworICAgIHRlc3RSdW5u ZXIuc2V0U3BhdGlhbE5hdmlnYXRpb25FbmFibGVkKHRydWUpOworfQorZnVuY3Rpb24gcnVuVGVz dCgpIHsKKyAgICBpZiAod2luZG93LmV2ZW50U2VuZGVyKSB7CisgICAgICAgIGV2ZW50U2VuZGVy LmtleURvd24oInJpZ2h0QXJyb3ciKTsKKyAgICB9Cit9CisKK3dpbmRvdy5vbmxvYWQgPSBydW5U ZXN0OworPC9zY3JpcHQ+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWYyMWZmZjNkYWYuLjkxNmRkOWQ2NDI3IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTgtMDgtMjggIERvbiBPbG1zdGVhZCAgPGRv bi5vbG1zdGVhZEBzb255LmNvbT4KKworICAgICAgICBDaGVjayBmb3IgbnVsbCByZW5kZXJlciBp biBjYW5CZVNjcm9sbGVkSW50b1ZpZXcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE4ODkzNQorCisgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEZyYXNl ci4KKworICAgICAgICBUZXN0OiBmYXN0L3NwYXRpYWwtbmF2aWdhdGlvbi9zbmF2LWRpc3BsYXkt Y29udGVudHMtY3Jhc2guaHRtbAorCisgICAgICAgICogcGFnZS9TcGF0aWFsTmF2aWdhdGlvbi5j cHA6CisgICAgICAgIChXZWJDb3JlOjpjYW5CZVNjcm9sbGVkSW50b1ZpZXcpOgorCiAyMDE4LTA4 LTI4ICBBZGl0eWEgS2VlcnRoaSAgPGFrZWVydGhpQGFwcGxlLmNvbT4KIAogICAgICAgICBbbWFj T1NdIENvbG9yIHdlbGxzIHNob3VsZCBhcHBlYXIgcm91bmRlZCBhbmQgdGV4dHVyZWQKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvU3BhdGlhbE5hdmlnYXRpb24uY3BwIGIvU291cmNl L1dlYkNvcmUvcGFnZS9TcGF0aWFsTmF2aWdhdGlvbi5jcHAKaW5kZXggNzYzYWVhNTgzYjAuLjU3 YjQ3NTM2OGUyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1NwYXRpYWxOYXZpZ2F0 aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1NwYXRpYWxOYXZpZ2F0aW9uLmNwcApA QCAtNzA1LDYgKzcwNSw4IEBAIGJvb2wgY2FuQmVTY3JvbGxlZEludG9WaWV3KEZvY3VzRGlyZWN0 aW9uIGRpcmVjdGlvbiwgY29uc3QgRm9jdXNDYW5kaWRhdGUmIGNhbmRpCiAgICAgQVNTRVJUKGNh bmRpZGF0ZS52aXNpYmxlTm9kZSAmJiBjYW5kaWRhdGUuaXNPZmZzY3JlZW4pOwogICAgIExheW91 dFJlY3QgY2FuZGlkYXRlUmVjdCA9IGNhbmRpZGF0ZS5yZWN0OwogICAgIGZvciAoTm9kZSogcGFy ZW50Tm9kZSA9IGNhbmRpZGF0ZS52aXNpYmxlTm9kZS0+cGFyZW50Tm9kZSgpOyBwYXJlbnROb2Rl OyBwYXJlbnROb2RlID0gcGFyZW50Tm9kZS0+cGFyZW50Tm9kZSgpKSB7CisgICAgICAgIGlmICgh cGFyZW50Tm9kZS0+cmVuZGVyZXIoKSkKKyAgICAgICAgICAgIGNvbnRpbnVlOwogICAgICAgICBM YXlvdXRSZWN0IHBhcmVudFJlY3QgPSBub2RlUmVjdEluQWJzb2x1dGVDb29yZGluYXRlcyhwYXJl bnROb2RlKTsKICAgICAgICAgaWYgKCFjYW5kaWRhdGVSZWN0LmludGVyc2VjdHMocGFyZW50UmVj dCkpIHsKICAgICAgICAgICAgIGlmICgoKGRpcmVjdGlvbiA9PSBGb2N1c0RpcmVjdGlvbkxlZnQg fHwgZGlyZWN0aW9uID09IEZvY3VzRGlyZWN0aW9uUmlnaHQpICYmIHBhcmVudE5vZGUtPnJlbmRl cmVyKCktPnN0eWxlKCkub3ZlcmZsb3dYKCkgPT0gT3ZlcmZsb3c6OkhpZGRlbikK