188919 2018-08-24 06:10:46 -0700 [FreeType] Do not cast through GLib types in FontCustomPlatformDataFreeType.cpp 2018-08-24 12:14:22 -0700 1 1 1 Unclassified WebKit WebKit Misc. Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aperez aperez clopez commit-queue dino don.olmstead mcatanzaro mmaxfield simon.fraser webkit-bug-importer oldest_to_newest 1453432 0 aperez 2018-08-24 06:10:46 -0700 As por Don's comment in bug #185462 (comment 8) > Noticed this issue while rebasing. GCallback shouldn't be in freetype files. > > > Source/WebCore/platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:51 > > + reinterpret_cast<cairo_destroy_func_t>(reinterpret_cast<GCallback>(FT_Done_Face))); > > This casts assumes USE(GLIB) 1453433 1 348003 aperez 2018-08-24 06:13:00 -0700 Created attachment 348003 Patch 1453436 2 348003 mcatanzaro 2018-08-24 06:49:50 -0700 Comment on attachment 348003 Patch The double cast is probably needed to silence -Wcast-function-type. Are you certain this doesn't introduce any new warnings when building with GCC 8? Instead of casting through GCallback, you can instead cast through void (*) (void). That's the documented way to avoid -Wcast-function-type. GCallback is just a typedef for that. 1453437 3 348003 mcatanzaro 2018-08-24 06:52:44 -0700 Comment on attachment 348003 Patch This blames to r231565 So you'll need to use void (*) (void) instead. 1453441 4 348005 aperez 2018-08-24 07:13:18 -0700 Created attachment 348005 Patch 1453461 5 don.olmstead 2018-08-24 09:08:09 -0700 Clang is happy with the change. So informally I would r+ this as long as GCC is happy. 1453520 6 348005 commit-queue 2018-08-24 12:13:09 -0700 Comment on attachment 348005 Patch Clearing flags on attachment: 348005 Committed r235325: <https://trac.webkit.org/changeset/235325> 1453521 7 commit-queue 2018-08-24 12:13:11 -0700 All reviewed patches have been landed. Closing bug. 1453523 8 webkit-bug-importer 2018-08-24 12:14:22 -0700 <rdar://problem/43693002> 348003 2018-08-24 06:13:00 -0700 2018-08-24 07:13:04 -0700 Patch bug-188919-20180824161258.patch text/plain 1834 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1MzE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjZjYWFiYzRlZjQ0YWRh ZDgzMDk5M2E0MTc3YzQ0NjQwY2EyNDIwZC4uYjE4MDFiMWIwOGI3NDc2MTlhMTQ3NDJiNWMzM2I1 OThmMjc0Y2U1NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTA4LTI0ICBBZHJp YW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0ZyZWVU eXBlXSBVbm5lZWRlZCBkb3VibGUgY2FzdCB1c2luZyBhIEdMaWIgdHlwZSBpbiBGb250Q3VzdG9t UGxhdGZvcm1EYXRhRnJlZVR5cGUuY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xODg5MTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgbmVlZGVkLgorCisgICAgICAgICogcGxhdGZv cm0vZ3JhcGhpY3MvZnJlZXR5cGUvRm9udEN1c3RvbVBsYXRmb3JtRGF0YUZyZWVUeXBlLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkZvbnRDdXN0b21QbGF0Zm9ybURhdGE6OkZvbnRDdXN0b21QbGF0 Zm9ybURhdGEpOiBSZW1vdmUKKyAgICAgICAgdW5uZWVkZWQgZG91YmxlIGNhc3QsIHdoaWNoIGFs c28gcmVtb3ZlcyB0aGUgdXNhZ2Ugb2YgR0NhbGxiYWNrLgorCiAyMDE4LTA4LTI0ICBGcmVkZXJp YyBXYW5nICA8ZndhbmdAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZW1vdmUgU2Nyb2xsQnlQcmVj aXNlUGl4ZWwgZ3JhbnVsYXJpdHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2ZyZWV0eXBlL0ZvbnRDdXN0b21QbGF0Zm9ybURhdGFGcmVlVHlwZS5jcHAgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9mcmVldHlwZS9Gb250Q3VzdG9tUGxhdGZv cm1EYXRhRnJlZVR5cGUuY3BwCmluZGV4IGJkOWNkMDAwOWFmYmEwOWVmNTFlZDRlOGUwZmMyYzQ0 ZjExZjJmYWYuLmM5ZWE3MzMxNjM1YTY2Y2QwMmY1MTc3M2E1ZTkyZTQ3NDk5ZTliY2UgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZyZWV0eXBlL0ZvbnRDdXN0 b21QbGF0Zm9ybURhdGFGcmVlVHlwZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvZnJlZXR5cGUvRm9udEN1c3RvbVBsYXRmb3JtRGF0YUZyZWVUeXBlLmNwcApAQCAt NDgsNyArNDgsNyBAQCBGb250Q3VzdG9tUGxhdGZvcm1EYXRhOjpGb250Q3VzdG9tUGxhdGZvcm1E YXRhKEZUX0ZhY2UgZnJlZVR5cGVGYWNlLCBTaGFyZWRCdWZmZQogICAgIC8vIHRoaXMgY2Fpcm9f Zm9udF9mYWNlX3QgaXMgZGVzdHJveWVkLCBpdCBjbGVhbnMgdXAgdGhlIEZyZWVUeXBlIGZhY2Ug YXMgd2VsbC4KICAgICBzdGF0aWMgY2Fpcm9fdXNlcl9kYXRhX2tleV90IGZyZWVUeXBlRmFjZUtl eTsKICAgICBjYWlyb19mb250X2ZhY2Vfc2V0X3VzZXJfZGF0YShtX2ZvbnRGYWNlLCAmZnJlZVR5 cGVGYWNlS2V5LCBmcmVlVHlwZUZhY2UsCi0gICAgICAgIHJlaW50ZXJwcmV0X2Nhc3Q8Y2Fpcm9f ZGVzdHJveV9mdW5jX3Q+KHJlaW50ZXJwcmV0X2Nhc3Q8R0NhbGxiYWNrPihGVF9Eb25lX0ZhY2Up KSk7CisgICAgICAgIHJlaW50ZXJwcmV0X2Nhc3Q8Y2Fpcm9fZGVzdHJveV9mdW5jX3Q+KEZUX0Rv bmVfRmFjZSkpOwogfQogCiBGb250Q3VzdG9tUGxhdGZvcm1EYXRhOjp+Rm9udEN1c3RvbVBsYXRm b3JtRGF0YSgpCg== 348005 2018-08-24 07:13:18 -0700 2018-08-24 12:13:09 -0700 Patch bug-188919-20180824171317.patch text/plain 1902 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1MzE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjZjYWFiYzRlZjQ0YWRh ZDgzMDk5M2E0MTc3YzQ0NjQwY2EyNDIwZC4uMTA1MzRmOWUyZmNjNjY4NmU0YzQ1NzUzZmRjYzdh Y2I2MWUwZGZjOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE4LTA4LTI0ICBBZHJp YW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0ZyZWVU eXBlXSBEbyBub3QgY2FzdCB0aHJvdWdoIEdMaWIgdHlwZXMgaW4gRm9udEN1c3RvbVBsYXRmb3Jt RGF0YUZyZWVUeXBlLmNwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTg4OTE5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgTm8gbmV3IHRlc3RzIG5lZWRlZC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL2ZyZWV0eXBlL0ZvbnRDdXN0b21QbGF0Zm9ybURhdGFGcmVlVHlwZS5jcHA6CisgICAgICAg IChXZWJDb3JlOjpGb250Q3VzdG9tUGxhdGZvcm1EYXRhOjpGb250Q3VzdG9tUGxhdGZvcm1EYXRh KTogQ2FzdAorICAgICAgICB0aHJvdWdoICJ2b2lkICgqKSh2b2lkKSIgaW5zdGVhZCBvZiBHQ2Fs bGJhY2sgdG8gYXZvaWQgdGhlIHdhcm5pbmcKKyAgICAgICAgcHJvZHVjZWQgYnkgLVdjYXN0LWZ1 bmN0aW9uLXR5cGUuCisKIDIwMTgtMDgtMjQgIEZyZWRlcmljIFdhbmcgIDxmd2FuZ0BpZ2FsaWEu Y29tPgogCiAgICAgICAgIFJlbW92ZSBTY3JvbGxCeVByZWNpc2VQaXhlbCBncmFudWxhcml0eQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZnJlZXR5cGUvRm9u dEN1c3RvbVBsYXRmb3JtRGF0YUZyZWVUeXBlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2ZyZWV0eXBlL0ZvbnRDdXN0b21QbGF0Zm9ybURhdGFGcmVlVHlwZS5jcHAKaW5k ZXggYmQ5Y2QwMDA5YWZiYTA5ZWY1MWVkNGU4ZTBmYzJjNDRmMTFmMmZhZi4uNTM2MjVkZjdhY2Y0 YzQ1ZDc1NzEzY2VlMDk2N2MxM2M3N2E0ZWI4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvZnJlZXR5cGUvRm9udEN1c3RvbVBsYXRmb3JtRGF0YUZyZWVUeXBl LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9mcmVldHlwZS9Gb250 Q3VzdG9tUGxhdGZvcm1EYXRhRnJlZVR5cGUuY3BwCkBAIC00OCw3ICs0OCw3IEBAIEZvbnRDdXN0 b21QbGF0Zm9ybURhdGE6OkZvbnRDdXN0b21QbGF0Zm9ybURhdGEoRlRfRmFjZSBmcmVlVHlwZUZh Y2UsIFNoYXJlZEJ1ZmZlCiAgICAgLy8gdGhpcyBjYWlyb19mb250X2ZhY2VfdCBpcyBkZXN0cm95 ZWQsIGl0IGNsZWFucyB1cCB0aGUgRnJlZVR5cGUgZmFjZSBhcyB3ZWxsLgogICAgIHN0YXRpYyBj YWlyb191c2VyX2RhdGFfa2V5X3QgZnJlZVR5cGVGYWNlS2V5OwogICAgIGNhaXJvX2ZvbnRfZmFj ZV9zZXRfdXNlcl9kYXRhKG1fZm9udEZhY2UsICZmcmVlVHlwZUZhY2VLZXksIGZyZWVUeXBlRmFj ZSwKLSAgICAgICAgcmVpbnRlcnByZXRfY2FzdDxjYWlyb19kZXN0cm95X2Z1bmNfdD4ocmVpbnRl cnByZXRfY2FzdDxHQ2FsbGJhY2s+KEZUX0RvbmVfRmFjZSkpKTsKKyAgICAgICAgcmVpbnRlcnBy ZXRfY2FzdDxjYWlyb19kZXN0cm95X2Z1bmNfdD4ocmVpbnRlcnByZXRfY2FzdDx2b2lkKCopKHZv aWQpPihGVF9Eb25lX0ZhY2UpKSk7CiB9CiAKIEZvbnRDdXN0b21QbGF0Zm9ybURhdGE6On5Gb250 Q3VzdG9tUGxhdGZvcm1EYXRhKCkK