188911 2018-08-23 17:42:10 -0700 fast/files/blob-network-process-crash.html is flaky 2018-08-24 13:13:01 -0700 1 1 1 Unclassified WebKit WebCore JavaScript WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=188880 InRadar P2 Normal --- 1 rniwa rniwa ap ryanhaddad saam webkit-bug-importer oldest_to_newest 1453348 0 rniwa 2018-08-23 17:42:10 -0700 fast/files/blob-network-process-crash.html, the test added in https://trac.webkit.org/changeset/235243 is flaky when the timer isn't saved in the global object. This is an indicative of some bug elsewhere. Scheduling another timer seems to fix the problem as well. 1453349 1 rniwa 2018-08-23 17:43:33 -0700 Committed r235264: <https://trac.webkit.org/changeset/235264> 1453351 2 webkit-bug-importer 2018-08-23 17:44:18 -0700 <rdar://problem/43666603> 1453352 3 rniwa 2018-08-23 17:45:23 -0700 Ugh... I didn't mean to close this bug. 1453377 4 rniwa 2018-08-23 20:37:02 -0700 Hm... the test is still flaky on bots. 1453378 5 rniwa 2018-08-23 20:42:36 -0700 Added the flaky test expectation in https://trac.webkit.org/changeset/235269. This is very weird. I suspect the bots are too overloaded to sanely process the crashing network process. We should probably replace this test with an API test. 1453391 6 347991 rniwa 2018-08-23 22:28:58 -0700 Created attachment 347991 Fix attempt 1453394 7 347991 saam 2018-08-23 22:48:01 -0700 Comment on attachment 347991 Fix attempt View in context: https://bugs.webkit.org/attachment.cgi?id=347991&action=review > LayoutTests/fast/files/blob-network-process-crash.html:17 > + setTimeout(() => testRunner.notifyDone(), 3000); Let's remove this as you said on IRC > LayoutTests/fast/files/blob-network-process-crash.html:37 > + await fetch('blob-network-process-crash.html'); Do we really need this here? Seems like we would have either crashed or not crashed at this point. 1453395 8 rniwa 2018-08-23 22:49:19 -0700 (In reply to Saam Barati from comment #7) > Comment on attachment 347991 [details] > Fix attempt > > View in context: > https://bugs.webkit.org/attachment.cgi?id=347991&action=review > > > LayoutTests/fast/files/blob-network-process-crash.html:17 > > + setTimeout(() => testRunner.notifyDone(), 3000); > > Let's remove this as you said on IRC Will do. > > LayoutTests/fast/files/blob-network-process-crash.html:37 > > + await fetch('blob-network-process-crash.html'); > > Do we really need this here? Seems like we would have either crashed or not > crashed at this point. This call is needed to ensure the network process had received IPC to unregister the blob since that's async. 1453396 9 rniwa 2018-08-23 22:51:36 -0700 Committed r235274: <https://trac.webkit.org/changeset/235274> 1453397 10 rniwa 2018-08-23 22:51:54 -0700 Keeping this bug open until I confirm that the flakiness is fixed: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Ffiles%2Fblob-network-process-crash.html 1453551 11 rniwa 2018-08-24 13:12:56 -0700 The test appears to be no longer flaky. Removed the flaky test expectation in https://trac.webkit.org/changeset/235330. 347991 2018-08-23 22:28:58 -0700 2018-08-23 22:48:01 -0700 Fix attempt bug-188911-20180823222858.patch text/plain 2841 rniwa SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDIzNTI3MykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE4LTA4LTIzICBSeW9zdWtlIE5pd2EgIDxy bml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIGZhc3QvZmlsZXMvYmxvYi1uZXR3b3JrLXByb2Nl c3MtY3Jhc2guaHRtbCBpcyBmbGFreQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTg4OTExCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVGhlIGZsYWtpbmVzcyBhcHBlYXJzIHRvIGNvbWUgZnJvbSB0aGUgd2Vi IGNvbnRlbnQgcHJvY2VzcyBub3QgZ2V0dGluZyBub3RpZmllZCBvZgorICAgICAgICB0aGUgdGVy bWluYXRpb24gb2YgdGhlIG5ldHdvcmsgcHJvY2VzcyBpbiB0aW1lLiBXYWl0IGZvciB0aGUgbmV0 d29yayBwcm9jZXNzIHRvCisgICAgICAgIHJlbGF1bmNoIGFmdGVyIHRlcm1pbmF0aW5nIG9uZSBi eSBjb250aW51b3VzbHkgZmV0Y2gnaW5nIGl0c2VsZiB3aXRoIGFuIGluY3JlYXNpbmcKKyAgICAg ICAgdGltZSBpbnRlcnZhbCB1bnRpbCBpdCBzdWNjZWVkcy4KKworICAgICAgICAqIGZhc3QvZmls ZXMvYmxvYi1uZXR3b3JrLXByb2Nlc3MtY3Jhc2guaHRtbDoKKwogMjAxOC0wOC0yMyAgUnlvc3Vr ZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBBZGQgYSBmbGFreSBmYWlsaW5n IHRlc3QgZXhwZWN0YXRpb24gdG8gZmFzdC9maWxlcy9ibG9iLW5ldHdvcmstcHJvY2Vzcy1jcmFz aC5odG1sCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2ZpbGVzL2Jsb2ItbmV0d29yay1wcm9jZXNz LWNyYXNoLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9maWxlcy9ibG9iLW5l dHdvcmstcHJvY2Vzcy1jcmFzaC5odG1sCShyZXZpc2lvbiAyMzUyNjgpCisrKyBMYXlvdXRUZXN0 cy9mYXN0L2ZpbGVzL2Jsb2ItbmV0d29yay1wcm9jZXNzLWNyYXNoLmh0bWwJKHdvcmtpbmcgY29w eSkKQEAgLTcsOSArNywxNCBAQCBXZWJLaXQgc2hvdWxkIG5vdCBoaXQgYSBkZWJ1ZyBhc3NlcnRp b24gCiAKIGlmICghd2luZG93LnRlc3RSdW5uZXIpCiAgICAgZG9jdW1lbnQud3JpdGUoJ1RoaXMg dGVzdCByZXF1aXJlcyB0ZXN0UnVubmVyIGFuZCBHQ0NvbnRyb2xsZXInKTsKLWVsc2UgeworZWxz ZQorICAgIHJ1blRlc3QoKTsKKworYXN5bmMgZnVuY3Rpb24gcnVuVGVzdCgpCit7CiAgICAgdGVz dFJ1bm5lci5kdW1wQXNUZXh0KCk7CiAgICAgdGVzdFJ1bm5lci53YWl0VW50aWxEb25lKCk7Cisg ICAgc2V0VGltZW91dCgoKSA9PiB0ZXN0UnVubmVyLm5vdGlmeURvbmUoKSwgMzAwMCk7CiAKICAg ICBsZXQgYmxvYnMgPSBuZXcgQXJyYXkoMTAwKTsKICAgICBmb3IgKGxldCBpID0gMDsgaSA8IDEw MDsgaSsrKSB7CkBAIC0yMCwxOSArMjUsMjggQEAgZWxzZSB7CiAKICAgICB0ZXN0UnVubmVyLnRl cm1pbmF0ZU5ldHdvcmtQcm9jZXNzKCk7CiAKLSAgICAvLyBGSVhNRTogSWYgd2UgZG9uJ3Qgc3Rv cmUgdGhlIHRpbWVyLCB0aW1lciBzb21ldGltZXMgbmV2ZXIgZmlyZXMuCi0gICAgd2luZG93LnRp bWVyID0gc2V0VGltZW91dCgoKSA9PiB7Ci0gICAgICAgIGNvbnN0IG5ld0Jsb2IgPSBuZXcgQmxv YihbInNvbWUgdGV4dCJdKTsKLSAgICAgICAgZm9yIChsZXQgaSA9IDA7IGkgPCAxMDA7IGkrKykg ewotICAgICAgICAgICAgZm9yIChsZXQgaiA9IDA7IGogPCAxMDsgaisrKQotICAgICAgICAgICAg ICAgIGJsb2JzW2ldW2pdID0geyB9OwotICAgICAgICB9Ci0gICAgICAgIGJsb2JzID0gbnVsbDsK LSAgICAgICAgR0NDb250cm9sbGVyLmNvbGxlY3QoKTsKLSAgICAgICAgZmV0Y2goJ2Jsb2ItbmV0 d29yay1wcm9jZXNzLWNyYXNoLmh0bWwnKS50aGVuKCgpID0+IHsKLSAgICAgICAgICAgIHRlc3RS dW5uZXIubm90aWZ5RG9uZSgpOwotICAgICAgICB9KTsKLSAgICB9LCAwKTsKKyAgICBhd2FpdCB3 YWl0Rm9yTmV0d29ya1Byb2Nlc3NUb1JlbGF1bmNoKCk7CisgICAgY29uc3QgbmV3QmxvYiA9IG5l dyBCbG9iKFsic29tZSB0ZXh0Il0pOworICAgIGZvciAobGV0IGkgPSAwOyBpIDwgMTAwOyBpKysp IHsKKyAgICAgICAgZm9yIChsZXQgaiA9IDA7IGogPCAxMDsgaisrKQorICAgICAgICAgICAgYmxv YnNbaV1bal0gPSB7IH07CisgICAgfQorICAgIGJsb2JzID0gbnVsbDsKKyAgICBHQ0NvbnRyb2xs ZXIuY29sbGVjdCgpOworCisgICAgYXdhaXQgZmV0Y2goJ2Jsb2ItbmV0d29yay1wcm9jZXNzLWNy YXNoLmh0bWwnKTsKKworICAgIHRlc3RSdW5uZXIubm90aWZ5RG9uZSgpOworfQorCitsZXQgd2Fp dFRpbWUgPSAxMDsKK2Z1bmN0aW9uIHdhaXRGb3JOZXR3b3JrUHJvY2Vzc1RvUmVsYXVuY2goKSB7 CisgICAgcmV0dXJuIGZldGNoKCdibG9iLW5ldHdvcmstcHJvY2Vzcy1jcmFzaC5odG1sJykuY2F0 Y2goKCkgPT4geworICAgICAgICByZXR1cm4gbmV3IFByb21pc2UoKHJlc29sdmUsIHJlamVjdCkg PT4geworICAgICAgICAgICAgd2FpdFRpbWUgKj0gMS4yOworICAgICAgICAgICAgc2V0VGltZW91 dCgoKSA9PiB3YWl0Rm9yTmV0d29ya1Byb2Nlc3NUb1JlbGF1bmNoKCkudGhlbihyZXNvbHZlKSwg d2FpdFRpbWUpOworICAgICAgICB9KQorICAgIH0pOwogfQogCiA8L3NjcmlwdD4K