188909 2018-08-23 17:00:12 -0700 initKeyboardEvent doesn't clear CapsLock state 2019-02-06 09:18:24 -0800 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa rniwa achristensen cdumez dbates esprehn+autocc ews-watchlist kangil.han simon.fraser webkit-bug-importer wenson_hsieh youennf oldest_to_newest 1453327 0 rniwa 2018-08-23 17:00:12 -0700 We should clear the caps lock state in initKeyboardEvent to match behaviors of Firefox & Chrome. Spec bug: https://github.com/w3c/uievents/issues/209 1453329 1 347974 rniwa 2018-08-23 17:02:47 -0700 Created attachment 347974 Fixes the bug 1453334 2 347974 wenson_hsieh 2018-08-23 17:08:38 -0700 Comment on attachment 347974 Fixes the bug r=mews 1453365 3 347974 rniwa 2018-08-23 19:01:30 -0700 Comment on attachment 347974 Fixes the bug Clearing flags on attachment: 347974 Committed r235268: <https://trac.webkit.org/changeset/235268> 1453366 4 rniwa 2018-08-23 19:01:32 -0700 All reviewed patches have been landed. Closing bug. 1453367 5 webkit-bug-importer 2018-08-23 19:03:25 -0700 <rdar://problem/43668541> 1503159 6 lforschler 2019-02-06 09:18:24 -0800 Mass move bugs into the DOM component. 347974 2018-08-23 17:02:47 -0700 2018-08-23 19:01:30 -0700 Fixes the bug bug-188909-20180823170246.patch text/plain 7291 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzNTI2MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE4LTA4LTIzICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIGluaXRLZXlib2FyZEV2ZW50IGRv ZXNuJ3QgY2xlYXIgQ2Fwc0xvY2sgc3RhdGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE4ODkwOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEZpeGVkIHRoZSBidWcgYnkgbm90IHByZXNlcnZpbmcgQ2Fwc0xv Y2sgc3RhdGUgaW4gc2V0TW9kaWZpZXJLZXlzIHZhcmlhbnQgd2hpY2ggdGFrZXMgYm9vbGVhbgor ICAgICAgICBmb3IgYWx0R3JhcGhLZXksIHdoaWNoIGlzIG9ubHkgY2FsbGVkIGJ5IEtleWJvYXJk RXZlbnQ6OmluaXRLZXlib2FyZEV2ZW50LgorCisgICAgICAgIFRlc3Q6IGZhc3QvZXZlbnRzL2lu aXQtZXZlbnQtY2xlYXJzLWNhcHNsb2NrLmh0bWwKKworICAgICAgICAqIGRvbS9VSUV2ZW50V2l0 aEtleVN0YXRlLmg6CisgICAgICAgIChXZWJDb3JlOjpVSUV2ZW50V2l0aEtleVN0YXRlOjpzZXRN b2RpZmllcktleXMpOgorCiAyMDE4LTA4LTIzICBTYWFtIGJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu Y29tPgogCiAgICAgICAgIEpTUnVuTG9vcFRpbWVyIG1heSBydW4gcGFydCBvZiBhIG1lbWJlciBm dW5jdGlvbiBhZnRlciBpdCdzIGRlc3Ryb3llZApJbmRleDogU291cmNlL1dlYkNvcmUvZG9tL1VJ RXZlbnRXaXRoS2V5U3RhdGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20vVUlF dmVudFdpdGhLZXlTdGF0ZS5oCShyZXZpc2lvbiAyMzUyNDgpCisrKyBTb3VyY2UvV2ViQ29yZS9k b20vVUlFdmVudFdpdGhLZXlTdGF0ZS5oCSh3b3JraW5nIGNvcHkpCkBAIC03Niw5ICs3Niw2IEBA IHByb3RlY3RlZDoKICAgICAgICAgICAgIHJlc3VsdCB8PSBNb2RpZmllcjo6TWV0YUtleTsKICAg ICAgICAgaWYgKGFsdEdyYXBoS2V5KQogICAgICAgICAgICAgcmVzdWx0IHw9IE1vZGlmaWVyOjpB bHRHcmFwaEtleTsKLSAgICAgICAgLy8gIEZJWE1FOiBDaHJvbWUgb3IgRmlyZWZveCBkb24ndCBw cmVzZXJ2ZSB0aGlzIHN0YXRlLgotICAgICAgICBpZiAobV9tb2RpZmllcnMgJiBNb2RpZmllcjo6 Q2Fwc0xvY2tLZXkpCi0gICAgICAgICAgICByZXN1bHQgfD0gTW9kaWZpZXI6OkNhcHNMb2NrS2V5 OwogICAgICAgICBtX21vZGlmaWVycyA9IHJlc3VsdDsKICAgICB9CiAKSW5kZXg6IExheW91dFRl c3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlz aW9uIDIzNTI0OCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAt MSwzICsxLDE2IEBACisyMDE4LTA4LTIzICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3Jn PgorCisgICAgICAgIGluaXRLZXlib2FyZEV2ZW50IGRvZXNuJ3QgY2xlYXIgQ2Fwc0xvY2sgc3Rh dGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4ODkw OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGVk IGEgcmVncmVzc2lvbiB0ZXN0LiBOb3RlIHRoYXQgYWx0R3JhcGggaXMgb25seSBzdXBwb3J0ZWQg aW4gV2ViS2l0CisgICAgICAgIHNvIENocm9tZSBhbmQgRmlyZWZveCB3b3VsZCBmYWlsIHRvIHJl c2V0IGl0IHZpYSBpbml0S2V5Ym9hcmRFdmVudC4KKworICAgICAgICAqIGZhc3QvZXZlbnRzL2lu aXQtZXZlbnQtY2xlYXJzLWNhcHNsb2NrLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICog ZmFzdC9ldmVudHMvaW5pdC1ldmVudC1jbGVhcnMtY2Fwc2xvY2suaHRtbDogQWRkZWQuCisKIDIw MTgtMDgtMjMgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFdl YiBJbnNwZWN0b3I6IHN1cHBvcnQgYnJlYWtwb2ludHMgZm9yIHRpbWVycyBhbmQgYW5pbWF0aW9u LWZyYW1lIGV2ZW50cwpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvaW5pdC1ldmVudC1j bGVhcnMtY2Fwc2xvY2stZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zh c3QvZXZlbnRzL2luaXQtZXZlbnQtY2xlYXJzLWNhcHNsb2NrLWV4cGVjdGVkLnR4dAkobm9uZXhp c3RlbnQpCisrKyBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9pbml0LWV2ZW50LWNsZWFycy1jYXBz bG9jay1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSw0MyBAQAorVGhpcyB0 ZXN0cyBpbnZva2luZyBpbml0S2V5Ym9hcmRFdmVudCBhZnRlciBzZXR0aW5nIENhcHNMb2NrIHN0 YXRlIHRvIHRydWUgdmlhIEtleWJvYXJkRXZlbnQncyBjb25zdHJ1Y3Rvci4KKworT24gc3VjY2Vz cywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkg IlRFU1QgQ09NUExFVEUiLgorCisKK2tleUV2ZW50ID0gbmV3IEtleWJvYXJkRXZlbnQoJ2tleWRv d24nLCB7IGJ1YmJsZXM6IHRydWUsIGNhbmNlbGFibGU6IHRydWUsIHZpZXc6IHdpbmRvdywgZGV0 YWlsOiAwLCBrZXk6ICdhJywgY29kZTogJ0tleUEnLAorICAgIGN0cmxLZXk6IHRydWUsIGFsdEtl eTogdHJ1ZSwgc2hpZnRLZXk6IHRydWUsIG1ldGFLZXk6IHRydWUsIG1vZGlmaWVyQWx0R3JhcGg6 IHRydWUsIG1vZGlmaWVyQ2Fwc0xvY2s6IHRydWUgfSk7CitQQVNTIGtleUV2ZW50LmN0cmxLZXkg aXMgdHJ1ZQorUEFTUyBrZXlFdmVudC5zaGlmdEtleSBpcyB0cnVlCitQQVNTIGtleUV2ZW50LmFs dEtleSBpcyB0cnVlCitQQVNTIGtleUV2ZW50Lm1ldGFLZXkgaXMgdHJ1ZQorUEFTUyBrZXlFdmVu dC5nZXRNb2RpZmllclN0YXRlKCJDb250cm9sIikgaXMgdHJ1ZQorUEFTUyBrZXlFdmVudC5nZXRN b2RpZmllclN0YXRlKCJTaGlmdCIpIGlzIHRydWUKK1BBU1Mga2V5RXZlbnQuZ2V0TW9kaWZpZXJT dGF0ZSgiQWx0IikgaXMgdHJ1ZQorUEFTUyBrZXlFdmVudC5nZXRNb2RpZmllclN0YXRlKCJNZXRh IikgaXMgdHJ1ZQorUEFTUyBrZXlFdmVudC5nZXRNb2RpZmllclN0YXRlKCJBbHRHcmFwaCIpIGlz IHRydWUKK1BBU1Mga2V5RXZlbnQuZ2V0TW9kaWZpZXJTdGF0ZSgiQ2Fwc0xvY2siKSBpcyB0cnVl CitrZXlFdmVudC5pbml0S2V5Ym9hcmRFdmVudCgna2V5ZG93bicsIGZhbHNlLCBmYWxzZSwgd2lu ZG93LCAnVSswMDQxJywgMCwgLyogY3RybCAqLyBmYWxzZSwgLyogYWx0ICovIGZhbHNlLCAvKiBz aGlmdCAqLyBmYWxzZSwgLyogbWV0YSAqLyBmYWxzZSwgLyogYWx0R3JhcGggKi8gZmFsc2UpCitQ QVNTIGtleUV2ZW50LmN0cmxLZXkgaXMgZmFsc2UKK1BBU1Mga2V5RXZlbnQuc2hpZnRLZXkgaXMg ZmFsc2UKK1BBU1Mga2V5RXZlbnQuYWx0S2V5IGlzIGZhbHNlCitQQVNTIGtleUV2ZW50Lm1ldGFL ZXkgaXMgZmFsc2UKK1BBU1Mga2V5RXZlbnQuZ2V0TW9kaWZpZXJTdGF0ZSgiQ29udHJvbCIpIGlz IGZhbHNlCitQQVNTIGtleUV2ZW50LmdldE1vZGlmaWVyU3RhdGUoIlNoaWZ0IikgaXMgZmFsc2UK K1BBU1Mga2V5RXZlbnQuZ2V0TW9kaWZpZXJTdGF0ZSgiQWx0IikgaXMgZmFsc2UKK1BBU1Mga2V5 RXZlbnQuZ2V0TW9kaWZpZXJTdGF0ZSgiTWV0YSIpIGlzIGZhbHNlCitQQVNTIGtleUV2ZW50Lmdl dE1vZGlmaWVyU3RhdGUoIkFsdEdyYXBoIikgaXMgZmFsc2UKK1BBU1Mga2V5RXZlbnQuZ2V0TW9k aWZpZXJTdGF0ZSgiQ2Fwc0xvY2siKSBpcyBmYWxzZQora2V5RXZlbnQuaW5pdEtleWJvYXJkRXZl bnQoJ2tleWRvd24nLCBmYWxzZSwgZmFsc2UsIHdpbmRvdywgJ1UrMDA0MScsIDAsIC8qIGN0cmwg Ki8gdHJ1ZSwgLyogYWx0ICovIHRydWUsIC8qIHNoaWZ0ICovIHRydWUsIC8qIG1ldGEgKi8gdHJ1 ZSwgLyogYWx0R3JhcGggKi8gdHJ1ZSkKK1BBU1Mga2V5RXZlbnQuY3RybEtleSBpcyB0cnVlCitQ QVNTIGtleUV2ZW50LnNoaWZ0S2V5IGlzIHRydWUKK1BBU1Mga2V5RXZlbnQuYWx0S2V5IGlzIHRy dWUKK1BBU1Mga2V5RXZlbnQubWV0YUtleSBpcyB0cnVlCitQQVNTIGtleUV2ZW50LmdldE1vZGlm aWVyU3RhdGUoIkNvbnRyb2wiKSBpcyB0cnVlCitQQVNTIGtleUV2ZW50LmdldE1vZGlmaWVyU3Rh dGUoIlNoaWZ0IikgaXMgdHJ1ZQorUEFTUyBrZXlFdmVudC5nZXRNb2RpZmllclN0YXRlKCJBbHQi KSBpcyB0cnVlCitQQVNTIGtleUV2ZW50LmdldE1vZGlmaWVyU3RhdGUoIk1ldGEiKSBpcyB0cnVl CitQQVNTIGtleUV2ZW50LmdldE1vZGlmaWVyU3RhdGUoIkFsdEdyYXBoIikgaXMgdHJ1ZQorUEFT UyBrZXlFdmVudC5nZXRNb2RpZmllclN0YXRlKCJDYXBzTG9jayIpIGlzIGZhbHNlCitQQVNTIHN1 Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpJbmRleDogTGF5b3V0 VGVzdHMvZmFzdC9ldmVudHMvaW5pdC1ldmVudC1jbGVhcnMtY2Fwc2xvY2suaHRtbAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9pbml0LWV2ZW50LWNsZWFycy1jYXBzbG9j ay5odG1sCShub25leGlzdGVudCkKKysrIExheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2luaXQtZXZl bnQtY2xlYXJzLWNhcHNsb2NrLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSw0OCBAQAor PCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxib2R5PgorPHNjcmlwdCBzcmM9Ii4uLy4uL3Jlc291 cmNlcy9qcy10ZXN0LmpzIj48L3NjcmlwdD4KKzxzY3JpcHQ+CisKK2Rlc2NyaXB0aW9uKGBUaGlz IHRlc3RzIGludm9raW5nIGluaXRLZXlib2FyZEV2ZW50IGFmdGVyIHNldHRpbmcgQ2Fwc0xvY2sg c3RhdGUgdG8gdHJ1ZSB2aWEgS2V5Ym9hcmRFdmVudCdzIGNvbnN0cnVjdG9yLmApOworCitldmFs QW5kTG9nKGBrZXlFdmVudCA9IG5ldyBLZXlib2FyZEV2ZW50KCdrZXlkb3duJywgeyBidWJibGVz OiB0cnVlLCBjYW5jZWxhYmxlOiB0cnVlLCB2aWV3OiB3aW5kb3csIGRldGFpbDogMCwga2V5OiAn YScsIGNvZGU6ICdLZXlBJywKKyAgICBjdHJsS2V5OiB0cnVlLCBhbHRLZXk6IHRydWUsIHNoaWZ0 S2V5OiB0cnVlLCBtZXRhS2V5OiB0cnVlLCBtb2RpZmllckFsdEdyYXBoOiB0cnVlLCBtb2RpZmll ckNhcHNMb2NrOiB0cnVlIH0pO2ApOworc2hvdWxkQmVUcnVlKCdrZXlFdmVudC5jdHJsS2V5Jyk7 CitzaG91bGRCZVRydWUoJ2tleUV2ZW50LnNoaWZ0S2V5Jyk7CitzaG91bGRCZVRydWUoJ2tleUV2 ZW50LmFsdEtleScpOworc2hvdWxkQmVUcnVlKCdrZXlFdmVudC5tZXRhS2V5Jyk7CitzaG91bGRC ZVRydWUoJ2tleUV2ZW50LmdldE1vZGlmaWVyU3RhdGUoIkNvbnRyb2wiKScpOworc2hvdWxkQmVU cnVlKCdrZXlFdmVudC5nZXRNb2RpZmllclN0YXRlKCJTaGlmdCIpJyk7CitzaG91bGRCZVRydWUo J2tleUV2ZW50LmdldE1vZGlmaWVyU3RhdGUoIkFsdCIpJyk7CitzaG91bGRCZVRydWUoJ2tleUV2 ZW50LmdldE1vZGlmaWVyU3RhdGUoIk1ldGEiKScpOworc2hvdWxkQmVUcnVlKCdrZXlFdmVudC5n ZXRNb2RpZmllclN0YXRlKCJBbHRHcmFwaCIpJyk7CitzaG91bGRCZVRydWUoJ2tleUV2ZW50Lmdl dE1vZGlmaWVyU3RhdGUoIkNhcHNMb2NrIiknKTsKKworZXZhbEFuZExvZyhga2V5RXZlbnQuaW5p dEtleWJvYXJkRXZlbnQoJ2tleWRvd24nLCBmYWxzZSwgZmFsc2UsIHdpbmRvdywgJ1UrMDA0MScs IDAsIC8qIGN0cmwgKi8gZmFsc2UsIC8qIGFsdCAqLyBmYWxzZSwgLyogc2hpZnQgKi8gZmFsc2Us IC8qIG1ldGEgKi8gZmFsc2UsIC8qIGFsdEdyYXBoICovIGZhbHNlKWApOworc2hvdWxkQmVGYWxz ZSgna2V5RXZlbnQuY3RybEtleScpOworc2hvdWxkQmVGYWxzZSgna2V5RXZlbnQuc2hpZnRLZXkn KTsKK3Nob3VsZEJlRmFsc2UoJ2tleUV2ZW50LmFsdEtleScpOworc2hvdWxkQmVGYWxzZSgna2V5 RXZlbnQubWV0YUtleScpOworc2hvdWxkQmVGYWxzZSgna2V5RXZlbnQuZ2V0TW9kaWZpZXJTdGF0 ZSgiQ29udHJvbCIpJyk7CitzaG91bGRCZUZhbHNlKCdrZXlFdmVudC5nZXRNb2RpZmllclN0YXRl KCJTaGlmdCIpJyk7CitzaG91bGRCZUZhbHNlKCdrZXlFdmVudC5nZXRNb2RpZmllclN0YXRlKCJB bHQiKScpOworc2hvdWxkQmVGYWxzZSgna2V5RXZlbnQuZ2V0TW9kaWZpZXJTdGF0ZSgiTWV0YSIp Jyk7CitzaG91bGRCZUZhbHNlKCdrZXlFdmVudC5nZXRNb2RpZmllclN0YXRlKCJBbHRHcmFwaCIp Jyk7CitzaG91bGRCZUZhbHNlKCdrZXlFdmVudC5nZXRNb2RpZmllclN0YXRlKCJDYXBzTG9jayIp Jyk7CisKK2V2YWxBbmRMb2coYGtleUV2ZW50LmluaXRLZXlib2FyZEV2ZW50KCdrZXlkb3duJywg ZmFsc2UsIGZhbHNlLCB3aW5kb3csICdVKzAwNDEnLCAwLCAvKiBjdHJsICovIHRydWUsIC8qIGFs dCAqLyB0cnVlLCAvKiBzaGlmdCAqLyB0cnVlLCAvKiBtZXRhICovIHRydWUsIC8qIGFsdEdyYXBo ICovIHRydWUpYCk7CitzaG91bGRCZVRydWUoJ2tleUV2ZW50LmN0cmxLZXknKTsKK3Nob3VsZEJl VHJ1ZSgna2V5RXZlbnQuc2hpZnRLZXknKTsKK3Nob3VsZEJlVHJ1ZSgna2V5RXZlbnQuYWx0S2V5 Jyk7CitzaG91bGRCZVRydWUoJ2tleUV2ZW50Lm1ldGFLZXknKTsKK3Nob3VsZEJlVHJ1ZSgna2V5 RXZlbnQuZ2V0TW9kaWZpZXJTdGF0ZSgiQ29udHJvbCIpJyk7CitzaG91bGRCZVRydWUoJ2tleUV2 ZW50LmdldE1vZGlmaWVyU3RhdGUoIlNoaWZ0IiknKTsKK3Nob3VsZEJlVHJ1ZSgna2V5RXZlbnQu Z2V0TW9kaWZpZXJTdGF0ZSgiQWx0IiknKTsKK3Nob3VsZEJlVHJ1ZSgna2V5RXZlbnQuZ2V0TW9k aWZpZXJTdGF0ZSgiTWV0YSIpJyk7CitzaG91bGRCZVRydWUoJ2tleUV2ZW50LmdldE1vZGlmaWVy U3RhdGUoIkFsdEdyYXBoIiknKTsKK3Nob3VsZEJlRmFsc2UoJ2tleUV2ZW50LmdldE1vZGlmaWVy U3RhdGUoIkNhcHNMb2NrIiknKTsKKworPC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg==