188907 2018-08-23 16:09:46 -0700 Add new _webViewRequestPointerLock SPI with a completionHandler 2018-08-23 16:38:16 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen aestes webkit-bug-importer oldest_to_newest 1453285 0 achristensen 2018-08-23 16:09:46 -0700 Add new _webViewRequestPointerLock SPI with a completionHandler 1453289 1 347968 achristensen 2018-08-23 16:12:40 -0700 Created attachment 347968 Patch 1453303 2 347968 aestes 2018-08-23 16:31:34 -0700 Comment on attachment 347968 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347968&action=review > Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:100 > - (void)_webViewRequestPointerLock:(WKWebView *)webView WK_API_AVAILABLE(macosx(10.12.3)); Should we deprecate this? > Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:101 > +- (void)_webViewRequestPointerLock:(WKWebView *)webView completionHandler:(void (^)(BOOL))completionHandler WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA)); _webViewDidRequestPointerLock? > Source/WebKit/UIProcess/Cocoa/UIDelegate.mm:1179 > + if (m_uiDelegate.m_delegateMethods.webViewRequestPointerLock) > + [static_cast<id <WKUIDelegatePrivate>>(delegate) _webViewRequestPointerLock:m_uiDelegate.m_webView]; I'd early return here and un-indent the rest. 1453307 3 achristensen 2018-08-23 16:37:14 -0700 http://trac.webkit.org/r235259 1453311 4 webkit-bug-importer 2018-08-23 16:38:16 -0700 <rdar://problem/43663953> 347968 2018-08-23 16:12:40 -0700 2018-08-23 16:31:34 -0700 Patch bug-188907-20180823161239.patch text/plain 6908 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzUxNTcpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE4LTA4LTIzICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgQWRkIG5ldyBfd2Vi Vmlld1JlcXVlc3RQb2ludGVyTG9jayBTUEkgd2l0aCBhIGNvbXBsZXRpb25IYW5kbGVyCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODg5MDcKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzM1ODcxMTA5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1VJRGVsZWdhdGVQ cml2YXRlLmg6CisgICAgICAgICogVUlQcm9jZXNzL0NvY29hL1VJRGVsZWdhdGUuaDoKKyAgICAg ICAgKiBVSVByb2Nlc3MvQ29jb2EvVUlEZWxlZ2F0ZS5tbToKKyAgICAgICAgKFdlYktpdDo6VUlE ZWxlZ2F0ZTo6c2V0RGVsZWdhdGUpOgorICAgICAgICAoV2ViS2l0OjpVSURlbGVnYXRlOjpVSUNs aWVudDo6cmVxdWVzdFBvaW50ZXJMb2NrKToKKwogMjAxOC0wOC0yMSAgQWxleCBDaHJpc3RlbnNl biAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIFJvbGwgb3V0IHIyMzUxMzkg YW5kIHIyMzUxNDYKSW5kZXg6IFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1VJ RGVsZWdhdGVQcml2YXRlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv QVBJL0NvY29hL1dLVUlEZWxlZ2F0ZVByaXZhdGUuaAkocmV2aXNpb24gMjM1MTU2KQorKysgU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLVUlEZWxlZ2F0ZVByaXZhdGUuaAkod29y a2luZyBjb3B5KQpAQCAtOTgsNiArOTgsNyBAQCBzdHJ1Y3QgVUlFZGdlSW5zZXRzOwogLSAodm9p ZClfd2ViVmlld0RpZEVudGVyRnVsbHNjcmVlbjooV0tXZWJWaWV3ICopd2ViVmlldyBXS19BUElf QVZBSUxBQkxFKG1hY29zeCgxMC4xMSksIGlvcyg4LjMpKTsKIC0gKHZvaWQpX3dlYlZpZXdEaWRF eGl0RnVsbHNjcmVlbjooV0tXZWJWaWV3ICopd2ViVmlldyBXS19BUElfQVZBSUxBQkxFKG1hY29z eCgxMC4xMSksIGlvcyg4LjMpKTsKIC0gKHZvaWQpX3dlYlZpZXdSZXF1ZXN0UG9pbnRlckxvY2s6 KFdLV2ViVmlldyAqKXdlYlZpZXcgV0tfQVBJX0FWQUlMQUJMRShtYWNvc3goMTAuMTIuMykpOwor LSAodm9pZClfd2ViVmlld1JlcXVlc3RQb2ludGVyTG9jazooV0tXZWJWaWV3ICopd2ViVmlldyBj b21wbGV0aW9uSGFuZGxlcjoodm9pZCAoXikoQk9PTCkpY29tcGxldGlvbkhhbmRsZXIgV0tfQVBJ X0FWQUlMQUJMRShtYWNvc3goV0tfTUFDX1RCQSksIGlvcyhXS19JT1NfVEJBKSk7CiAtICh2b2lk KV93ZWJWaWV3RGlkTG9zZVBvaW50ZXJMb2NrOihXS1dlYlZpZXcgKil3ZWJWaWV3IFdLX0FQSV9B VkFJTEFCTEUobWFjb3N4KDEwLjEyLjMpKTsKIC0gKHZvaWQpX3dlYlZpZXc6KFdLV2ViVmlldyAq KXdlYlZpZXcgaGFzVmlkZW9JblBpY3R1cmVJblBpY3R1cmVEaWRDaGFuZ2U6KEJPT0wpaGFzVmlk ZW9JblBpY3R1cmVJblBpY3R1cmUgV0tfQVBJX0FWQUlMQUJMRShtYWNvc3goMTAuMTMpLCBpb3Mo MTEuMCkpOwogCkluZGV4OiBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9VSURlbGVnYXRl LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvVUlEZWxlZ2F0 ZS5oCShyZXZpc2lvbiAyMzUxNTYpCisrKyBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9V SURlbGVnYXRlLmgJKHdvcmtpbmcgY29weSkKQEAgLTIxMCw2ICsyMTAsNyBAQCBwcml2YXRlOgog ICAgICAgICBib29sIHdlYlZpZXdJbWFnZU9yTWVkaWFEb2N1bWVudFNpemVDaGFuZ2VkIDogMTsK ICNpZiBFTkFCTEUoUE9JTlRFUl9MT0NLKQogICAgICAgICBib29sIHdlYlZpZXdSZXF1ZXN0UG9p bnRlckxvY2sgOiAxOworICAgICAgICBib29sIHdlYlZpZXdSZXF1ZXN0UG9pbnRlckxvY2tDb21w bGV0aW9uSGFuZGxlciA6IDE7CiAgICAgICAgIGJvb2wgd2ViVmlld0RpZExvc2VQb2ludGVyTG9j ayA6IDE7CiAjZW5kaWYKICNpZiBFTkFCTEUoQ09OVEVYVF9NRU5VUykKSW5kZXg6IFNvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL0NvY29hL1VJRGVsZWdhdGUubW0KPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvVUlEZWxlZ2F0ZS5tbQkocmV2aXNpb24gMjM1MTU2KQor KysgU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvVUlEZWxlZ2F0ZS5tbQkod29ya2luZyBj b3B5KQpAQCAtMTU3LDYgKzE1Nyw3IEBAIHZvaWQgVUlEZWxlZ2F0ZTo6c2V0RGVsZWdhdGUoaWQg PFdLVUlEZWwKIAogI2lmIEVOQUJMRShQT0lOVEVSX0xPQ0spCiAgICAgbV9kZWxlZ2F0ZU1ldGhv ZHMud2ViVmlld1JlcXVlc3RQb2ludGVyTG9jayA9IFtkZWxlZ2F0ZSByZXNwb25kc1RvU2VsZWN0 b3I6QHNlbGVjdG9yKF93ZWJWaWV3UmVxdWVzdFBvaW50ZXJMb2NrOildOworICAgIG1fZGVsZWdh dGVNZXRob2RzLndlYlZpZXdSZXF1ZXN0UG9pbnRlckxvY2tDb21wbGV0aW9uSGFuZGxlciA9IFtk ZWxlZ2F0ZSByZXNwb25kc1RvU2VsZWN0b3I6QHNlbGVjdG9yKF93ZWJWaWV3UmVxdWVzdFBvaW50 ZXJMb2NrOmNvbXBsZXRpb25IYW5kbGVyOildOwogICAgIG1fZGVsZWdhdGVNZXRob2RzLndlYlZp ZXdEaWRMb3NlUG9pbnRlckxvY2sgPSBbZGVsZWdhdGUgcmVzcG9uZHNUb1NlbGVjdG9yOkBzZWxl Y3Rvcihfd2ViVmlld0RpZExvc2VQb2ludGVyTG9jazopXTsKICNlbmRpZgogI2lmIEVOQUJMRShD T05URVhUX01FTlVTKQpAQCAtMTE2NSwxNiArMTE2NiwzMCBAQCBOU0RpY3Rpb25hcnkgKlVJRGVs ZWdhdGU6OlVJQ2xpZW50OjpkYXRhCiAKICNpZiBFTkFCTEUoUE9JTlRFUl9MT0NLKQogCi12b2lk IFVJRGVsZWdhdGU6OlVJQ2xpZW50OjpyZXF1ZXN0UG9pbnRlckxvY2soV2ViUGFnZVByb3h5KikK K3ZvaWQgVUlEZWxlZ2F0ZTo6VUlDbGllbnQ6OnJlcXVlc3RQb2ludGVyTG9jayhXZWJQYWdlUHJv eHkqIHBhZ2UpCiB7Ci0gICAgaWYgKCFtX3VpRGVsZWdhdGUubV9kZWxlZ2F0ZU1ldGhvZHMud2Vi Vmlld1JlcXVlc3RQb2ludGVyTG9jaykKKyAgICBpZiAoIW1fdWlEZWxlZ2F0ZS5tX2RlbGVnYXRl TWV0aG9kcy53ZWJWaWV3UmVxdWVzdFBvaW50ZXJMb2NrICYmICFtX3VpRGVsZWdhdGUubV9kZWxl Z2F0ZU1ldGhvZHMud2ViVmlld1JlcXVlc3RQb2ludGVyTG9ja0NvbXBsZXRpb25IYW5kbGVyKQog ICAgICAgICByZXR1cm47CiAKICAgICBhdXRvIGRlbGVnYXRlID0gbV91aURlbGVnYXRlLm1fZGVs ZWdhdGUuZ2V0KCk7CiAgICAgaWYgKCFkZWxlZ2F0ZSkKICAgICAgICAgcmV0dXJuOwogCi0gICAg W3N0YXRpY19jYXN0PGlkIDxXS1VJRGVsZWdhdGVQcml2YXRlPj4oZGVsZWdhdGUpIF93ZWJWaWV3 UmVxdWVzdFBvaW50ZXJMb2NrOm1fdWlEZWxlZ2F0ZS5tX3dlYlZpZXddOworICAgIGlmIChtX3Vp RGVsZWdhdGUubV9kZWxlZ2F0ZU1ldGhvZHMud2ViVmlld1JlcXVlc3RQb2ludGVyTG9jaykKKyAg ICAgICAgW3N0YXRpY19jYXN0PGlkIDxXS1VJRGVsZWdhdGVQcml2YXRlPj4oZGVsZWdhdGUpIF93 ZWJWaWV3UmVxdWVzdFBvaW50ZXJMb2NrOm1fdWlEZWxlZ2F0ZS5tX3dlYlZpZXddOworICAgIGVs c2UgeworICAgICAgICBhdXRvIGNoZWNrZXIgPSBDb21wbGV0aW9uSGFuZGxlckNhbGxDaGVja2Vy OjpjcmVhdGUoZGVsZWdhdGUuZ2V0KCksIEBzZWxlY3Rvcihfd2ViVmlld1JlcXVlc3RQb2ludGVy TG9jazpjb21wbGV0aW9uSGFuZGxlcjopKTsKKyAgICAgICAgW3N0YXRpY19jYXN0PGlkIDxXS1VJ RGVsZWdhdGVQcml2YXRlPj4oZGVsZWdhdGUpIF93ZWJWaWV3UmVxdWVzdFBvaW50ZXJMb2NrOm1f dWlEZWxlZ2F0ZS5tX3dlYlZpZXcgY29tcGxldGlvbkhhbmRsZXI6QmxvY2tQdHI8dm9pZChCT09M KT46OmZyb21DYWxsYWJsZShbY2hlY2tlciA9IFdURk1vdmUoY2hlY2tlciksIHBhZ2UgPSBtYWtl UmVmUHRyKHBhZ2UpXSAoQk9PTCBhbGxvdykgeworICAgICAgICAgICAgaWYgKGNoZWNrZXItPmNv bXBsZXRpb25IYW5kbGVySGFzQmVlbkNhbGxlZCgpKQorICAgICAgICAgICAgICAgIHJldHVybjsK KyAgICAgICAgICAgIGNoZWNrZXItPmRpZENhbGxDb21wbGV0aW9uSGFuZGxlcigpOworCisgICAg ICAgICAgICBpZiAoYWxsb3cpCisgICAgICAgICAgICAgICAgcGFnZS0+ZGlkQWxsb3dQb2ludGVy TG9jaygpOworICAgICAgICAgICAgZWxzZQorICAgICAgICAgICAgICAgIHBhZ2UtPmRpZERlbnlQ b2ludGVyTG9jaygpOworICAgICAgICB9KS5nZXQoKV07CisgICAgfQogfQogCiB2b2lkIFVJRGVs ZWdhdGU6OlVJQ2xpZW50OjpkaWRMb3NlUG9pbnRlckxvY2soV2ViUGFnZVByb3h5KikKSW5kZXg6 IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJldmlzaW9u IDIzNTI1NCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2 IEBACisyMDE4LTA4LTIzICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5v cmc+CisKKyAgICAgICAgQWRkIG5ldyBfd2ViVmlld1JlcXVlc3RQb2ludGVyTG9jayBTUEkgd2l0 aCBhIGNvbXBsZXRpb25IYW5kbGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xODg5MDcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM1ODcxMTA5Pgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVGVzdFdl YktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9VSURlbGVnYXRlLm1tOgorICAgICAgICAoLVtQb2lu dGVyTG9ja0RlbGVnYXRlIF93ZWJWaWV3UmVxdWVzdFBvaW50ZXJMb2NrOmNvbXBsZXRpb25IYW5k bGVyOl0pOgorICAgICAgICAoLVtQb2ludGVyTG9ja0RlbGVnYXRlIHdlYlZpZXc6cnVuSmF2YVNj cmlwdEFsZXJ0UGFuZWxXaXRoTWVzc2FnZTppbml0aWF0ZWRCeUZyYW1lOmNvbXBsZXRpb25IYW5k bGVyOl0pOgorICAgICAgICAoVEVTVCk6CisKIDIwMTgtMDgtMjMgIEpvbmF0aGFuIEJlZGFyZCAg PGpiZWRhcmRAYXBwbGUuY29tPgogCiAgICAgICAgIEFQSSB0ZXN0cyBzaG91bGQgb3V0cHV0IGpz b24gcmVzdWx0cwpJbmRleDogVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9V SURlbGVnYXRlLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2Vi S2l0Q29jb2EvVUlEZWxlZ2F0ZS5tbQkocmV2aXNpb24gMjM1MTU2KQorKysgVG9vbHMvVGVzdFdl YktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9VSURlbGVnYXRlLm1tCSh3b3JraW5nIGNvcHkpCkBA IC0yMjYsNiArMjI2LDM0IEBAIFRFU1QoV2ViS2l0LCBTaG93V2ViVmlldykKICAgICBBU1NFUlRf RVEod2ViVmlld0Zyb21EZWxlZ2F0ZUNhbGxiYWNrLCBjcmVhdGVkV2ViVmlldyk7CiB9CiAKK0Bp bnRlcmZhY2UgUG9pbnRlckxvY2tEZWxlZ2F0ZSA6IE5TT2JqZWN0IDxXS1VJRGVsZWdhdGVQcml2 YXRlPgorQGVuZAorCitAaW1wbGVtZW50YXRpb24gUG9pbnRlckxvY2tEZWxlZ2F0ZQorCistICh2 b2lkKV93ZWJWaWV3UmVxdWVzdFBvaW50ZXJMb2NrOihXS1dlYlZpZXcgKil3ZWJWaWV3IGNvbXBs ZXRpb25IYW5kbGVyOih2b2lkICheKShCT09MKSljb21wbGV0aW9uSGFuZGxlcgoreworICAgIGNv bXBsZXRpb25IYW5kbGVyKFlFUyk7CisgICAgZG9uZSA9IHRydWU7Cit9CisKK0BlbmQKKworVEVT VChXZWJLaXQsIFBvaW50ZXJMb2NrKQoreworICAgIGF1dG8gd2ViVmlldyA9IGFkb3B0TlMoW1tU ZXN0V0tXZWJWaWV3IGFsbG9jXSBpbml0V2l0aEZyYW1lOkNHUmVjdE1ha2UoMCwgMCwgODAwLCA2 MDApXSk7CisgICAgYXV0byBkZWxlZ2F0ZSA9IGFkb3B0TlMoW1tQb2ludGVyTG9ja0RlbGVnYXRl IGFsbG9jXSBpbml0XSk7CisgICAgW3dlYlZpZXcgc2V0VUlEZWxlZ2F0ZTpkZWxlZ2F0ZS5nZXQo KV07CisgICAgW3dlYlZpZXcgc3luY2hyb25vdXNseUxvYWRIVE1MU3RyaW5nOgorICAgICAgICBA IjxjYW52YXMgd2lkdGg9JzgwMCcgaGVpZ2h0PSc2MDAnPjwvY2FudmFzPjxzY3JpcHQ+IgorICAg ICAgICBAInZhciBjYW52YXMgPSBkb2N1bWVudC5xdWVyeVNlbGVjdG9yKCdjYW52YXMnKTsiCisg ICAgICAgIEAiY2FudmFzLm9uY2xpY2sgPSAoKT0+e2NhbnZhcy5yZXF1ZXN0UG9pbnRlckxvY2so KX07IgorICAgICAgICBAIjwvc2NyaXB0PiIKKyAgICBdOworICAgIFt3ZWJWaWV3IHNlbmRDbGlj a3NBdFBvaW50Ok5TTWFrZVBvaW50KDIwMCwgMjAwKSBudW1iZXJPZkNsaWNrczoxXTsKKyAgICBU ZXN0V2ViS2l0QVBJOjpVdGlsOjpydW4oJmRvbmUpOworfQorCiBzdGF0aWMgYm9vbCByZXNpemFi bGVTZXQ7CiAKIEBpbnRlcmZhY2UgTW9kYWxEZWxlZ2F0ZSA6IE5TT2JqZWN0IDxXS1VJRGVsZWdh dGVQcml2YXRlPgo=