188862 2018-08-22 13:53:25 -0700 [GTK] [2.22.0] Fails to build in armel 2018-11-26 00:54:26 -0800 1 1 1 Unclassified WebKit WebKitGTK Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 berto webkit-unassigned bugs-noreply dominik.infuehr guijemont mcatanzaro oldest_to_newest 1452798 0 berto 2018-08-22 13:53:25 -0700 Here's the error message: [ 33%] Generating ../../DerivedSources/JavaScriptCore/LLIntAssembly.h cd webkit2gtk-2.21.91/obj-arm-linux-gnueabi/DerivedSources/JavaScriptCore && /usr/bin/ruby webkit2gtk-2.21.91/Source/JavaScriptCore/offlineasm/asm.rb -Iwebkit2gtk-2.21.91/obj-arm-linux-gnueabi/DerivedSources/JavaScriptCore/ webkit2gtk-2.21.91/Source/JavaScriptCore/llint/LowLevelInterpreter.asm webkit2gtk-2.21.91/obj-arm-linux-gnueabi/bin/LLIntOffsetsExtractor webkit2gtk-2.21.91/obj-arm-linux-gnueabi/DerivedSources/JavaScriptCore/LLIntAssembly.h offlineasm: No magic values found. Skipping assembly file generation. make[2]: *** [Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/build.make:110: DerivedSources/JavaScriptCore/LLIntAssembly.h] Error 1 1456148 1 berto 2018-09-03 04:36:12 -0700 Still happening with 2.22.0 1456289 2 berto 2018-09-04 04:46:43 -0700 Building with -DENABLE_JIT=OFF works around that problem, but the build ultimately fails when generating the documentation: gtkdoc-fixxref --module=webkit2gtk-4.0 --module-dir=html/webkit2gtk-4.0 --extra-dir=/usr/share/gtk-doc/html/libsoup-2.4 --extra-dir=/usr/share/gtk-doc/html/gtk3 --extra-dir=/usr/share/gtk-doc/html/gdk3 --extra-dir=/usr/share/gtk-doc/html/gdk-pixbuf --extra-dir=/usr/share/gtk-doc/html/glib --extra-dir=/usr/share/gtk-doc/html/gobject --extra-dir=/usr/share/gtk-doc/html/gio --extra-dir=/home/user/webkit2gtk-2.22.0/obj-arm-linux-gnueabi/Documentation/webkitdomgtk-4.0/html --extra-dir=/home/user/webkit2gtk-2.22.0/obj-arm-linux-gnueabi/Documentation/jsc-glib-4.0/html Traceback (most recent call last): File "/usr/bin/gtkdoc-fixxref", line 57, in <module> fixxref.Run(options) File "/usr/share/gtk-doc/python/gtkdoc/fixxref.py", line 64, in Run FixCrossReferences(options.module_dir, options.module, options.src_lang) File "/usr/share/gtk-doc/python/gtkdoc/fixxref.py", line 224, in FixCrossReferences FixHTMLFile(src_lang, module, full_entry) File "/usr/share/gtk-doc/python/gtkdoc/fixxref.py", line 247, in FixHTMLFile repl_func, content, flags=re.DOTALL) File "/usr/lib/python2.7/re.py", line 155, in sub return _compile(pattern, flags).sub(repl, string, count) File "/usr/share/gtk-doc/python/gtkdoc/fixxref.py", line 244, in repl_func return HighlightSource(src_lang, m.group(1), m.group(2)) File "/usr/share/gtk-doc/python/gtkdoc/fixxref.py", line 354, in HighlightSource [config.highlight] + shlex.split(highlight_options) + [temp_source_file]).decode('utf-8') File "/usr/lib/python2.7/subprocess.py", line 223, in check_output raise CalledProcessError(retcode, cmd, output=output) subprocess.CalledProcessError: Command '['/usr/bin/highlight', '--syntax=c', '--out-format=xhtml', '-f', '--class-name=gtkdoc', '/tmp/tmpjRU4NW.c']' returned non-zero exit status -4 But this is almost certainly not a webkit bug. 1481390 3 berto 2018-11-25 09:47:00 -0800 I tried this again with WebKitGTK+ 2.23.1 I think this fails because OFFLINE_ASM_BACKEND is unset in Source/JavaScriptCore/CMakeLists.txt There's no ARMv7 (because the Debian armel port targets older CPUs) and there's no CLoop because it's disabled by default on ARM. I can fix this by passing ENABLE_C_LOOP=ON manually, but should the build system detect this scenario instead? 1481391 4 mcatanzaro 2018-11-25 09:56:32 -0800 Per https://lists.webkit.org/pipermail/webkit-dev/2018-October/030220.html cloop should be enabled. This architecture check in WebKitFeatures.cmake is insufficient: if (WTF_CPU_ARM64 OR WTF_CPU_X86_64) set(ENABLE_JIT_DEFAULT ON) set(ENABLE_FTL_DEFAULT ON) set(USE_SYSTEM_MALLOC_DEFAULT OFF) set(ENABLE_C_LOOP_DEFAULT OFF) set(ENABLE_SAMPLING_PROFILER_DEFAULT ON) elseif (WTF_CPU_ARM AND WTF_OS_LINUX) set(ENABLE_JIT_DEFAULT ON) set(ENABLE_FTL_DEFAULT OFF) set(USE_SYSTEM_MALLOC_DEFAULT OFF) set(ENABLE_C_LOOP_DEFAULT OFF) set(ENABLE_SAMPLING_PROFILER_DEFAULT ON) else () set(ENABLE_JIT_DEFAULT OFF) set(ENABLE_FTL_DEFAULT OFF) set(USE_SYSTEM_MALLOC_DEFAULT ON) set(ENABLE_C_LOOP_DEFAULT ON) set(ENABLE_SAMPLING_PROFILER_DEFAULT OFF) endif () The WTF_CPU_ARM branch enables the JIT stuff, but this is no longer supported on your WTF_CPU_ARM board. So that branch is incorrect. More logic is needed to distinguish between ARMv7 + thumb and older ARM. Should look something like: elseif (WTF_CPU_ARM AND has thumb2 AND armv7 AND WTF_OS_LINUX) 1481397 5 berto 2018-11-25 11:48:16 -0800 Yeah, something like that. I can give it a try and try to come up with a patch. 1481422 6 355607 berto 2018-11-25 14:49:45 -0800 Created attachment 355607 Patch 1481423 7 355608 berto 2018-11-25 14:50:57 -0800 Created attachment 355608 Patch This seems to be enough 1481482 8 berto 2018-11-26 00:54:26 -0800 Committed r238489: <https://trac.webkit.org/changeset/238489> 355607 2018-11-25 14:49:45 -0800 2018-11-25 14:50:57 -0800 Patch file_188862.txt text/plain 24 berto VGhpcyBzZWVtcyB0byBiZSBlbm91Z2gu 355608 2018-11-25 14:50:57 -0800 2018-11-25 18:59:57 -0800 Patch 188862.diff text/plain 1194 berto ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA0NjhiMjRkOTQ4MC4uZTY0 ZDg5NWRkNjUgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxNSBAQAorMjAxOC0xMS0yNSAgQWxiZXJ0byBHYXJjaWEgIDxiZXJ0b0BpZ2FsaWEuY29tPgor CisgICAgICAgIFtHVEtdIFsyLjIyLjBdIEZhaWxzIHRvIGJ1aWxkIGluIGFybWVsCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODg4NjIKKworICAgICAg ICBEaXNhYmxlIHRoZSBKSVQgYW5kIGVuYWJsZSBDX0xPT1Agb24gQVJNIENQVXMgd2l0aG91dCBU aHVtYjIKKyAgICAgICAgc3VwcG9ydC4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFrZToKKwog MjAxOC0xMS0yMiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAK ICAgICAgICAgVW5yZXZpZXdlZC4gVXBkYXRlIE9wdGlvbnNHVEsuY21ha2UgYW5kIE5FV1MgZm9y IDIuMjMuMSByZWxlYXNlLgpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL1dlYktpdEZlYXR1cmVz LmNtYWtlIGIvU291cmNlL2NtYWtlL1dlYktpdEZlYXR1cmVzLmNtYWtlCmluZGV4IDA0YmNmZTQw Yzg1Li41YjQ2NjlmZDM3YSAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL1dlYktpdEZlYXR1cmVz LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFrZQpAQCAtNjgsNyAr NjgsNyBAQCBtYWNybyhXRUJLSVRfT1BUSU9OX0JFR0lOKQogICAgICAgICBzZXQoVVNFX1NZU1RF TV9NQUxMT0NfREVGQVVMVCBPRkYpCiAgICAgICAgIHNldChFTkFCTEVfQ19MT09QX0RFRkFVTFQg T0ZGKQogICAgICAgICBzZXQoRU5BQkxFX1NBTVBMSU5HX1BST0ZJTEVSX0RFRkFVTFQgT04pCi0g ICAgZWxzZWlmIChXVEZfQ1BVX0FSTSBBTkQgV1RGX09TX0xJTlVYKQorICAgIGVsc2VpZiAoV1RG X0NQVV9BUk0gQU5EIFdURl9PU19MSU5VWCBBTkQgQVJNX1RIVU1CMl9ERVRFQ1RFRCkKICAgICAg ICAgc2V0KEVOQUJMRV9KSVRfREVGQVVMVCBPTikKICAgICAgICAgc2V0KEVOQUJMRV9GVExfREVG QVVMVCBPRkYpCiAgICAgICAgIHNldChVU0VfU1lTVEVNX01BTExPQ19ERUZBVUxUIE9GRikK