188861 2018-08-22 13:49:21 -0700 [iOS] Make color of spelling dots match UIKit 2018-08-27 10:11:23 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Local Build iPhone / iPad iOS 11 RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=188828 InRadar, PlatformOnly P2 Normal --- 1 dbates dbates simon.fraser webkit-bug-importer wenson_hsieh oldest_to_newest 1452794 0 dbates 2018-08-22 13:49:21 -0700 The color of the spelling dots on iOS should match the colors used in UIKit-based apps. 1452797 1 347843 dbates 2018-08-22 13:53:06 -0700 Created attachment 347843 Patch I am open to naming suggestions. 1453950 2 347843 dbates 2018-08-27 10:11:00 -0700 Comment on attachment 347843 Patch Clearing flags on attachment: 347843 Committed r235380: <https://trac.webkit.org/changeset/235380> 1453951 3 dbates 2018-08-27 10:11:01 -0700 All reviewed patches have been landed. Closing bug. 1453952 4 webkit-bug-importer 2018-08-27 10:11:23 -0700 <rdar://problem/43758256> 347843 2018-08-22 13:53:06 -0700 2018-08-27 10:11:00 -0700 Patch bug-188861-20180822135305.patch text/plain 7300 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1MTQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDEzMzY4OGU4NDVhODQw MDYyNDFjM2VlMzliNjM3NjUxY2U5NjQ4YS4uMDkyNWYzZjAzYmQ2MzY0MDdlZGQ2M2UyOGI2ZGJj NmQ5YjU4NGM4MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE4LTA4LTIyICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBNYWtlIGNvbG9y IG9mIHNwZWxsaW5nIGRvdHMgbWF0Y2ggVUlLaXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE4ODg2MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRoZW1lQ29jb2EuaDoKKyAg ICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGhlbWVDb2NvYS5tbToKKyAgICAgICAgKFdlYkNvcmU6 OlJlbmRlclRoZW1lQ29jb2E6OmRyYXdMaW5lRm9yRG9jdW1lbnRNYXJrZXIpOiBNb2RpZmllZCB0 byBjYWxsIGNvbG9yRm9yTWFya2VyTGluZVN0eWxlKCkKKyAgICAgICAgZm9yIHRoZSBjb2xvciB0 byB1c2UgZm9yIHRoZSBsaW5lIHN0eWxlLgorICAgICAgICAoV2ViQ29yZTo6Y29sb3JGb3JTdHls ZSk6IERlbGV0ZWQuCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRoZW1lSU9TLmg6CisgICAg ICAgICogcmVuZGVyaW5nL1JlbmRlclRoZW1lSU9TLm1tOgorICAgICAgICAoV2ViQ29yZTo6UmVu ZGVyVGhlbWVJT1M6OmNvbG9yRm9yTWFya2VyTGluZVN0eWxlKTogQWRkZWQuCisgICAgICAgICog cmVuZGVyaW5nL1JlbmRlclRoZW1lTWFjLmg6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRo ZW1lTWFjLm1tOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVNYWM6OmNvbG9yRm9yTWFy a2VyTGluZVN0eWxlKTogQWRkZWQuCisKIDIwMTgtMDgtMjIgIERhbmllbCBCYXRlcyAgPGRhYmF0 ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFNwZWxsaW5nIGRvdHMgZG8gbm90IHNjYWxlIHdpdGgg cGFnZSBvbiBpT1M7IHNoYXJlIHNwZWxsaW5nIGRvdCBwYWludGluZyBjb2RlIGJldHdlZW4gTWFj IGFuZCBpT1MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVt ZUNvY29hLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDb2NvYS5oCmlu ZGV4IGMyODMwZmU4YWRjYWQ1MWUxMmQ0MzFiZDZhZmUxMzM0OTlkYjMzM2IuLjE2ZGU5NjU0ZmIy NmFlYWFhYWIxYWQ4MzkzODMxMzhhNTZiZmUzMWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJUaGVtZUNvY29hLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlclRoZW1lQ29jb2EuaApAQCAtNDMsNiArNDMsOCBAQCBwcml2YXRlOgogICAgIGJv b2wgcGFpbnRBcHBsZVBheUJ1dHRvbihjb25zdCBSZW5kZXJPYmplY3QmLCBjb25zdCBQYWludElu Zm8mLCBjb25zdCBJbnRSZWN0Jikgb3ZlcnJpZGU7CiAjZW5kaWYKIHByb3RlY3RlZDoKKyAgICB2 aXJ0dWFsIENHQ29sb3JSZWYgY29sb3JGb3JNYXJrZXJMaW5lU3R5bGUoRG9jdW1lbnRNYXJrZXJM aW5lU3R5bGUsIGJvb2wgdXNlRGFya01vZGUpID0gMDsKKwogI2lmIEVOQUJMRShWSURFTykKICAg ICBTdHJpbmcgbWVkaWFDb250cm9sc0Zvcm1hdHRlZFN0cmluZ0ZvckR1cmF0aW9uKGRvdWJsZSkg b3ZlcnJpZGU7CiAjZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJUaGVtZUNvY29hLm1tIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1l Q29jb2EubW0KaW5kZXggMWQ2ZmY2ZWI1NTAxZjdiNDU0MThmNTExNWJhMTFiNTFkMDZjNDM3Ni4u MjAyOGE2YTVkZGRjZjkwNTMzZjc2MWRjZGRhNzMyM2IwMWQ1YTcwMyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lQ29jb2EubW0KKysrIGIvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lQ29jb2EubW0KQEAgLTUzLDI5ICs1MywxMiBAQCBT T0ZUX0xJTktfTUFZX0ZBSUwoUGFzc0tpdCwgUEtEcmF3QXBwbGVQYXlCdXR0b24sIHZvaWQsIChD R0NvbnRleHRSZWYgY29udGV4dCwgQwogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKLXN0YXRpYyBD R0NvbG9yUmVmIGNvbG9yRm9yU3R5bGUoRG9jdW1lbnRNYXJrZXJMaW5lU3R5bGUgc3R5bGUsIGJv b2wgdXNlRGFya01vZGUpCi17Ci0gICAgc3dpdGNoIChzdHlsZSkgewotICAgIC8vIFJlZAotICAg IGNhc2UgRG9jdW1lbnRNYXJrZXJMaW5lU3R5bGU6OlNwZWxsaW5nOgotICAgICAgICByZXR1cm4g Y2FjaGVkQ0dDb2xvcih1c2VEYXJrTW9kZSA/IENvbG9yIHsgMjU1LCAxNDAsIDE0MCwgMjE3IH0g OiBDb2xvciB7IDI1NSwgNTksIDQ4LCAxOTEgfSk7Ci0gICAgLy8gQmx1ZQotICAgIGNhc2UgRG9j dW1lbnRNYXJrZXJMaW5lU3R5bGU6OkRpY3RhdGlvbkFsdGVybmF0aXZlczoKLSAgICBjYXNlIERv Y3VtZW50TWFya2VyTGluZVN0eWxlOjpUZXh0Q2hlY2tpbmdEaWN0YXRpb25QaHJhc2VXaXRoQWx0 ZXJuYXRpdmVzOgotICAgIGNhc2UgRG9jdW1lbnRNYXJrZXJMaW5lU3R5bGU6OkF1dG9jb3JyZWN0 aW9uUmVwbGFjZW1lbnQ6Ci0gICAgICAgIHJldHVybiBjYWNoZWRDR0NvbG9yKHVzZURhcmtNb2Rl ID8gQ29sb3IgeyA0MCwgMTQ1LCAyNTUsIDIxNyB9IDogQ29sb3IgeyAwLCAxMjIsIDI1NSwgMTkx IH0pOwotICAgIC8vIEdyZWVuCi0gICAgY2FzZSBEb2N1bWVudE1hcmtlckxpbmVTdHlsZTo6R3Jh bW1hcjoKLSAgICAgICAgcmV0dXJuIGNhY2hlZENHQ29sb3IodXNlRGFya01vZGUgPyBDb2xvciB7 IDUwLCAyMTUsIDc1LCAyMTcgfSA6IENvbG9yIHsgMjUsIDE3NSwgNTAsIDE5MSB9KTsKLSAgICB9 Ci19Ci0KIHZvaWQgUmVuZGVyVGhlbWVDb2NvYTo6ZHJhd0xpbmVGb3JEb2N1bWVudE1hcmtlcihj b25zdCBSZW5kZXJUZXh0JiByZW5kZXJlciwgR3JhcGhpY3NDb250ZXh0JiBjb250ZXh0LCBjb25z dCBGbG9hdFBvaW50JiBvcmlnaW4sIGZsb2F0IHdpZHRoLCBEb2N1bWVudE1hcmtlckxpbmVTdHls ZSBzdHlsZSkKIHsKICAgICBpZiAoY29udGV4dC5wYWludGluZ0Rpc2FibGVkKCkpCiAgICAgICAg IHJldHVybjsKIAotICAgIGF1dG8gY2lyY2xlQ29sb3IgPSBjb2xvckZvclN0eWxlKHN0eWxlLCBy ZW5kZXJlci5wYWdlKCkudXNlU3lzdGVtQXBwZWFyYW5jZSgpICYmIHJlbmRlcmVyLnBhZ2UoKS51 c2VEYXJrQXBwZWFyYW5jZSgpKTsKKyAgICBhdXRvIGNpcmNsZUNvbG9yID0gY29sb3JGb3JNYXJr ZXJMaW5lU3R5bGUoc3R5bGUsIHJlbmRlcmVyLnBhZ2UoKS51c2VTeXN0ZW1BcHBlYXJhbmNlKCkg JiYgcmVuZGVyZXIucGFnZSgpLnVzZURhcmtBcHBlYXJhbmNlKCkpOwogCiAgICAgLy8gQ2VudGVy IHRoZSB1bmRlcmxpbmUgYW5kIGVuc3VyZSB3ZSBvbmx5IGRyYXcgZW50aXJlIGRvdHMuCiAgICAg RmxvYXRQb2ludCBvZmZzZXRQb2ludCA9IG9yaWdpbjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUlPUy5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlclRoZW1lSU9TLmgKaW5kZXggOWNhNzYzMTRjMDkxMmViN2I5YmQyMjgzZGQzZTMwZWMw NzFkZjU4ZC4uMGQ4ODZiYjNhZTYzY2U1MjZlODFmMTZlZjg1Y2Y2OWY0NjZiMGQ4OSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lSU9TLmgKKysrIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lSU9TLmgKQEAgLTE1MCw2ICsxNTAsOCBA QCBwcml2YXRlOgogCiAgICAgQ29sb3Igc3lzdGVtQ29sb3IoQ1NTVmFsdWVJRCwgT3B0aW9uU2V0 PFN0eWxlQ29sb3I6Ok9wdGlvbnM+KSBjb25zdCBvdmVycmlkZTsKIAorICAgIENHQ29sb3JSZWYg Y29sb3JGb3JNYXJrZXJMaW5lU3R5bGUoRG9jdW1lbnRNYXJrZXJMaW5lU3R5bGUsIGJvb2wgdXNl RGFya01vZGUpIG92ZXJyaWRlOworCiAgICAgU3RyaW5nIG1fbGVnYWN5TWVkaWFDb250cm9sc1Nj cmlwdDsKICAgICBTdHJpbmcgbV9tZWRpYUNvbnRyb2xzU2NyaXB0OwogICAgIFN0cmluZyBtX2xl Z2FjeU1lZGlhQ29udHJvbHNTdHlsZVNoZWV0OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlclRoZW1lSU9TLm1tIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlclRoZW1lSU9TLm1tCmluZGV4IDBlNTUwMWRjZTY4YjQ3NGVlY2M4MTgzMTNlYjY3YzJjNWU1 YWJlNDAuLmI4NjI3MzQxMjZmYmQxZDUzZWRlMjVmOWYxMzgxY2RkNjJjNDQxN2EgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUlPUy5tbQorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVJT1MubW0KQEAgLTE0MjEsNiArMTQyMSwy MCBAQCBTdHJpbmcgUmVuZGVyVGhlbWVJT1M6Om1lZGlhQ29udHJvbHNCYXNlNjRTdHJpbmdGb3JJ Y29uTmFtZUFuZFR5cGUoY29uc3QgU3RyaW5nJgogCiAjZW5kaWYgLy8gRU5BQkxFKFZJREVPKQog CitDR0NvbG9yUmVmIFJlbmRlclRoZW1lSU9TOjpjb2xvckZvck1hcmtlckxpbmVTdHlsZShEb2N1 bWVudE1hcmtlckxpbmVTdHlsZSBzdHlsZSwgYm9vbCkKK3sKKyAgICBzd2l0Y2ggKHN0eWxlKSB7 CisgICAgY2FzZSBEb2N1bWVudE1hcmtlckxpbmVTdHlsZTo6U3BlbGxpbmc6CisgICAgICAgIHJl dHVybiBbZ2V0VUlDb2xvckNsYXNzKCkgc3lzdGVtUmVkQ29sb3JdLkNHQ29sb3I7CisgICAgY2Fz ZSBEb2N1bWVudE1hcmtlckxpbmVTdHlsZTo6RGljdGF0aW9uQWx0ZXJuYXRpdmVzOgorICAgIGNh c2UgRG9jdW1lbnRNYXJrZXJMaW5lU3R5bGU6OlRleHRDaGVja2luZ0RpY3RhdGlvblBocmFzZVdp dGhBbHRlcm5hdGl2ZXM6CisgICAgY2FzZSBEb2N1bWVudE1hcmtlckxpbmVTdHlsZTo6QXV0b2Nv cnJlY3Rpb25SZXBsYWNlbWVudDoKKyAgICAgICAgcmV0dXJuIFtnZXRVSUNvbG9yQ2xhc3MoKSBz eXN0ZW1CbHVlQ29sb3JdLkNHQ29sb3I7CisgICAgY2FzZSBEb2N1bWVudE1hcmtlckxpbmVTdHls ZTo6R3JhbW1hcjoKKyAgICAgICAgcmV0dXJuIFtnZXRVSUNvbG9yQ2xhc3MoKSBzeXN0ZW1HcmVl bkNvbG9yXS5DR0NvbG9yOworICAgIH0KK30KKwogQ29sb3IgUmVuZGVyVGhlbWVJT1M6OnN5c3Rl bUNvbG9yKENTU1ZhbHVlSUQgY3NzVmFsdWVJRCwgT3B0aW9uU2V0PFN0eWxlQ29sb3I6Ok9wdGlv bnM+IG9wdGlvbnMpIGNvbnN0CiB7CiAgICAgY29uc3QgYm9vbCBmb3JWaXNpdGVkTGluayA9IG9w dGlvbnMuY29udGFpbnMoU3R5bGVDb2xvcjo6T3B0aW9uczo6Rm9yVmlzaXRlZExpbmspOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFjLmggYi9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVNYWMuaAppbmRleCBiYTc5YmRhYzcyOTdi MzFiNDZhNmJmNGQ1ZDM3MjE1YWEzOTgzOWZiLi4yODdjMmE2YjFkZDNlZjRlMjFjOTVlYjU5MmFm N2YwZmIwYzBkYzdkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy VGhlbWVNYWMuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVNYWMu aApAQCAtMTgxLDYgKzE4MSw4IEBAIHByaXZhdGU6CiAKICAgICBDb2xvciBzeXN0ZW1Db2xvcihD U1NWYWx1ZUlELCBPcHRpb25TZXQ8U3R5bGVDb2xvcjo6T3B0aW9ucz4pIGNvbnN0IGZpbmFsOwog CisgICAgQ0dDb2xvclJlZiBjb2xvckZvck1hcmtlckxpbmVTdHlsZShEb2N1bWVudE1hcmtlckxp bmVTdHlsZSwgYm9vbCB1c2VEYXJrTW9kZSkgb3ZlcnJpZGU7CisKICAgICBDb2xvckNhY2hlJiBj b2xvckNhY2hlKE9wdGlvblNldDxTdHlsZUNvbG9yOjpPcHRpb25zPikgY29uc3QgZmluYWw7CiAK ICAgICB2b2lkIHB1cmdlQ2FjaGVzKCkgZmluYWw7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVNYWMubW0gYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyVGhlbWVNYWMubW0KaW5kZXggMDVlNzgxYTIzMzc0Yjg3NGEwZTM4ODk1ZTQxZjc5ZjZk MGQyMGE3My4uMGMwNDU5NmMwNGNjZmRjZDk4MmM2OTU0Y2Y1MjE1NjU2NTc3NGE4YyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFjLm1tCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZU1hYy5tbQpAQCAtMjk4Miw2ICsyOTgy LDIzIEBAIGJvb2wgUmVuZGVyVGhlbWVNYWM6OnVzaW5nRGFya0FwcGVhcmFuY2UoY29uc3QgUmVu ZGVyT2JqZWN0JiBvKSBjb25zdAogI2VuZGlmCiB9CiAKK0NHQ29sb3JSZWYgUmVuZGVyVGhlbWVN YWM6OmNvbG9yRm9yTWFya2VyTGluZVN0eWxlKERvY3VtZW50TWFya2VyTGluZVN0eWxlIHN0eWxl LCBib29sIHVzZURhcmtNb2RlKQoreworICAgIHN3aXRjaCAoc3R5bGUpIHsKKyAgICAvLyBSZWQK KyAgICBjYXNlIERvY3VtZW50TWFya2VyTGluZVN0eWxlOjpTcGVsbGluZzoKKyAgICAgICAgcmV0 dXJuIGNhY2hlZENHQ29sb3IodXNlRGFya01vZGUgPyBDb2xvciB7IDI1NSwgMTQwLCAxNDAsIDIx NyB9IDogQ29sb3IgeyAyNTUsIDU5LCA0OCwgMTkxIH0pOworICAgIC8vIEJsdWUKKyAgICBjYXNl IERvY3VtZW50TWFya2VyTGluZVN0eWxlOjpEaWN0YXRpb25BbHRlcm5hdGl2ZXM6CisgICAgY2Fz ZSBEb2N1bWVudE1hcmtlckxpbmVTdHlsZTo6VGV4dENoZWNraW5nRGljdGF0aW9uUGhyYXNlV2l0 aEFsdGVybmF0aXZlczoKKyAgICBjYXNlIERvY3VtZW50TWFya2VyTGluZVN0eWxlOjpBdXRvY29y cmVjdGlvblJlcGxhY2VtZW50OgorICAgICAgICByZXR1cm4gY2FjaGVkQ0dDb2xvcih1c2VEYXJr TW9kZSA/IENvbG9yIHsgNDAsIDE0NSwgMjU1LCAyMTcgfSA6IENvbG9yIHsgMCwgMTIyLCAyNTUs IDE5MSB9KTsKKyAgICAvLyBHcmVlbgorICAgIGNhc2UgRG9jdW1lbnRNYXJrZXJMaW5lU3R5bGU6 OkdyYW1tYXI6CisgICAgICAgIHJldHVybiBjYWNoZWRDR0NvbG9yKHVzZURhcmtNb2RlID8gQ29s b3IgeyA1MCwgMjE1LCA3NSwgMjE3IH0gOiBDb2xvciB7IDI1LCAxNzUsIDUwLCAxOTEgfSk7Cisg ICAgfQorfQorCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCiAKICNlbmRpZiAvLyBQTEFURk9STShN QUMpCg==