18886 2008-05-04 11:54:48 -0700 RenderLayer::shouldBeOverflowOnly() should look for transforms 2008-07-11 10:58:25 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser dino oldest_to_newest 79623 0 simon.fraser 2008-05-04 11:54:48 -0700 RenderLayer::shouldBeOverflowOnly() decides if a layer is an overflow-only layer (just used for clipping, and not a parent of other RenderLayers). It currently does not look for transforms, which create stacking context and behave like position:relative. I think it should. 85587 1 hyatt 2008-07-09 17:45:01 -0700 <body style="margin:0"> <div style="position:absolute; background-color:red; z-index:0; left: 50px; top:50px; width:100px;height:100px"></div> <div style="overflow:auto; -webkit-transform: scale(0.5); background-color:green; z-index:0; width:200px; height:200px"></div> 85588 2 hyatt 2008-07-09 17:47:40 -0700 I think that might be a valid test case, but not 100% sure. Would have to think about it some more. 85589 3 22194 simon.fraser 2008-07-09 17:56:37 -0700 Created attachment 22194 Testcase 85590 4 22195 simon.fraser 2008-07-09 17:57:41 -0700 Created attachment 22195 Patch 85591 5 22195 hyatt 2008-07-09 18:02:40 -0700 Comment on attachment 22195 Patch r=me, but need a ChangeLog and the test case included in LayoutTests to land. 85616 6 22200 simon.fraser 2008-07-10 10:58:47 -0700 Created attachment 22200 Final patch with changelog and testcase 85618 7 22200 simon.fraser 2008-07-10 11:07:58 -0700 Comment on attachment 22200 Final patch with changelog and testcase Transferring r= from hyatt 85625 8 dino 2008-07-10 12:15:47 -0700 Committed r35100 85637 9 simon.fraser 2008-07-10 13:48:26 -0700 Committed by dino in r35100 22194 2008-07-09 17:56:37 -0700 2008-07-09 17:56:37 -0700 Testcase transform-overflow.html text/html 555 simon.fraser PGh0bWw+CjxoZWFkPgogIDxzdHlsZSB0eXBlPSJ0ZXh0L2NzcyIgbWVkaWE9InNjcmVlbiI+CiAg ICBib2R5IHsKICAgICAgbWFyZ2luOiAwOwogICAgfQogICAgCiAgICAjb25lIHsKICAgICAgcG9z aXRpb246YWJzb2x1dGU7CiAgICAgIGxlZnQ6IDUwcHg7CiAgICAgIHRvcDo1MHB4OwogICAgICB3 aWR0aDoxMDBweDsKICAgICAgaGVpZ2h0OjEwMHB4OwogICAgICBiYWNrZ3JvdW5kLWNvbG9yOnJl ZDsKICAgICAgei1pbmRleDowOwogICAgfQogICAgCiAgICAjdHdvIHsKICAgICAgd2lkdGg6MjAw cHg7CiAgICAgIGhlaWdodDoyMDBweDsKICAgICAgb3ZlcmZsb3c6IGF1dG87CiAgICAgIC13ZWJr aXQtdHJhbnNmb3JtOiBzY2FsZSgwLjUpOwogICAgICBiYWNrZ3JvdW5kLWNvbG9yOmdyZWVuOwog ICAgICB6LWluZGV4OjA7CiAgICB9CiAgPC9zdHlsZT4KPC9oZWFkPgo8Ym9keT4KICA8ZGl2IGlk PSJvbmUiPjwvZGl2PgogIDxkaXYgaWQ9InR3byI+PC9kaXY+CiAgPHA+WW91IHNob3VsZCBzZWUg b25lIGdyZWVuIHNxdWFyZSBhYm92ZTwvcD4KPC9ib2R5Pgo8L2h0bWw+ 22195 2008-07-09 17:57:41 -0700 2008-07-10 10:58:47 -0700 Patch patch_18886.txt text/plain 508 simon.fraser ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcCBiL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAppbmRleCA4OWEzNzM2Li43YmQ3NjBjIDEwMDY0NAot LS0gYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKKysrIGIvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCkBAIC0yMjg3LDYgKzIyODcsNyBAQCBib29sIFJlbmRlckxh eWVyOjpzaG91bGRCZU92ZXJmbG93T25seSgpIGNvbnN0CiAgICAgcmV0dXJuIChyZW5kZXJlcigp LT5oYXNPdmVyZmxvd0NsaXAoKSB8fCByZW5kZXJlcigpLT5oYXNSZWZsZWN0aW9uKCkpICYmIAog ICAgICAgICAgICAhcmVuZGVyZXIoKS0+aXNQb3NpdGlvbmVkKCkgJiYKICAgICAgICAgICAgIXJl bmRlcmVyKCktPmlzUmVsUG9zaXRpb25lZCgpICYmCisgICAgICAgICAgICFyZW5kZXJlcigpLT5o YXNUcmFuc2Zvcm0oKSAmJgogICAgICAgICAgICAhaXNUcmFuc3BhcmVudCgpOwogfQogCg== 22200 2008-07-10 10:58:47 -0700 2008-07-10 11:07:58 -0700 Final patch with changelog and testcase shouldBeOverflowOny_patch.txt text/plain 3507 simon.fraser ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAxZWZhMGU5Li45ODRiYjUyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDgtMDct MTAgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgRGF2ZSBIeWF0dAorICAgICAgICAKKyAgICAgICAgVGVzdCBmb3IgPGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODg4Nj4KKyAgICAgICAgUmVuZGVyTGF5 ZXI6OnNob3VsZEJlT3ZlcmZsb3dPbmx5KCkgc2hvdWxkIGxvb2sgZm9yIHRyYW5zZm9ybXMKKwor ICAgICAgICAqIGZhc3QvdHJhbnNmb3Jtcy90cmFuc2Zvcm0tb3ZlcmZsb3cuaHRtbDogQWRkZWQu CisgICAgICAgICogcGxhdGZvcm0vbWFjL2Zhc3QvdHJhbnNmb3Jtcy90cmFuc2Zvcm0tb3ZlcmZs b3ctZXhwZWN0ZWQudHh0OiBBZGRlZC4KKwogMjAwOC0wNy0wOSAgQnJhZHkgRWlkc29uICA8YmVp ZHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4KZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL2Zhc3QvdHJhbnNmb3Jtcy90cmFuc2Zvcm0tb3ZlcmZsb3cuaHRtbCBiL0xh eW91dFRlc3RzL2Zhc3QvdHJhbnNmb3Jtcy90cmFuc2Zvcm0tb3ZlcmZsb3cuaHRtbApuZXcgZmls ZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi4zYmFkZTA5Ci0tLSAvZGV2L251bGwKKysrIGIv TGF5b3V0VGVzdHMvZmFzdC90cmFuc2Zvcm1zL3RyYW5zZm9ybS1vdmVyZmxvdy5odG1sCkBAIC0w LDAgKzEsMzMgQEAKKzxodG1sPgorPGhlYWQ+CisgIDxzdHlsZSB0eXBlPSJ0ZXh0L2NzcyIgbWVk aWE9InNjcmVlbiI+CisgICAgYm9keSB7CisgICAgICBtYXJnaW46IDA7CisgICAgfQorICAgIAor ICAgICNvbmUgeworICAgICAgcG9zaXRpb246YWJzb2x1dGU7CisgICAgICBsZWZ0OiA1MHB4Owor ICAgICAgdG9wOjUwcHg7CisgICAgICB3aWR0aDoxMDBweDsKKyAgICAgIGhlaWdodDoxMDBweDsK KyAgICAgIGJhY2tncm91bmQtY29sb3I6cmVkOworICAgICAgei1pbmRleDowOworICAgIH0KKyAg ICAKKyAgICAjdHdvIHsKKyAgICAgIHdpZHRoOjIwMHB4OworICAgICAgaGVpZ2h0OjIwMHB4Owor ICAgICAgb3ZlcmZsb3c6IGF1dG87CisgICAgICAtd2Via2l0LXRyYW5zZm9ybTogc2NhbGUoMC41 KTsKKyAgICAgIGJhY2tncm91bmQtY29sb3I6Z3JlZW47CisgICAgICB6LWluZGV4OjA7CisgICAg fQorICA8L3N0eWxlPgorPC9oZWFkPgorPGJvZHk+CisgIDxkaXYgaWQ9Im9uZSI+PC9kaXY+Cisg IDxkaXYgaWQ9InR3byI+PC9kaXY+CisgIDxwPllvdSBzaG91bGQgc2VlIG9uZSBncmVlbiBzcXVh cmUgYWJvdmU8L3A+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9tYWMvZmFzdC90cmFuc2Zvcm1zL3RyYW5zZm9ybS1vdmVyZmxvdy1leHBlY3RlZC50 eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC90cmFuc2Zvcm1zL3RyYW5zZm9ybS1v dmVyZmxvdy1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4u OTA2YjljMwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0 L3RyYW5zZm9ybXMvdHJhbnNmb3JtLW92ZXJmbG93LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDEy IEBACitsYXllciBhdCAoMCwwKSBzaXplIDgwMHg2MDAKKyAgUmVuZGVyVmlldyBhdCAoMCwwKSBz aXplIDgwMHg2MDAKK2xheWVyIGF0ICgwLDApIHNpemUgODAweDYwMAorICBSZW5kZXJCbG9jayB7 SFRNTH0gYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCisgICAgUmVuZGVyQm9keSB7Qk9EWX0gYXQgKDAs MCkgc2l6ZSA4MDB4NTg0CisgICAgICBSZW5kZXJCbG9jayB7UH0gYXQgKDAsMjE2KSBzaXplIDgw MHgxOAorICAgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDAsMCkgc2l6ZSAyNTF4MTgKKyAg ICAgICAgICB0ZXh0IHJ1biBhdCAoMCwwKSB3aWR0aCAyNTE6ICJZb3Ugc2hvdWxkIHNlZSBvbmUg Z3JlZW4gc3F1YXJlIGFib3ZlIgorbGF5ZXIgYXQgKDUwLDUwKSBzaXplIDEwMHgxMDAKKyAgUmVu ZGVyQmxvY2sgKHBvc2l0aW9uZWQpIHtESVZ9IGF0ICg1MCw1MCkgc2l6ZSAxMDB4MTAwIFtiZ2Nv bG9yPSNGRjAwMDBdCitsYXllciBhdCAoMCwwKSBzaXplIDIwMHgyMDAKKyAgUmVuZGVyQmxvY2sg e0RJVn0gYXQgKDAsMCkgc2l6ZSAyMDB4MjAwIFtiZ2NvbG9yPSMwMDgwMDBdCmRpZmYgLS1naXQg YS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGVlZmQ4ZWEuLmRl M2M4OTAgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDgtMDctMTAgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZy YXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgVHJhbnNmb3JtcyBjcmVhdGUgYSBjb250YWluaW5n IGJsb2NrLCBzbworICAgICAgICBSZW5kZXJMYXllcjo6c2hvdWxkQmVPdmVyZmxvd09ubHkoKSBu ZWVkcyB0byBsb29rIGZvciB0cmFuc2Zvcm1zLgorICAgICAgICA8aHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE4ODg2PgorICAgICAgICAKKyAgICAgICAgUmV2aWV3ZWQg YnkgRGF2ZSBIeWF0dAorCisgICAgICAgIFRlc3Q6IGZhc3QvdHJhbnNmb3Jtcy90cmFuc2Zvcm0t b3ZlcmZsb3cuaHRtbAorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyOjpzaG91bGRCZU92ZXJmbG93T25seSk6CisKIDIw MDgtMDctMDkgIEFsZXggTWF0aGV3cyAgPHBvc3Nlc3NlZHBlbmd1aW5ib2JAZ21haWwuY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IE9saXZlciBIdW50LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIu Y3BwCmluZGV4IDU4OWQxYzEuLjQzNzc1NGYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckxheWVyLmNwcAorKysgYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAK QEAgLTIzMzMsNiArMjMzMyw3IEBAIGJvb2wgUmVuZGVyTGF5ZXI6OnNob3VsZEJlT3ZlcmZsb3dP bmx5KCkgY29uc3QKICAgICByZXR1cm4gKHJlbmRlcmVyKCktPmhhc092ZXJmbG93Q2xpcCgpIHx8 IHJlbmRlcmVyKCktPmhhc1JlZmxlY3Rpb24oKSkgJiYgCiAgICAgICAgICAgICFyZW5kZXJlcigp LT5pc1Bvc2l0aW9uZWQoKSAmJgogICAgICAgICAgICAhcmVuZGVyZXIoKS0+aXNSZWxQb3NpdGlv bmVkKCkgJiYKKyAgICAgICAgICAgIXJlbmRlcmVyKCktPmhhc1RyYW5zZm9ybSgpICYmCiAgICAg ICAgICAgICFpc1RyYW5zcGFyZW50KCk7CiB9CiAK