188858 2018-08-22 12:52:09 -0700 Don't use WTF_CPU_MIPS when building for mips64 2018-08-22 13:29:05 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 berto webkit-unassigned berto cgarcia clopez lforschler mcatanzaro webkit-bug-importer oldest_to_newest 1452754 0 berto 2018-08-22 12:52:09 -0700 We want that the build system detects automatically when to enable the JIT, but we can't do it with mips64 as we do it for mips, since the former is not supported and results on a build failure: In file included from Source/JavaScriptCore/jit/GPRInfo.h:28, from Source/JavaScriptCore/interpreter/VMEntryRecord.h:28, from Source/JavaScriptCore/interpreter/StackVisitor.h:29, from Source/JavaScriptCore/interpreter/CallFrame.h:29, from Source/JavaScriptCore/runtime/ClassInfo.h:25, from Source/JavaScriptCore/runtime/Structure.h:28, from Source/JavaScriptCore/bytecode/ArrayProfile.h:29, from Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:28: Source/JavaScriptCore/assembler/MacroAssembler.h:69:2: error: #error "The MacroAssembler is not supported on this platform." There's a separate WTF_CPU_MIPS64 for this architecture. 1452756 1 347832 berto 2018-08-22 12:54:21 -0700 Created attachment 347832 Patch 1452774 2 347832 mcatanzaro 2018-08-22 13:22:31 -0700 Comment on attachment 347832 Patch * Reviewed all the checks in existing CMake code * Verified this matches WTF's WTF_CPU_MIPS64 macro * Good! 1452776 3 berto 2018-08-22 13:27:32 -0700 Committed r235194: <https://trac.webkit.org/changeset/235194> 1452778 4 webkit-bug-importer 2018-08-22 13:29:05 -0700 <rdar://problem/43617883> 347832 2018-08-22 12:54:21 -0700 2018-08-22 13:22:31 -0700 Patch 188858.diff text/plain 1077 berto ZGlmZiAtLWdpdCBhL0NNYWtlTGlzdHMudHh0IGIvQ01ha2VMaXN0cy50eHQKaW5kZXggOGY1MzIx Y2FmNmMuLmFlNWM3Yjc2MTM4IDEwMDY0NAotLS0gYS9DTWFrZUxpc3RzLnR4dAorKysgYi9DTWFr ZUxpc3RzLnR4dApAQCAtODcsNiArODcsOCBAQCBpZiAoTE9XRVJDQVNFX0NNQUtFX1NZU1RFTV9Q Uk9DRVNTT1IgTUFUQ0hFUyAiXmFybSIpCiAgICAgc2V0KFdURl9DUFVfQVJNIDEpCiBlbHNlaWYg KExPV0VSQ0FTRV9DTUFLRV9TWVNURU1fUFJPQ0VTU09SIE1BVENIRVMgIl5hYXJjaDY0IikKICAg ICBzZXQoV1RGX0NQVV9BUk02NCAxKQorZWxzZWlmIChMT1dFUkNBU0VfQ01BS0VfU1lTVEVNX1BS T0NFU1NPUiBNQVRDSEVTICJebWlwczY0IikKKyAgICBzZXQoV1RGX0NQVV9NSVBTNjQgMSkKIGVs c2VpZiAoTE9XRVJDQVNFX0NNQUtFX1NZU1RFTV9QUk9DRVNTT1IgTUFUQ0hFUyAiXm1pcHMiKQog ICAgIHNldChXVEZfQ1BVX01JUFMgMSkKIGVsc2VpZiAoTE9XRVJDQVNFX0NNQUtFX1NZU1RFTV9Q Uk9DRVNTT1IgTUFUQ0hFUyAiKHg2NHx4ODZfNjR8YW1kNjQpIikKZGlmZiAtLWdpdCBhL0NoYW5n ZUxvZyBiL0NoYW5nZUxvZwppbmRleCA2MjkzMGY4MGNhNS4uMWMyZGU1OGEyMDAgMTAwNjQ0Ci0t LSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxOC0wOC0y MiAgQWxiZXJ0byBHYXJjaWEgIDxiZXJ0b0BpZ2FsaWEuY29tPgorCisgICAgICAgIERvbid0IHVz ZSBXVEZfQ1BVX01JUFMgd2hlbiBidWlsZGluZyBmb3IgbWlwczY0CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODg4NTgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIENNYWtlTGlzdHMudHh0OiBVc2UgV1RG X0NQVV9NSVBTNjQgZm9yIHRoaXMgYXJjaGl0ZWN0dXJlLgorCiAyMDE4LTA4LTIyICBaYW4gRG9i ZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAogICAgICAgICBbQ29vcmRHcmFwaGljc10g U3dpdGNoIHRvIE5pY29zaWE6OkNvbXBvc2l0aW9uTGF5ZXIgc3RhdGUgdHJhY2tpbmcK