18885 2008-05-04 11:48:57 -0700 RenderLayer::enclosingPositionedAncestor should look at transforms 2008-07-11 15:44:10 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser dino hyatt oldest_to_newest 79621 0 simon.fraser 2008-05-04 11:48:57 -0700 It seems that RenderLayer::enclosingPositionedAncestor() should look for transforms when walking up the RenderLayer tree for a layer to be treated as its positioned ancestor. I noticed this while debugging: convertToLayerCoords() would give the wrong answer if there was an intermediate layer in the tree for a transformed element which was not positioned (will attach sample). 79622 1 20960 simon.fraser 2008-05-04 11:49:35 -0700 Created attachment 20960 Sample with two sets of divs, one of which has a transform. 85660 2 22213 simon.fraser 2008-07-10 14:47:43 -0700 Created attachment 22213 Testcase, but it requires visual inspection 85661 3 simon.fraser 2008-07-10 14:48:14 -0700 Filed bug 19982 on enhancing DRT to dump info about transforms. 85662 4 22214 simon.fraser 2008-07-10 14:49:22 -0700 Created attachment 22214 Patch Patch to enclosingPositionedAncestor() to respect transforms. Also removed some bogus semicolons. 85671 5 22214 hyatt 2008-07-10 15:13:40 -0700 Comment on attachment 22214 Patch Pretty sure the semicolons were needed to stop some bizarre compile error on some platform. I tried to remove this code in an earlier patch as well and was told it was needed. 85672 6 hyatt 2008-07-10 15:14:25 -0700 Although maybe the empty braces would be sufficient for whatever platform was complaining. I think bdash would remember. 85707 7 simon.fraser 2008-07-10 16:23:40 -0700 How about rewriting those as while() loops? The for loops make my head hurt. 85713 8 simon.fraser 2008-07-10 16:37:48 -0700 bdash says that for (...) { } is OK. It's for (...); that had issues. 85783 9 22249 simon.fraser 2008-07-11 10:54:07 -0700 Created attachment 22249 Patch, testcase, changelog 85785 10 22249 hyatt 2008-07-11 11:34:16 -0700 Comment on attachment 22249 Patch, testcase, changelog r=me 85814 11 dino 2008-07-11 15:35:20 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog A LayoutTests/fast/transforms/transform-positioned-ancestor.html A LayoutTests/platform/mac/fast/transforms/transform-positioned-ancestor-expected.txt M WebCore/ChangeLog M WebCore/rendering/RenderLayer.cpp Committed r35138 20960 2008-05-04 11:49:35 -0700 2008-07-10 14:47:43 -0700 Sample with two sets of divs, one of which has a transform. negative_margin_redraw.html text/html 1083 simon.fraser PCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMDEgVHJhbnNpdGlvbmFs Ly9FTiIKICAgImh0dHA6Ly93d3cudzMub3JnL1RSL2h0bWw0L2xvb3NlLmR0ZCI+Cgo8aHRtbCBs YW5nPSJlbiI+CjxoZWFkPgogIDxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVu dD0idGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4KICA8dGl0bGU+TmVnYXRpdmUgbWFyZ2luIHJl ZHJhdzwvdGl0bGU+CiAgPHN0eWxlIHR5cGU9InRleHQvY3NzIiBtZWRpYT0ic2NyZWVuIj4KICAg IC5jb250YWluZXIgewogICAgICBoZWlnaHQ6IDIwMHB4OwogICAgICB3aWR0aDogMjAwcHg7CiAg ICAgIG1hcmdpbjogMTBweDsKICAgICAgYmFja2dyb3VuZC1jb2xvcjogZ3JheTsKICAgIH0KICAg IC5ib3ggewogICAgICBwb3NpdGlvbjogYWJzb2x1dGU7CiAgICAgIGxlZnQ6IDEwMHB4OwogICAg ICB0b3A6IDEwMHB4OwogICAgICBoZWlnaHQ6IDIwcHg7CiAgICAgIHdpZHRoOiAyMHB4OwogICAg ICBvdXRsaW5lOiAxcHggc29saWQgcmVkOwogICAgfQogICAgLm92ZXJmbG93IHsKICAgICAgaGVp Z2h0OiA2MHB4OwogICAgICB3aWR0aDogNjBweDsKICAgICAgbWFyZ2luLWxlZnQ6IC0yMHB4Owog ICAgICBtYXJnaW4tdG9wOiAtMjBweDsKICAgICAgb3V0bGluZTogMXB4IHNvbGlkIGJsdWU7CiAg ICB9CgogICAgLm92ZXJmbG93OmhvdmVyIHsKICAgICAgYmFja2dyb3VuZC1jb2xvcjogcmVkOwog ICAgfQogIDwvc3R5bGU+CjwvaGVhZD4KPGJvZHk+Cgo8aDI+Tm8gVHJhbnNmb3JtPC9oMj4KPGRp diBjbGFzcz0iY29udGFpbmVyIj4KICA8ZGl2IGNsYXNzPSJib3giPgogICAgPGRpdiBjbGFzcz0i b3ZlcmZsb3ciPgogICAgPC9kaXY+CiAgPC9kaXY+CjwvZGl2PgoKPGgyPldpdGggdHJhbnNmb3Jt IG9uIGdyYXkgYm94PC9oMj4KPGRpdiBjbGFzcz0iY29udGFpbmVyIiBzdHlsZT0iLXdlYmtpdC10 cmFuc2Zvcm06IHJvdGF0ZSgwKTsiPgogIDxkaXYgY2xhc3M9ImJveCI+CiAgICA8ZGl2IGNsYXNz PSJvdmVyZmxvdyI+CiAgICA8L2Rpdj4KICA8L2Rpdj4KPC9kaXY+Cgo8L2JvZHk+CjwvaHRtbD4K 22213 2008-07-10 14:47:43 -0700 2008-07-10 14:47:43 -0700 Testcase, but it requires visual inspection transform-positioned-ancestor.html text/html 1219 simon.fraser PCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMDEgVHJhbnNpdGlvbmFs Ly9FTiIKICAgImh0dHA6Ly93d3cudzMub3JnL1RSL2h0bWw0L2xvb3NlLmR0ZCI+Cgo8aHRtbCBs YW5nPSJlbiI+CjxoZWFkPgogIDxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVu dD0idGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4KICA8dGl0bGU+VHJhbnNmb3JtIGFuZCBwb3Np dGlvbmVkIGFuY2VzdG9yPC90aXRsZT4KICA8c3R5bGUgdHlwZT0idGV4dC9jc3MiIG1lZGlhPSJz Y3JlZW4iPgogIAogICAgI3dyYXBwZXIgewogICAgICBib3JkZXI6IDFweCBzb2xpZCBibGFjazsK ICAgICAgcG9zaXRpb246IHJlbGF0aXZlOwogICAgICB3aWR0aDogMzAwcHg7CiAgICB9CiAgICAu Y29udGFpbmVyIHsKICAgICAgaGVpZ2h0OiAyMDBweDsKICAgICAgd2lkdGg6IDIwMHB4OwogICAg ICBtYXJnaW46IDUwcHg7CiAgICAgIGJhY2tncm91bmQtY29sb3I6IGdyYXk7CiAgICAgIC13ZWJr aXQtdHJhbnNmb3JtOiByb3RhdGUoMCk7CiAgICB9CiAgICAuYm94IHsKICAgICAgcG9zaXRpb246 IGFic29sdXRlOwogICAgICBsZWZ0OiA1MHB4OwogICAgICB0b3A6IDUwcHg7CiAgICAgIGhlaWdo dDogMTAwcHg7CiAgICAgIHdpZHRoOiAxMDBweDsKICAgICAgYmFja2dyb3VuZC1jb2xvcjogcmVk OwogICAgfQogICAgCiAgICAuZ3JlZW4tYm94IHsKICAgICAgcG9zaXRpb246IGFic29sdXRlOwog ICAgICBsZWZ0OiAxMDBweDsKICAgICAgdG9wOiAxMDBweDsKICAgICAgaGVpZ2h0OiAxMDBweDsK ICAgICAgd2lkdGg6IDEwMHB4OwogICAgICBiYWNrZ3JvdW5kLWNvbG9yOiBncmVlbjsKICAgIH0K CiAgPC9zdHlsZT4KPC9oZWFkPgo8Ym9keT4KCjxwPllvdSBzaG91bGQgc2VlIGEgZ3JlZW4gYm94 IGluc2lkZSBhIGdyYXkgYm94LiBJZiB5b3Ugc2VlIHJlZCwgdGhlIHRlc3QgaGFzIGZhaWxlZC4g PGEgaHJlZj0iaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4ODg1Ij5o dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg4ODU8L2E+CjwvcD4KPGRp diBpZD0id3JhcHBlciI+CgogIDxkaXYgY2xhc3M9ImNvbnRhaW5lciI+CiAgICA8ZGl2IGNsYXNz PSJib3giPjwvZGl2PgogIDwvZGl2PgogIDxkaXYgY2xhc3M9ImdyZWVuLWJveCI+PC9kaXY+Cjwv ZGl2PgoKPC9ib2R5Pgo8L2h0bWw+Cg== 22214 2008-07-10 14:49:22 -0700 2008-07-11 10:54:07 -0700 Patch enclosingPositionedAncestor_patch.txt text/plain 1296 simon.fraser ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcCBiL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAppbmRleCA0Mzc3NTRmLi44M2NjZjFjIDEwMDY0NAot LS0gYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKKysrIGIvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCkBAIC00MjUsMTUgKzQyNSwxNSBAQCBSZW5kZXJMYXllciAq UmVuZGVyTGF5ZXI6OnN0YWNraW5nQ29udGV4dCgpIGNvbnN0CiAgICAgUmVuZGVyTGF5ZXIqIGN1 cnIgPSBwYXJlbnQoKTsKICAgICBmb3IgKCA7IGN1cnIgJiYgIWN1cnItPm1fb2JqZWN0LT5pc1Jl bmRlclZpZXcoKSAmJiAhY3Vyci0+bV9vYmplY3QtPmlzUm9vdCgpICYmCiAgICAgICAgICAgY3Vy ci0+bV9vYmplY3QtPnN0eWxlKCktPmhhc0F1dG9aSW5kZXgoKTsKLSAgICAgICAgICBjdXJyID0g Y3Vyci0+cGFyZW50KCkpIHsgfTsKKyAgICAgICAgICBjdXJyID0gY3Vyci0+cGFyZW50KCkpIHsg fQogICAgIHJldHVybiBjdXJyOwogfQogCiBSZW5kZXJMYXllciogUmVuZGVyTGF5ZXI6OmVuY2xv c2luZ1Bvc2l0aW9uZWRBbmNlc3RvcigpIGNvbnN0CiB7CiAgICAgUmVuZGVyTGF5ZXIqIGN1cnIg PSBwYXJlbnQoKTsKLSAgICBmb3IgKCA7IGN1cnIgJiYgIWN1cnItPm1fb2JqZWN0LT5pc1JlbmRl clZpZXcoKSAmJiAhY3Vyci0+bV9vYmplY3QtPmlzUG9zaXRpb25lZCgpICYmICFjdXJyLT5tX29i amVjdC0+aXNSZWxQb3NpdGlvbmVkKCk7Ci0gICAgICAgICBjdXJyID0gY3Vyci0+cGFyZW50KCkp IHsgfTsKKyAgICBmb3IgKCA7IGN1cnIgJiYgIWN1cnItPm1fb2JqZWN0LT5pc1JlbmRlclZpZXco KSAmJiAhY3Vyci0+bV9vYmplY3QtPmlzUG9zaXRpb25lZCgpICYmICFjdXJyLT5tX29iamVjdC0+ aXNSZWxQb3NpdGlvbmVkKCkgJiYgIWN1cnItPm1fb2JqZWN0LT5oYXNUcmFuc2Zvcm0oKTsKKyAg ICAgICAgIGN1cnIgPSBjdXJyLT5wYXJlbnQoKSkgeyB9CiAgICAgcmV0dXJuIGN1cnI7CiB9CiAK QEAgLTQ0MSw3ICs0NDEsNyBAQCBSZW5kZXJMYXllciogUmVuZGVyTGF5ZXI6OmVuY2xvc2luZ1Ry YW5zZm9ybWVkQW5jZXN0b3IoKSBjb25zdAogewogICAgIFJlbmRlckxheWVyKiBjdXJyID0gcGFy ZW50KCk7CiAgICAgZm9yICggOyBjdXJyICYmICFjdXJyLT5tX29iamVjdC0+aXNSZW5kZXJWaWV3 KCkgJiYgIWN1cnItPnRyYW5zZm9ybSgpOyBjdXJyID0gY3Vyci0+cGFyZW50KCkpCi0gICAgICAg IHsgfTsKKyAgICAgICAgeyB9CiAgICAgcmV0dXJuIGN1cnI7CiB9CiAK 22249 2008-07-11 10:54:07 -0700 2008-07-11 11:34:16 -0700 Patch, testcase, changelog enclosingPositionedAncestor_patch.txt text/plain 5821 simon.fraser ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5ODRiYjUyLi42MDU1YzU3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDgtMDct MTEgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgRGF2ZSBIeWF0dAorCisgICAgICAgIFRlc3QgZm9yIDxodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg4ODU+CisgICAgICAgIChyZXF1aXJlcyB2aXN1YWwg aW5zcGVjdGlvbiBvciBwaXhlbCB0ZXN0KS4KKyAgICAgICAgCisgICAgICAgICogZmFzdC90cmFu c2Zvcm1zL3RyYW5zZm9ybS1wb3NpdGlvbmVkLWFuY2VzdG9yLmh0bWw6IEFkZGVkLgorICAgICAg ICAqIHBsYXRmb3JtL21hYy9mYXN0L3RyYW5zZm9ybXMvdHJhbnNmb3JtLXBvc2l0aW9uZWQtYW5j ZXN0b3ItZXhwZWN0ZWQudHh0OiBBZGRlZC4KKwogMjAwOC0wNy0xMCAgU2ltb24gRnJhc2VyICA8 c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXZlIEh5YXR0 CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L3RyYW5zZm9ybXMvdHJhbnNmb3JtLXBvc2l0 aW9uZWQtYW5jZXN0b3IuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvdHJhbnNmb3Jtcy90cmFuc2Zv cm0tcG9zaXRpb25lZC1hbmNlc3Rvci5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAw MDAwMDAuLmQ2YThhYzgKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L3RyYW5z Zm9ybXMvdHJhbnNmb3JtLXBvc2l0aW9uZWQtYW5jZXN0b3IuaHRtbApAQCAtMCwwICsxLDU1IEBA Cis8IURPQ1RZUEUgaHRtbCBQVUJMSUMgIi0vL1czQy8vRFREIEhUTUwgNC4wMSBUcmFuc2l0aW9u YWwvL0VOIgorICAgImh0dHA6Ly93d3cudzMub3JnL1RSL2h0bWw0L2xvb3NlLmR0ZCI+CisKKzxo dG1sIGxhbmc9ImVuIj4KKzxoZWFkPgorICA8bWV0YSBodHRwLWVxdWl2PSJDb250ZW50LVR5cGUi IGNvbnRlbnQ9InRleHQvaHRtbDsgY2hhcnNldD11dGYtOCI+CisgIDx0aXRsZT5UcmFuc2Zvcm0g YW5kIHBvc2l0aW9uZWQgYW5jZXN0b3I8L3RpdGxlPgorICA8c3R5bGUgdHlwZT0idGV4dC9jc3Mi IG1lZGlhPSJzY3JlZW4iPgorICAKKyAgICAjd3JhcHBlciB7CisgICAgICBib3JkZXI6IDFweCBz b2xpZCBibGFjazsKKyAgICAgIHBvc2l0aW9uOiByZWxhdGl2ZTsKKyAgICAgIHdpZHRoOiAzMDBw eDsKKyAgICB9CisgICAgLmNvbnRhaW5lciB7CisgICAgICBoZWlnaHQ6IDIwMHB4OworICAgICAg d2lkdGg6IDIwMHB4OworICAgICAgbWFyZ2luOiA1MHB4OworICAgICAgYmFja2dyb3VuZC1jb2xv cjogZ3JheTsKKyAgICAgIC13ZWJraXQtdHJhbnNmb3JtOiByb3RhdGUoMCk7CisgICAgfQorICAg IC5ib3ggeworICAgICAgcG9zaXRpb246IGFic29sdXRlOworICAgICAgbGVmdDogNTBweDsKKyAg ICAgIHRvcDogNTBweDsKKyAgICAgIGhlaWdodDogMTAwcHg7CisgICAgICB3aWR0aDogMTAwcHg7 CisgICAgICBiYWNrZ3JvdW5kLWNvbG9yOiByZWQ7CisgICAgfQorICAgIAorICAgIC5ncmVlbi1i b3ggeworICAgICAgcG9zaXRpb246IGFic29sdXRlOworICAgICAgbGVmdDogMTAwcHg7CisgICAg ICB0b3A6IDEwMHB4OworICAgICAgaGVpZ2h0OiAxMDBweDsKKyAgICAgIHdpZHRoOiAxMDBweDsK KyAgICAgIGJhY2tncm91bmQtY29sb3I6IGdyZWVuOworICAgIH0KKworICA8L3N0eWxlPgorPC9o ZWFkPgorPGJvZHk+CisKKzxwPllvdSBzaG91bGQgc2VlIGEgZ3JlZW4gYm94IGluc2lkZSBhIGdy YXkgYm94LiBJZiB5b3Ugc2VlIHJlZCwgdGhlIHRlc3QgaGFzIGZhaWxlZC4gPGEgaHJlZj0iaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4ODg1Ij5odHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg4ODU8L2E+Cis8L3A+Cis8ZGl2IGlkPSJ3cmFw cGVyIj4KKworICA8ZGl2IGNsYXNzPSJjb250YWluZXIiPgorICAgIDxkaXYgY2xhc3M9ImJveCI+ PC9kaXY+CisgIDwvZGl2PgorICA8ZGl2IGNsYXNzPSJncmVlbi1ib3giPjwvZGl2PgorPC9kaXY+ CisKKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21h Yy9mYXN0L3RyYW5zZm9ybXMvdHJhbnNmb3JtLXBvc2l0aW9uZWQtYW5jZXN0b3ItZXhwZWN0ZWQu dHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Zhc3QvdHJhbnNmb3Jtcy90cmFuc2Zvcm0t cG9zaXRpb25lZC1hbmNlc3Rvci1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMC4uZmU4MjZjZAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3BsYXRm b3JtL21hYy9mYXN0L3RyYW5zZm9ybXMvdHJhbnNmb3JtLXBvc2l0aW9uZWQtYW5jZXN0b3ItZXhw ZWN0ZWQudHh0CkBAIC0wLDAgKzEsMjEgQEAKK2xheWVyIGF0ICgwLDApIHNpemUgODAweDYwMAor ICBSZW5kZXJWaWV3IGF0ICgwLDApIHNpemUgODAweDYwMAorbGF5ZXIgYXQgKDAsMCkgc2l6ZSA4 MDB4Mzc4CisgIFJlbmRlckJsb2NrIHtIVE1MfSBhdCAoMCwwKSBzaXplIDgwMHgzNzgKKyAgICBS ZW5kZXJCb2R5IHtCT0RZfSBhdCAoOCwxNikgc2l6ZSA3ODR4MzU0CisgICAgICBSZW5kZXJCbG9j ayB7UH0gYXQgKDAsMCkgc2l6ZSA3ODR4MzYKKyAgICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0 ICgwLDApIHNpemUgNTA2eDE4CisgICAgICAgICAgdGV4dCBydW4gYXQgKDAsMCkgd2lkdGggNTA2 OiAiWW91IHNob3VsZCBzZWUgYSBncmVlbiBib3ggaW5zaWRlIGEgZ3JheSBib3guIElmIHlvdSBz ZWUgcmVkLCB0aGUgdGVzdCBoYXMgZmFpbGVkLiAiCisgICAgICAgIFJlbmRlcklubGluZSB7QX0g YXQgKDAsMCkgc2l6ZSA3NTB4MzYgW2NvbG9yPSMwMDAwRUVdCisgICAgICAgICAgUmVuZGVyVGV4 dCB7I3RleHR9IGF0ICg1MDYsMCkgc2l6ZSA3NTB4MzYKKyAgICAgICAgICAgIHRleHQgcnVuIGF0 ICg1MDYsMCkgd2lkdGggMjQ0OiAiaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp PyIKKyAgICAgICAgICAgIHRleHQgcnVuIGF0ICgwLDE4KSB3aWR0aCA2MTogImlkPTE4ODg1Igor ICAgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDAsMCkgc2l6ZSAweDAKK2xheWVyIGF0ICg4 LDY4KSBzaXplIDMwMngzMDIKKyAgUmVuZGVyQmxvY2sgKHJlbGF0aXZlIHBvc2l0aW9uZWQpIHtE SVZ9IGF0ICgwLDUyKSBzaXplIDMwMngzMDIgW2JvcmRlcjogKDFweCBzb2xpZCAjMDAwMDAwKV0K K2xheWVyIGF0ICg1OSwxMTkpIHNpemUgMjAweDIwMAorICBSZW5kZXJCbG9jayB7RElWfSBhdCAo NTEsNTEpIHNpemUgMjAweDIwMCBbYmdjb2xvcj0jODA4MDgwXQorbGF5ZXIgYXQgKDEwOSwxNjkp IHNpemUgMTAweDEwMAorICBSZW5kZXJCbG9jayAocG9zaXRpb25lZCkge0RJVn0gYXQgKDUwLDUw KSBzaXplIDEwMHgxMDAgW2JnY29sb3I9I0ZGMDAwMF0KK2xheWVyIGF0ICgxMDksMTY5KSBzaXpl IDEwMHgxMDAKKyAgUmVuZGVyQmxvY2sgKHBvc2l0aW9uZWQpIHtESVZ9IGF0ICgxMDEsMTAxKSBz aXplIDEwMHgxMDAgW2JnY29sb3I9IzAwODAwMF0KZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdl TG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTI0MjA2Ny4uYjNkOTAwMyAxMDA2NDQKLS0t IGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx OSBAQAorMjAwOC0wNy0xMSAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBEYXZlIEh5YXR0CisKKyAgICAgICAgQnVnIDE4ODg1OiBS ZW5kZXJMYXllcjo6ZW5jbG9zaW5nUG9zaXRpb25lZEFuY2VzdG9yKCkgc2hvdWxkCisgICAgICAg IGxvb2sgZm9yIHRyYW5zZm9ybXMsIHNpbmNlIHRyYW5zZm9ybXMgY3JlYXRlIGNvbnRhaW5pbmcK KyAgICAgICAgYmxvY2tzLgorICAgICAgICA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE4ODg1PgorICAgICAgICAKKyAgICAgICAgVGVzdDogZmFzdC90cmFuc2Zvcm1z L3RyYW5zZm9ybS1wb3NpdGlvbmVkLWFuY2VzdG9yLmh0bWwKKworICAgICAgICAqIHJlbmRlcmlu Zy9SZW5kZXJMYXllci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllcjo6c3RhY2tp bmdDb250ZXh0KToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyOjplbmNsb3NpbmdQb3Np dGlvbmVkQW5jZXN0b3IpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXI6OmVuY2xvc2lu Z1RyYW5zZm9ybWVkQW5jZXN0b3IpOgorCiAyMDA4LTA3LTEwICBTaW1vbiBGcmFzZXIgIDxzaW1v bi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFdoZW4gYSBtYXNrIGltYWdlIGNoYW5nZXMs IGVuc3VyZSB0aGF0IGVsZW1lbnRzCmRpZmYgLS1naXQgYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJMYXllci5jcHAgYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKaW5kZXggNDM3 NzU0Zi4uODNjY2YxYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIu Y3BwCisrKyBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcApAQCAtNDI1LDE1ICs0 MjUsMTUgQEAgUmVuZGVyTGF5ZXIgKlJlbmRlckxheWVyOjpzdGFja2luZ0NvbnRleHQoKSBjb25z dAogICAgIFJlbmRlckxheWVyKiBjdXJyID0gcGFyZW50KCk7CiAgICAgZm9yICggOyBjdXJyICYm ICFjdXJyLT5tX29iamVjdC0+aXNSZW5kZXJWaWV3KCkgJiYgIWN1cnItPm1fb2JqZWN0LT5pc1Jv b3QoKSAmJgogICAgICAgICAgIGN1cnItPm1fb2JqZWN0LT5zdHlsZSgpLT5oYXNBdXRvWkluZGV4 KCk7Ci0gICAgICAgICAgY3VyciA9IGN1cnItPnBhcmVudCgpKSB7IH07CisgICAgICAgICAgY3Vy ciA9IGN1cnItPnBhcmVudCgpKSB7IH0KICAgICByZXR1cm4gY3VycjsKIH0KIAogUmVuZGVyTGF5 ZXIqIFJlbmRlckxheWVyOjplbmNsb3NpbmdQb3NpdGlvbmVkQW5jZXN0b3IoKSBjb25zdAogewog ICAgIFJlbmRlckxheWVyKiBjdXJyID0gcGFyZW50KCk7Ci0gICAgZm9yICggOyBjdXJyICYmICFj dXJyLT5tX29iamVjdC0+aXNSZW5kZXJWaWV3KCkgJiYgIWN1cnItPm1fb2JqZWN0LT5pc1Bvc2l0 aW9uZWQoKSAmJiAhY3Vyci0+bV9vYmplY3QtPmlzUmVsUG9zaXRpb25lZCgpOwotICAgICAgICAg Y3VyciA9IGN1cnItPnBhcmVudCgpKSB7IH07CisgICAgZm9yICggOyBjdXJyICYmICFjdXJyLT5t X29iamVjdC0+aXNSZW5kZXJWaWV3KCkgJiYgIWN1cnItPm1fb2JqZWN0LT5pc1Bvc2l0aW9uZWQo KSAmJiAhY3Vyci0+bV9vYmplY3QtPmlzUmVsUG9zaXRpb25lZCgpICYmICFjdXJyLT5tX29iamVj dC0+aGFzVHJhbnNmb3JtKCk7CisgICAgICAgICBjdXJyID0gY3Vyci0+cGFyZW50KCkpIHsgfQog ICAgIHJldHVybiBjdXJyOwogfQogCkBAIC00NDEsNyArNDQxLDcgQEAgUmVuZGVyTGF5ZXIqIFJl bmRlckxheWVyOjplbmNsb3NpbmdUcmFuc2Zvcm1lZEFuY2VzdG9yKCkgY29uc3QKIHsKICAgICBS ZW5kZXJMYXllciogY3VyciA9IHBhcmVudCgpOwogICAgIGZvciAoIDsgY3VyciAmJiAhY3Vyci0+ bV9vYmplY3QtPmlzUmVuZGVyVmlldygpICYmICFjdXJyLT50cmFuc2Zvcm0oKTsgY3VyciA9IGN1 cnItPnBhcmVudCgpKQotICAgICAgICB7IH07CisgICAgICAgIHsgfQogICAgIHJldHVybiBjdXJy OwogfQogCg==