188834 2018-08-22 03:36:39 -0700 AudioNode.connect does not return destination node 2018-10-02 18:38:54 -0700 1 1 1 Unclassified WebKit Web Audio Safari 11 All iOS 11 RESOLVED FIXED InRadar P2 Minor --- 1 j4kub.fiala webkit-unassigned commit-queue darin eric.carlson jer.noble webkit-bug-importer wjahenderson oldest_to_newest 1452567 0 j4kub.fiala 2018-08-22 03:36:39 -0700 According to the Web Audio spec https://webaudio.github.io/web-audio-api/#dom-audionode-connect AudioNode.connect "returns destination AudioNode object". This does not seem to be the case in both iOS Safari 11 and desktop Safari 11, where AudioNode.connect returns `undefined`. It's problematic for code which uses chaining of .connect methods. Steps to reproduce: > const ac = new webkitAudioContext() < undefined > g1 = ac.createGain() < GainNode {gain: AudioParam, context: webkitAudioContext, numberOfInputs: 1, numberOfOutputs: 1, channelCount: 2, …} > g2 = ac.createGain() < GainNode {gain: AudioParam, context: webkitAudioContext, numberOfInputs: 1, numberOfOutputs: 1, channelCount: 2, …} > g3 = ac.createGain() < GainNode {gain: AudioParam, context: webkitAudioContext, numberOfInputs: 1, numberOfOutputs: 1, channelCount: 2, …} > g1.connect(g2).connect(g3) < TypeError: undefined is not an object (evaluating 'g1.connect(g2).connect') 1452693 1 webkit-bug-importer 2018-08-22 10:12:57 -0700 <rdar://problem/43609703> 1464797 2 wjahenderson 2018-09-29 14:11:10 -0700 I started work on a patch for this. 1464803 3 351198 wjahenderson 2018-09-29 14:29:41 -0700 Created attachment 351198 Patch 1464852 4 351198 eric.carlson 2018-09-30 03:03:12 -0700 Comment on attachment 351198 Patch Thank you! 1464878 5 351198 commit-queue 2018-09-30 15:07:52 -0700 Comment on attachment 351198 Patch Clearing flags on attachment: 351198 Committed r236648: <https://trac.webkit.org/changeset/236648> 1464879 6 commit-queue 2018-09-30 15:07:53 -0700 All reviewed patches have been landed. Closing bug. 1464890 7 351198 darin 2018-09-30 19:37:24 -0700 Comment on attachment 351198 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351198&action=review > Source/WebCore/Modules/webaudio/AudioNode.idl:37 > - [MayThrowException] void connect(AudioNode destination, optional unsigned long output = 0, optional unsigned long input = 0); > + [MayThrowException] AudioNode connect(AudioNode destination, optional unsigned long output = 0, optional unsigned long input = 0); I believe there is a slightly more efficient way to do this by using the [ReturnValue] attribute on the destination object, so the JavaScript binding will reuse the passed-in wrapper rather than having to look it up. 1465149 8 351198 wjahenderson 2018-10-01 11:43:51 -0700 Comment on attachment 351198 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351198&action=review >> Source/WebCore/Modules/webaudio/AudioNode.idl:37 >> + [MayThrowException] AudioNode connect(AudioNode destination, optional unsigned long output = 0, optional unsigned long input = 0); > > I believe there is a slightly more efficient way to do this by using the [ReturnValue] attribute on the destination object, so the JavaScript binding will reuse the passed-in wrapper rather than having to look it up. Gotcha, should I put together a new patch for that? If so, should the patch be attached to a new bug? 1465491 9 eric.carlson 2018-10-02 03:54:41 -0700 (In reply to Walker Henderson from comment #8) > Comment on attachment 351198 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=351198&action=review > > >> Source/WebCore/Modules/webaudio/AudioNode.idl:37 > >> + [MayThrowException] AudioNode connect(AudioNode destination, optional unsigned long output = 0, optional unsigned long input = 0); > > > > I believe there is a slightly more efficient way to do this by using the [ReturnValue] attribute on the destination object, so the JavaScript binding will reuse the passed-in wrapper rather than having to look it up. > > Gotcha, should I put together a new patch for that? If so, should the patch > be attached to a new bug? Why don't you file a new bug and reference this. 1465864 10 darin 2018-10-02 18:38:54 -0700 I threw together a patch for this already. Filed bug 190231. 351198 2018-09-29 14:29:41 -0700 2018-09-30 15:07:52 -0700 Patch bug-188834-20180929142940.patch text/plain 6828 wjahenderson U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2NjQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWJjN2M4ODY2MmRlZTVm YjliMzY1NjMyODIxODhkMDMzZjJmYWJlNy4uM2ExMGMwOWZkNTRlNDQwMGYwM2NkNDUwOTQwNTNj MTNiYzkyMWQ2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4LTA5LTI5ICBXYWxr ZXIgSGVuZGVyc29uICA8d2phaGVuZGVyc29uQGdtYWlsLmNvbT4KKworICAgICAgICBBdWRpb05v ZGUuY29ubmVjdCBzaG91bGQgcmV0dXJuIHBhc3NlZCBkZXN0aW5hdGlvbiBub2RlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODg4MzQKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIHJl YmFzZWxpbmVkIGV4aXN0aW5nIHRlc3QuCisKKyAgICAgICAgKiBNb2R1bGVzL3dlYmF1ZGlvL0F1 ZGlvQmFzaWNJbnNwZWN0b3JOb2RlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkF1ZGlvQmFzaWNJ bnNwZWN0b3JOb2RlOjpjb25uZWN0KTogRGVsZXRlZC4KKyAgICAgICAgKiBNb2R1bGVzL3dlYmF1 ZGlvL0F1ZGlvQmFzaWNJbnNwZWN0b3JOb2RlLmg6CisgICAgICAgICogTW9kdWxlcy93ZWJhdWRp by9BdWRpb05vZGUuY3BwOgorICAgICAgICAqIE1vZHVsZXMvd2ViYXVkaW8vQXVkaW9Ob2RlLmg6 CisgICAgICAgICogTW9kdWxlcy93ZWJhdWRpby9BdWRpb05vZGUuaWRsOgorCiAyMDE4LTA5LTI5 ICBPcmlvbCBCcnVmYXUgIDxvYnJ1ZmF1QGlnYWxpYS5jb20+CiAKICAgICAgICAgW2Nzcy1ncmlk XSBQcm9wZXJseSBhbGlnbiBpdGVtcyBuZXh0IHRvIGNvbGxhcHNlZCB0cmFja3Mgd2l0aCBndXR0 ZXJzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0F1ZGlvQmFz aWNJbnNwZWN0b3JOb2RlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQXVk aW9CYXNpY0luc3BlY3Rvck5vZGUuY3BwCmluZGV4IDI3ZTU2YzRjNmI5NDdhZWI4MjQ1OWVkMTNm MzNiNTgxYTNkM2EwYTQuLjUwMzNiN2Q3ZGQ4OGQxMmE1NGVjODIwZGZkNTUwZjc5ZmY3ZDBlMTUg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQXVkaW9CYXNpY0lu c3BlY3Rvck5vZGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQXVk aW9CYXNpY0luc3BlY3Rvck5vZGUuY3BwCkBAIC00OSw3ICs0OSw3IEBAIHZvaWQgQXVkaW9CYXNp Y0luc3BlY3Rvck5vZGU6OnB1bGxJbnB1dHMoc2l6ZV90IGZyYW1lc1RvUHJvY2VzcykKICAgICBp bnB1dCgwKS0+cHVsbChvdXRwdXQoMCktPmJ1cygpLCBmcmFtZXNUb1Byb2Nlc3MpOwogfQogCi1F eGNlcHRpb25Pcjx2b2lkPiBBdWRpb0Jhc2ljSW5zcGVjdG9yTm9kZTo6Y29ubmVjdChBdWRpb05v ZGUmIGRlc3RpbmF0aW9uLCB1bnNpZ25lZCBvdXRwdXRJbmRleCwgdW5zaWduZWQgaW5wdXRJbmRl eCkKK0V4Y2VwdGlvbk9yPEF1ZGlvTm9kZSY+IEF1ZGlvQmFzaWNJbnNwZWN0b3JOb2RlOjpjb25u ZWN0KEF1ZGlvTm9kZSYgZGVzdGluYXRpb24sIHVuc2lnbmVkIG91dHB1dEluZGV4LCB1bnNpZ25l ZCBpbnB1dEluZGV4KQogewogICAgIEFTU0VSVChpc01haW5UaHJlYWQoKSk7CiAKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQXVkaW9CYXNpY0luc3BlY3Rvck5v ZGUuaCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQXVkaW9CYXNpY0luc3BlY3Rv ck5vZGUuaAppbmRleCBiODZmMWEzODdmZGRmOGMyYjU4MzQ1ODM1YjlhZDU1NWRkZWZlMTJiLi5m YWUyMzU5ZDUyODFjYzUyYmU1ODMwYmI0YjM0YjVhYTZjZDY0N2QwIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0F1ZGlvQmFzaWNJbnNwZWN0b3JOb2RlLmgKKysr IGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9BdWRpb0Jhc2ljSW5zcGVjdG9yTm9k ZS5oCkBAIC0zNyw3ICszNyw3IEBAIHB1YmxpYzoKIAogcHJpdmF0ZToKICAgICB2b2lkIHB1bGxJ bnB1dHMoc2l6ZV90IGZyYW1lc1RvUHJvY2Vzcykgb3ZlcnJpZGU7Ci0gICAgRXhjZXB0aW9uT3I8 dm9pZD4gY29ubmVjdChBdWRpb05vZGUmLCB1bnNpZ25lZCBvdXRwdXRJbmRleCwgdW5zaWduZWQg aW5wdXRJbmRleCkgb3ZlcnJpZGU7CisgICAgRXhjZXB0aW9uT3I8QXVkaW9Ob2RlJj4gY29ubmVj dChBdWRpb05vZGUmLCB1bnNpZ25lZCBvdXRwdXRJbmRleCwgdW5zaWduZWQgaW5wdXRJbmRleCkg b3ZlcnJpZGU7CiAgICAgRXhjZXB0aW9uT3I8dm9pZD4gZGlzY29ubmVjdCh1bnNpZ25lZCBvdXRw dXRJbmRleCkgb3ZlcnJpZGU7CiAgICAgdm9pZCBjaGVja051bWJlck9mQ2hhbm5lbHNGb3JJbnB1 dChBdWRpb05vZGVJbnB1dCopIG92ZXJyaWRlOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9Nb2R1bGVzL3dlYmF1ZGlvL0F1ZGlvTm9kZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz L3dlYmF1ZGlvL0F1ZGlvTm9kZS5jcHAKaW5kZXggYWQxMzUxZjQ0YWVlZjM0N2MzZWRiMGQ1ZGE1 YmUxNzExM2U3OTdmYS4uNmYzYzYzYzVlNjVmNTY3MjQ2YzIzNDk4NTMzMDU2ZDg2ZGJkMWQ3ZSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9BdWRpb05vZGUuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQXVkaW9Ob2RlLmNwcApAQCAt MTIyLDcgKzEyMiw3IEBAIEF1ZGlvTm9kZU91dHB1dCogQXVkaW9Ob2RlOjpvdXRwdXQodW5zaWdu ZWQgaSkKICAgICByZXR1cm4gbnVsbHB0cjsKIH0KIAotRXhjZXB0aW9uT3I8dm9pZD4gQXVkaW9O b2RlOjpjb25uZWN0KEF1ZGlvTm9kZSYgZGVzdGluYXRpb24sIHVuc2lnbmVkIG91dHB1dEluZGV4 LCB1bnNpZ25lZCBpbnB1dEluZGV4KQorRXhjZXB0aW9uT3I8QXVkaW9Ob2RlJj4gQXVkaW9Ob2Rl Ojpjb25uZWN0KEF1ZGlvTm9kZSYgZGVzdGluYXRpb24sIHVuc2lnbmVkIG91dHB1dEluZGV4LCB1 bnNpZ25lZCBpbnB1dEluZGV4KQogewogICAgIEFTU0VSVChpc01haW5UaHJlYWQoKSk7IAogICAg IEF1ZGlvQ29udGV4dDo6QXV0b0xvY2tlciBsb2NrZXIoY29udGV4dCgpKTsKQEAgLTE0NCw3ICsx NDQsNyBAQCBFeGNlcHRpb25Pcjx2b2lkPiBBdWRpb05vZGU6OmNvbm5lY3QoQXVkaW9Ob2RlJiBk ZXN0aW5hdGlvbiwgdW5zaWduZWQgb3V0cHV0SW5kZQogICAgIC8vIExldCBjb250ZXh0IGtub3cg dGhhdCBhIGNvbm5lY3Rpb24gaGFzIGJlZW4gbWFkZS4KICAgICBjb250ZXh0KCkuaW5jcmVtZW50 Q29ubmVjdGlvbkNvdW50KCk7CiAKLSAgICByZXR1cm4geyB9OworICAgIHJldHVybiBkZXN0aW5h dGlvbjsKIH0KIAogRXhjZXB0aW9uT3I8dm9pZD4gQXVkaW9Ob2RlOjpjb25uZWN0KEF1ZGlvUGFy YW0mIHBhcmFtLCB1bnNpZ25lZCBvdXRwdXRJbmRleCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL01vZHVsZXMvd2ViYXVkaW8vQXVkaW9Ob2RlLmggYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz L3dlYmF1ZGlvL0F1ZGlvTm9kZS5oCmluZGV4IDMwYTVmODE0NDUyYjlhMzllODY1MmY3ZjIxNGY1 MWMzMzg5OWNlMWYuLmM0Zjc4NGI0NDBhNmJiMjI5YjY0Yzk0NDU4YmE5ZTQ0NTU3MThhODggMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQXVkaW9Ob2RlLmgKKysr IGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9BdWRpb05vZGUuaApAQCAtMTIzLDcg KzEyMyw3IEBAIHB1YmxpYzoKICAgICBBdWRpb05vZGVPdXRwdXQqIG91dHB1dCh1bnNpZ25lZCk7 CiAKICAgICAvLyBDYWxsZWQgZnJvbSBtYWluIHRocmVhZCBieSBjb3JyZXNwb25kaW5nIEphdmFT Y3JpcHQgbWV0aG9kcy4KLSAgICB2aXJ0dWFsIEV4Y2VwdGlvbk9yPHZvaWQ+IGNvbm5lY3QoQXVk aW9Ob2RlJiwgdW5zaWduZWQgb3V0cHV0SW5kZXgsIHVuc2lnbmVkIGlucHV0SW5kZXgpOworICAg IHZpcnR1YWwgRXhjZXB0aW9uT3I8QXVkaW9Ob2RlJj4gY29ubmVjdChBdWRpb05vZGUmLCB1bnNp Z25lZCBvdXRwdXRJbmRleCwgdW5zaWduZWQgaW5wdXRJbmRleCk7CiAgICAgRXhjZXB0aW9uT3I8 dm9pZD4gY29ubmVjdChBdWRpb1BhcmFtJiwgdW5zaWduZWQgb3V0cHV0SW5kZXgpOwogICAgIHZp cnR1YWwgRXhjZXB0aW9uT3I8dm9pZD4gZGlzY29ubmVjdCh1bnNpZ25lZCBvdXRwdXRJbmRleCk7 CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQXVkaW9Ob2Rl LmlkbCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQXVkaW9Ob2RlLmlkbAppbmRl eCA5MTk3MGM0ZDMzY2FlNjY0ZDZlZjdiMmEzZGExN2EwMmZiNjUxYjgwLi44MDBmMDFlY2ZiN2Zl YjIzODljMzkyNjIwOTY4NmExYzgyY2NmZjA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL3dlYmF1ZGlvL0F1ZGlvTm9kZS5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxl cy93ZWJhdWRpby9BdWRpb05vZGUuaWRsCkBAIC0zNCw3ICszNCw3IEBACiAgICAgYXR0cmlidXRl IERPTVN0cmluZyBjaGFubmVsQ291bnRNb2RlOwogICAgIGF0dHJpYnV0ZSBET01TdHJpbmcgY2hh bm5lbEludGVycHJldGF0aW9uOwogCi0gICAgW01heVRocm93RXhjZXB0aW9uXSB2b2lkIGNvbm5l Y3QoQXVkaW9Ob2RlIGRlc3RpbmF0aW9uLCBvcHRpb25hbCB1bnNpZ25lZCBsb25nIG91dHB1dCA9 IDAsIG9wdGlvbmFsIHVuc2lnbmVkIGxvbmcgaW5wdXQgPSAwKTsKKyAgICBbTWF5VGhyb3dFeGNl cHRpb25dIEF1ZGlvTm9kZSBjb25uZWN0KEF1ZGlvTm9kZSBkZXN0aW5hdGlvbiwgb3B0aW9uYWwg dW5zaWduZWQgbG9uZyBvdXRwdXQgPSAwLCBvcHRpb25hbCB1bnNpZ25lZCBsb25nIGlucHV0ID0g MCk7CiAgICAgW01heVRocm93RXhjZXB0aW9uXSB2b2lkIGNvbm5lY3QoQXVkaW9QYXJhbSBkZXN0 aW5hdGlvbiwgb3B0aW9uYWwgdW5zaWduZWQgbG9uZyBvdXRwdXQgPSAwKTsKICAgICBbTWF5VGhy b3dFeGNlcHRpb25dIHZvaWQgZGlzY29ubmVjdChvcHRpb25hbCB1bnNpZ25lZCBsb25nIG91dHB1 dCA9IDApOwogfTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VM b2cgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCmluZGV4IDlmNWFiZmU5YzYy OGMxNWVlNDEzYjU2NjA5ZGI5ZTc5NDkzYzFlZjguLjQ0YmJmMDJkYThiMzdiNTU5NDVkODY1NDkw OGU3MGVlYTEwODBlODUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFu Z2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwpAQCAtMSwzICsx LDEyIEBACisyMDE4LTA5LTI5ICBXYWxrZXIgSGVuZGVyc29uICA8d2phaGVuZGVyc29uQGdtYWls LmNvbT4KKworICAgICAgICBBdWRpb05vZGUuY29ubmVjdCBzaG91bGQgcmV0dXJuIHBhc3NlZCBk ZXN0aW5hdGlvbiBub2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xODg4MzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIHdlYi1wbGF0Zm9ybS10ZXN0cy93ZWJhdWRpby90aGUtYXVkaW8tYXBpL3RoZS1h dWRpb25vZGUtaW50ZXJmYWNlL2F1ZGlvbm9kZS1jb25uZWN0LXJldHVybi12YWx1ZS1leHBlY3Rl ZC50eHQ6CisKIDIwMTgtMDktMjkgIE9yaW9sIEJydWZhdSAgPG9icnVmYXVAaWdhbGlhLmNvbT4K IAogICAgICAgICBbY3NzLWdyaWRdIFByb3Blcmx5IGFsaWduIGl0ZW1zIG5leHQgdG8gY29sbGFw c2VkIHRyYWNrcyB3aXRoIGd1dHRlcnMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVk L3czYy93ZWItcGxhdGZvcm0tdGVzdHMvd2ViYXVkaW8vdGhlLWF1ZGlvLWFwaS90aGUtYXVkaW9u b2RlLWludGVyZmFjZS9hdWRpb25vZGUtY29ubmVjdC1yZXR1cm4tdmFsdWUtZXhwZWN0ZWQudHh0 IGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy93ZWJhdWRpby90 aGUtYXVkaW8tYXBpL3RoZS1hdWRpb25vZGUtaW50ZXJmYWNlL2F1ZGlvbm9kZS1jb25uZWN0LXJl dHVybi12YWx1ZS1leHBlY3RlZC50eHQKaW5kZXggNDkzNmMyMjQzOTY5ZDI0ZDkzYjdlYmQyOTVk MjA2YzkwNTRhM2M2Zi4uMDViOTUxMWVmZjFmNmNhNTZhMjE4NDIwNGI5Mzc3YTQ0OWVmZTRkMyAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy93 ZWJhdWRpby90aGUtYXVkaW8tYXBpL3RoZS1hdWRpb25vZGUtaW50ZXJmYWNlL2F1ZGlvbm9kZS1j b25uZWN0LXJldHVybi12YWx1ZS1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0 ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy93ZWJhdWRpby90aGUtYXVkaW8tYXBpL3RoZS1hdWRp b25vZGUtaW50ZXJmYWNlL2F1ZGlvbm9kZS1jb25uZWN0LXJldHVybi12YWx1ZS1leHBlY3RlZC50 eHQKQEAgLTEsMyArMSwzIEBACiAKLUZBSUwgY29ubmVjdCBzaG91bGQgcmV0dXJuIHRoZSBub2Rl IGNvbm5lY3RlZCB0by4gYXNzZXJ0X2VxdWFsczogZXhwZWN0ZWQgKG9iamVjdCkgb2JqZWN0ICJb b2JqZWN0IEdhaW5Ob2RlXSIgYnV0IGdvdCAodW5kZWZpbmVkKSB1bmRlZmluZWQKK1BBU1MgY29u bmVjdCBzaG91bGQgcmV0dXJuIHRoZSBub2RlIGNvbm5lY3RlZCB0by4gCiAK