188830 2018-08-21 17:08:53 -0700 The Storage Access API prompt should show the eTLD+1s, not the full host names 2018-08-22 15:54:43 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=188783 InRadar P2 Normal --- 1 wilander wilander bfulgham commit-queue webkit-bug-importer oldest_to_newest 1452430 0 wilander 2018-08-21 17:08:53 -0700 WebKit::WebPageProxy::requestStorageAccess()'s handling of the StorageAccessStatus::RequiresUserPrompt case should pass on the eTLD+1 for the top and sub frames, not their full host names. 1452431 1 wilander 2018-08-21 17:09:04 -0700 <rdar://problem/43380645> 1452434 2 347738 wilander 2018-08-21 17:12:37 -0700 Created attachment 347738 Patch 1452841 3 347738 bfulgham 2018-08-22 15:38:08 -0700 Comment on attachment 347738 Patch r=me. 1452842 4 347738 wilander 2018-08-22 15:38:45 -0700 Comment on attachment 347738 Patch Thanks, Brent! 1452867 5 347738 commit-queue 2018-08-22 15:54:41 -0700 Comment on attachment 347738 Patch Clearing flags on attachment: 347738 Committed r235209: <https://trac.webkit.org/changeset/235209> 1452868 6 commit-queue 2018-08-22 15:54:43 -0700 All reviewed patches have been landed. Closing bug. 347738 2018-08-21 17:12:37 -0700 2018-08-22 15:54:41 -0700 Patch bug-188830-20180821171236.patch text/plain 2548 wilander U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1MTQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDg5N2RkMDU3NWIyODY0YTNj YzFjMjQ3MjcxM2E1OTAzODliOGViOWYuLjBkZWQyODNlYjJkOTJmN2UzZTFmZjAzN2QyMTg2MDhl OTlkMjFiMWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTgtMDgtMjEgIEpvaG4gV2ls YW5kZXIgIDx3aWxhbmRlckBhcHBsZS5jb20+CisKKyAgICAgICAgVGhlIFN0b3JhZ2UgQWNjZXNz IEFQSSBwcm9tcHQgc2hvdWxkIHNob3cgdGhlIGVUTEQrMXMsIG5vdCB0aGUgZnVsbCBob3N0IG5h bWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODg4 MzAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQzMzgwNjQ1PgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5j cHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6cmVxdWVzdFN0b3JhZ2VBY2Nlc3Mp OgorCiAyMDE4LTA4LTIxICBKb2huIFdpbGFuZGVyICA8d2lsYW5kZXJAYXBwbGUuY29tPgogCiAg ICAgICAgIFN0b3JhZ2UgQWNjZXNzIEFQSTogVGhlIGNhbGwgdG8gUmVzb3VyY2VMb2FkU3RhdGlz dGljc01lbW9yeVN0b3JlOjpncmFudFN0b3JhZ2VBY2Nlc3NJbnRlcm5hbCgpIHNob3VsZCBzZW5k IGVUTEQrMXMsIG5vdCBmdWxsIGhvc3QgbmFtZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQ YWdlUHJveHkuY3BwCmluZGV4IDVhOTUzMWIwNGJiNzQ3MjU3MmZmYWE0OGRmNzYwMjczZjg4NDFh YzMuLmMwMGQ1MTQxYjcxODExZjJkZTcxMjcwMjkxMDU4NDM2YzQ5Y2VmYWUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKKysrIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcApAQCAtMTQzLDYgKzE0Myw3IEBACiAjaW5j bHVkZSA8V2ViQ29yZS9QZXJmb3JtYW5jZUxvZ2dpbmdDbGllbnQuaD4KICNpbmNsdWRlIDxXZWJD b3JlL1B1YmxpY1N1ZmZpeC5oPgogI2luY2x1ZGUgPFdlYkNvcmUvUmVuZGVyRW1iZWRkZWRPYmpl Y3QuaD4KKyNpbmNsdWRlIDxXZWJDb3JlL1Jlc291cmNlTG9hZFN0YXRpc3RpY3MuaD4KICNpbmNs dWRlIDxXZWJDb3JlL1NTTEtleUdlbmVyYXRvci5oPgogI2luY2x1ZGUgPFdlYkNvcmUvU2VyaWFs aXplZENyeXB0b0tleVdyYXAuaD4KICNpbmNsdWRlIDxXZWJDb3JlL1NoYXJlZEJ1ZmZlci5oPgpA QCAtNzY5Nyw3ICs3Njk4LDcgQEAgdm9pZCBXZWJQYWdlUHJveHk6OnJlcXVlc3RTdG9yYWdlQWNj ZXNzKFN0cmluZyYmIHN1YkZyYW1lSG9zdCwgU3RyaW5nJiYgdG9wRnJhbWUKICAgICAgICAgICAg IHJldHVybjsKICAgICAgICAgY2FzZSBTdG9yYWdlQWNjZXNzU3RhdHVzOjpSZXF1aXJlc1VzZXJQ cm9tcHQ6CiAgICAgICAgICAgICBBU1NFUlRfVU5VU0VEKHByb21wdEVuYWJsZWQsIHByb21wdEVu YWJsZWQpOwotICAgICAgICAgICAgbV91aUNsaWVudC0+cmVxdWVzdFN0b3JhZ2VBY2Nlc3NDb25m aXJtKCp0aGlzLCBtX3Byb2Nlc3MtPndlYkZyYW1lKGZyYW1lSUQpLCBTdHJpbmcoc3ViRnJhbWVI b3N0KSwgU3RyaW5nKHRvcEZyYW1lSG9zdCksIFt0aGlzLCBwcm90ZWN0ZWRUaGlzID0gbWFrZVJl ZigqdGhpcyksIHN1YkZyYW1lSG9zdCwgdG9wRnJhbWVIb3N0LCBmcmFtZUlELCBjb21wbGV0aW9u SGFuZGxlciA9IFdURk1vdmUoY29tcGxldGlvbkhhbmRsZXIpXSAoYm9vbCB1c2VyRGlkR3JhbnRB Y2Nlc3MpIG11dGFibGUgeworICAgICAgICAgICAgbV91aUNsaWVudC0+cmVxdWVzdFN0b3JhZ2VB Y2Nlc3NDb25maXJtKCp0aGlzLCBtX3Byb2Nlc3MtPndlYkZyYW1lKGZyYW1lSUQpLCBSZXNvdXJj ZUxvYWRTdGF0aXN0aWNzOjpwcmltYXJ5RG9tYWluKHN1YkZyYW1lSG9zdCksIFJlc291cmNlTG9h ZFN0YXRpc3RpY3M6OnByaW1hcnlEb21haW4odG9wRnJhbWVIb3N0KSwgW3RoaXMsIHByb3RlY3Rl ZFRoaXMgPSBtYWtlUmVmKCp0aGlzKSwgc3ViRnJhbWVIb3N0LCB0b3BGcmFtZUhvc3QsIGZyYW1l SUQsIGNvbXBsZXRpb25IYW5kbGVyID0gV1RGTW92ZShjb21wbGV0aW9uSGFuZGxlcildIChib29s IHVzZXJEaWRHcmFudEFjY2VzcykgbXV0YWJsZSB7CiAgICAgICAgICAgICAgICAgaWYgKHVzZXJE aWRHcmFudEFjY2VzcykKICAgICAgICAgICAgICAgICAgICAgbV93ZWJzaXRlRGF0YVN0b3JlLT5n cmFudFN0b3JhZ2VBY2Nlc3MoV1RGTW92ZShzdWJGcmFtZUhvc3QpLCBXVEZNb3ZlKHRvcEZyYW1l SG9zdCksIGZyYW1lSUQsIG1fcGFnZUlELCB1c2VyRGlkR3JhbnRBY2Nlc3MsIFdURk1vdmUoY29t cGxldGlvbkhhbmRsZXIpKTsKICAgICAgICAgICAgICAgICBlbHNlCg==