18882 2008-05-04 03:55:10 -0700 nspluginwrapper causes segfault in WebKit 2008-05-20 04:36:47 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 chris marc.ordinasillopis marc.ordinasillopis markybob oldest_to_newest 79610 0 chris 2008-05-04 03:55:10 -0700 nspluginwrapper causes webkit to segfault when it calls NPN_GetURLNotify with a NULL instance. Attached backtrace and patch that fixes it. It seems that plugins expect to be able to call NPN functions with a NULL instance after the browser has called into an NPP function - Should all m_plugin->pluginFuncs()->*() be wrapped in a setCurrentPluginView(this/0) block? 79611 1 20957 chris 2008-05-04 03:55:47 -0700 Created attachment 20957 Backtrace 79612 2 20958 chris 2008-05-04 03:56:53 -0700 Created attachment 20958 Patch that fixes the problem 79805 3 marc.ordinasillopis 2008-05-07 02:31:54 -0700 (In reply to comment #2) > Created an attachment (id=20958) [edit] > Patch that fixes the problem > I've made a patch for bug #18892 (attachment #20998) that includes your fix, could you test it with nspluginwrapper? Thanks! 79847 4 markybob 2008-05-07 15:47:40 -0700 works perfectly here, thanks. hope it gets committed soon 80887 5 marc.ordinasillopis 2008-05-19 03:15:46 -0700 Patch landed in r33570. 80971 6 marc.ordinasillopis 2008-05-20 04:36:47 -0700 Chris Lord's patch that fixes this was included in my patch for bug #18892 and landed in r33750, so I'm closing this one. Thanks, Chris! 20957 2008-05-04 03:55:47 -0700 2008-05-04 03:55:47 -0700 Backtrace nspluginwrapper-crash-backtrace.txt text/plain 3043 chris KGdkYikgYnQNCiMwICBXZWJDb3JlOjpLVVJMOjppbml0ICh0aGlzPTB4N2ZmZmZiZjZhYmYwLCBi YXNlPUAweDcwLCANCiAgICByZWxhdGl2ZT1AMHg3ZmZmZmJmNmFhYTAsIGVuY29kaW5nPUAweDdm YmZmM2Q0YWUxOCkNCiAgICBhdCBXZWJDb3JlL3BsYXRmb3JtL0tVUkwuY3BwOjMyOQ0KIzEgIDB4 MDAwMDdmYmZmMmM0MjgwOSBpbiBLVVJMICh0aGlzPTB4N2ZmZmZiZjZhYmYwLCBiYXNlPUAweDcw LCANCiAgICByZWxhdGl2ZT1AMHg3ZmZmZmJmNmFhYTApIGF0IFdlYkNvcmUvcGxhdGZvcm0vS1VS TC5jcHA6MzE3DQojMiAgMHgwMDAwN2ZiZmYyYzkyYzFmIGluIG1ha2VVUkwgKGJhc2VVUkw9QDB4 NzAsIA0KICAgIHJlbGF0aXZlVVJMU3RyaW5nPTx2YWx1ZSBvcHRpbWl6ZWQgb3V0PikNCiAgICBh dCBXZWJDb3JlL3BsdWdpbnMvUGx1Z2luVmlldy5jcHA6MzMyDQojMyAgMHgwMDAwN2ZiZmYyYzk1 OTBlIGluIFdlYkNvcmU6OlBsdWdpblZpZXc6OmdldFVSTE5vdGlmeSAodGhpcz0weDAsIA0KICAg IHVybD0weGMwOTUxMCAiamF2YXNjcmlwdDp0b3AubG9jYXRpb24rXCJfX2ZsYXNocGx1Z2luX3Vu aXF1ZV9fXCIiLCANCiAgICB0YXJnZXQ9MHgwLCBub3RpZnlEYXRhPTB4MSkgYXQgV2ViQ29yZS9w bHVnaW5zL1BsdWdpblZpZXcuY3BwOjM0MQ0KIzQgIDB4MDAwMDdmYmZmMmM5YmE3MiBpbiBOUE5f R2V0VVJMTm90aWZ5IChpbnN0YW5jZT08dmFsdWUgb3B0aW1pemVkIG91dD4sIA0KICAgIHVybD0w eGMwOTUxMCAiamF2YXNjcmlwdDp0b3AubG9jYXRpb24rXCJfX2ZsYXNocGx1Z2luX3VuaXF1ZV9f XCIiLCANCiAgICB0YXJnZXQ9MHgwLCBub3RpZnlEYXRhPTB4MSkgYXQgV2ViQ29yZS9wbHVnaW5z L25wYXBpLmNwcDo3Mw0KIzUgIDB4MDAwMDdmYmZlNTQwYTA5MiBpbiA/PyAoKQ0KICAgZnJvbSAv dXNyL2xpYi9tb3ppbGxhL3BsdWdpbnMvZmxhc2hwbHVnaW4tYWx0ZXJuYXRpdmUuc28NCiM2ICAw eDAwMDA3ZmJmZTU0MGYzZGIgaW4gPz8gKCkNCiAgIGZyb20gL3Vzci9saWIvbW96aWxsYS9wbHVn aW5zL2ZsYXNocGx1Z2luLWFsdGVybmF0aXZlLnNvDQojNyAgMHgwMDAwN2ZiZmU1NDBmODdiIGlu ID8/ICgpDQogICBmcm9tIC91c3IvbGliL21vemlsbGEvcGx1Z2lucy9mbGFzaHBsdWdpbi1hbHRl cm5hdGl2ZS5zbw0KIzggIDB4MDAwMDdmYmZlNTQwYjY5MSBpbiA/PyAoKQ0KICAgZnJvbSAvdXNy L2xpYi9tb3ppbGxhL3BsdWdpbnMvZmxhc2hwbHVnaW4tYWx0ZXJuYXRpdmUuc28NCiM5ICAweDAw MDA3ZmJmZjJjOGQzMDggaW4gV2ViQ29yZTo6UGx1Z2luU3RyZWFtOjpzdGFydFN0cmVhbSAodGhp cz0weGJmNTg3MCkNCi0tLVR5cGUgPHJldHVybj4gdG8gY29udGludWUsIG9yIHEgPHJldHVybj4g dG8gcXVpdC0tLQ0KICAgIGF0IFdlYkNvcmUvcGx1Z2lucy9QbHVnaW5TdHJlYW0uY3BwOjE4Mw0K IzEwIDB4MDAwMDdmYmZmMmI2ZGU2NCBpbiBXZWJDb3JlOjpOZXRzY2FwZVBsdWdJblN0cmVhbUxv YWRlcjo6ZGlkUmVjZWl2ZVJlc3BvbnNlICh0aGlzPTB4YzBkNDgwLCByZXNwb25zZT1AMHhjMGRk ZDApDQogICAgYXQgV2ViQ29yZS9sb2FkZXIvTmV0c2NhcGVQbHVnSW5TdHJlYW1Mb2FkZXIuY3Bw OjY3DQojMTEgMHgwMDAwN2ZiZmYyZGFlODc4IGluIGdvdEhlYWRlcnNDYWxsYmFjayAobXNnPTB4 YjY5MGMwLCBkYXRhPTB4ZDUyYjkwKQ0KICAgIGF0IFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9z b3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHA6MTI1DQojMTIgMHgwMDAwN2ZiZmVlOTcyYmNmIGlu IGdfY2xvc3VyZV9pbnZva2UgKCkgZnJvbSAvdXNyL2xpYi9saWJnb2JqZWN0LTIuMC5zby4wDQoj MTMgMHgwMDAwN2ZiZmVlOTg2NmJjIGluID8/ICgpIGZyb20gL3Vzci9saWIvbGliZ29iamVjdC0y LjAuc28uMA0KIzE0IDB4MDAwMDdmYmZlZTk4ODBkNSBpbiBnX3NpZ25hbF9lbWl0X3ZhbGlzdCAo KQ0KICAgZnJvbSAvdXNyL2xpYi9saWJnb2JqZWN0LTIuMC5zby4wDQojMTUgMHgwMDAwN2ZiZmVl OTg4NDgzIGluIGdfc2lnbmFsX2VtaXQgKCkgZnJvbSAvdXNyL2xpYi9saWJnb2JqZWN0LTIuMC5z by4wDQojMTYgMHgwMDAwN2ZiZmVkNzczNjZjIGluIGlvX3JlYWQgKHNvY2s9MHhhYzIxZjAsIG1z Zz0weGI2OTBjMCkNCiAgICBhdCBzb3VwLW1lc3NhZ2UtaW8uYzo3NDANCiMxNyAweDAwMDA3ZmJm ZWU5NzJiY2YgaW4gZ19jbG9zdXJlX2ludm9rZSAoKSBmcm9tIC91c3IvbGliL2xpYmdvYmplY3Qt Mi4wLnNvLjANCiMxOCAweDAwMDA3ZmJmZWU5ODY2YmMgaW4gPz8gKCkgZnJvbSAvdXNyL2xpYi9s aWJnb2JqZWN0LTIuMC5zby4wDQojMTkgMHgwMDAwN2ZiZmVlOTg4MGQ1IGluIGdfc2lnbmFsX2Vt aXRfdmFsaXN0ICgpDQogICBmcm9tIC91c3IvbGliL2xpYmdvYmplY3QtMi4wLnNvLjANCiMyMCAw eDAwMDA3ZmJmZWU5ODg0ODMgaW4gZ19zaWduYWxfZW1pdCAoKSBmcm9tIC91c3IvbGliL2xpYmdv YmplY3QtMi4wLnNvLjANCiMyMSAweDAwMDA3ZmJmZWQ3N2FmZjIgaW4gc29ja2V0X3JlYWRfd2F0 Y2ggKGNoYW49PHZhbHVlIG9wdGltaXplZCBvdXQ+LCANCiAgICBjb25kPTAsIHVzZXJfZGF0YT08 dmFsdWUgb3B0aW1pemVkIG91dD4pIGF0IHNvdXAtc29ja2V0LmM6MTAzNg0KIzIyIDB4MDAwMDdm YmZlZTJkNjI2MiBpbiBnX21haW5fY29udGV4dF9kaXNwYXRjaCAoKQ0KICAgZnJvbSAvdXNyL2xp Yi9saWJnbGliLTIuMC5zby4wDQojMjMgMHgwMDAwN2ZiZmVlMmQ5NTE2IGluID8/ICgpIGZyb20g L3Vzci9saWIvbGliZ2xpYi0yLjAuc28uMA0KLS0tVHlwZSA8cmV0dXJuPiB0byBjb250aW51ZSwg b3IgcSA8cmV0dXJuPiB0byBxdWl0LS0tDQojMjQgMHgwMDAwN2ZiZmVlMmQ5N2Q3IGluIGdfbWFp bl9sb29wX3J1biAoKSBmcm9tIC91c3IvbGliL2xpYmdsaWItMi4wLnNvLjANCiMyNSAweDAwMDA3 ZmJmZjBkMjVmMDMgaW4gZ3RrX21haW4gKCkgZnJvbSAvdXNyL2xpYi9saWJndGsteDExLTIuMC5z by4wDQojMjYgMHgwMDAwMDAwMDAwNDBkMzFkIGluIG1haW4gKGFyZ2M9MSwgYXJndj0weDdmZmZm YmY2ZTQ2OCkgYXQgbWFpbi5jOjQ3Nw== 20958 2008-05-04 03:56:53 -0700 2008-05-04 03:56:53 -0700 Patch that fixes the problem webkit-fix-nspluginwrapper.patch text/plain 1798 chris SW5kZXg6IFdlYkNvcmUvcGx1Z2lucy9ucGFwaS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9w bHVnaW5zL25wYXBpLmNwcAkocmV2aXNpb24gMzI4NDMpCisrKyBXZWJDb3JlL3BsdWdpbnMvbnBh cGkuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMzcsMTEgKzEzNyw2IEBACiAKIE5QRXJyb3IgTlBO X0dldFZhbHVlKE5QUCBpbnN0YW5jZSwgTlBOVmFyaWFibGUgdmFyaWFibGUsIHZvaWQqIHZhbHVl KQogewotICAgIC8vIEZJWE1FOiBBY3JvYmF0IHJlYWRlciBwbHVnaW4gY2FsbHMgTlBOX0dldFZh bHVlIGJlZm9yZSBhIFBsdWdpblZpZXcKLSAgICAvLyBoYXMgYmVlbiBjcmVhdGVkCi0gICAgaWYg KCFpbnN0YW5jZSkKLSAgICAgICAgcmV0dXJuIE5QRVJSX0dFTkVSSUNfRVJST1I7Ci0KICAgICBy ZXR1cm4gcGx1Z2luVmlld0Zvckluc3RhbmNlKGluc3RhbmNlKS0+Z2V0VmFsdWUodmFyaWFibGUs IHZhbHVlKTsKIH0KIApJbmRleDogV2ViQ29yZS9wbHVnaW5zL1BsdWdpblZpZXcuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYkNvcmUvcGx1Z2lucy9QbHVnaW5WaWV3LmNwcAkocmV2aXNpb24gMzI4NDMp CisrKyBXZWJDb3JlL3BsdWdpbnMvUGx1Z2luVmlldy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIz NCwxMCArMjM0LDEyIEBACiAgICAgICAKICAgICAgICAgICAgIC8vIEZJWE1FOiA8cmRhcjovL3By b2JsZW0vNDgwNzQ2OT4gVGhpcyBzaG91bGQgYmUgc2VudCB3aGVuIHRoZSBkb2N1bWVudCBoYXMg ZmluaXNoZWQgbG9hZGluZwogICAgICAgICAgICAgaWYgKHJlcXVlc3QtPnNlbmROb3RpZmljYXRp b24oKSkgeworICAgICAgICAgICAgICAgIFBsdWdpblZpZXc6OnNldEN1cnJlbnRQbHVnaW5WaWV3 KHRoaXMpOwogICAgICAgICAgICAgICAgIEtKUzo6SlNMb2NrOjpEcm9wQWxsTG9ja3MgZHJvcEFs bExvY2tzOwogICAgICAgICAgICAgICAgIHNldENhbGxpbmdQbHVnaW4odHJ1ZSk7CiAgICAgICAg ICAgICAgICAgbV9wbHVnaW4tPnBsdWdpbkZ1bmNzKCktPnVybG5vdGlmeShtX2luc3RhbmNlLCBy ZXF1ZXN0VVJMLnN0cmluZygpLnV0ZjgoKS5kYXRhKCksIE5QUkVTX0RPTkUsIHJlcXVlc3QtPm5v dGlmeURhdGEoKSk7CiAgICAgICAgICAgICAgICAgc2V0Q2FsbGluZ1BsdWdpbihmYWxzZSk7Cisg ICAgICAgICAgICAgICAgUGx1Z2luVmlldzo6c2V0Q3VycmVudFBsdWdpblZpZXcoMCk7CiAgICAg ICAgICAgICB9CiAgICAgICAgIH0KICAgICAgICAgcmV0dXJuOwpAQCAtNDYwLDEyICs0NjIsMTQg QEAKICAgICAgICAgcmV0dXJuIDA7CiAKICAgICBOUEVycm9yIG5wRXJyOworICAgIFBsdWdpblZp ZXc6OnNldEN1cnJlbnRQbHVnaW5WaWV3KHRoaXMpOwogICAgIHsKICAgICAgICAgS0pTOjpKU0xv Y2s6OkRyb3BBbGxMb2NrcyBkcm9wQWxsTG9ja3M7CiAgICAgICAgIHNldENhbGxpbmdQbHVnaW4o dHJ1ZSk7CiAgICAgICAgIG5wRXJyID0gbV9wbHVnaW4tPnBsdWdpbkZ1bmNzKCktPmdldHZhbHVl KG1faW5zdGFuY2UsIE5QUFZwbHVnaW5TY3JpcHRhYmxlTlBPYmplY3QsICZvYmplY3QpOwogICAg ICAgICBzZXRDYWxsaW5nUGx1Z2luKGZhbHNlKTsKICAgICB9CisgICAgUGx1Z2luVmlldzo6c2V0 Q3VycmVudFBsdWdpblZpZXcoMCk7CiAKICAgICBpZiAobnBFcnIgIT0gTlBFUlJfTk9fRVJST1Ig fHwgIW9iamVjdCkKICAgICAgICAgcmV0dXJuIDA7Cg==