188818 2018-08-21 14:53:03 -0700 Cleanup: Remove unused file-local static variable from TextCheckerIOS.mm 2018-08-22 09:44:19 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 dbates dbates simon.fraser webkit-bug-importer wenson_hsieh oldest_to_newest 1452317 0 dbates 2018-08-21 14:53:03 -0700 Remove the file-local static variable, smartInsertDeleteEnabled, as it is unused and increases binary size. $ nm -a WebKitBuild/Debug-iphonesimulator/WebKit.framework/WebKit | grep smartInsertDeleteEnabled ... 00000000017f0970 b __ZN6WebKitL24smartInsertDeleteEnabledE 1452318 1 347704 dbates 2018-08-21 14:54:17 -0700 Created attachment 347704 Patch 1452451 2 347704 dbates 2018-08-21 17:49:40 -0700 Comment on attachment 347704 Patch Clearing flags on attachment: 347704 Committed r235150: <https://trac.webkit.org/changeset/235150> 1452452 3 dbates 2018-08-21 17:49:43 -0700 All reviewed patches have been landed. Closing bug. 1452453 4 webkit-bug-importer 2018-08-21 17:50:17 -0700 <rdar://problem/43585928> 1452673 5 dbates 2018-08-22 09:44:19 -0700 (In reply to Daniel Bates from comment #0) > Remove the file-local static variable, smartInsertDeleteEnabled, as it is > unused and increases binary size. Disregard the remark about increasing binary size. 347704 2018-08-21 14:54:17 -0700 2018-08-21 17:49:40 -0700 Patch bug-188818-20180821145416.patch text/plain 1335 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0ODQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDE3YjhiZWE2ZDNjMjM5NDcx OTVhOGNkZjFlZDdhNTU5Y2NhZmQ4YjUuLjE4YzUyNWMwNGNmZGFlOTUzZDFmZmNlNmRhNjU4N2Ey MWNjY2FiZTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTgtMDgtMjEgIERhbmllbCBC YXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgorCisgICAgICAgIENsZWFudXA6IFJlbW92ZSB1bnVz ZWQgZmlsZS1sb2NhbCBzdGF0aWMgdmFyaWFibGUgZnJvbSBUZXh0Q2hlY2tlcklPUy5tbQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg4ODE4CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv aW9zL1RleHRDaGVja2VySU9TLm1tOgorICAgICAgICAoV2ViS2l0OjpUZXh0Q2hlY2tlcjo6aXNT bWFydEluc2VydERlbGV0ZUVuYWJsZWQpOgorCiAyMDE4LTA4LTIxICBEYW5pZWwgQmF0ZXMgIDxk YWJhdGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBDbGVhbnVwOiBBZGQgdHlwZSBhbGlhcyBmb3Ig c3BlbGwgZG9jdW1lbnQgdGFnCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9p b3MvVGV4dENoZWNrZXJJT1MubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvVGV4dENo ZWNrZXJJT1MubW0KaW5kZXggYmViMWZlNzRmMGQ1YjljNDMwNmQxMzE4ZjI2YjY0NmRjOTRjY2U2 OC4uYTJkYzc2YWE4MTAyZWRkNGE2YzJlMzZhYWUzYTlhZWFlZmFhZTVjZiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1RleHRDaGVja2VySU9TLm1tCisrKyBiL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9UZXh0Q2hlY2tlcklPUy5tbQpAQCAtMTEzLDEzICsxMTMs MTAgQEAgYm9vbCBUZXh0Q2hlY2tlcjo6aXNUZXN0aW5nTW9kZSgpCiAgICAgcmV0dXJuIHRlc3Rp bmdNb2RlRW5hYmxlZDsKIH0KIAotCi1zdGF0aWMgYm9vbCBzbWFydEluc2VydERlbGV0ZUVuYWJs ZWQ7Ci0KIGJvb2wgVGV4dENoZWNrZXI6OmlzU21hcnRJbnNlcnREZWxldGVFbmFibGVkKCkKIHsK ICAgICBub3RJbXBsZW1lbnRlZCgpOwotICAgIHJldHVybiBzbWFydEluc2VydERlbGV0ZUVuYWJs ZWQ7CisgICAgcmV0dXJuIGZhbHNlOwogfQogCiB2b2lkIFRleHRDaGVja2VyOjpzZXRTbWFydElu c2VydERlbGV0ZUVuYWJsZWQoYm9vbCkK