188808 2018-08-21 13:22:25 -0700 Web Inspector: REGRESSION(r235095): duplicate actions existing in WI.CanvasSidebarPanel 2018-08-21 15:09:21 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 175485 185152 1 hi hi commit-queue inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1452225 0 hi 2018-08-21 13:22:25 -0700 STEPS TO REPRODUCE: 1. Go to <http://acko.net> 2. Take a recording of the main WebGL canvas => There are two "Initial State" actions in the sidebar 1452232 1 347681 hi 2018-08-21 13:31:14 -0700 Created attachment 347681 Patch 1452297 2 347681 joepeck 2018-08-21 14:28:32 -0700 Comment on attachment 347681 Patch rs=me 1452325 3 347681 commit-queue 2018-08-21 15:08:25 -0700 Comment on attachment 347681 Patch Clearing flags on attachment: 347681 Committed r235142: <https://trac.webkit.org/changeset/235142> 1452326 4 commit-queue 2018-08-21 15:08:27 -0700 All reviewed patches have been landed. Closing bug. 1452328 5 webkit-bug-importer 2018-08-21 15:09:21 -0700 <rdar://problem/43579577> 347681 2018-08-21 13:31:14 -0700 2018-08-21 15:08:25 -0700 Patch bug-188808-20180821133113.patch text/plain 4175 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGVkMWI1NzA5YmM2ODMzZGUzMjI4YjFlZWZmNWUz MjYzMjNjYjBiMWQuLmQ3NThhYjBmMGRhZDljYmU5YjhjYjE4NTRkNWUxMzBjOWIyNGRhN2YgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4LTA4LTIxICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBS RUdSRVNTSU9OKHIyMzUwOTUpOiBkdXBsaWNhdGUgYWN0aW9ucyBleGlzdGluZyBpbiBXSS5DYW52 YXNTaWRlYmFyUGFuZWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE4ODgwOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9DYW52YXNTaWRlYmFyUGFuZWwuanM6CisgICAg ICAgIChXSS5DYW52YXNTaWRlYmFyUGFuZWwucHJvdG90eXBlLl9yZWNvcmRpbmdDaGFuZ2VkKToK KyAgICAgICAgQ2hlY2sgdGhhdCB0aGUgYFdJLlJlY29yZGluZ0FjdGlvbmAgaXMgbm90IGFscmVh ZHkgcmVwcmVzZW50ZWQgaW4gdGhlIGBXSS5UcmVlT3V0bGluZWAKKyAgICAgICAgYmVmb3JlIGFk ZGluZyBpdC4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvQ2FudmFzU2lkZWJhclBh bmVsLmNzczoKKyAgICAgICAgKC5zaWRlYmFyID4gLnBhbmVsLm5hdmlnYXRpb24uY2FudmFzID4g LmNvbnRlbnQgPiAucmVjb3JkaW5nLWNvbnRlbnQgPiAudHJlZS1vdXRsaW5lIC5pdGVtLnByb2Nl c3NpbmcgLnN1YnRpdGxlID4gcHJvZ3Jlc3MpOgorICAgICAgICBEcml2ZS1ieTogdmVydGljYWxs eSBjZW50ZXIgdGhlIDxwcm9ncmVzcz4gc2hvd24gZm9yIGBXSS5SZWNvcmRpbmdGcmFtZWAgZHVy aW5nIHByb2Nlc3NpbmcuCisKIDIwMTgtMDgtMjAgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBw bGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IGFsbG93IGJyZWFrcG9pbnRzIHRvIGJl IHNldCBmb3Igc3BlY2lmaWMgZXZlbnQgbGlzdGVuZXJzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9DYW52YXNTaWRlYmFyUGFuZWwuY3NzIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ2FudmFzU2lkZWJhclBh bmVsLmNzcwppbmRleCAwZDFhNWU0YmM4NDk1Y2YyMWM2NjYxYzRmMDI5ZmVjYTZhMTVlOGY5Li40 MjY2MGJlZWQ0MTM5ZTVjNTQ0MThhNTFiNGRiMDA5ODRhN2ZhNTMxIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9DYW52YXNTaWRlYmFyUGFuZWwu Y3NzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NhbnZh c1NpZGViYXJQYW5lbC5jc3MKQEAgLTc1LDcgKzc1LDggQEAKIC5zaWRlYmFyID4gLnBhbmVsLm5h dmlnYXRpb24uY2FudmFzID4gLmNvbnRlbnQgPiAucmVjb3JkaW5nLWNvbnRlbnQgPiAudHJlZS1v dXRsaW5lIC5pdGVtLnByb2Nlc3NpbmcgLnN1YnRpdGxlID4gcHJvZ3Jlc3MgewogICAgIHdpZHRo OiAxMDAlOwogICAgIG1heC13aWR0aDogMTAwcHg7Ci0gICAgbWFyZ2luOiAycHggNHB4IDA7Cisg ICAgbWFyZ2luOiAwIDRweDsKKyAgICB2ZXJ0aWNhbC1hbGlnbjogLTNweDsKIH0KIAogLnNpZGVi YXIgPiAucGFuZWwubmF2aWdhdGlvbi5jYW52YXMgPiAuY29udGVudCA+IC5yZWNvcmRpbmctY29u dGVudCA+IC50cmVlLW91dGxpbmU6bWF0Y2hlcyg6Zm9jdXMsIC5mb3JjZS1mb2N1cykgLml0ZW0u cHJvY2Vzc2luZy5zZWxlY3RlZCAuc3VidGl0bGUgPiBwcm9ncmVzcyB7CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9DYW52YXNTaWRlYmFyUGFu ZWwuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9DYW52YXNT aWRlYmFyUGFuZWwuanMKaW5kZXggNjhiMTgxN2Q2MTIyOTZkMjVmMzE1ZmYzYzJhMmM1NTQ0YWYz NGFkMy4uMzQ2NTNkYWYyZGJkNDFjMGIwZTJiNTM3MmFlZWQ0ZWFhYWM5NDA4MSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ2FudmFzU2lkZWJh clBhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L0NhbnZhc1NpZGViYXJQYW5lbC5qcwpAQCAtNDA3LDExICs0MDcsMTIgQEAgV0kuQ2FudmFzU2lk ZWJhclBhbmVsID0gY2xhc3MgQ2FudmFzU2lkZWJhclBhbmVsIGV4dGVuZHMgV0kuTmF2aWdhdGlv blNpZGViYXJQYW4KICAgICAgICAgICAgIHNjb3BlQmFySXRlbS5zZWxlY3RlZCA9IHRydWU7CiAg ICAgICAgIH0KIAotICAgICAgICBpZiAodGhpcy5fcmVjb3JkaW5nLmFjdGlvbnNbMF0ucmVhZHkp IHsKLSAgICAgICAgICAgIHRoaXMuX3JlY29yZGluZ1RyZWVPdXRsaW5lLmFwcGVuZENoaWxkKG5l dyBXSS5SZWNvcmRpbmdBY3Rpb25UcmVlRWxlbWVudCh0aGlzLl9yZWNvcmRpbmcuYWN0aW9uc1sw XSwgMCwgdGhpcy5fcmVjb3JkaW5nLnR5cGUpKTsKKyAgICAgICAgbGV0IGluaXRpYWxTdGF0ZUFj dGlvbiA9IHRoaXMuX3JlY29yZGluZy5hY3Rpb25zWzBdOworICAgICAgICBpZiAoaW5pdGlhbFN0 YXRlQWN0aW9uLnJlYWR5ICYmICF0aGlzLl9yZWNvcmRpbmdUcmVlT3V0bGluZS5nZXRDYWNoZWRU cmVlRWxlbWVudChpbml0aWFsU3RhdGVBY3Rpb24pKSB7CisgICAgICAgICAgICB0aGlzLl9yZWNv cmRpbmdUcmVlT3V0bGluZS5hcHBlbmRDaGlsZChuZXcgV0kuUmVjb3JkaW5nQWN0aW9uVHJlZUVs ZW1lbnQoaW5pdGlhbFN0YXRlQWN0aW9uLCAwLCB0aGlzLl9yZWNvcmRpbmcudHlwZSkpOwogCiAg ICAgICAgICAgICBpZiAoIXRoaXMuX3JlY29yZGluZ1tXSS5DYW52YXNTaWRlYmFyUGFuZWwuU2Vs ZWN0ZWRBY3Rpb25TeW1ib2xdKQotICAgICAgICAgICAgICAgIHRoaXMuYWN0aW9uID0gdGhpcy5f cmVjb3JkaW5nLmFjdGlvbnNbMF07CisgICAgICAgICAgICAgICAgdGhpcy5hY3Rpb24gPSBpbml0 aWFsU3RhdGVBY3Rpb247CiAgICAgICAgIH0KIAogICAgICAgICBsZXQgY3VtdWxhdGl2ZUFjdGlv bkluZGV4ID0gMDsKQEAgLTQxOSwxNCArNDIwLDE2IEBAIFdJLkNhbnZhc1NpZGViYXJQYW5lbCA9 IGNsYXNzIENhbnZhc1NpZGViYXJQYW5lbCBleHRlbmRzIFdJLk5hdmlnYXRpb25TaWRlYmFyUGFu CiAgICAgICAgICAgICBpZiAoIWZyYW1lLmFjdGlvbnNbMF0ucmVhZHkpCiAgICAgICAgICAgICAg ICAgcmV0dXJuOwogCi0gICAgICAgICAgICBsZXQgZm9sZGVyID0gdGhpcy5fY3JlYXRlUmVjb3Jk aW5nRnJhbWVUcmVlRWxlbWVudChmcmFtZSwgZnJhbWVJbmRleCwgdGhpcy5fcmVjb3JkaW5nVHJl ZU91dGxpbmUpOworICAgICAgICAgICAgbGV0IGZvbGRlciA9IHRoaXMuX3JlY29yZGluZ1RyZWVP dXRsaW5lLmdldENhY2hlZFRyZWVFbGVtZW50KGZyYW1lKTsKKyAgICAgICAgICAgIGlmICghZm9s ZGVyKQorICAgICAgICAgICAgICAgIGZvbGRlciA9IHRoaXMuX2NyZWF0ZVJlY29yZGluZ0ZyYW1l VHJlZUVsZW1lbnQoZnJhbWUsIGZyYW1lSW5kZXgsIHRoaXMuX3JlY29yZGluZ1RyZWVPdXRsaW5l KTsKIAogICAgICAgICAgICAgZm9yIChsZXQgYWN0aW9uIG9mIGZyYW1lLmFjdGlvbnMpIHsKLSAg ICAgICAgICAgICAgICBpZiAoIWFjdGlvbi5yZWFkeSkKLSAgICAgICAgICAgICAgICAgICAgYnJl YWs7Ci0KICAgICAgICAgICAgICAgICArK2N1bXVsYXRpdmVBY3Rpb25JbmRleDsKIAorICAgICAg ICAgICAgICAgIGlmICghYWN0aW9uLnJlYWR5IHx8IHRoaXMuX3JlY29yZGluZ1RyZWVPdXRsaW5l LmdldENhY2hlZFRyZWVFbGVtZW50KGFjdGlvbikpCisgICAgICAgICAgICAgICAgICAgIGJyZWFr OworCiAgICAgICAgICAgICAgICAgdGhpcy5fY3JlYXRlUmVjb3JkaW5nQWN0aW9uVHJlZUVsZW1l bnQoYWN0aW9uLCBjdW11bGF0aXZlQWN0aW9uSW5kZXgsIGZvbGRlcik7CiAgICAgICAgICAgICB9 CiAgICAgICAgIH0pOwo=