188803 2018-08-21 12:31:50 -0700 Web Inspector: cannot delete multiple event breakpoints by repeatedly hitting delete 2018-08-22 10:56:52 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker hi commit-queue inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1452204 0 mattbaker 2018-08-21 12:31:50 -0700 The next breakpoint in the tree is selected, but doesn't have the focus, preventing the next delete key press to do nothing. Steps to Reproduce: 1. Debugger tab 2. Add multiple Event Breakpoints 3. Select the last breakpoint item in the list 4. Press the delete key => Breakpoint deleted, previous breakpoint item is selected 5. Hit delete key => Nothing happens, because the tree outline has lost the focus 1452206 1 webkit-bug-importer 2018-08-21 12:34:03 -0700 <rdar://problem/43572838> 1452549 2 347771 hi 2018-08-21 23:50:21 -0700 Created attachment 347771 Patch 1452704 3 347771 mattbaker 2018-08-22 10:29:08 -0700 Comment on attachment 347771 Patch We removed and re-appended the tree whenever a breakpoint was deleted! Looks like copypasta from the broken code I added for DOM breakpoints. :( 1452720 4 347771 commit-queue 2018-08-22 10:56:50 -0700 Comment on attachment 347771 Patch Clearing flags on attachment: 347771 Committed r235183: <https://trac.webkit.org/changeset/235183> 1452721 5 commit-queue 2018-08-22 10:56:52 -0700 All reviewed patches have been landed. Closing bug. 347771 2018-08-21 23:50:21 -0700 2018-08-22 10:56:50 -0700 Patch bug-188803-20180821235021.patch text/plain 1964 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGRkNmI4NjViNWI2YTcyNzViNTJkMmNhYjQxMGI2 ZTRhY2I2YjYzMjcuLjUwNDlhYTFjOGZhYjUyOTQ4YmZkYzdjYjA5ZjIzMjBkMmM3MDI1ZTAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE4LTA4LTIxICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBj YW5ub3QgZGVsZXRlIG11bHRpcGxlIGV2ZW50IGJyZWFrcG9pbnRzIGJ5IHJlcGVhdGVkbHkgaGl0 dGluZyBkZWxldGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE4ODgwMworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDM1NzI4Mzg+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1Zp ZXdzL0RlYnVnZ2VyU2lkZWJhclBhbmVsLmpzOgorICAgICAgICAoV0kuRGVidWdnZXJTaWRlYmFy UGFuZWwucHJvdG90eXBlLl9kb21CcmVha3BvaW50QWRkZWRPclJlbW92ZWQpOgorICAgICAgICAo V0kuRGVidWdnZXJTaWRlYmFyUGFuZWwucHJvdG90eXBlLl9ldmVudEJyZWFrcG9pbnRBZGRlZE9y UmVtb3ZlZCk6CisKIDIwMTgtMDgtMjEgIE1hdHQgQmFrZXIgIDxtYXR0YmFrZXJAYXBwbGUuY29t PgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFJlbW92ZSBUcmVlT3V0bGluZURhdGFHcmlkU3lu Y2hyb25pemVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9WaWV3cy9EZWJ1Z2dlclNpZGViYXJQYW5lbC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL0RlYnVnZ2VyU2lkZWJhclBhbmVsLmpzCmluZGV4IDRlMjMzMTU4 ODBiMTZkZjFlZWQyMzkwYTY3MTk4NmU2NGU1MWJiODYuLjg5ZTM2MjMxZDNlN2RiNDM1NzFkYjVi NmU2YTZjZGZjZmNhNmE4ZTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL0RlYnVnZ2VyU2lkZWJhclBhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RlYnVnZ2VyU2lkZWJhclBhbmVsLmpzCkBA IC0xMjIzLDcgKzEyMjMsNyBAQCBXSS5EZWJ1Z2dlclNpZGViYXJQYW5lbCA9IGNsYXNzIERlYnVn Z2VyU2lkZWJhclBhbmVsIGV4dGVuZHMgV0kuTmF2aWdhdGlvblNpZGViYQogICAgICAgICAgICAg cmV0dXJuOwogICAgICAgICB9CiAKLSAgICAgICAgaWYgKHRoaXMuX2RvbUJyZWFrcG9pbnRzQ29u dGVudFRyZWVPdXRsaW5lLmVsZW1lbnQucGFyZW50KQorICAgICAgICBpZiAodGhpcy5fZG9tQnJl YWtwb2ludHNDb250ZW50VHJlZU91dGxpbmUuZWxlbWVudC5wYXJlbnROb2RlKQogICAgICAgICAg ICAgcmV0dXJuOwogCiAgICAgICAgIHRoaXMuX2RvbUJyZWFrcG9pbnRzUm93LmhpZGVFbXB0eU1l c3NhZ2UoKTsKQEAgLTEyMzksNyArMTIzOSw3IEBAIFdJLkRlYnVnZ2VyU2lkZWJhclBhbmVsID0g Y2xhc3MgRGVidWdnZXJTaWRlYmFyUGFuZWwgZXh0ZW5kcyBXSS5OYXZpZ2F0aW9uU2lkZWJhCiAg ICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KIAotICAgICAgICBpZiAodGhpcy5fZXZlbnRC cmVha3BvaW50c0NvbnRlbnRUcmVlT3V0bGluZS5lbGVtZW50LnBhcmVudCkKKyAgICAgICAgaWYg KHRoaXMuX2V2ZW50QnJlYWtwb2ludHNDb250ZW50VHJlZU91dGxpbmUuZWxlbWVudC5wYXJlbnRO b2RlKQogICAgICAgICAgICAgcmV0dXJuOwogCiAgICAgICAgIHRoaXMuX2V2ZW50QnJlYWtwb2lu dHNSb3cuaGlkZUVtcHR5TWVzc2FnZSgpOwo=