188795 2018-08-21 06:24:03 -0700 REGRESSION(r234993): Test results page ignores TestExpectations, shows 1800 failures 2018-08-21 11:51:07 -0700 1 1 1 Unclassified WebKit Tools / Tests Other PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 mcatanzaro simon.fraser ap bugs-noreply commit-queue lforschler mcatanzaro simon.fraser thorton webkit-bug-importer oldest_to_newest 1452069 0 mcatanzaro 2018-08-21 06:24:03 -0700 Since r234993 "Modernize results.html" our test results page has gone crazy. For example: https://build.webkit.org/results/GTK Linux 64-bit Release (Tests)/r235110 (7847)/results.html shows 1815 tests that failed pixel/audio diff. But the bot dashboard reports only 13 layout test failures. And looking at the text file, there were indeed only 13 failures: https://build.webkit.org/builders/GTK Linux 64-bit Release (Tests)/builds/7847/steps/layout-test/logs/stdio The problem seems to be that the platform TestExpectations file is now ignored, so all the expected failures are showing up as unexpected failures. It seems this issue only affects GTK: the results for macOS, iOS, Windows, and WPE are all fine. 1452070 1 mcatanzaro 2018-08-21 06:25:48 -0700 (In reply to Michael Catanzaro from comment #0) > Since r234993 "Modernize results.html" our test results page has gone crazy. > For example: > > https://build.webkit.org/results/GTK Linux 64-bit Release (Tests)/r235110 > (7847)/results.html Unrelated: it looks like Epiphany's code to percent-encode URLs when copied from the address bar is broken. :) 1452094 2 simon.fraser 2018-08-21 08:30:20 -0700 https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r235110%20(7847)/results.html 1452095 3 simon.fraser 2018-08-21 08:30:54 -0700 It's showing expected failures; I'll fix. 1452097 4 347643 simon.fraser 2018-08-21 08:41:59 -0700 Created attachment 347643 Patch 1452164 5 347643 commit-queue 2018-08-21 11:08:32 -0700 Comment on attachment 347643 Patch Clearing flags on attachment: 347643 Committed r235126: <https://trac.webkit.org/changeset/235126> 1452165 6 commit-queue 2018-08-21 11:08:34 -0700 All reviewed patches have been landed. Closing bug. 1452166 7 webkit-bug-importer 2018-08-21 11:09:23 -0700 <rdar://problem/43568697> 1452187 8 mcatanzaro 2018-08-21 11:51:07 -0700 Thanks Simon! 347643 2018-08-21 08:41:59 -0700 2018-08-21 11:08:32 -0700 Patch bug-188795-20180821084158.patch text/plain 2237 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1MTE2CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZGRiZTJhOTE2MDViZWJmZGQ4ZjI4 MjhmOGUzN2JjZjkwMTUwOTIyNy4uYjdjNDVkOWFhYjM4NDhlZGMwMTlmNDVmOWJiZGVlNTU4N2Fk ZDliMiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE4LTA4LTIxICBTaW1vbiBGcmFzZXIgIDxz aW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjIzNDk5Myk6IFRl c3QgcmVzdWx0cyBwYWdlIGlnbm9yZXMgVGVzdEV4cGVjdGF0aW9ucywgc2hvd3MgMTgwMCBmYWls dXJlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg4 Nzk1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAg ICAgICBBIE1JU1NJTkcgcmVzdWx0IHdvdWxkIHRyaWdnZXIgYSBjb2RlIHBhdGggdGhhdCBoaXQg YXBwZW5kQWN0dWFsT25seUxpbmtzKCkgd2hpY2ggaGFkCisgICAgICAgIGEgSlMgZXJyb3IsIGNh dXNpbmcgYWxsIGV4cGVjdGVkIHJlc3VsdHMgdG8gYmUgdmlzaWJsZS4gRml4IHdpdGggYSBjaGFu Z2UgdG8gZnVsbF9yZXN1bHRzLmpzb24KKyAgICAgICAgd2hpY2ggdGVzdHMgdGhlIGNoYW5nZS4K KworICAgICAgICAqIGZhc3QvaGFybmVzcy9mdWxsX3Jlc3VsdHMuanNvbjoKKyAgICAgICAgKiBm YXN0L2hhcm5lc3MvcmVzdWx0cy5odG1sOgorCiAyMDE4LTA4LTIwICBGdWppaSBIaXJvbm9yaSAg PEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgV2luQ2Fpcm8g cG9ydCB0ZXN0IGdhcmRlbmluZwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9oYXJuZXNz L2Z1bGxfcmVzdWx0cy5qc29uIGIvTGF5b3V0VGVzdHMvZmFzdC9oYXJuZXNzL2Z1bGxfcmVzdWx0 cy5qc29uCmluZGV4IGVkMjM1Y2VjMmJiZGM5MjI0ZGQ5MjQyMjAxMzNhOWU2YzlhZWU4MjguLmY0 NDZkOTNhNGY2MzA0OTgxZTU4OTA4MjcwNWJmZjMxNjg0YmNhYjggMTAwNjQ0Ci0tLSBhL0xheW91 dFRlc3RzL2Zhc3QvaGFybmVzcy9mdWxsX3Jlc3VsdHMuanNvbgorKysgYi9MYXlvdXRUZXN0cy9m YXN0L2hhcm5lc3MvZnVsbF9yZXN1bHRzLmpzb24KQEAgLTQyLDYgKzQyLDExIEBAIEFERF9SRVNV TFRTKHsKICAgICAgICAgICAgICAgICAiZXhwZWN0ZWQiOiAiUEFTUyBUSU1FT1VUIiwKICAgICAg ICAgICAgICAgICAiYWN0dWFsIjogIlRFWFQgUEFTUyBUSU1FT1VUIgogICAgICAgICAgICAgfSwK KyAgICAgICAgICAgICJzY2FsZS10cmFuc2l0aW9uLW5vLXN0YXJ0Lmh0bWwiOiB7CisgICAgICAg ICAgICAgICAgImV4cGVjdGVkIjogIkZBSUwgTUlTU0lORyIsCisgICAgICAgICAgICAgICAgImlz X21pc3NpbmdfdGV4dCI6IHRydWUsCisgICAgICAgICAgICAgICAgImFjdHVhbCI6ICJNSVNTSU5H IgorICAgICAgICAgICAgfQogICAgICAgICB9LAogICAgICAgICAiY2FudmFzIjogewogICAgICAg ICAgICAgInBoaWxpcCI6IHsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvaGFybmVzcy9y ZXN1bHRzLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2hhcm5lc3MvcmVzdWx0cy5odG1sCmluZGV4 IDRhNTE0MDY5YjhhMzQ0OWU1MjVmMDY1OTc0ZDAxNmI3ZGFmZDMzNzcuLmYxMzQyYmU2Njk4ZjJk ZjA4ODExNDI5MjU3ZGJjZDIxYWJiN2M3NDEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3Qv aGFybmVzcy9yZXN1bHRzLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9oYXJuZXNzL3Jlc3Vs dHMuaHRtbApAQCAtMTIzNCw2ICsxMjM0LDcgQEAgY2xhc3MgRmFpbHVyZXNTZWN0aW9uQnVpbGRl ciBleHRlbmRzIFNlY3Rpb25CdWlsZGVyIHsKICAgICAKICAgICBhcHBlbmRBY3R1YWxPbmx5TGlu a3ModGVzdFJlc3VsdCwgY2VsbCkKICAgICB7CisgICAgICAgIGxldCBwcmVmaXggPSBVdGlscy5z dHJpcEV4dGVuc2lvbih0ZXN0UmVzdWx0Lm5hbWUpOwogICAgICAgICBpZiAodGVzdFJlc3VsdC5p bmZvLmlzX21pc3NpbmdfYXVkaW8pCiAgICAgICAgICAgICBjZWxsLmlubmVySFRNTCArPSBUZXN0 UmVzdWx0c0NvbnRyb2xsZXIucmVzdWx0TGluayhwcmVmaXgsICctYWN0dWFsLndhdicsICdhdWRp byByZXN1bHQnKTsKIAo=