188791 2018-08-21 05:58:32 -0700 [Linux] Cache the memory footprint and only update it after 1 second 2018-08-21 23:20:19 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=188787 Gtk, InRadar P2 Normal --- 1 cgarcia webkit-unassigned benjamin bugs-noreply cdumez cmarcelo dbates ews-watchlist saam webkit-bug-importer ysuzuki zan oldest_to_newest 1452053 0 cgarcia 2018-08-21 05:58:32 -0700 Getting the memory footprint is an expensive operation in Linux. When called multiple times, the CPU usage is too much (see bug #188787). We could cache the result for at least 1 second to ensure we don't call it more than once per second. 1452054 1 347635 cgarcia 2018-08-21 06:02:18 -0700 Created attachment 347635 Patch 1452063 2 347635 ysuzuki 2018-08-21 06:13:26 -0700 Comment on attachment 347635 Patch r=me 1452072 3 cgarcia 2018-08-21 06:27:52 -0700 Committed r235113: <https://trac.webkit.org/changeset/235113> 1452073 4 webkit-bug-importer 2018-08-21 06:28:24 -0700 <rdar://problem/43558827> 1452499 5 saam 2018-08-21 19:47:45 -0700 1 second is a long time! 1452544 6 cgarcia 2018-08-21 23:20:19 -0700 I tried with lower values but cpu usage was still too much and tests were timing out. It seems RenderLayerCompositor::cacheAcceleratedCompositingFlags() is called too often. 347635 2018-08-21 06:02:18 -0700 2018-08-21 06:13:26 -0700 Patch wtf-memory-linux.diff text/plain 2380 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggZjkzM2U0NzZlNmYuLjU5NDM1OWM5OTIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0No YW5nZUxvZworKysgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4 LTA4LTIxICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKworICAg ICAgICBbTGludXhdIENhY2hlIHRoZSBtZW1vcnkgZm9vdHByaW50IGFuZCBvbmx5IHVwZGF0ZSBp dCBhZnRlciAxIHNlY29uZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTg4NzkxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgR2V0dGluZyB0aGUgbWVtb3J5IGZvb3RwcmludCBpcyBhbiBleHBlbnNpdmUgb3Bl cmF0aW9uIGluIExpbnV4LiBXaGVuIGNhbGxlZCBtdWx0aXBsZSB0aW1lcywgdGhlIENQVSB1c2Fn ZSBpcworICAgICAgICB0b28gbXVjaCAoc2VlIGJ1ZyAjMTg4Nzg3KS4gV2UgY291bGQgY2FjaGUg dGhlIHJlc3VsdCBmb3IgYXQgbGVhc3QgMSBzZWNvbmQgdG8gZW5zdXJlIHdlIGRvbid0IGNhbGwg aXQgbW9yZSB0aGFuCisgICAgICAgIG9uY2UgcGVyIHNlY29uZC4KKworICAgICAgICAqIHd0Zi9s aW51eC9NZW1vcnlGb290cHJpbnRMaW51eC5jcHA6CisgICAgICAgIChXVEY6OmZvckVhY2hMaW5l KToKKyAgICAgICAgKFdURjo6Y29tcHV0ZU1lbW9yeUZvb3RwcmludCk6CisgICAgICAgIChXVEY6 Om1lbW9yeUZvb3RwcmludCk6CisKIDIwMTgtMDgtMTkgIFl1c3VrZSBTdXp1a2kgIDx5dXN1a2Vz dXp1a2lAc2xvd3N0YXJ0Lm9yZz4KIAogICAgICAgICBbV1RGXSBBZGQgV1RGOjp1bmFsaWduZWRM b2FkIGFuZCBXVEY6OnVuYWxpZ25lZFN0b3JlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9s aW51eC9NZW1vcnlGb290cHJpbnRMaW51eC5jcHAgYi9Tb3VyY2UvV1RGL3d0Zi9saW51eC9NZW1v cnlGb290cHJpbnRMaW51eC5jcHAKaW5kZXggZjI3NjU4Y2M0OTEuLjdiYzlkN2M3N2U0IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9saW51eC9NZW1vcnlGb290cHJpbnRMaW51eC5jcHAKKysr IGIvU291cmNlL1dURi93dGYvbGludXgvTWVtb3J5Rm9vdHByaW50TGludXguY3BwCkBAIC0yNyw2 ICsyNyw3IEBACiAjaW5jbHVkZSAiTWVtb3J5Rm9vdHByaW50LmgiCiAKICNpZiBPUyhMSU5VWCkK KyNpbmNsdWRlICJNb25vdG9uaWNUaW1lLmgiCiAjaW5jbHVkZSA8c3RkaW8uaD4KICNpbmNsdWRl IDx3dGYvU3RkTGliRXh0cmFzLmg+CiAjaW5jbHVkZSA8d3RmL3RleHQvU3RyaW5nVmlldy5oPgpA QCAtMzUsNiArMzYsOCBAQAogbmFtZXNwYWNlIFdURiB7CiAKICNpZiBPUyhMSU5VWCkKK3N0YXRp YyBjb25zdCBTZWNvbmRzIHNfbWVtb3J5Rm9vdHByaW50VXBkYXRlSW50ZXJ2YWwgPSAxX3M7CisK IHRlbXBsYXRlPHR5cGVuYW1lIEZ1bmN0b3I+CiBzdGF0aWMgdm9pZCBmb3JFYWNoTGluZShGSUxF KiBmaWxlLCBGdW5jdG9yIGZ1bmN0b3IpCiB7CkBAIC00NSwxMSArNDgsOSBAQCBzdGF0aWMgdm9p ZCBmb3JFYWNoTGluZShGSUxFKiBmaWxlLCBGdW5jdG9yIGZ1bmN0b3IpCiAgICAgfQogICAgIGZy ZWUoYnVmZmVyKTsKIH0KLSNlbmRpZgogCi1zaXplX3QgbWVtb3J5Rm9vdHByaW50KCkKK3N0YXRp YyBzaXplX3QgY29tcHV0ZU1lbW9yeUZvb3RwcmludCgpCiB7Ci0jaWYgT1MoTElOVVgpCiAgICAg RklMRSogZmlsZSA9IGZvcGVuKCIvcHJvYy9zZWxmL3NtYXBzIiwgInIiKTsKICAgICBpZiAoIWZp bGUpCiAgICAgICAgIHJldHVybiAwOwpAQCAtODYsNiArODcsMjEgQEAgc2l6ZV90IG1lbW9yeUZv b3RwcmludCgpCiAgICAgfSk7CiAgICAgZmNsb3NlKGZpbGUpOwogICAgIHJldHVybiB0b3RhbFBy aXZhdGVEaXJ0eUluS0IgKiBLQjsKK30KKyNlbmRpZgorCitzaXplX3QgbWVtb3J5Rm9vdHByaW50 KCkKK3sKKyNpZiBPUyhMSU5VWCkKKyAgICBzdGF0aWMgc2l6ZV90IGZvb3RwcmludCA9IDA7Cisg ICAgc3RhdGljIE1vbm90b25pY1RpbWUgcHJldmlvdXNVcGRhdGVUaW1lID0geyB9OworICAgIFNl Y29uZHMgZWxhcHNlZCA9IE1vbm90b25pY1RpbWU6Om5vdygpIC0gcHJldmlvdXNVcGRhdGVUaW1l OworICAgIGlmIChlbGFwc2VkID49IHNfbWVtb3J5Rm9vdHByaW50VXBkYXRlSW50ZXJ2YWwpIHsK KyAgICAgICAgZm9vdHByaW50ID0gY29tcHV0ZU1lbW9yeUZvb3RwcmludCgpOworICAgICAgICBw cmV2aW91c1VwZGF0ZVRpbWUgPSBNb25vdG9uaWNUaW1lOjpub3coKTsKKyAgICB9CisKKyAgICBy ZXR1cm4gZm9vdHByaW50OwogI2VuZGlmCiAgICAgcmV0dXJuIDA7CiB9Cg==