18879 2008-05-03 20:48:58 -0700 Reproducible crash when removing a gradient 2008-05-04 15:07:55 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED InRadar P1 Normal --- 1 mitz webkit-unassigned hyatt oldest_to_newest 79597 0 mitz 2008-05-03 20:48:58 -0700 The attached test case crashes beneath StyleGeneratedImage::removeClient(), because the CSSImageGeneratorValue is deleted when the background-image property is removed. 79598 1 20954 mitz 2008-05-03 20:49:21 -0700 Created attachment 20954 Test case (will crash) 79599 2 mitz 2008-05-03 20:49:51 -0700 <rdar://problem/5909481> 79600 3 20955 mitz 2008-05-03 21:23:49 -0700 Created attachment 20955 Make clients implicitly ref() the CSSImageGeneratorValue The "autoDeref" trick may be the wrong trade-off between readability and leak safety for such a small function. I can replace it with a deref() at the end. 79634 4 20955 sam 2008-05-04 14:03:10 -0700 Comment on attachment 20955 Make clients implicitly ref() the CSSImageGeneratorValue I think you should replace the "autoDeref" trick with a deref at the end to make the calls symmetrical. r=me, the change is up to you though. 79636 5 mitz 2008-05-04 15:07:55 -0700 Fixed in <http://trac.webkit.org/changeset/32854>. 20954 2008-05-03 20:49:21 -0700 2008-05-03 20:49:21 -0700 Test case (will crash) gradient-crash.html text/html 280 mitz PGRpdiBpZD0idGFyZ2V0IiBzdHlsZT0id2lkdGg6IDEwMHB4OyBoZWlnaHQ6IDEwMHB4OyBiYWNr Z3JvdW5kLWltYWdlOiAtd2Via2l0LWdyYWRpZW50KGxpbmVhciwgbGVmdCB0b3AsIGxlZnQgYm90 dG9tLCBmcm9tKHdoaXRlKSwgdG8oYmxhY2spKSI+CjwvZGl2Pgo8c2NyaXB0PgogICAgZG9jdW1l bnQuYm9keS5vZmZzZXRUb3A7CiAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgidGFyZ2V0Iiku c3R5bGUucmVtb3ZlUHJvcGVydHkoImJhY2tncm91bmQtaW1hZ2UiKTsKPC9zY3JpcHQ+Cg== 20955 2008-05-03 21:23:49 -0700 2008-05-04 14:03:10 -0700 Make clients implicitly ref() the CSSImageGeneratorValue 18879_r1.diff text/plain 3857 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzMjg0OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMDgtMDUtMDMgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAtIGZp eCBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg4NzkKKyAgICAgICAg ICA8cmRhcjovL3Byb2JsZW0vNTkwOTQ4MT4gUmVwcm9kdWNpYmxlIGNyYXNoIHdoZW4gcmVtb3Zp bmcgYSBncmFkaWVudAorCisgICAgICAgIFRlc3Q6IGZhc3QvZ3JhZGllbnRzL2NyYXNoLW9uLXJl bW92ZS5odG1sCisKKyAgICAgICAgKiBjc3MvQ1NTSW1hZ2VHZW5lcmF0b3JWYWx1ZS5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpDU1NJbWFnZUdlbmVyYXRvclZhbHVlOjpDU1NJbWFnZUdlbmVyYXRv clZhbHVlKToKKyAgICAgICAgKFdlYkNvcmU6OkNTU0ltYWdlR2VuZXJhdG9yVmFsdWU6OmFkZENs aWVudCk6IEFkZGVkIGEgY2FsbCB0byByZWYoKSB0aGUKKyAgICAgICAgdmFsdWUuCisgICAgICAg IChXZWJDb3JlOjpDU1NJbWFnZUdlbmVyYXRvclZhbHVlOjpyZW1vdmVDbGllbnQpOiBBZGRlZCBj b2RlIHRvIGRlcmVmKCkKKyAgICAgICAgdGhlIHZhbHVlLgorCiAyMDA4LTA1LTAzICBTYW0gV2Vp bmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFyayBSb3dlLgpJ bmRleDogV2ViQ29yZS9jc3MvQ1NTSW1hZ2VHZW5lcmF0b3JWYWx1ZS5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS9jc3MvQ1NTSW1hZ2VHZW5lcmF0b3JWYWx1ZS5jcHAJKHJldmlzaW9uIDMyODQ3 KQorKysgV2ViQ29yZS9jc3MvQ1NTSW1hZ2VHZW5lcmF0b3JWYWx1ZS5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTM3LDcgKzM3LDYgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogQ1NTSW1hZ2VHZW5lcmF0 b3JWYWx1ZTo6Q1NTSW1hZ2VHZW5lcmF0b3JWYWx1ZSgpCiA6IG1fYWNjZXNzZWRJbWFnZShmYWxz ZSkKIHsKLQogfQogCiBDU1NJbWFnZUdlbmVyYXRvclZhbHVlOjp+Q1NTSW1hZ2VHZW5lcmF0b3JW YWx1ZSgpCkBAIC00Nyw2ICs0Niw3IEBAIENTU0ltYWdlR2VuZXJhdG9yVmFsdWU6On5DU1NJbWFn ZUdlbmVyYXQKIAogdm9pZCBDU1NJbWFnZUdlbmVyYXRvclZhbHVlOjphZGRDbGllbnQoUmVuZGVy T2JqZWN0KiByZW5kZXJlciwgY29uc3QgSW50U2l6ZSYgc2l6ZSkKIHsKKyAgICByZWYoKTsKICAg ICBpZiAoIXNpemUuaXNFbXB0eSgpKQogICAgICAgICBtX3NpemVzLmFkZChzaXplKTsKICAgICBt X2NsaWVudHMuYWRkKHJlbmRlcmVyLCBzaXplKTsKQEAgLTU0LDYgKzU0LDcgQEAgdm9pZCBDU1NJ bWFnZUdlbmVyYXRvclZhbHVlOjphZGRDbGllbnQoUgogCiB2b2lkIENTU0ltYWdlR2VuZXJhdG9y VmFsdWU6OnJlbW92ZUNsaWVudChSZW5kZXJPYmplY3QqIHJlbmRlcmVyKQogeworICAgIFBhc3NS ZWZQdHI8Q1NTSW1hZ2VHZW5lcmF0b3JWYWx1ZT4gYXV0b0RlcmVmID0gYWRvcHRSZWYodGhpcyk7 CiAgICAgSW50U2l6ZSBzaXplID0gbV9jbGllbnRzLmdldChyZW5kZXJlcik7CiAgICAgaWYgKCFz aXplLmlzRW1wdHkoKSkgewogICAgICAgICBtX3NpemVzLnJlbW92ZShzaXplKTsKSW5kZXg6IExh eW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJ KHJldmlzaW9uIDMyODQ4KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkp CkBAIC0xLDMgKzEsMTMgQEAKKzIwMDgtMDUtMDMgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxl LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAt IHRlc3QgZm9yIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODg3OQor ICAgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81OTA5NDgxPiBSZXByb2R1Y2libGUgY3Jhc2ggd2hl biByZW1vdmluZyBhIGdyYWRpZW50CisKKyAgICAgICAgKiBmYXN0L2dyYWRpZW50cy9jcmFzaC1v bi1yZW1vdmUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2dyYWRpZW50cy9j cmFzaC1vbi1yZW1vdmUuaHRtbDogQWRkZWQuCisKIDIwMDgtMDUtMDMgIFNhbSBXZWluaWcgIDxz YW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYW4gQmVybnN0ZWluLgpJbmRl eDogTGF5b3V0VGVzdHMvZmFzdC9ncmFkaWVudHMvY3Jhc2gtb24tcmVtb3ZlLWV4cGVjdGVkLnR4 dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2dyYWRpZW50cy9jcmFzaC1vbi1yZW1v dmUtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9ncmFkaWVu dHMvY3Jhc2gtb24tcmVtb3ZlLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw1 IEBACitUZXN0IGZvciBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg4 NzkgUmVwcm9kdWNpYmxlIGNyYXNoIHdoZW4gcmVtb3ZpbmcgYSBncmFkaWVudC4KKworVGhlIHRl c3Qgc2hvdWxkIG5vdCBjcmFzaCBhbmQgdGhlcmUgc2hvdWxkIGJlIGEgZ3JlZW4gc3F1YXJlIGJl bG93LgorCisKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZ3JhZGllbnRzL2NyYXNoLW9uLXJlbW92 ZS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZ3JhZGllbnRzL2NyYXNoLW9u LXJlbW92ZS5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9ncmFkaWVudHMv Y3Jhc2gtb24tcmVtb3ZlLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTYgQEAKKzxwPgor ICAgIFRlc3QgZm9yIDxpPjxhIGhyZWY9Imh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xODg3OSI+aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4 ODc5PC9hPgorICAgIFJlcHJvZHVjaWJsZSBjcmFzaCB3aGVuIHJlbW92aW5nIGEgZ3JhZGllbnQ8 L2k+LgorPC9wPgorPHA+CisgICAgVGhlIHRlc3Qgc2hvdWxkIG5vdCBjcmFzaCBhbmQgdGhlcmUg c2hvdWxkIGJlIGEgZ3JlZW4gc3F1YXJlIGJlbG93LgorPC9wPgorPGRpdiBpZD0idGFyZ2V0IiBz dHlsZT0id2lkdGg6IDEwMHB4OyBoZWlnaHQ6IDEwMHB4OyBiYWNrZ3JvdW5kLWNvbG9yOiBncmVl bjsgYmFja2dyb3VuZC1pbWFnZTogLXdlYmtpdC1ncmFkaWVudChsaW5lYXIsIGxlZnQgdG9wLCBs ZWZ0IGJvdHRvbSwgZnJvbShyZWQpLCB0byh0cmFuc3BhcmVudCkpIj4KKzwvZGl2PgorPHNjcmlw dD4KKyAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgICAgICBsYXlvdXRU ZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisKKyAgICBkb2N1bWVudC5ib2R5Lm9mZnNldFRv cDsKKyAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgidGFyZ2V0Iikuc3R5bGUucmVtb3ZlUHJv cGVydHkoImJhY2tncm91bmQtaW1hZ2UiKTsKKzwvc2NyaXB0Pgo=