188786 2018-08-21 05:08:09 -0700 [GStreamer] Extra ASSERTs at MainThreadNotifier 2018-09-06 03:51:32 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 calvaris calvaris cgarcia commit-queue ews-watchlist webkit-bug-importer oldest_to_newest 1452038 0 calvaris 2018-08-21 05:08:09 -0700 [GStreamer] Extra ASSERTs at MainThreadNotifier 1452039 1 347630 calvaris 2018-08-21 05:10:07 -0700 Created attachment 347630 Patch It looks like the MainThread notifier could have these two extra checks in debug mode. 1452041 2 ews-watchlist 2018-08-21 05:11:29 -0700 Attachment 347630 did not pass style-queue: ERROR: Source/WebCore/ChangeLog:9: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] ERROR: Source/WebCore/ChangeLog:10: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1452042 3 calvaris 2018-08-21 05:12:23 -0700 (In reply to Build Bot from comment #2) > ERROR: Source/WebCore/ChangeLog:9: Need whitespace between colon and > description [changelog/filechangedescriptionwhitespace] [5] > ERROR: Source/WebCore/ChangeLog:10: Need whitespace between colon and > description [changelog/filechangedescriptionwhitespace] [5] > Total errors found: 2 in 2 files Weird, local check said nothing... 1457016 4 349012 calvaris 2018-09-06 03:11:39 -0700 Created attachment 349012 Patch for landing 1457017 5 calvaris 2018-09-06 03:12:53 -0700 (In reply to Xabier Rodríguez Calvar from comment #3) > (In reply to Build Bot from comment #2) > > ERROR: Source/WebCore/ChangeLog:9: Need whitespace between colon and > > description [changelog/filechangedescriptionwhitespace] [5] > > ERROR: Source/WebCore/ChangeLog:10: Need whitespace between colon and > > description [changelog/filechangedescriptionwhitespace] [5] > > Total errors found: 2 in 2 files > > Weird, local check said nothing... Because style checks are done before opening the changelogs. 1457023 6 349012 commit-queue 2018-09-06 03:50:48 -0700 Comment on attachment 349012 Patch for landing Clearing flags on attachment: 349012 Committed r235732: <https://trac.webkit.org/changeset/235732> 1457024 7 commit-queue 2018-09-06 03:50:50 -0700 All reviewed patches have been landed. Closing bug. 1457025 8 webkit-bug-importer 2018-09-06 03:51:32 -0700 <rdar://problem/44176399> 347630 2018-08-21 05:10:07 -0700 2018-09-06 03:11:35 -0700 Patch bug-188786-20180821141006.patch text/plain 1795 calvaris U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1MTEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjdjZTY0MGQ0YWVmNzMz OWZkZGNjZjU5MjA1YjcxYTk4MzAwZmNkZC4uZmU5M2Y3OWE1YTI2M2U2OGI3MWExYzMyZWZmMGU4 YTRiMWY4M2NjMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTA4LTIxICBYYWJp ZXIgUm9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dT dHJlYW1lcl0gRXh0cmEgQVNTRVJUcyBhdCBNYWluVGhyZWFkTm90aWZpZXIKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4ODc4NgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIGFkZCBhIGNvdXBsZSBvZiBj aGVja3MgaW4gZGVidWcgbW9kZToKKyAgICAgICAgKiBUaGVyZSBpcyBvbmx5IG9uZSBiaXQgb24g cGVyIG5vdGlmaWNhdGlvbi4KKyAgICAgICAgKiBFbnN1cmUgYSBub3RpZmllciB3YXMgaW52YWxp ZGF0ZWQgYmVmb3JlIGJlaW5nIGRlc3Ryb3llZC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL2dzdHJlYW1lci9NYWluVGhyZWFkTm90aWZpZXIuaDoKKwogMjAxOC0wOC0yMSAgUGhpbGlw cGUgTm9ybWFuZCAgPHBoaWxuQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dTdHJlYW1lcl1bTVNF XSBHZW5lcmljIG1haW4gdGhyZWFkIG5vdGlmaWNhdGlvbiBzdXBwb3J0CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWFpblRocmVhZE5vdGlm aWVyLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWFpblRo cmVhZE5vdGlmaWVyLmgKaW5kZXggMzc1MmRjMjc1ZTcxOTU3OGViZjE5NTk2ZjRmYTZiZjJmYzg4 ZjliNS4uNWVhZGE2MzliOTkyOTNlMmJiYTNmZDE3YzgxZTI4NjM4YzU1ZmY3ZCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01haW5UaHJlYWRO b3RpZmllci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1l ci9NYWluVGhyZWFkTm90aWZpZXIuaApAQCAtMzUsMTAgKzM1LDE3IEBAIHB1YmxpYzoKICAgICAg ICAgcmV0dXJuIGFkb3B0UmVmKCpuZXcgTWFpblRocmVhZE5vdGlmaWVyKCkpOwogICAgIH0KIAor ICAgIH5NYWluVGhyZWFkTm90aWZpZXIoKQorICAgIHsKKyAgICAgICAgQVNTRVJUKCFtX2lzVmFs aWQubG9hZCgpKTsKKyAgICB9CisKICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBGPgogICAgIHZvaWQg bm90aWZ5KFQgbm90aWZpY2F0aW9uVHlwZSwgRiYmIGNhbGxiYWNrRnVuY3RvcikKICAgICB7CiAg ICAgICAgIEFTU0VSVChtX2lzVmFsaWQubG9hZCgpKTsKKyAgICAgICAgLy8gQXNzZXJ0IHRoYXQg dGhlcmUgaXMgb25seSBvbmUgYml0IG9uIGF0IGEgdGltZS4KKyAgICAgICAgQVNTRVJUKCEoc3Rh dGljX2Nhc3Q8aW50Pihub3RpZmljYXRpb25UeXBlKSAmIChzdGF0aWNfY2FzdDxpbnQ+KG5vdGlm aWNhdGlvblR5cGUpIC0gMSkpKTsKICAgICAgICAgaWYgKGlzTWFpblRocmVhZCgpKSB7CiAgICAg ICAgICAgICByZW1vdmVQZW5kaW5nTm90aWZpY2F0aW9uKG5vdGlmaWNhdGlvblR5cGUpOwogICAg ICAgICAgICAgY2FsbGJhY2tGdW5jdG9yKCk7Cg== 349012 2018-09-06 03:11:39 -0700 2018-09-06 03:50:48 -0700 Patch for landing bug-188786-20180906121138.patch text/plain 1807 calvaris U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1NjEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTdhNjJlYTg1NmI1YzBj YzQ0ZWM5ZjZmM2M5YmU2Nzk5Mzk0OWY0ZC4uZDJmMjdmNjk4ZDU2NGU0YjRkNWFkNTE3ZTFkNWY3 YzVjZDk3MjUyZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTA4LTIxICBYYWJp ZXIgUm9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dT dHJlYW1lcl0gRXh0cmEgQVNTRVJUcyBhdCBNYWluVGhyZWFkTm90aWZpZXIKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4ODc4NgorCisgICAgICAgIFJl dmlld2VkIGJ5IENhcmxvcyBHYXJjaWEgQ2FtcG9zLgorCisgICAgICAgIFdlIGFkZCBhIGNvdXBs ZSBvZiBjaGVja3MgaW4gZGVidWcgbW9kZTogdGhlcmUgaXMgb25seSBvbmUgYml0IG9uCisgICAg ICAgIHBlciBub3RpZmljYXRpb24gYW5kIGVuc3VyZSBhIG5vdGlmaWVyIHdhcyBpbnZhbGlkYXRl ZCBiZWZvcmUKKyAgICAgICAgYmVpbmcgZGVzdHJveWVkLgorCisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3MvZ3N0cmVhbWVyL01haW5UaHJlYWROb3RpZmllci5oOgorCiAyMDE4LTA5LTA0ICBZ YWNpbmUgQmFuZG91ICA8eWFjaW5lLmJhbmRvdV9leHRAc29mdGF0aG9tZS5jb20+CiAKICAgICAg ICAgW0VNRV0gQWRkIHRoZSBXZWJNIGluaXREYXRhIHN1cHBvcnQgaW4gQ2xlYXJLZXkgQ0RNCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWFp blRocmVhZE5vdGlmaWVyLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3Ry ZWFtZXIvTWFpblRocmVhZE5vdGlmaWVyLmgKaW5kZXggMzc1MmRjMjc1ZTcxOTU3OGViZjE5NTk2 ZjRmYTZiZjJmYzg4ZjliNS4uNWVhZGE2MzliOTkyOTNlMmJiYTNmZDE3YzgxZTI4NjM4YzU1ZmY3 ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVy L01haW5UaHJlYWROb3RpZmllci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2dzdHJlYW1lci9NYWluVGhyZWFkTm90aWZpZXIuaApAQCAtMzUsMTAgKzM1LDE3IEBAIHB1 YmxpYzoKICAgICAgICAgcmV0dXJuIGFkb3B0UmVmKCpuZXcgTWFpblRocmVhZE5vdGlmaWVyKCkp OwogICAgIH0KIAorICAgIH5NYWluVGhyZWFkTm90aWZpZXIoKQorICAgIHsKKyAgICAgICAgQVNT RVJUKCFtX2lzVmFsaWQubG9hZCgpKTsKKyAgICB9CisKICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBG PgogICAgIHZvaWQgbm90aWZ5KFQgbm90aWZpY2F0aW9uVHlwZSwgRiYmIGNhbGxiYWNrRnVuY3Rv cikKICAgICB7CiAgICAgICAgIEFTU0VSVChtX2lzVmFsaWQubG9hZCgpKTsKKyAgICAgICAgLy8g QXNzZXJ0IHRoYXQgdGhlcmUgaXMgb25seSBvbmUgYml0IG9uIGF0IGEgdGltZS4KKyAgICAgICAg QVNTRVJUKCEoc3RhdGljX2Nhc3Q8aW50Pihub3RpZmljYXRpb25UeXBlKSAmIChzdGF0aWNfY2Fz dDxpbnQ+KG5vdGlmaWNhdGlvblR5cGUpIC0gMSkpKTsKICAgICAgICAgaWYgKGlzTWFpblRocmVh ZCgpKSB7CiAgICAgICAgICAgICByZW1vdmVQZW5kaW5nTm90aWZpY2F0aW9uKG5vdGlmaWNhdGlv blR5cGUpOwogICAgICAgICAgICAgY2FsbGJhY2tGdW5jdG9yKCk7Cg==