188758 2018-08-20 14:28:34 -0700 WebKitTestRunner: Add watchOS entitlements 2018-08-27 15:40:08 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard commit-queue dbates lforschler thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1451742 0 jbedard 2018-08-20 14:28:34 -0700 Testing WebKit on watchOS requires some specific entitlements. 1451752 1 347547 jbedard 2018-08-20 14:43:42 -0700 Created attachment 347547 Patch 1451754 2 jbedard 2018-08-20 14:44:59 -0700 Talking with Tim Horton, while service workers are not supported on watchOS, in the event that they were supported in the future, someone would need to re-discover this entitlement, so I kept it. 1451783 3 347547 commit-queue 2018-08-20 16:10:27 -0700 Comment on attachment 347547 Patch Clearing flags on attachment: 347547 Committed r235099: <https://trac.webkit.org/changeset/235099> 1451784 4 commit-queue 2018-08-20 16:10:28 -0700 All reviewed patches have been landed. Closing bug. 1451811 5 webkit-bug-importer 2018-08-20 16:48:21 -0700 <rdar://problem/43534326> 1454062 6 dbates 2018-08-27 13:40:22 -0700 (In reply to Jonathan Bedard from comment #2) > Talking with Tim Horton, while service workers are not supported on watchOS, > in the event that they were supported in the future, someone would need to > re-discover this entitlement, so I kept it. We (the WebKit OpenSource Project and Apple) practice <https://en.wikipedia.org/wiki/You_aren%27t_gonna_need_it>: do not add functionality until deemed necessary. And this bug does just that. Adding "dead code" like what is being done in this patch hurts hackability and I suggest we revert <https://trac.webkit.org/changeset/235099>. The entitlement can be found by looking at <https://trac.webkit.org/browser/webkit/trunk/Tools/WebKitTestRunner/Configurations/WebKitTestRunnerApp-iOS.entitlements?rev=228589> or grepping ChangeLogs and blaming code to find the code changes associated with the bug #182865 , which added the entitlement. 1454063 7 dbates 2018-08-27 13:42:50 -0700 (In reply to Daniel Bates from comment #6) > (In reply to Jonathan Bedard from comment #2) > > Talking with Tim Horton, while service workers are not supported on watchOS, > > in the event that they were supported in the future, someone would need to > > re-discover this entitlement, so I kept it. > > We (the WebKit OpenSource Project and Apple) practice > <https://en.wikipedia.org/wiki/You_aren%27t_gonna_need_it>: do not add > functionality until deemed necessary. And this bug does just that. *And this bug does does the opposite: It adds functionality that is not necessary. 1454154 8 jbedard 2018-08-27 15:40:08 -0700 (In reply to Daniel Bates from comment #6) > (In reply to Jonathan Bedard from comment #2) > > Talking with Tim Horton, while service workers are not supported on watchOS, > > in the event that they were supported in the future, someone would need to > > re-discover this entitlement, so I kept it. > > We (the WebKit OpenSource Project and Apple) practice > <https://en.wikipedia.org/wiki/You_aren%27t_gonna_need_it>: do not add > functionality until deemed necessary. And this bug does just that. Adding > "dead code" like what is being done in this patch hurts hackability and I > suggest we revert <https://trac.webkit.org/changeset/235099>. The > entitlement can be found by looking at > <https://trac.webkit.org/browser/webkit/trunk/Tools/WebKitTestRunner/ > Configurations/WebKitTestRunnerApp-iOS.entitlements?rev=228589> or grepping > ChangeLogs and blaming code to find the code changes associated with the bug > #182865 , which added the entitlement. Do not revert <https://trac.webkit.org/changeset/235099>. There are two entitlements in that change, one which is most certainly being used. If you would like to remove the Service Workers entitlement, then upload a patch to do so. 347547 2018-08-20 14:43:42 -0700 2018-08-20 16:10:27 -0700 Patch bug-188758-20180820144341.patch text/plain 4467 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzNTA5NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDE4LTA4LTIwICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBXZWJLaXRUZXN0UnVubmVyOiBBZGQgd2F0Y2hPUyBlbnRpdGxlbWVudHMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4ODc1OAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHdhdGNoT1Mg bmVlZHMgYW4gYWRkaXRpb25hbCBlbnRpdGxlbWVudCB0byBvcGVuIHVwIGEgc29ja2V0IGZvciBv bi1kZXZpY2UgdGVzdGluZy4KKworICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvQ29uZmlndXJh dGlvbnMvV2ViS2l0VGVzdFJ1bm5lckFwcC13YXRjaE9TLmVudGl0bGVtZW50czogQWRkZWQuCisg ICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9Db25maWd1cmF0aW9ucy9XZWJLaXRUZXN0UnVubmVy QXBwLnhjY29uZmlnOgorICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvV2ViS2l0VGVzdFJ1bm5l ci54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qOgorCiAyMDE4LTA4LTIwICBUaG9tYXMgRGVubmV5 ICA8dGRlbm5leUBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkZWQgVGhvbWFzIERlbm5leSB0byBj b250cmlidXRvcnMuanNvbi4KSW5kZXg6IFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvQ29uZmlndXJh dGlvbnMvV2ViS2l0VGVzdFJ1bm5lckFwcC13YXRjaE9TLmVudGl0bGVtZW50cwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBUb29scy9XZWJLaXRUZXN0UnVubmVyL0NvbmZpZ3VyYXRpb25zL1dlYktpdFRlc3RSdW5u ZXJBcHAtd2F0Y2hPUy5lbnRpdGxlbWVudHMJKG5vbmV4aXN0ZW50KQorKysgVG9vbHMvV2ViS2l0 VGVzdFJ1bm5lci9Db25maWd1cmF0aW9ucy9XZWJLaXRUZXN0UnVubmVyQXBwLXdhdGNoT1MuZW50 aXRsZW1lbnRzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMTAgQEAKKzw/eG1sIHZlcnNpb249 IjEuMCIgZW5jb2Rpbmc9IlVURi04Ij8+Cis8IURPQ1RZUEUgcGxpc3QgUFVCTElDICItLy9BcHBs ZS8vRFREIFBMSVNUIDEuMC8vRU4iICJodHRwOi8vd3d3LmFwcGxlLmNvbS9EVERzL1Byb3BlcnR5 TGlzdC0xLjAuZHRkIj4KKzxwbGlzdCB2ZXJzaW9uPSIxLjAiPgorPGRpY3Q+CisJPGtleT5jb20u YXBwbGUuc2VjdXJpdHkubmV0d29yay5jbGllbnQ8L2tleT4KKwk8dHJ1ZS8+CisJPGtleT5jb20u YXBwbGUuZGV2ZWxvcGVyLldlYktpdC5TZXJ2aWNlV29ya2Vyczwva2V5PgorCTx0cnVlLz4KKzwv ZGljdD4KKzwvcGxpc3Q+CkluZGV4OiBUb29scy9XZWJLaXRUZXN0UnVubmVyL0NvbmZpZ3VyYXRp b25zL1dlYktpdFRlc3RSdW5uZXJBcHAueGNjb25maWcKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvV2Vi S2l0VGVzdFJ1bm5lci9Db25maWd1cmF0aW9ucy9XZWJLaXRUZXN0UnVubmVyQXBwLnhjY29uZmln CShyZXZpc2lvbiAyMzUwOTQpCisrKyBUb29scy9XZWJLaXRUZXN0UnVubmVyL0NvbmZpZ3VyYXRp b25zL1dlYktpdFRlc3RSdW5uZXJBcHAueGNjb25maWcJKHdvcmtpbmcgY29weSkKQEAgLTQxLDMg KzQxLDQgQEAgRVhDTFVERURfU09VUkNFX0ZJTEVfTkFNRVNbc2RrPXdhdGNoKl0gPQogVEFSR0VU RURfREVWSUNFX0ZBTUlMWSA9IDEsMiw0OwogCiBDT0RFX1NJR05fRU5USVRMRU1FTlRTW3Nkaz1p cGhvbmUqXSA9IENvbmZpZ3VyYXRpb25zL1dlYktpdFRlc3RSdW5uZXJBcHAtaU9TLmVudGl0bGVt ZW50czsKK0NPREVfU0lHTl9FTlRJVExFTUVOVFNbc2RrPXdhdGNoKl0gPSBDb25maWd1cmF0aW9u cy9XZWJLaXRUZXN0UnVubmVyQXBwLXdhdGNoT1MuZW50aXRsZW1lbnRzOwpJbmRleDogVG9vbHMv V2ViS2l0VGVzdFJ1bm5lci9XZWJLaXRUZXN0UnVubmVyLnhjb2RlcHJvai9wcm9qZWN0LnBieHBy b2oKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9XZWJLaXRUZXN0UnVubmVy Lnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oJKHJldmlzaW9uIDIzNTA5NCkKKysrIFRvb2xzL1dl YktpdFRlc3RSdW5uZXIvV2ViS2l0VGVzdFJ1bm5lci54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9q CSh3b3JraW5nIGNvcHkpCkBAIC0yNzUsNiArMjc1LDcgQEAKIAkJMkVFNTJEMTQxODkwQTlGQjAw MTBFRDIxIC8qIFRlc3RDb250cm9sbGVySU9TLm1tICovID0ge2lzYSA9IFBCWEZpbGVSZWZlcmVu Y2U7IGZpbGVFbmNvZGluZyA9IDQ7IGxhc3RLbm93bkZpbGVUeXBlID0gc291cmNlY29kZS5jcHAu b2JqY3BwOyBwYXRoID0gVGVzdENvbnRyb2xsZXJJT1MubW07IHNvdXJjZVRyZWUgPSAiPGdyb3Vw PiI7IH07CiAJCTJFRTUyRDE2MTg5MEE5RkIwMDEwRUQyMSAvKiBtYWluSU9TLm1tICovID0ge2lz YSA9IFBCWEZpbGVSZWZlcmVuY2U7IGZpbGVFbmNvZGluZyA9IDQ7IGxhc3RLbm93bkZpbGVUeXBl ID0gc291cmNlY29kZS5jcHAub2JqY3BwOyBuYW1lID0gbWFpbklPUy5tbTsgcGF0aCA9IC4uL2lv cy9tYWluSU9TLm1tOyBzb3VyY2VUcmVlID0gIjxncm91cD4iOyB9OwogCQkzMTEwQkUwRjE1QkEw MTE0MDBEMjE2QUMgLyogV2ViTm90aWZpY2F0aW9uUHJvdmlkZXIuaCAqLyA9IHtpc2EgPSBQQlhG aWxlUmVmZXJlbmNlOyBsYXN0S25vd25GaWxlVHlwZSA9IHNvdXJjZWNvZGUuYy5oOyBwYXRoID0g V2ViTm90aWZpY2F0aW9uUHJvdmlkZXIuaDsgc291cmNlVHJlZSA9ICI8Z3JvdXA+IjsgfTsKKwkJ MzExMTgzQUEyMTJCMUFDNzAwNzdCQ0UwIC8qIFdlYktpdFRlc3RSdW5uZXJBcHAtd2F0Y2hPUy5l bnRpdGxlbWVudHMgKi8gPSB7aXNhID0gUEJYRmlsZVJlZmVyZW5jZTsgZmlsZUVuY29kaW5nID0g NDsgbGFzdEtub3duRmlsZVR5cGUgPSB0ZXh0LnBsaXN0LmVudGl0bGVtZW50czsgcGF0aCA9ICJX ZWJLaXRUZXN0UnVubmVyQXBwLXdhdGNoT1MuZW50aXRsZW1lbnRzIjsgc291cmNlVHJlZSA9ICI8 Z3JvdXA+IjsgfTsKIAkJMzEyNjhFQjkxRUYwNkEzQjAwMTk2M0UyIC8qIFVJS2l0VGVzdFNQSS5o ICovID0ge2lzYSA9IFBCWEZpbGVSZWZlcmVuY2U7IGZpbGVFbmNvZGluZyA9IDQ7IGxhc3RLbm93 bkZpbGVUeXBlID0gc291cmNlY29kZS5jLmg7IG5hbWUgPSBVSUtpdFRlc3RTUEkuaDsgcGF0aCA9 IC4uL1Rlc3RSdW5uZXJTaGFyZWQvc3BpL1VJS2l0VGVzdFNQSS5oOyBzb3VyY2VUcmVlID0gIjxn cm91cD4iOyB9OwogCQkzMTQ4QTA1MzFFNkY4NUI2MDBEM0IzMTYgLyogSU9TTGF5b3V0VGVzdENv bW11bmljYXRpb24uY3BwICovID0ge2lzYSA9IFBCWEZpbGVSZWZlcmVuY2U7IGZpbGVFbmNvZGlu ZyA9IDQ7IGxhc3RLbm93bkZpbGVUeXBlID0gc291cmNlY29kZS5jcHAuY3BwOyBuYW1lID0gSU9T TGF5b3V0VGVzdENvbW11bmljYXRpb24uY3BwOyBwYXRoID0gLi4vVGVzdFJ1bm5lclNoYXJlZC9J T1NMYXlvdXRUZXN0Q29tbXVuaWNhdGlvbi5jcHA7IHNvdXJjZVRyZWUgPSAiPGdyb3VwPiI7IH07 CiAJCTMxNDhBMDU0MUU2Rjg1QjYwMEQzQjMxNiAvKiBJT1NMYXlvdXRUZXN0Q29tbXVuaWNhdGlv bi5oICovID0ge2lzYSA9IFBCWEZpbGVSZWZlcmVuY2U7IGZpbGVFbmNvZGluZyA9IDQ7IGxhc3RL bm93bkZpbGVUeXBlID0gc291cmNlY29kZS5jLmg7IG5hbWUgPSBJT1NMYXlvdXRUZXN0Q29tbXVu aWNhdGlvbi5oOyBwYXRoID0gLi4vVGVzdFJ1bm5lclNoYXJlZC9JT1NMYXlvdXRUZXN0Q29tbXVu aWNhdGlvbi5oOyBzb3VyY2VUcmVlID0gIjxncm91cD4iOyB9OwpAQCAtNzY3LDYgKzc2OCw3IEBA CiAJCQkJQkMyNTE5NzExMUQxNUU2MTAwMkVCQzAxIC8qIEluamVjdGVkQnVuZGxlLnhjY29uZmln ICovLAogCQkJCUExODUxMDM4MUI5QURGMjIwMDc0NEFFQiAvKiBXZWJLaXRUZXN0UnVubmVyLnhj Y29uZmlnICovLAogCQkJCTlCMEQxMzJFMjAzNkQzNDYwMDhGQzhGQiAvKiBXZWJLaXRUZXN0UnVu bmVyQXBwLWlPUy5lbnRpdGxlbWVudHMgKi8sCisJCQkJMzExMTgzQUEyMTJCMUFDNzAwNzdCQ0Uw IC8qIFdlYktpdFRlc3RSdW5uZXJBcHAtd2F0Y2hPUy5lbnRpdGxlbWVudHMgKi8sCiAJCQkJQTE4 NTEwMzkxQjlBREZGODAwNzQ0QUVCIC8qIFdlYktpdFRlc3RSdW5uZXJBcHAueGNjb25maWcgKi8s CiAJCQkJQkMyNTFBMTgxMUQxNjc5NTAwMkVCQzAxIC8qIFdlYktpdFRlc3RSdW5uZXJMaWJyYXJ5 LnhjY29uZmlnICovLAogCQkJKTsK