<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>188718</bug_id>
          
          <creation_ts>2018-08-17 20:57:44 -0700</creation_ts>
          <short_desc>run-webkit-tests triggers a python error if building DumpRenderTree produces non-ASCII output</short_desc>
          <delta_ts>2018-11-30 16:19:56 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>192260</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Simon Fraser (smfr)">simon.fraser</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>ap</cc>
    
    <cc>jbedard</cc>
    
    <cc>lforschler</cc>
    
    <cc>simon.fraser</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1451337</commentid>
    <comment_count>0</comment_count>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2018-08-17 20:57:44 -0700</bug_when>
    <thetext>If I make a change to DumpRenderTree that fails to compile, and have an iPhone plugged into my computer, xcodebuild can dump non-ASCII stuff like &quot;2018-08-17 20:55:52.550 xcodebuild[30152:213122]  iPhoneConnect: 📱&lt;TheX, iPhone, 12.0...&quot; and then webkitpy fails trying to show that:

UnicodeEncodeError raised: &apos;ascii&apos; codec can&apos;t encode character u&apos;\u2019&apos; in position 1694: ordinal not in range(128)
Traceback (most recent call last):
  File &quot;/Volumes/Data/Development/apple/webkit/OpenSource/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py&quot;, line 85, in main
    run_details = run(port, options, args, stderr)
  File &quot;/Volumes/Data/Development/apple/webkit/OpenSource/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py&quot;, line 449, in run
    run_details = manager.run(args)
  File &quot;/Volumes/Data/Development/apple/webkit/OpenSource/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py&quot;, line 246, in run
    if not self._set_up_run(tests_to_run):
  File &quot;/Volumes/Data/Development/apple/webkit/OpenSource/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py&quot;, line 164, in _set_up_run
    if not self._port.check_build():
  File &quot;/Volumes/Data/Development/apple/webkit/OpenSource/Tools/Scripts/webkitpy/port/base.py&quot;, line 230, in check_build
    if not self._root_was_set and self.get_option(&apos;build&apos;) and not self._build_driver():
  File &quot;/Volumes/Data/Development/apple/webkit/OpenSource/Tools/Scripts/webkitpy/port/base.py&quot;, line 1500, in _build_driver
    _log.error(e.message_with_output(output_limit=None))
  File &quot;/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/logging/__init__.py&quot;, line 1191, in error
    self._log(ERROR, msg, args, **kwargs)
  File &quot;/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/logging/__init__.py&quot;, line 1284, in _log
    self.handle(record)
  File &quot;/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/logging/__init__.py&quot;, line 1294, in handle
    self.callHandlers(record)
  File &quot;/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/logging/__init__.py&quot;, line 1334, in callHandlers
    hdlr.handle(record)
  File &quot;/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/logging/__init__.py&quot;, line 757, in handle
    self.emit(record)
  File &quot;/Volumes/Data/Development/apple/webkit/OpenSource/Tools/Scripts/webkitpy/layout_tests/views/metered_stream.py&quot;, line 142, in emit
    self._meter.writeln(record.getMessage(), record.created, record.process)
  File &quot;/Volumes/Data/Development/apple/webkit/OpenSource/Tools/Scripts/webkitpy/layout_tests/views/metered_stream.py&quot;, line 118, in writeln
    self.write(self._ensure_newline(txt), now, pid)
  File &quot;/Volumes/Data/Development/apple/webkit/OpenSource/Tools/Scripts/webkitpy/layout_tests/views/metered_stream.py&quot;, line 111, in write
    msg = &apos;{}{}&apos;.format(timestamp_string, txt)
UnicodeEncodeError: &apos;ascii&apos; codec can&apos;t encode character u&apos;\u2019&apos; in position 1694: ordinal not in range(128)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1451394</commentid>
    <comment_count>1</comment_count>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2018-08-18 10:45:38 -0700</bug_when>
    <thetext>This might not be triggered by the iPhone emoji; it might be the filter-build-webkit stuff since I have org.webkit.BuildConfiguration BuildTranscriptVerbosity set to &quot;Quiet&quot;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1483825</commentid>
    <comment_count>2</comment_count>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2018-11-30 16:19:44 -0800</bug_when>
    <thetext>Was looking through my old bugs and found this...I&apos;m forward duping to &lt;https://bugs.webkit.org/show_bug.cgi?id=192260&gt;, since that has the fix for this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1483826</commentid>
    <comment_count>3</comment_count>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2018-11-30 16:19:56 -0800</bug_when>
    <thetext>

*** This bug has been marked as a duplicate of bug 192260 ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>