188710 2018-08-17 15:55:15 -0700 Remove Adobe SSO exception now that StorageAccess API is available 2018-08-17 17:09:41 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 174533 174691 1 bfulgham bfulgham achristensen bfulgham cdumez commit-queue dbates ews-watchlist japhet wilander oldest_to_newest 1451252 0 bfulgham 2018-08-17 15:55:15 -0700 In Bug 174533 (revised in Bug 174691) we added a site-specific hack for Adobe SSO authentication to support TV providers. Since that time, we have implemented the StorageAccess API, which provides the ability to perform proper sharing of web data without requiring site-specific hacks. This patch removes the site-specific quirk to simplify loading code and remove maintenance burden. 1451253 1 347402 bfulgham 2018-08-17 15:58:26 -0700 Created attachment 347402 Patch 1451257 2 bfulgham 2018-08-17 15:59:21 -0700 <rdar://problem/35056707> 1451289 3 347402 commit-queue 2018-08-17 17:09:39 -0700 Comment on attachment 347402 Patch Clearing flags on attachment: 347402 Committed r235000: <https://trac.webkit.org/changeset/235000> 1451290 4 commit-queue 2018-08-17 17:09:41 -0700 All reviewed patches have been landed. Closing bug. 347402 2018-08-17 15:58:26 -0700 2018-08-17 17:09:39 -0700 Patch bug-188710-20180817155825.patch text/plain 2461 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0NzE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWE3ZGU2NWVmMTE1OThk ZDRiZWNhYjVjNDY1NDIyOTJhZTFiZDRmMS4uMjY4MDRkNGNkMGJjNDgwZmEwZTIyODVmN2E5YWJk YmExMDljNWE1MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE4LTA4LTE3ICBCcmVu dCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFJlbW92ZSBBZG9iZSBT U08gZXhjZXB0aW9uIG5vdyB0aGF0IFN0b3JhZ2VBY2Nlc3MgQVBJIGlzIGF2YWlsYWJsZQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg4NzEwCisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS8zNTA1NjcwNz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgY3VzdG9tIHF1aXJrIG5vdyB0aGF0IHByb3Bl ciBBUEkgZXhpc3RzIHRvIGFsbG93IHRoZSBzYW1lIGZ1bmN0aW9ucy4KKworICAgICAgICAqIGxv YWRlci9SZXNvdXJjZUxvYWRPYnNlcnZlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJj ZUxvYWRPYnNlcnZlcjo6bG9nU3VicmVzb3VyY2VMb2FkaW5nKTogUmVtb3ZlIHVubmVlZGVkIHF1 aXJrLgorICAgICAgICAoV2ViQ29yZTo6cmVzb3VyY2VOZWVkc1NTT1F1aXJrKTogRGVsZXRlZC4K KwogMjAxOC0wOC0wOCAgRG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0ZWFkQHNvbnkuY29tPgogCiAg ICAgICAgIFtOaWNvc2lhXSBBZGQgdGhlIE5pY29zaWEtc3BlY2lmaWMgUGxhdGZvcm1MYXllciB0 eXBlIGFsaWFzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvUmVzb3VyY2VMb2Fk T2JzZXJ2ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL1Jlc291cmNlTG9hZE9ic2VydmVy LmNwcAppbmRleCA4Yjk4MzZlMWNlMTI3MTRiZWQyYjZjMmNhZTI2ZjFmYTc4YzlhODU2Li41MTFi OTEyYTI1NDBjMzkyNjMwNGFiZWRjYjhlYzA0NTQwMjE3MDkyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9sb2FkZXIvUmVzb3VyY2VMb2FkT2JzZXJ2ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL2xvYWRlci9SZXNvdXJjZUxvYWRPYnNlcnZlci5jcHAKQEAgLTEwNCwxNSArMTA0LDYgQEAg Ym9vbCBSZXNvdXJjZUxvYWRPYnNlcnZlcjo6c2hvdWxkTG9nKFBhZ2UqIHBhZ2UpIGNvbnN0CiAg ICAgcmV0dXJuIERlcHJlY2F0ZWRHbG9iYWxTZXR0aW5nczo6cmVzb3VyY2VMb2FkU3RhdGlzdGlj c0VuYWJsZWQoKSAmJiAhcGFnZS0+dXNlc0VwaGVtZXJhbFNlc3Npb24oKSAmJiBtX25vdGlmaWNh dGlvbkNhbGxiYWNrOwogfQogCi0vLyBGSVhNRTogVGhpcyBxdWlyayB3YXMgYWRkZWQgdG8gYWRk cmVzcyA8cmRhcjovL3Byb2JsZW0vMzMzMjU4ODE+IGFuZCBzaG91bGQgYmUgcmVtb3ZlZCBvbmNl IGNvbnRlbnQgaXMgZml4ZWQuCi1zdGF0aWMgYm9vbCByZXNvdXJjZU5lZWRzU1NPUXVpcmsoUGFn ZSogcGFnZSwgY29uc3QgVVJMJiB1cmwpCi17Ci0gICAgaWYgKCFzaG91bGRFbmFibGVTaXRlU3Bl Y2lmaWNRdWlya3MocGFnZSkpCi0gICAgICAgIHJldHVybiBmYWxzZTsKLQotICAgIHJldHVybiBl cXVhbElnbm9yaW5nQVNDSUlDYXNlKHVybC5ob3N0KCksICJzcC5hdXRoLmFkb2JlLmNvbSIpOwot fQotCiB2b2lkIFJlc291cmNlTG9hZE9ic2VydmVyOjpsb2dTdWJyZXNvdXJjZUxvYWRpbmcoY29u c3QgRnJhbWUqIGZyYW1lLCBjb25zdCBSZXNvdXJjZVJlcXVlc3QmIG5ld1JlcXVlc3QsIGNvbnN0 IFJlc291cmNlUmVzcG9uc2UmIHJlZGlyZWN0UmVzcG9uc2UpCiB7CiAgICAgQVNTRVJUKGZyYW1l LT5wYWdlKCkpOwpAQCAtMTM5LDkgKzEzMCw2IEBAIHZvaWQgUmVzb3VyY2VMb2FkT2JzZXJ2ZXI6 OmxvZ1N1YnJlc291cmNlTG9hZGluZyhjb25zdCBGcmFtZSogZnJhbWUsIGNvbnN0IFJlc291CiAg ICAgaWYgKGFyZURvbWFpbnNBc3NvY2lhdGVkKHBhZ2UsIHRhcmdldFByaW1hcnlEb21haW4sIG1h aW5GcmFtZVByaW1hcnlEb21haW4pIHx8IChpc1JlZGlyZWN0ICYmIGFyZURvbWFpbnNBc3NvY2lh dGVkKHBhZ2UsIHRhcmdldFByaW1hcnlEb21haW4sIHNvdXJjZVByaW1hcnlEb21haW4pKSkKICAg ICAgICAgcmV0dXJuOwogCi0gICAgaWYgKHJlc291cmNlTmVlZHNTU09RdWlyayhwYWdlLCB0YXJn ZXRVUkwpKQotICAgICAgICByZXR1cm47Ci0KICAgICBib29sIHNob3VsZENhbGxOb3RpZmljYXRp b25DYWxsYmFjayA9IGZhbHNlOwogICAgIHsKICAgICAgICAgYXV0byYgdGFyZ2V0U3RhdGlzdGlj cyA9IGVuc3VyZVJlc291cmNlU3RhdGlzdGljc0ZvclByaW1hcnlEb21haW4odGFyZ2V0UHJpbWFy eURvbWFpbik7Cg==