18868 2008-05-03 01:35:49 -0700 SQUIRRELFISH: window.this shows up as a property, but it shouldn't 2008-05-06 20:58:16 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 18631 1 mjs mjs oldest_to_newest 79558 0 mjs 2008-05-03 01:35:49 -0700 "this" appears as a property of the window object to enumeration and lookup as "window.this", but it should not. This is likely a side effect of us treating it as a special local/global var. 79719 1 ggaren 2008-05-05 20:52:33 -0700 I think we should remove "this" from the symbol table after codegen. 79786 2 20995 mjs 2008-05-06 20:14:37 -0700 Created attachment 20995 don't keep "this" in the symbol table at runtime 79787 3 20995 oliver 2008-05-06 20:23:05 -0700 Comment on attachment 20995 don't keep "this" in the symbol table at runtime r=me, with the aswsertion changes we discussed 20995 2008-05-06 20:14:37 -0700 2008-05-06 20:23:05 -0700 don't keep "this" in the symbol table at runtime this-patch.txt text/plain 3385 mjs SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDMyOTM2 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMDgtMDUt MDYgIE1hY2llaiBTdGFjaG93aWFrICA8bWpzQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIC0gZml4ZWQgIlNRVUlSUkVM RklTSDogd2luZG93LnRoaXMgc2hvd3MgdXAgYXMgYSBwcm9wZXJ0eSwgYnV0IGl0IHNob3VsZG4n dCIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4ODY4 CisgICAgICAgIAorICAgICAgICBUaGUgYmFzaWMgYXBwcm9hY2ggaXMgdG8gaGF2ZSAidGhpcyIg b25seSBiZSBwcmVzZW50IGluIHRoZSBzeW1ib2wKKyAgICAgICAgdGFibGUgYXQgY29tcGlsZSB0 aW1lLCBub3QgcnVudGltZS4KKworICAgICAgICAqIFZNL0NvZGVHZW5lcmF0b3IuY3BwOgorICAg ICAgICAoS0pTOjpDb2RlR2VuZXJhdG9yOjp+Q29kZUdlbmVyYXRvcik6IFJlbW92ZSAidGhpcyIg ZnJvbSBzeW1ib2wgdGFibGUuCisgICAgICAgIChLSlM6OkNvZGVHZW5lcmF0b3I6OkNvZGVHZW5l cmF0b3IpOiBBZGQgInRoaXMiIGJhY2sgd2hlbiByZS11c2luZworICAgICAgICBhIHN5bWJvbCB0 YWJsZS4KKyAgICAgICAgKiBWTS9Db2RlR2VuZXJhdG9yLmg6CisgICAgICAgICogVk0vTWFjaGlu ZS5jcHA6CisgICAgICAgIChLSlM6Ok1hY2hpbmU6OmV4ZWN1dGUpOiBEb24ndCBhc3NlcnQgdGhh dCAidGhpcyIgaXMgaW4gdGhlIHN5bWJvbCB0YWJsZS4KKwogMjAwOC0wNS0wNiAgR2VvZmZyZXkg R2FyZW4gIDxnZ2FyZW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE9saXZlciBI dW50LgpJbmRleDogVk0vQ29kZUdlbmVyYXRvci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVk0vQ29kZUdl bmVyYXRvci5jcHAJKHJldmlzaW9uIDMyOTM1KQorKysgVk0vQ29kZUdlbmVyYXRvci5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTE3Miw4ICsxNzIsMTAgQEAgQ29kZUdlbmVyYXRvcjo6Q29kZUdlbmVy YXRvcihQcm9ncmFtTm9kZQogewogICAgIC8vIEdsb2JhbCBjb2RlIGNhbiBpbmhlcml0IHByZXZp b3VzbHkgZGVmaW5lZCBzeW1ib2xzLgogICAgIGlmIChpbnQgc2l6ZSA9IHN5bWJvbFRhYmxlLT5z aXplKCkpIHsKLSAgICAgICAgQVNTRVJUKHN5bWJvbFRhYmxlLT5jb250YWlucyhtX3Byb3BlcnR5 TmFtZXMtPnRoaXNJZGVudGlmaWVyLnVzdHJpbmcoKS5yZXAoKSkpOwotICAgICAgICAKKyAgICAg ICAgLy8gcmUtYWRkICJ0aGlzIiB0byBzeW1ib2wgdGFibGUKKyAgICAgICAgc3ltYm9sVGFibGUt PmFkZChtX3Byb3BlcnR5TmFtZXMtPnRoaXNJZGVudGlmaWVyLnVzdHJpbmcoKS5yZXAoKSwgTWFj aGluZTo6UHJvZ3JhbUNvZGVUaGlzUmVnaXN0ZXIpOworICAgICAgICBzaXplICs9IDE7CisKICAg ICAgICAgLy8gQWRkIHByZXZpb3VzbHkgZGVmaW5lZCBzeW1ib2xzIHRvIGJvb2trZWVwaW5nLgog ICAgICAgICBtX2xvY2Fscy5yZXNpemUoc2l6ZSk7CiAgICAgICAgIFN5bWJvbFRhYmxlOjppdGVy YXRvciBlbmQgPSBzeW1ib2xUYWJsZS0+ZW5kKCk7CkBAIC0yNzksNiArMjgxLDEyIEBAIENvZGVH ZW5lcmF0b3I6OkNvZGVHZW5lcmF0b3IoRXZhbE5vZGUqIGUKICAgICB9CiB9CiAKK0NvZGVHZW5l cmF0b3I6On5Db2RlR2VuZXJhdG9yKCkKK3sKKyAgICAvLyByZW1vdmUgInRoaXMiIGZyb20gc3lt Ym9sIHRhYmxlIHNvIGl0IGRvZXMgbm90IGFwcGVhciBhcyBhIGdsb2JhbCBvYmplY3QgcHJvcGVy dHkgYXQgcnVudGltZQorICAgIHN5bWJvbFRhYmxlKCkucmVtb3ZlKG1fcHJvcGVydHlOYW1lcy0+ dGhpc0lkZW50aWZpZXIudXN0cmluZygpLnJlcCgpKTsKK30KKwogdm9pZCBDb2RlR2VuZXJhdG9y OjphZGRQYXJhbWV0ZXIoY29uc3QgSWRlbnRpZmllciYgaWRlbnQpCiB7CiAgICAgLy8gUGFyYW1l dGVycyBvdmVyd3JpdGUgdmFyIGRlY2xhcmF0aW9ucywgYnV0IG5vdCBmdW5jdGlvbiBkZWNsYXJh dGlvbnMsCkluZGV4OiBWTS9Db2RlR2VuZXJhdG9yLmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVk0vQ29kZUdl bmVyYXRvci5oCShyZXZpc2lvbiAzMjkzNSkKKysrIFZNL0NvZGVHZW5lcmF0b3IuaAkod29ya2lu ZyBjb3B5KQpAQCAtNzgsNiArNzgsOCBAQCBuYW1lc3BhY2UgS0pTIHsKICAgICAgICAgQ29kZUdl bmVyYXRvcihGdW5jdGlvbkJvZHlOb2RlKiwgY29uc3QgU2NvcGVDaGFpbiYsIFN5bWJvbFRhYmxl KiwgQ29kZUJsb2NrKiwgVmFyU3RhY2smLCBGdW5jdGlvblN0YWNrJiwgVmVjdG9yPElkZW50aWZp ZXI+JiBwYXJhbWV0ZXJzKTsKICAgICAgICAgQ29kZUdlbmVyYXRvcihFdmFsTm9kZSosIGNvbnN0 IFNjb3BlQ2hhaW4mLCBTeW1ib2xUYWJsZSosIEV2YWxDb2RlQmxvY2sqLCBWYXJTdGFjayYsIEZ1 bmN0aW9uU3RhY2smIGZ1bmN0aW9uU3RhY2spOwogCisgICAgICAgIH5Db2RlR2VuZXJhdG9yKCk7 CisKICAgICAgICAgY29uc3QgQ29tbW9uSWRlbnRpZmllcnMmIHByb3BlcnR5TmFtZXMoKSBjb25z dCB7IHJldHVybiAqbV9wcm9wZXJ0eU5hbWVzOyB9CiAKICAgICAgICAgdm9pZCBnZW5lcmF0ZSgp OwpJbmRleDogVk0vTWFjaGluZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVk0vTWFjaGluZS5jcHAJKHJl dmlzaW9uIDMyOTM1KQorKysgVk0vTWFjaGluZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU2Niw3 ICs1NjYsNiBAQCBKU1ZhbHVlKiBNYWNoaW5lOjpleGVjdXRlKFByb2dyYW1Ob2RlKiBwCiAgICAg cmVnaXN0ZXJGaWxlLT51bmNoZWNrZWRHcm93KGNvZGVCbG9jay0+bnVtVGVtcG9yYXJpZXMpOwog ICAgIFJlZ2lzdGVyKiByID0gKCpyZWdpc3RlckZpbGUtPmJhc2VQb2ludGVyKCkpOwogCi0gICAg QVNTRVJUKGV4ZWMtPmR5bmFtaWNHbG9iYWxPYmplY3QoKS0+c3ltYm9sVGFibGUoKS5nZXQoQ29t bW9uSWRlbnRpZmllcnM6OnNoYXJlZCgpLT50aGlzSWRlbnRpZmllci51c3RyaW5nKCkucmVwKCkp LmluZGV4ID09IFByb2dyYW1Db2RlVGhpc1JlZ2lzdGVyKTsKICAgICByW1Byb2dyYW1Db2RlVGhp c1JlZ2lzdGVyXS51LmpzVmFsdWUgPSB0aGlzT2JqOwogICAgIAogICAgIGlmIChjb2RlQmxvY2st Pm5lZWRzRnVsbFNjb3BlQ2hhaW4pCg==