188663 2018-08-16 11:11:44 -0700 Transition more WKWebViewConfiguration ivars to API::PageConfiguration values 2018-08-23 14:31:29 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified REOPENED InRadar P2 Normal --- 1 achristensen achristensen ryanhaddad simon.fraser thorton webkit-bug-importer oldest_to_newest 1450749 0 achristensen 2018-08-16 11:11:44 -0700 Transition more WKWebViewConfiguration ivars to API::PageConfiguration values 1450750 1 347275 achristensen 2018-08-16 11:11:59 -0700 Created attachment 347275 Patch 1450752 2 achristensen 2018-08-16 11:19:32 -0700 http://trac.webkit.org/r234942 1450754 3 webkit-bug-importer 2018-08-16 11:21:02 -0700 <rdar://problem/43389584> 1453222 4 ryanhaddad 2018-08-23 14:31:29 -0700 Reverted r234942 for reason: Caused page loading issues in iTunes Committed r235247: <https://trac.webkit.org/changeset/235247> 347275 2018-08-16 11:11:59 -0700 2018-08-16 11:18:20 -0700 Patch bug-188663-20180816111158.patch text/plain 6773 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzQ5NDEpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE4LTA4LTE2ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgVHJhbnNpdGlvbiBt b3JlIFdLV2ViVmlld0NvbmZpZ3VyYXRpb24gaXZhcnMgdG8gQVBJOjpQYWdlQ29uZmlndXJhdGlv biB2YWx1ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE4ODY2MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW06CisgICAgICAgICgtW1dLV2ViVmll dyBfaW5pdGlhbGl6ZVdpdGhDb25maWd1cmF0aW9uOl0pOgorICAgICAgICAqIFVJUHJvY2Vzcy9B UEkvQ29jb2EvV0tXZWJWaWV3Q29uZmlndXJhdGlvbi5tbToKKyAgICAgICAgKC1bV0tXZWJWaWV3 Q29uZmlndXJhdGlvbiBpbml0XSk6CisgICAgICAgICgtW1dLV2ViVmlld0NvbmZpZ3VyYXRpb24g Y29weVdpdGhab25lOl0pOgorICAgICAgICAoLVtXS1dlYlZpZXdDb25maWd1cmF0aW9uIF9kcmF3 c0JhY2tncm91bmRdKToKKyAgICAgICAgKC1bV0tXZWJWaWV3Q29uZmlndXJhdGlvbiBfc2V0RHJh d3NCYWNrZ3JvdW5kOl0pOgorICAgICAgICAoLVtXS1dlYlZpZXdDb25maWd1cmF0aW9uIF93YWl0 c0ZvclBhaW50QWZ0ZXJWaWV3RGlkTW92ZVRvV2luZG93XSk6CisgICAgICAgICgtW1dLV2ViVmll d0NvbmZpZ3VyYXRpb24gX3NldFdhaXRzRm9yUGFpbnRBZnRlclZpZXdEaWRNb3ZlVG9XaW5kb3c6 XSk6CisgICAgICAgICgtW1dLV2ViVmlld0NvbmZpZ3VyYXRpb24gX2lzQ29udHJvbGxlZEJ5QXV0 b21hdGlvbl0pOgorICAgICAgICAoLVtXS1dlYlZpZXdDb25maWd1cmF0aW9uIF9zZXRDb250cm9s bGVkQnlBdXRvbWF0aW9uOl0pOgorCiAyMDE4LTA4LTE2ICBBbGV4IENocmlzdGVuc2VuICA8YWNo cmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgU3RvcCB1c2luZyBjYW5BdXRoZW50aWNh dGVBZ2FpbnN0UHJvdGVjdGlvblNwYWNlIGluIG1vZGVybiBXZWJLaXQKSW5kZXg6IFNvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0KPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbQkocmV2aXNpb24gMjM0 OTM5KQorKysgU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbQko d29ya2luZyBjb3B5KQpAQCAtNTM4LDkgKzUzOCw2IEBAIC0gKHZvaWQpX2luaXRpYWxpemVXaXRo Q29uZmlndXJhdGlvbjooV0sKICAgICBwYWdlQ29uZmlndXJhdGlvbi0+cHJlZmVyZW5jZVZhbHVl cygpLnNldChXZWJLaXQ6OldlYlByZWZlcmVuY2VzS2V5OjpzaG91bGRDb252ZXJ0UG9zaXRpb25T dHlsZU9uQ29weUtleSgpLCBXZWJLaXQ6OldlYlByZWZlcmVuY2VzU3RvcmU6OlZhbHVlKCEhW19j b25maWd1cmF0aW9uIF9jb252ZXJ0c1Bvc2l0aW9uU3R5bGVPbkNvcHldKSk7CiAgICAgcGFnZUNv bmZpZ3VyYXRpb24tPnByZWZlcmVuY2VWYWx1ZXMoKS5zZXQoV2ViS2l0OjpXZWJQcmVmZXJlbmNl c0tleTo6aHR0cEVxdWl2RW5hYmxlZEtleSgpLCBXZWJLaXQ6OldlYlByZWZlcmVuY2VzU3RvcmU6 OlZhbHVlKCEhW19jb25maWd1cmF0aW9uIF9hbGxvd3NNZXRhUmVmcmVzaF0pKTsKICAgICBwYWdl Q29uZmlndXJhdGlvbi0+cHJlZmVyZW5jZVZhbHVlcygpLnNldChXZWJLaXQ6OldlYlByZWZlcmVu Y2VzS2V5OjphbGxvd1VuaXZlcnNhbEFjY2Vzc0Zyb21GaWxlVVJMc0tleSgpLCBXZWJLaXQ6Oldl YlByZWZlcmVuY2VzU3RvcmU6OlZhbHVlKCEhW19jb25maWd1cmF0aW9uIF9hbGxvd1VuaXZlcnNh bEFjY2Vzc0Zyb21GaWxlVVJMc10pKTsKLSAgICBwYWdlQ29uZmlndXJhdGlvbi0+c2V0V2FpdHNG b3JQYWludEFmdGVyVmlld0RpZE1vdmVUb1dpbmRvdyhbX2NvbmZpZ3VyYXRpb24gX3dhaXRzRm9y UGFpbnRBZnRlclZpZXdEaWRNb3ZlVG9XaW5kb3ddKTsKLSAgICBwYWdlQ29uZmlndXJhdGlvbi0+ c2V0RHJhd3NCYWNrZ3JvdW5kKFtfY29uZmlndXJhdGlvbiBfZHJhd3NCYWNrZ3JvdW5kXSk7Ci0g ICAgcGFnZUNvbmZpZ3VyYXRpb24tPnNldENvbnRyb2xsZWRCeUF1dG9tYXRpb24oW19jb25maWd1 cmF0aW9uIF9pc0NvbnRyb2xsZWRCeUF1dG9tYXRpb25dKTsKICAgICBwYWdlQ29uZmlndXJhdGlv bi0+cHJlZmVyZW5jZVZhbHVlcygpLnNldChXZWJLaXQ6OldlYlByZWZlcmVuY2VzS2V5OjppbmNv bXBsZXRlSW1hZ2VCb3JkZXJFbmFibGVkS2V5KCksIFdlYktpdDo6V2ViUHJlZmVyZW5jZXNTdG9y ZTo6VmFsdWUoISFbX2NvbmZpZ3VyYXRpb24gX2luY29tcGxldGVJbWFnZUJvcmRlckVuYWJsZWRd KSk7CiAgICAgcGFnZUNvbmZpZ3VyYXRpb24tPnByZWZlcmVuY2VWYWx1ZXMoKS5zZXQoV2ViS2l0 OjpXZWJQcmVmZXJlbmNlc0tleTo6c2hvdWxkRGVmZXJBc3luY2hyb25vdXNTY3JpcHRzVW50aWxB ZnRlckRvY3VtZW50TG9hZEtleSgpLCBXZWJLaXQ6OldlYlByZWZlcmVuY2VzU3RvcmU6OlZhbHVl KCEhW19jb25maWd1cmF0aW9uIF9zaG91bGREZWZlckFzeW5jaHJvbm91c1NjcmlwdHNVbnRpbEFm dGVyRG9jdW1lbnRMb2FkXSkpOwogCkluZGV4OiBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkv Q29jb2EvV0tXZWJWaWV3Q29uZmlndXJhdGlvbi5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Q29uZmlndXJhdGlvbi5tbQkocmV2aXNp b24gMjM0OTM5KQorKysgU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmll d0NvbmZpZ3VyYXRpb24ubW0JKHdvcmtpbmcgY29weSkKQEAgLTE0Nyw4ICsxNDcsNiBAQCBzdGF0 aWMgX1dLRHJhZ0xpZnREZWxheSB0b0RyYWdMaWZ0RGVsYXkoCiAgICAgQk9PTCBfaW1hZ2VDb250 cm9sc0VuYWJsZWQ7CiAgICAgQk9PTCBfcmVxdWlyZXNVc2VyQWN0aW9uRm9yRWRpdGluZ0NvbnRy b2xzTWFuYWdlcjsKICNlbmRpZgotICAgIEJPT0wgX3dhaXRzRm9yUGFpbnRBZnRlclZpZXdEaWRN b3ZlVG9XaW5kb3c7Ci0gICAgQk9PTCBfY29udHJvbGxlZEJ5QXV0b21hdGlvbjsKIAogI2lmIEVO QUJMRShBUFBMSUNBVElPTl9NQU5JRkVTVCkKICAgICBSZXRhaW5QdHI8X1dLQXBwbGljYXRpb25N YW5pZmVzdD4gX2FwcGxpY2F0aW9uTWFuaWZlc3Q7CkBAIC0xNjMsNyArMTYxLDYgQEAgc3RhdGlj IF9XS0RyYWdMaWZ0RGVsYXkgdG9EcmFnTGlmdERlbGF5KAogICAgIEJPT0wgX2NvbG9yRmlsdGVy RW5hYmxlZDsKICAgICBCT09MIF9pbmNvbXBsZXRlSW1hZ2VCb3JkZXJFbmFibGVkOwogICAgIEJP T0wgX3Nob3VsZERlZmVyQXN5bmNocm9ub3VzU2NyaXB0c1VudGlsQWZ0ZXJEb2N1bWVudExvYWQ7 Ci0gICAgQk9PTCBfZHJhd3NCYWNrZ3JvdW5kOwogCiAgICAgUmV0YWluUHRyPE5TU3RyaW5nPiBf bWVkaWFDb250ZW50VHlwZXNSZXF1aXJpbmdIYXJkd2FyZVN1cHBvcnQ7CiB9CkBAIC0yMTcsNyAr MjE0LDYgQEAgLSAoaW5zdGFuY2V0eXBlKWluaXQKICAgICBfaW1hZ2VDb250cm9sc0VuYWJsZWQg PSBOTzsKICAgICBfcmVxdWlyZXNVc2VyQWN0aW9uRm9yRWRpdGluZ0NvbnRyb2xzTWFuYWdlciA9 IE5POwogI2VuZGlmCi0gICAgX3dhaXRzRm9yUGFpbnRBZnRlclZpZXdEaWRNb3ZlVG9XaW5kb3cg PSBZRVM7CiAKICNpZiBFTkFCTEUoV0lSRUxFU1NfUExBWUJBQ0tfVEFSR0VUKQogICAgIF9hbGxv d3NBaXJQbGF5Rm9yTWVkaWFQbGF5YmFjayA9IFlFUzsKQEAgLTI0OSw3ICsyNDUsNiBAQCAtIChp bnN0YW5jZXR5cGUpaW5pdAogICAgIF9jb2xvckZpbHRlckVuYWJsZWQgPSBOTzsKICAgICBfaW5j b21wbGV0ZUltYWdlQm9yZGVyRW5hYmxlZCA9IE5POwogICAgIF9zaG91bGREZWZlckFzeW5jaHJv bm91c1NjcmlwdHNVbnRpbEFmdGVyRG9jdW1lbnRMb2FkID0gTk87Ci0gICAgX2RyYXdzQmFja2dy b3VuZCA9IFlFUzsKIAogICAgIHJldHVybiBzZWxmOwogfQpAQCAtMzY0LDggKzM1OSw2IEBAIC0g KGlkKWNvcHlXaXRoWm9uZTooTlNab25lICopem9uZQogICAgIGNvbmZpZ3VyYXRpb24tPl9hdHRh Y2htZW50RWxlbWVudEVuYWJsZWQgPSBzZWxmLT5fYXR0YWNobWVudEVsZW1lbnRFbmFibGVkOwog ICAgIGNvbmZpZ3VyYXRpb24tPl9tZWRpYVR5cGVzUmVxdWlyaW5nVXNlckFjdGlvbkZvclBsYXli YWNrID0gc2VsZi0+X21lZGlhVHlwZXNSZXF1aXJpbmdVc2VyQWN0aW9uRm9yUGxheWJhY2s7CiAg ICAgY29uZmlndXJhdGlvbi0+X21haW5Db250ZW50VXNlckdlc3R1cmVPdmVycmlkZUVuYWJsZWQg PSBzZWxmLT5fbWFpbkNvbnRlbnRVc2VyR2VzdHVyZU92ZXJyaWRlRW5hYmxlZDsKLSAgICBjb25m aWd1cmF0aW9uLT5fd2FpdHNGb3JQYWludEFmdGVyVmlld0RpZE1vdmVUb1dpbmRvdyA9IHNlbGYt Pl93YWl0c0ZvclBhaW50QWZ0ZXJWaWV3RGlkTW92ZVRvV2luZG93OwotICAgIGNvbmZpZ3VyYXRp b24tPl9jb250cm9sbGVkQnlBdXRvbWF0aW9uID0gc2VsZi0+X2NvbnRyb2xsZWRCeUF1dG9tYXRp b247CiAKICNpZiBQTEFURk9STShJT1MpCiAgICAgY29uZmlndXJhdGlvbi0+X2FsbG93c0lubGlu ZU1lZGlhUGxheWJhY2sgPSBzZWxmLT5fYWxsb3dzSW5saW5lTWVkaWFQbGF5YmFjazsKQEAgLTQx MCw3ICs0MDMsNiBAQCAtIChpZCljb3B5V2l0aFpvbmU6KE5TWm9uZSAqKXpvbmUKICAgICBjb25m aWd1cmF0aW9uLT5fY29sb3JGaWx0ZXJFbmFibGVkID0gc2VsZi0+X2NvbG9yRmlsdGVyRW5hYmxl ZDsKICAgICBjb25maWd1cmF0aW9uLT5faW5jb21wbGV0ZUltYWdlQm9yZGVyRW5hYmxlZCA9IHNl bGYtPl9pbmNvbXBsZXRlSW1hZ2VCb3JkZXJFbmFibGVkOwogICAgIGNvbmZpZ3VyYXRpb24tPl9z aG91bGREZWZlckFzeW5jaHJvbm91c1NjcmlwdHNVbnRpbEFmdGVyRG9jdW1lbnRMb2FkID0gc2Vs Zi0+X3Nob3VsZERlZmVyQXN5bmNocm9ub3VzU2NyaXB0c1VudGlsQWZ0ZXJEb2N1bWVudExvYWQ7 Ci0gICAgY29uZmlndXJhdGlvbi0+X2RyYXdzQmFja2dyb3VuZCA9IHNlbGYtPl9kcmF3c0JhY2tn cm91bmQ7CiAKICAgICByZXR1cm4gY29uZmlndXJhdGlvbjsKIH0KQEAgLTc5MCwxMiArNzgyLDEy IEBAIC0gKHZvaWQpX3NldFNob3VsZERlZmVyQXN5bmNocm9ub3VzU2NyaXAKIAogLSAoQk9PTClf ZHJhd3NCYWNrZ3JvdW5kCiB7Ci0gICAgcmV0dXJuIF9kcmF3c0JhY2tncm91bmQ7CisgICAgcmV0 dXJuIF9wYWdlQ29uZmlndXJhdGlvbi0+ZHJhd3NCYWNrZ3JvdW5kKCk7CiB9CiAKIC0gKHZvaWQp X3NldERyYXdzQmFja2dyb3VuZDooQk9PTClkcmF3c0JhY2tncm91bmQKIHsKLSAgICBfZHJhd3NC YWNrZ3JvdW5kID0gZHJhd3NCYWNrZ3JvdW5kOworICAgIF9wYWdlQ29uZmlndXJhdGlvbi0+c2V0 RHJhd3NCYWNrZ3JvdW5kKGRyYXdzQmFja2dyb3VuZCk7CiB9CiAKIC0gKEJPT0wpX3JlcXVpcmVz VXNlckFjdGlvbkZvclZpZGVvUGxheWJhY2sKQEAgLTg0NiwyMiArODM4LDIyIEBAIC0gKHZvaWQp X3NldEluaXRpYWxDYXBpdGFsaXphdGlvbkVuYWJsZWQKIAogLSAoQk9PTClfd2FpdHNGb3JQYWlu dEFmdGVyVmlld0RpZE1vdmVUb1dpbmRvdwogewotICAgIHJldHVybiBfd2FpdHNGb3JQYWludEFm dGVyVmlld0RpZE1vdmVUb1dpbmRvdzsKKyAgICByZXR1cm4gX3BhZ2VDb25maWd1cmF0aW9uLT53 YWl0c0ZvclBhaW50QWZ0ZXJWaWV3RGlkTW92ZVRvV2luZG93KCk7CiB9CiAKLS0gKHZvaWQpX3Nl dFdhaXRzRm9yUGFpbnRBZnRlclZpZXdEaWRNb3ZlVG9XaW5kb3c6KEJPT0wpc2hvdWxkU3luY2hy b25pemUKKy0gKHZvaWQpX3NldFdhaXRzRm9yUGFpbnRBZnRlclZpZXdEaWRNb3ZlVG9XaW5kb3c6 KEJPT0wpd2FpdHNGb3JQYWludEFmdGVyVmlld0RpZE1vdmVUb1dpbmRvdwogewotICAgIF93YWl0 c0ZvclBhaW50QWZ0ZXJWaWV3RGlkTW92ZVRvV2luZG93ID0gc2hvdWxkU3luY2hyb25pemU7Cisg ICAgX3BhZ2VDb25maWd1cmF0aW9uLT5zZXRXYWl0c0ZvclBhaW50QWZ0ZXJWaWV3RGlkTW92ZVRv V2luZG93KHdhaXRzRm9yUGFpbnRBZnRlclZpZXdEaWRNb3ZlVG9XaW5kb3cpOwogfQogCiAtIChC T09MKV9pc0NvbnRyb2xsZWRCeUF1dG9tYXRpb24KIHsKLSAgICByZXR1cm4gX2NvbnRyb2xsZWRC eUF1dG9tYXRpb247CisgICAgcmV0dXJuIF9wYWdlQ29uZmlndXJhdGlvbi0+aXNDb250cm9sbGVk QnlBdXRvbWF0aW9uKCk7CiB9CiAKIC0gKHZvaWQpX3NldENvbnRyb2xsZWRCeUF1dG9tYXRpb246 KEJPT0wpY29udHJvbGxlZEJ5QXV0b21hdGlvbgogewotICAgIF9jb250cm9sbGVkQnlBdXRvbWF0 aW9uID0gY29udHJvbGxlZEJ5QXV0b21hdGlvbjsKKyAgICBfcGFnZUNvbmZpZ3VyYXRpb24tPnNl dENvbnRyb2xsZWRCeUF1dG9tYXRpb24oY29udHJvbGxlZEJ5QXV0b21hdGlvbik7CiB9CiAKIC0g KF9XS0FwcGxpY2F0aW9uTWFuaWZlc3QgKilfYXBwbGljYXRpb25NYW5pZmVzdAo=