<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>188635</bug_id>
          
          <creation_ts>2018-08-15 21:23:21 -0700</creation_ts>
          <short_desc>[Win] Visual Studio 2017 version 15.8 can&apos;t compile WebKit</short_desc>
          <delta_ts>2018-09-25 21:57:09 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Template Framework</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Fujii Hironori">fujii</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>achristensen</cc>
    
    <cc>bfulgham</cc>
    
    <cc>don.olmstead</cc>
    
    <cc>mark.salisbury</cc>
    
    <cc>pvollan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1450582</commentid>
    <comment_count>0</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2018-08-15 21:23:21 -0700</bug_when>
    <thetext>I upgraded VS today. It can&apos;t build ToT WebKit.

  Microsoft Visual Studio Professional 2017 
  Version 15.8.0
  VisualStudio.15.Release/15.8.0+28010.0
  Microsoft .NET Framework
  Version 4.7.02556

&gt; 2&gt;------ Build started: Project: WTF (WTF\WTF), Configuration: Debug x64 ------
&gt; 2&gt;TextBreakIterator.obj : error LNK2005: &quot;public: static void (__cdecl*const * const WTF::__visitor_table&lt;struct WTF::Visitor&lt;class &lt;lambda_4688178ac87a3efd1e417c3ce7f3aa28&gt; &gt;,class WTF::TextBreakIteratorICU,class WTF::NullTextBreakIterator&gt;::__trampoline)(struct WTF::Visitor&lt;class &lt;lambda_4688178ac87a3efd1e417c3ce7f3aa28&gt; &gt; &amp;,class WTF::Variant&lt;class WTF::TextBreakIteratorICU,class WTF::NullTextBreakIterator&gt; &amp;)&quot; (?__trampoline@?$__visitor_table@U?$Visitor@V&lt;lambda_4688178ac87a3efd1e417c3ce7f3aa28&gt;@@$$V@WTF@@VTextBreakIteratorICU@2@VNullTextBreakIterator@2@@WTF@@2QBQ6AXAEAU?$Visitor@V&lt;lambda_4688178ac87a3efd1e417c3ce7f3aa28&gt;@@$$V@2@AEAV?$Variant@VTextBreakIteratorICU@WTF@@VNullTextBreakIterator@2@@2@@ZB) already defined in StringView.obj
&gt; 2&gt;   Creating library C:/webkit/wa/WebKitBuild/Debug/lib64/WTF.lib and object C:/webkit/wa/WebKitBuild/Debug/lib64/WTF.exp
&gt; 2&gt;C:\webkit\wa\WebKitBuild\Debug\bin64\WTF.dll : fatal error LNK1169: one or more multiply defined symbols found
&gt; 2&gt;Done building project &quot;WTF.vcxproj&quot; -- FAILED.
&gt; ========== Build: 1 succeeded, 1 failed, 1 up-to-date, 0 skipped ==========</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1450583</commentid>
    <comment_count>1</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2018-08-15 21:26:34 -0700</bug_when>
    <thetext>another build log: https://gist.github.com/fujii/d8208ba24a38caa14f6f1b9198867d91</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1450591</commentid>
    <comment_count>2</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2018-08-15 21:58:30 -0700</bug_when>
    <thetext>https://blogs.msdn.microsoft.com/visualstudio/2018/08/14/visual-studio-2017-version-15-8/</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1451240</commentid>
    <comment_count>3</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2018-08-17 15:18:09 -0700</bug_when>
    <thetext>https://twitter.com/stephantlavavej/status/1030543709295636480?s=21</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1451892</commentid>
    <comment_count>4</comment_count>
    <who name="Mark Salisbury">mark.salisbury</who>
    <bug_when>2018-08-20 18:21:23 -0700</bug_when>
    <thetext>We are seeing this too.  Thanks for working with Microsoft to get this fixed so fast!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1451895</commentid>
    <comment_count>5</comment_count>
    <who name="Mark Salisbury">mark.salisbury</who>
    <bug_when>2018-08-20 18:23:15 -0700</bug_when>
    <thetext>(In reply to Fujii Hironori from comment #3)
&gt; https://twitter.com/stephantlavavej/status/1030543709295636480?s=21

Wow!  They&apos;re going to build WebKit before releasing Visual C++ compiler updates?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1456562</commentid>
    <comment_count>6</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2018-09-04 17:48:41 -0700</bug_when>
    <thetext>According to Don, this issue will be fixed in 15.8.3.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1458804</commentid>
    <comment_count>7</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2018-09-11 17:36:53 -0700</bug_when>
    <thetext>I confirmed version 15.8.3 also reports the same error. Is it a problem in WebKit side?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1463502</commentid>
    <comment_count>8</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2018-09-25 21:01:04 -0700</bug_when>
    <thetext>https://docs.microsoft.com/en-us/visualstudio/releasenotes/vs2017-relnotes#-visual-studio-2017-version-1584

&gt; Top Issues Fixed in 15.8.4
&gt; These are the customer-reported issues addressed in 15.8.4:
&gt; 
&gt; (..)
&gt; [WebKit] &quot;Already defined symbol&quot; for static template member definition (regression).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1463514</commentid>
    <comment_count>9</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2018-09-25 21:57:09 -0700</bug_when>
    <thetext>This issue has been fixed, but another issue comes here. Filed:

Bug 189987 – [Win] error C2139: &apos;WebKit::UpdateInfo&apos;: an undefined class is not allowed as an argument to compiler intrinsic type trait &apos;__is_assignable&apos;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>