188588 2018-08-14 16:14:47 -0700 [Curl] Don't send Content-Type header for POST request when body is null. 2018-08-15 20:18:14 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 basuke basuke achristensen basuke commit-queue ews-watchlist fujii galpeter webkit-bug-importer youennf oldest_to_newest 1450146 0 basuke 2018-08-14 16:14:47 -0700 Caught by http/tests/xmlhttprequest/methods.html 1450158 1 347126 basuke 2018-08-14 16:30:17 -0700 Created attachment 347126 PATCH 1450226 2 347126 youennf 2018-08-14 20:54:19 -0700 Comment on attachment 347126 PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=347126&action=review > Source/WebCore/ChangeLog:9 > + when body is null. Is it done for CURL only for POST when setting CURLOPT_POST? Is it also happening for other methods like PUT? > Source/WebCore/platform/network/curl/CurlRequest.cpp:468 > + m_curlHandle->removeRequestHeader("Content-Type"_s); What happens if there are elementSize but no provided HTTPHeaderName::ContentType? If it is the default CURL, does it align with other ports? 1450362 3 347126 basuke 2018-08-15 11:23:16 -0700 Comment on attachment 347126 PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=347126&action=review >> Source/WebCore/ChangeLog:9 >> + when body is null. > > Is it done for CURL only for POST when setting CURLOPT_POST? > Is it also happening for other methods like PUT? libcurl only behaves like this on POST. I guess POST is more popular use case for libcurl. >> Source/WebCore/platform/network/curl/CurlRequest.cpp:468 >> + m_curlHandle->removeRequestHeader("Content-Type"_s); > > What happens if there are elementSize but no provided HTTPHeaderName::ContentType? > If it is the default CURL, does it align with other ports? That is covered by this case in the test: req.open("POST", "methods.cgi", false); req.send(""); log('POST(""): ' + req.getResponseHeader("REQMETHOD") + "(" + req.getResponseHeader("REQLENGTH") + " bytes), Content-Type: " + req.getResponseHeader("REQTYPE")); All three ports returns that content type is sent as "Content-Type: text/plain;charset=UTF-8". 1450363 4 347126 basuke 2018-08-15 11:23:46 -0700 Comment on attachment 347126 PATCH Thanks Youenn for r+ 1450372 5 347126 commit-queue 2018-08-15 11:51:00 -0700 Comment on attachment 347126 PATCH Clearing flags on attachment: 347126 Committed r234892: <https://trac.webkit.org/changeset/234892> 1450373 6 commit-queue 2018-08-15 11:51:01 -0700 All reviewed patches have been landed. Closing bug. 1450374 7 webkit-bug-importer 2018-08-15 11:52:15 -0700 <rdar://problem/43343571> 1450445 8 fujii 2018-08-15 13:46:34 -0700 http/tests/xmlhttprequest/methods.html is starting to fail. https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Release%20%28Tests%29/builds/1043 1450569 9 basuke 2018-08-15 20:18:14 -0700 I confirmed this difference. It is weird the result was different than at home. I'm double check my build env. 347126 2018-08-14 16:30:17 -0700 2018-08-15 11:51:00 -0700 PATCH 188588.diff text/plain 2795 basuke ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBlZTc0OTYwYWEwMS4uNDk3NzlhYTAxYTUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAor MjAxOC0wOC0xNCAgQmFzdWtlIFN1enVraSAgPEJhc3VrZS5TdXp1a2lAc29ueS5jb20+CisKKyAg ICAgICAgW0N1cmxdIERvbid0IHNlbmQgQ29udGVudC1UeXBlIGhlYWRlciBmb3IgUE9TVCByZXF1 ZXN0IHdoZW4gYm9keSBpcyBudWxsLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTg4NTg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS93aW5jYWlyby9UZXN0RXhwZWN0YXRpb25zOgorCiAy MDE4LTA4LTE0ICBBbnRvaW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CiAKICAgICAgICAg W1dlYiBBbmltYXRpb25zXSBDcmFzaCB1bmRlciBBbmltYXRpb25UaW1lbGluZTo6Y2FuY2VsT3JS ZW1vdmVEZWNsYXJhdGl2ZUFuaW1hdGlvbigpCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS93aW5jYWlyby9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2lu Y2Fpcm8vVGVzdEV4cGVjdGF0aW9ucwppbmRleCA1ZWNkOTA5MDA3MC4uYmM0ZWQwNDM2MGIgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3dpbmNhaXJvL1Rlc3RFeHBlY3RhdGlvbnMK KysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luY2Fpcm8vVGVzdEV4cGVjdGF0aW9ucwpAQCAt OTQ4LDcgKzk0OCw2IEBAIGh0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvY3Jvc3Mtb3JpZ2luLWNv b2tpZS1zdG9yYWdlLmh0bWwgWyBGYWlsdXJlIF0KIGh0dHAvdGVzdHMveG1saHR0cHJlcXVlc3Qv Y3Jvc3Mtb3JpZ2luLW5vLWF1dGhvcml6YXRpb24uaHRtbCBbIEZhaWx1cmUgXQogaHR0cC90ZXN0 cy94bWxodHRwcmVxdWVzdC9sb2dvdXQuaHRtbCBbIEZhaWx1cmUgXQogaHR0cC90ZXN0cy94bWxo dHRwcmVxdWVzdC9tZXRob2RzLWFzeW5jLmh0bWwgWyBGYWlsdXJlIF0KLWh0dHAvdGVzdHMveG1s aHR0cHJlcXVlc3QvbWV0aG9kcy5odG1sIFsgRmFpbHVyZSBdCiBodHRwL3Rlc3RzL3htbGh0dHBy ZXF1ZXN0L251bGwtYXV0aC5waHAgWyBGYWlsdXJlIF0KIGh0dHAvdGVzdHMveG1saHR0cHJlcXVl c3QvcmFuZ2UtdGVzdC5odG1sIFsgRmFpbHVyZSBdCiBodHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0 L3JlLWxvZ2luLWFzeW5jLmh0bWwgWyBGYWlsdXJlIF0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhZjU5Njg1M2Vk ZS4uMTIyZjgxY2Y2MTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysg Yi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxOC0wOC0xNCAg QmFzdWtlIFN1enVraSAgPEJhc3VrZS5TdXp1a2lAc29ueS5jb20+CisKKyAgICAgICAgW0N1cmxd IERvbid0IHNlbmQgQ29udGVudC1UeXBlIGhlYWRlciBmb3IgUE9TVCByZXF1ZXN0IHdoZW4gYm9k eSBpcyBudWxsLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTg4NTg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVGhlIENvbnRlbnQtVHlwZSBoZWFkZXIgd2FzIHNlbnQgYnkgbGliY3VybCBhdXRvbWF0aWNh bGx5LiBTdXBwcmVzcyB0aGF0IGJlaGF2aW9yCisgICAgICAgIHdoZW4gYm9keSBpcyBudWxsLgor CisgICAgICAgIFRlc3RzOiBodHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L21ldGhvZHMuaHRtbAor CisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9jdXJsL0N1cmxSZXF1ZXN0LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkN1cmxSZXF1ZXN0OjpzZXR1cFBPU1QpOgorCiAyMDE4LTA4LTE0ICBBbGkg SnVtYSAgPGFqdW1hQGNocm9taXVtLm9yZz4KIAogICAgICAgICBGb2xsb3ctdXA6IFtJbnRlcnNl Y3Rpb25PYnNlcnZlcl0gSW1wbGVtZW50IHJvb3RNYXJnaW4gcGFyc2luZwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL0N1cmxSZXF1ZXN0LmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9DdXJsUmVxdWVzdC5jcHAKaW5kZXgg MTMzY2IyODMwYzYuLjcyNjk5MmFhM2QyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9uZXR3b3JrL2N1cmwvQ3VybFJlcXVlc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL25ldHdvcmsvY3VybC9DdXJsUmVxdWVzdC5jcHAKQEAgLTQ2Myw2ICs0NjMsMTAgQEAg dm9pZCBDdXJsUmVxdWVzdDo6c2V0dXBQT1NUKFJlc291cmNlUmVxdWVzdCYgcmVxdWVzdCkKICAg ICBtX2N1cmxIYW5kbGUtPmVuYWJsZUh0dHBQb3N0UmVxdWVzdCgpOwogCiAgICAgYXV0byBlbGVt ZW50U2l6ZSA9IG1fZm9ybURhdGFTdHJlYW0uZWxlbWVudFNpemUoKTsKKworICAgIGlmICghbV9y ZXF1ZXN0Lmhhc0hUVFBIZWFkZXIoSFRUUEhlYWRlck5hbWU6OkNvbnRlbnRUeXBlKSAmJiAhZWxl bWVudFNpemUpCisgICAgICAgIG1fY3VybEhhbmRsZS0+cmVtb3ZlUmVxdWVzdEhlYWRlcigiQ29u dGVudC1UeXBlIl9zKTsKKwogICAgIGlmICghZWxlbWVudFNpemUpCiAgICAgICAgIHJldHVybjsK IAo=