188582 2018-08-14 15:19:27 -0700 HashMap<Ref<P>, V> asserts when V is not zero for its empty value 2018-08-23 11:32:23 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=188893 InRadar P2 Normal --- 188426 1 saam saam achristensen benjamin cdumez cmarcelo commit-queue darin dbates ews-watchlist fpizlo ggaren keith_miller mark.lam msaboff saam sam webkit-bug-importer ysuzuki oldest_to_newest 1450117 0 saam 2018-08-14 15:19:27 -0700 Basically, we end up with code that does this: Ref<P>(Ref<P>(HashTableEmptyValue)) Which: - invokes move constructor on an incoming empty value - that incoming empty value has nullptr for m_ptr - The move constructor calls leakRef on the incoming value - leakRef does: ASSERT(m_ptr) 1450209 1 347141 saam 2018-08-14 18:25:16 -0700 Created attachment 347141 patch 1450228 2 347141 commit-queue 2018-08-14 21:08:15 -0700 Comment on attachment 347141 patch Clearing flags on attachment: 347141 Committed r234879: <https://trac.webkit.org/changeset/234879> 1450229 3 commit-queue 2018-08-14 21:08:17 -0700 All reviewed patches have been landed. Closing bug. 1450230 4 webkit-bug-importer 2018-08-14 21:09:20 -0700 <rdar://problem/43318499> 347141 2018-08-14 18:25:16 -0700 2018-08-14 21:08:15 -0700 patch b-backup.diff text/plain 7153 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjM0ODYzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBA CisyMDE4LTA4LTE0ICBTYWFtIGJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IEhhc2hNYXA8UmVmPFA+LCBWPiBhc3NlcnRzIHdoZW4gViBpcyBub3QgemVybyBmb3IgaXRzIGVt cHR5IHZhbHVlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xODg1ODIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHJ1bnRpbWUvU3BhcnNlQXJyYXlWYWx1ZU1hcC5oOgorCiAyMDE4LTA4LTE0ICBLZWl0aCBN aWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBtaXNzaW5nIGF2 YWlsYWJpbGl0eSBtYWNyby4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1Nw YXJzZUFycmF5VmFsdWVNYXAuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9TcGFyc2VBcnJheVZhbHVlTWFwLmgJKHJldmlzaW9uIDIzNDg2MykKKysrIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1NwYXJzZUFycmF5VmFsdWVNYXAuaAkod29ya2luZyBj b3B5KQpAQCAtMzcsNiArMzcsNyBAQCBuYW1lc3BhY2UgSlNDIHsKIGNsYXNzIFNwYXJzZUFycmF5 VmFsdWVNYXA7CiAKIGNsYXNzIFNwYXJzZUFycmF5RW50cnkgOiBwcml2YXRlIFdyaXRlQmFycmll cjxVbmtub3duPiB7CisgICAgV1RGX01BS0VfRkFTVF9BTExPQ0FURUQ7CiBwdWJsaWM6CiAgICAg dXNpbmcgQmFzZSA9IFdyaXRlQmFycmllcjxVbmtub3duPjsKIApJbmRleDogU291cmNlL1dURi9D aGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIz NDg2MykKKysrIFNvdXJjZS9XVEYvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEs MjcgQEAKKzIwMTgtMDgtMTQgIFNhYW0gYmFyYXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CisKKyAg ICAgICAgSGFzaE1hcDxSZWY8UD4sIFY+IGFzc2VydHMgd2hlbiBWIGlzIG5vdCB6ZXJvIGZvciBp dHMgZW1wdHkgdmFsdWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE4ODU4MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFRoZSBpc3N1ZSBoYXBwZW5lZCB3aGVuIHdlJ2QgZmlsbCB0aGUgaGFzaCB0YWJsZSBi dWZmZXIgd2l0aCBlbXB0eSB2YWx1ZXMuIFdlCisgICAgICAgIHdvdWxkIGl0ZXJhdGUgdGhlIGJ1 ZmZlciBhbmQgaW52b2tlIHBsYWNlbWVudCBuZXcgd2l0aCB0aGUgaW5jb21pbmcgdmFsdWUgYmVp bmcgdGhlCisgICAgICAgIGVtcHR5IHZhbHVlLiBGb3IgUmVmLCB0aGlzIG1lYW5zIHRoYXQsIHdl J2QgY2FsbCBpdHMgbW92ZSBjb25zdHJ1Y3Rvciwgd2hpY2ggY2FsbHMKKyAgICAgICAgbGVha1Jl ZigpLCB3aGljaCBhc3NlcnRzIHRoYXQgdGhlIFJlZidzIHBvaW50ZXIgaXMgbm90IG51bGwuIFdl J2QgbGlrZSB0byBrZWVwCisgICAgICAgIHRoaXMgYXNzZXJ0IHNpbmNlIGl0IGNhdGNoZXMgYnVn cyB3aGVyZSB5b3UgbGVha1JlZigpIG1vcmUgdGhhbiBvbmNlIG9yIFdURk1vdmUKKyAgICAgICAg YW4gYWxyZWFkeSBtb3ZlZCBSZWYuCisgICAgICAgIAorICAgICAgICBUaGlzIHBhdGNoIGZpeGVz IHRoaXMgaXNzdWUgYnkgYWRkaW5nIGEgbmV3IHRyYWl0IGZvciBjb25zdHJ1Y3RpbmcgYW4gZW1w dHkKKyAgICAgICAgdmFsdWUuIFdlIHVzZSB0aGF0IGluIEhhc2hUYWJsZSBpbnN0ZWFkIG9mIGRp cmVjdGx5IGNhbGxpbmcgcGxhY2VtZW50IG5ldy4KKworICAgICAgICAqIHd0Zi9IYXNoVGFibGUu aDoKKyAgICAgICAgKFdURjo6SGFzaFRhYmxlQnVja2V0SW5pdGlhbGl6ZXI8ZmFsc2U+Ojppbml0 aWFsaXplKToKKyAgICAgICAgKiB3dGYvSGFzaFRyYWl0cy5oOgorICAgICAgICAoV1RGOjpHZW5l cmljSGFzaFRyYWl0czo6Y29uc3RydWN0RW1wdHlWYWx1ZSk6CisgICAgICAgIChXVEY6Okhhc2hU cmFpdHM8UmVmPFA+Pjo6Y29uc3RydWN0RW1wdHlWYWx1ZSk6CisgICAgICAgIChXVEY6OktleVZh bHVlUGFpckhhc2hUcmFpdHM6OmNvbnN0cnVjdEVtcHR5VmFsdWUpOgorCiAyMDE4LTA4LTE0ICBB bGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVXNl IGEgVmFyaWFudCBpbnN0ZWFkIG9mIGEgdW5pb24gaW4gQ1NTU2VsZWN0b3IKSW5kZXg6IFNvdXJj ZS9XVEYvd3RmL0hhc2hUYWJsZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL0hhc2hU YWJsZS5oCShyZXZpc2lvbiAyMzQ4NjMpCisrKyBTb3VyY2UvV1RGL3d0Zi9IYXNoVGFibGUuaAko d29ya2luZyBjb3B5KQpAQCAtODM3LDcgKzgzNyw3IEBAIG5hbWVzcGFjZSBXVEYgewogICAgIHRl bXBsYXRlPD4gc3RydWN0IEhhc2hUYWJsZUJ1Y2tldEluaXRpYWxpemVyPGZhbHNlPiB7CiAgICAg ICAgIHRlbXBsYXRlPHR5cGVuYW1lIFRyYWl0cywgdHlwZW5hbWUgVmFsdWU+IHN0YXRpYyB2b2lk IGluaXRpYWxpemUoVmFsdWUmIGJ1Y2tldCkKICAgICAgICAgewotICAgICAgICAgICAgbmV3IChO b3ROdWxsLCBzdGQ6OmFkZHJlc3NvZihidWNrZXQpKSBWYWx1ZShUcmFpdHM6OmVtcHR5VmFsdWUo KSk7CisgICAgICAgICAgICBUcmFpdHM6OnRlbXBsYXRlIGNvbnN0cnVjdEVtcHR5VmFsdWU8VHJh aXRzPihidWNrZXQpOwogICAgICAgICB9CiAgICAgfTsKIApJbmRleDogU291cmNlL1dURi93dGYv SGFzaFRyYWl0cy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL0hhc2hUcmFpdHMuaAko cmV2aXNpb24gMjM0ODYzKQorKysgU291cmNlL1dURi93dGYvSGFzaFRyYWl0cy5oCSh3b3JraW5n IGNvcHkpCkBAIC03MCw2ICs3MCwxMiBAQCB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBzdHJ1Y3QgR2Vu ZXJpY0hhc2hUCiAgICAgICAgIGVtcHR5VmFsdWUgPSBzdGQ6OmZvcndhcmQ8Vj4odmFsdWUpOwog ICAgIH0KIAorICAgIHRlbXBsYXRlIDx0eXBlbmFtZSBUcmFpdHM+CisgICAgc3RhdGljIHZvaWQg Y29uc3RydWN0RW1wdHlWYWx1ZShUJiBzbG90KQorICAgIHsKKyAgICAgICAgbmV3IChOb3ROdWxs LCBzdGQ6OmFkZHJlc3NvZihzbG90KSkgVChUcmFpdHM6OmVtcHR5VmFsdWUoKSk7CisgICAgfQor CiAgICAgLy8gVHlwZSBmb3IgcmV0dXJuIHZhbHVlIG9mIGZ1bmN0aW9ucyB0aGF0IGRvIG5vdCB0 cmFuc2ZlciBvd25lcnNoaXAsIHN1Y2ggYXMgZ2V0LgogICAgIHR5cGVkZWYgVCBQZWVrVHlwZTsK ICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBVPiBzdGF0aWMgVSYmIHBlZWsoVSYmIHZhbHVlKSB7IHJl dHVybiBzdGQ6OmZvcndhcmQ8VT4odmFsdWUpOyB9CkBAIC0xOTEsNiArMTk3LDEyIEBAIHRlbXBs YXRlPHR5cGVuYW1lIFA+IHN0cnVjdCBIYXNoVHJhaXRzPFIKICAgICBzdGF0aWMgY29uc3QgYm9v bCBlbXB0eVZhbHVlSXNaZXJvID0gdHJ1ZTsKICAgICBzdGF0aWMgUmVmPFA+IGVtcHR5VmFsdWUo KSB7IHJldHVybiBIYXNoVGFibGVFbXB0eVZhbHVlOyB9CiAKKyAgICB0ZW1wbGF0ZSA8dHlwZW5h bWU+CisgICAgc3RhdGljIHZvaWQgY29uc3RydWN0RW1wdHlWYWx1ZShSZWY8UD4mIHNsb3QpCisg ICAgeworICAgICAgICBuZXcgKE5vdE51bGwsIHN0ZDo6YWRkcmVzc29mKHNsb3QpKSBSZWY8UD4o SGFzaFRhYmxlRW1wdHlWYWx1ZSk7CisgICAgfQorCiAgICAgc3RhdGljIGNvbnN0IGJvb2wgaGFz SXNFbXB0eVZhbHVlRnVuY3Rpb24gPSB0cnVlOwogICAgIHN0YXRpYyBib29sIGlzRW1wdHlWYWx1 ZShjb25zdCBSZWY8UD4mIHZhbHVlKSB7IHJldHVybiB2YWx1ZS5pc0hhc2hUYWJsZUVtcHR5VmFs dWUoKTsgfQogCkBAIC0zMDIsNiArMzE0LDEzIEBAIHN0cnVjdCBLZXlWYWx1ZVBhaXJIYXNoVHJh aXRzIDogR2VuZXJpY0gKICAgICBzdGF0aWMgY29uc3QgYm9vbCBlbXB0eVZhbHVlSXNaZXJvID0g S2V5VHJhaXRzOjplbXB0eVZhbHVlSXNaZXJvICYmIFZhbHVlVHJhaXRzOjplbXB0eVZhbHVlSXNa ZXJvOwogICAgIHN0YXRpYyBFbXB0eVZhbHVlVHlwZSBlbXB0eVZhbHVlKCkgeyByZXR1cm4gS2V5 VmFsdWVQYWlyPHR5cGVuYW1lIEtleVRyYWl0czo6RW1wdHlWYWx1ZVR5cGUsIHR5cGVuYW1lIFZh bHVlVHJhaXRzOjpFbXB0eVZhbHVlVHlwZT4oS2V5VHJhaXRzOjplbXB0eVZhbHVlKCksIFZhbHVl VHJhaXRzOjplbXB0eVZhbHVlKCkpOyB9CiAKKyAgICB0ZW1wbGF0ZSA8dHlwZW5hbWU+CisgICAg c3RhdGljIHZvaWQgY29uc3RydWN0RW1wdHlWYWx1ZShUcmFpdFR5cGUmIHNsb3QpCisgICAgewor ICAgICAgICBLZXlUcmFpdHM6OnRlbXBsYXRlIGNvbnN0cnVjdEVtcHR5VmFsdWU8S2V5VHJhaXRz PihzbG90LmtleSk7CisgICAgICAgIFZhbHVlVHJhaXRzOjp0ZW1wbGF0ZSBjb25zdHJ1Y3RFbXB0 eVZhbHVlPFZhbHVlVHJhaXRzPihzbG90LnZhbHVlKTsKKyAgICB9CisKICAgICBzdGF0aWMgY29u c3QgdW5zaWduZWQgbWluaW11bVRhYmxlU2l6ZSA9IEtleVRyYWl0czo6bWluaW11bVRhYmxlU2l6 ZTsKIAogICAgIHN0YXRpYyB2b2lkIGNvbnN0cnVjdERlbGV0ZWRWYWx1ZShUcmFpdFR5cGUmIHNs b3QpIHsgS2V5VHJhaXRzOjpjb25zdHJ1Y3REZWxldGVkVmFsdWUoc2xvdC5rZXkpOyB9CkluZGV4 OiBUb29scy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQ2hhbmdlTG9nCShyZXZpc2lv biAyMzQ4NzUpCisrKyBUb29scy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwx MyBAQAorMjAxOC0wOC0xNCAgU2FhbSBiYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KKworICAg ICAgICBIYXNoTWFwPFJlZjxQPiwgVj4gYXNzZXJ0cyB3aGVuIFYgaXMgbm90IHplcm8gZm9yIGl0 cyBlbXB0eSB2YWx1ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTg4NTgyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9IYXNoTWFwLmNwcDoKKyAgICAgICAgKFRl c3RXZWJLaXRBUEk6OlRFU1QpOgorCiAyMDE4LTA4LTE0IFNpaHVpIExpdSA8c2lodWlfbGl1QGFw cGxlLmNvbT4KIAogICAgICAgICBDcmFzaCBpbiBXZWJLaXQ6OmZpbHRlclByZWxvYWRIU1RTRW50 cnkgdmlhIE5ldHdvcmtQcm9jZXNzOjpnZXRIb3N0TmFtZXNXaXRoSFNUU0NhY2hlCkluZGV4OiBU b29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9IYXNoTWFwLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBU b29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9IYXNoTWFwLmNwcAkocmV2aXNpb24gMjM0ODYz KQorKysgVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvSGFzaE1hcC5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTk0NSw0ICs5NDUsNDcgQEAgVEVTVChXVEZfSGFzaE1hcCwgRGVsZXRlZEFkZHJl c3NPZk9wZXJhdAogICAgICAgICAodm9pZCl2YWx1ZTsKIH0KIAorVEVTVChXVEZfSGFzaE1hcCwg UmVmTWFwcGVkVG9Ob25aZXJvRW1wdHlWYWx1ZSkKK3sKKyAgICBjbGFzcyBWYWx1ZSB7CisgICAg cHVibGljOgorICAgICAgICBWYWx1ZSgpID0gZGVmYXVsdDsKKyAgICAgICAgVmFsdWUoVmFsdWUm JikgPSBkZWZhdWx0OworICAgICAgICBWYWx1ZShjb25zdCBWYWx1ZSYpID0gZGVmYXVsdDsKKyAg ICAgICAgVmFsdWUmIG9wZXJhdG9yPShWYWx1ZSYmKSA9IGRlZmF1bHQ7CisKKyAgICAgICAgVmFs dWUoaW50MzJfdCBmKQorICAgICAgICAgICAgOiBtX2ZpZWxkKGYpCisgICAgICAgIHsgfQorCisg ICAgICAgIGludDMyX3QgZmllbGQoKSB7IHJldHVybiBtX2ZpZWxkOyB9CisKKyAgICBwcml2YXRl OgorICAgICAgICBpbnQzMl90IG1fZmllbGQgeyAweGJhZGJlZWYgfTsKKyAgICB9OworCisgICAg Y2xhc3MgS2V5IDogcHVibGljIFJlZkNvdW50ZWQ8S2V5PiB7CisgICAgICAgIEtleSgpID0gZGVm YXVsdDsKKyAgICBwdWJsaWM6CisgICAgICAgIHN0YXRpYyBSZWY8S2V5PiBjcmVhdGUoKSB7IHJl dHVybiBhZG9wdFJlZigqbmV3IEtleSk7IH0KKyAgICB9OworCisgICAgc3RhdGljX2Fzc2VydCgh V1RGOjpIYXNoVHJhaXRzPFZhbHVlPjo6ZW1wdHlWYWx1ZUlzWmVybywgIiIpOworCisgICAgSGFz aE1hcDxSZWY8S2V5PiwgVmFsdWU+IG1hcDsKKyAgICBWZWN0b3I8c3RkOjpwYWlyPFJlZjxLZXk+ LCBpbnQzMl90Pj4gdmVjdG9yTWFwOworCisgICAgZm9yIChpbnQzMl90IGkgPSAwOyBpIDwgMTYw OyArK2kpIHsKKyAgICAgICAgUmVmPEtleT4ga2V5ID0gS2V5OjpjcmVhdGUoKTsKKyAgICAgICAg bWFwLmFkZChSZWY8S2V5PihrZXkuZ2V0KCkpLCBWYWx1ZSB7IGkgfSk7CisgICAgICAgIHZlY3Rv ck1hcC5hcHBlbmQoeyBXVEZNb3ZlKGtleSksIGkgfSk7CisgICAgfQorCisgICAgZm9yIChhdXRv JiBwYWlyIDogdmVjdG9yTWFwKQorICAgICAgICBBU1NFUlRfRVEocGFpci5zZWNvbmQsIG1hcC5n ZXQocGFpci5maXJzdCkuZmllbGQoKSk7CisKKyAgICBmb3IgKGF1dG8mIHBhaXIgOiB2ZWN0b3JN YXApCisgICAgICAgIEFTU0VSVF9UUlVFKG1hcC5yZW1vdmUocGFpci5maXJzdCkpOworfQorCiB9 IC8vIG5hbWVzcGFjZSBUZXN0V2ViS2l0QVBJCg==