188579 2018-08-14 14:17:16 -0700 Remove api misuse check so that custom webcontent service identifier can be set at runtime 2018-08-14 19:33:52 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 benton_richards benton_richards ap commit-queue rniwa webkit-bug-importer oldest_to_newest 1450097 0 benton_richards 2018-08-14 14:17:16 -0700 Remove api misuse check so that custom webcontent service identifier can be set at runtime 1450098 1 347109 benton_richards 2018-08-14 14:18:31 -0700 Created attachment 347109 Patch 1450152 2 347109 commit-queue 2018-08-14 16:22:15 -0700 Comment on attachment 347109 Patch Clearing flags on attachment: 347109 Committed r234865: <https://trac.webkit.org/changeset/234865> 1450153 3 commit-queue 2018-08-14 16:22:17 -0700 All reviewed patches have been landed. Closing bug. 1450154 4 webkit-bug-importer 2018-08-14 16:24:30 -0700 <rdar://problem/43308992> 1450215 5 ap 2018-08-14 19:31:03 -0700 This opens up possibilities for terrible misuse, what is the super important reason for this? 1450216 6 rniwa 2018-08-14 19:33:52 -0700 (In reply to Alexey Proskuryakov from comment #5) > This opens up possibilities for terrible misuse, what is the super important > reason for this? It's because we'd like to make this configurable at runtime. We would eventually bring back this API misuse check once we've solidified the feature. 347109 2018-08-14 14:18:31 -0700 2018-08-14 16:22:15 -0700 Patch bug-188579-20180814141830.patch text/plain 2685 benton_richards U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0ODU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDMzYjExZWIwMTY0MWFhNzM5 YTEyNzJlN2IxMDg2NTlkMDc1NDAzNjYuLjQ1MTJkNTYwZDJmYmYzM2IwNTY2MmZiYzQ1NzZjOTYx ZmQwOTg2OWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTgtMDgtMTQgIEJlbiBSaWNo YXJkcyAgPGJlbnRvbl9yaWNoYXJkc0BhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIGFwaSBt aXN1c2UgY2hlY2sgc28gdGhhdCBjdXN0b20gd2ViY29udGVudCBzZXJ2aWNlIGlkZW50aWZpZXIg Y2FuIGJlIHNldCBhdCBydW50aW1lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xODg1NzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBDaGFuZ2VkIEFQSSBtaXN1c2UgY2hlY2sgc28gdGhhdCBhIGN1c3RvbSBi dW5kbGUgaWRlbnRpZmllciBjYW4gYmUgc2V0IGF0IHJ1bnRpbWUgd2l0aCBhIGRlYnVnIGZsYWcK KworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQcm9jZXNzUG9vbC5jcHA6CisgICAgICAgIChXZWJL aXQ6OldlYlByb2Nlc3NQb29sOjpzZXRDdXN0b21XZWJDb250ZW50U2VydmljZUJ1bmRsZUlkZW50 aWZpZXIpOgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQcm9jZXNzUHJveHkuY3BwOgorICAgICAg ICAoV2ViS2l0OjpXZWJQcm9jZXNzUHJveHk6OmdldExhdW5jaE9wdGlvbnMpOgorCiAyMDE4LTA4 LTE0ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdGVM YXllclRyZWVUcmFuc2FjdGlvbiBzaG91bGQgdXNlIE9wdGlvblNldCBmb3IgY2hhbmdlIGZsYWdz CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzUG9vbC5jcHAg Yi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzUG9vbC5jcHAKaW5kZXggYzcyMWEz MGE3NmVjNTU0YzMwNWI2NDg0NDgyYzAxNDZmZDM5OWIzYi4uN2E5M2JmN2E3MmEyYmI2ODJhODQz NWEwNDJjNmQ4MDU4ZDU2YzllOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv V2ViUHJvY2Vzc1Bvb2wuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlByb2Nl c3NQb29sLmNwcApAQCAtNDIxLDcgKzQyMSw3IEBAIHZvaWQgV2ViUHJvY2Vzc1Bvb2w6OnNldE1h eGltdW1OdW1iZXJPZlByZXdhcm1lZFByb2Nlc3Nlcyh1bnNpZ25lZCBtYXhpbXVtTnVtYmVyCiB2 b2lkIFdlYlByb2Nlc3NQb29sOjpzZXRDdXN0b21XZWJDb250ZW50U2VydmljZUJ1bmRsZUlkZW50 aWZpZXIoY29uc3QgU3RyaW5nJiBjdXN0b21XZWJDb250ZW50U2VydmljZUJ1bmRsZUlkZW50aWZp ZXIpCiB7CiAgICAgLy8gR3VhcmQgYWdhaW5zdCBBUEkgbWlzdXNlLgotICAgIGlmIChtX3Byb2Nl c3Nlcy5zaXplKCkgfHwgIWN1c3RvbVdlYkNvbnRlbnRTZXJ2aWNlQnVuZGxlSWRlbnRpZmllci5p c0FsbEFTQ0lJKCkpCisgICAgaWYgKCFjdXN0b21XZWJDb250ZW50U2VydmljZUJ1bmRsZUlkZW50 aWZpZXIuaXNBbGxBU0NJSSgpKQogICAgICAgICBDUkFTSCgpOwogCiAgICAgbV9jb25maWd1cmF0 aW9uLT5zZXRDdXN0b21XZWJDb250ZW50U2VydmljZUJ1bmRsZUlkZW50aWZpZXIoY3VzdG9tV2Vi Q29udGVudFNlcnZpY2VCdW5kbGVJZGVudGlmaWVyKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL1dlYlByb2Nlc3NQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9XZWJQcm9jZXNzUHJveHkuY3BwCmluZGV4IDVlMGJjNjBiNTA1ZjZiMWM3MGRiY2Q0ZDMyZmI4 ZjlhYTgxN2Y2MTcuLjFhYmVlNTZmODZjYTVlMDU4NDU5ZTNmN2EwM2Y1MWM3N2NjOTViYzggMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlByb2Nlc3NQcm94eS5jcHAKKysr IGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Byb3h5LmNwcApAQCAtMTYyLDcg KzE2Miw3IEBAIHZvaWQgV2ViUHJvY2Vzc1Byb3h5OjpnZXRMYXVuY2hPcHRpb25zKFByb2Nlc3NM YXVuY2hlcjo6TGF1bmNoT3B0aW9ucyYgbGF1bmNoT3B0CiAKICAgICBDaGlsZFByb2Nlc3NQcm94 eTo6Z2V0TGF1bmNoT3B0aW9ucyhsYXVuY2hPcHRpb25zKTsKIAotICAgIGlmICghbV9wcm9jZXNz UG9vbC0+Y3VzdG9tV2ViQ29udGVudFNlcnZpY2VCdW5kbGVJZGVudGlmaWVyKCkuaXNOdWxsKCkp CisgICAgaWYgKCFtX3Byb2Nlc3NQb29sLT5jdXN0b21XZWJDb250ZW50U2VydmljZUJ1bmRsZUlk ZW50aWZpZXIoKS5pc0VtcHR5KCkpCiAgICAgICAgIGxhdW5jaE9wdGlvbnMuY3VzdG9tV2ViQ29u dGVudFNlcnZpY2VCdW5kbGVJZGVudGlmaWVyID0gbV9wcm9jZXNzUG9vbC0+Y3VzdG9tV2ViQ29u dGVudFNlcnZpY2VCdW5kbGVJZGVudGlmaWVyKCkuYXNjaWkoKTsKICAgICBpZiAoV2ViS2l0Ojpp c0luc3BlY3RvclByb2Nlc3NQb29sKHByb2Nlc3NQb29sKCkpKQogICAgICAgICBsYXVuY2hPcHRp b25zLmV4dHJhSW5pdGlhbGl6YXRpb25EYXRhLmFkZCgiaW5zcGVjdG9yLXByb2Nlc3MiX3MsICIx Il9zKTsK