188569 2018-08-14 11:50:41 -0700 Crashes in Quip under _dictionaryPopupInfoForRange, in setObject:forKey: 2018-08-15 14:00:06 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton commit-queue ews-feeder jonlee megan_gardner timothy webkit-bug-importer wenson_hsieh oldest_to_newest 1450046 0 thorton 2018-08-14 11:50:41 -0700 Crashes in Quip under _dictionaryPopupInfoForRange, in setObject:forKey: 1450047 1 347097 thorton 2018-08-14 11:51:21 -0700 Created attachment 347097 Patch 1450089 2 347097 megan_gardner 2018-08-14 14:02:53 -0700 Comment on attachment 347097 Patch Since this is speculative, I think a comment mentioning the radar might be helpful. 1450355 3 thorton 2018-08-15 11:11:32 -0700 I'm going to refrain from adding a comment for two reasons: 1) it'll definitely fix the crash; there's no longer any way to get nil in the setObject:forKey:, and 2) we'll never revisit this, so the comment will live forever. The speculativeness is more about the "how we got here" than the fix. 1450356 4 thorton 2018-08-15 11:11:40 -0700 Thank you for your review! 1450357 5 347097 ews-feeder 2018-08-15 11:12:24 -0700 Comment on attachment 347097 Patch Rejecting attachment 347097 from review queue. megan_gardner@apple.com does not have reviewer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. 1450358 6 thorton 2018-08-15 11:19:10 -0700 <rdar://problem/34201095> 1450359 7 347097 ews-feeder 2018-08-15 11:19:51 -0700 Comment on attachment 347097 Patch Rejecting attachment 347097 from review queue. megan_gardner@apple.com does not have reviewer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. 1450455 8 347097 commit-queue 2018-08-15 14:00:04 -0700 Comment on attachment 347097 Patch Clearing flags on attachment: 347097 Committed r234900: <https://trac.webkit.org/changeset/234900> 1450456 9 commit-queue 2018-08-15 14:00:06 -0700 All reviewed patches have been landed. Closing bug. 347097 2018-08-14 11:51:21 -0700 2018-08-15 14:00:04 -0700 Patch bug-188569-20180814115120.patch text/plain 4086 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0ODU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDMzYjExZWIwMTY0MWFhNzM5 YTEyNzJlN2IxMDg2NTlkMDc1NDAzNjYuLmJkYWFjZDA2YjZhMzNhZGI1ZWU1MDg2MWYzMjljMTY4 YjZiOTExOWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTgtMDgtMTQgIFRpbSBIb3J0 b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgQ3Jhc2hlcyBpbiBRdWlw IHVuZGVyIF9kaWN0aW9uYXJ5UG9wdXBJbmZvRm9yUmFuZ2UsIGluIHNldE9iamVjdDpmb3JLZXk6 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODg1NjkK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM0MjAxMDk1PgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9XZWJQ YWdlTWFjLm1tOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjpkaWN0aW9uYXJ5UG9wdXBJbmZv Rm9yUmFuZ2UpOgorICAgICAgICBTcGVjdWxhdGl2ZSBmaXg7IHRoZSBjcmFzaGVzIGluZGljYXRl IGZvbnQgaXMgbnVsbCwgYnV0IHdlIGp1c3QgY2hlY2tlZCBpdCwKKyAgICAgICAgc28gaXQgbXVz dCBiZSBnZXR0aW5nIG1hZGUgbnVsbCBieSBjb252ZXJ0Rm9udDp0b1NpemU6LiBDaGVjayBhZ2Fp biEKKwogMjAxOC0wOC0xNCAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAg ICAgICAgUmVtb3RlTGF5ZXJUcmVlVHJhbnNhY3Rpb24gc2hvdWxkIHVzZSBPcHRpb25TZXQgZm9y IGNoYW5nZSBmbGFncwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvQ2hhbmdl TG9nIGIvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvQ2hhbmdlTG9nCmluZGV4IDc3MDkzZjEwMjQ0 NTg0OWQ1NjRlOTBmZjg3YmFkODY2ZjFhMTYwZGYuLjYyNGVmNjMyYjFjNDA2ZTNhMGFhYWFiYTEx YTk1NGU2OGI2YzFmMzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5n ZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx NiBAQAorMjAxOC0wOC0xNCAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4K KworICAgICAgICBDcmFzaGVzIGluIFF1aXAgdW5kZXIgX2RpY3Rpb25hcnlQb3B1cEluZm9Gb3JS YW5nZSwgaW4gc2V0T2JqZWN0OmZvcktleToKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE4ODU2OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzQyMDEw OTU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBX ZWJWaWV3L1dlYkltbWVkaWF0ZUFjdGlvbkNvbnRyb2xsZXIubW06CisgICAgICAgICgrW1dlYklt bWVkaWF0ZUFjdGlvbkNvbnRyb2xsZXIgX2RpY3Rpb25hcnlQb3B1cEluZm9Gb3JSYW5nZTppbkZy YW1lOndpdGhMb29rdXBPcHRpb25zOmluZGljYXRvck9wdGlvbnM6dHJhbnNpdGlvbjpdKToKKyAg ICAgICAgU3BlY3VsYXRpdmUgZml4OyB0aGUgY3Jhc2hlcyBpbmRpY2F0ZSBmb250IGlzIG51bGws IGJ1dCB3ZSBqdXN0IGNoZWNrZWQgaXQsCisgICAgICAgIHNvIGl0IG11c3QgYmUgZ2V0dGluZyBt YWRlIG51bGwgYnkgY29udmVydEZvbnQ6dG9TaXplOi4gQ2hlY2sgYWdhaW4hCisKIDIwMTgtMDgt MTMgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAg ICBVc2UgYSAxLWJ5dGUgZW51bSBjbGFzcyBmb3IgVGV4dERpcmVjdGlvbgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1dlYlBhZ2VNYWMubW0gYi9Tb3Vy Y2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvV2ViUGFnZU1hYy5tbQppbmRleCA3NjI3 OWY4ZGFiNzVkMmEzY2NkZDFjZTU3MDlhYWY2NTI1NTZhODUxLi5kNmU2ZDQ2NTUxODI5MmIzZTM4 Y2ZmOWU1MGIzNmI3YmY3ODE5MTJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nl c3MvV2ViUGFnZS9tYWMvV2ViUGFnZU1hYy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nl c3MvV2ViUGFnZS9tYWMvV2ViUGFnZU1hYy5tbQpAQCAtNDYyLDEwICs0NjIsMTAgQEAgRGljdGlv bmFyeVBvcHVwSW5mbyBXZWJQYWdlOjpkaWN0aW9uYXJ5UG9wdXBJbmZvRm9yUmFuZ2UoRnJhbWUm IGZyYW1lLCBSYW5nZSYgcmEKICAgICAgICAgUmV0YWluUHRyPE5TTXV0YWJsZURpY3Rpb25hcnk+ IHNjYWxlZEF0dHJpYnV0ZXMgPSBhZG9wdE5TKFthdHRyaWJ1dGVzIG11dGFibGVDb3B5XSk7CiAK ICAgICAgICAgTlNGb250ICpmb250ID0gW3NjYWxlZEF0dHJpYnV0ZXMgb2JqZWN0Rm9yS2V5Ok5T Rm9udEF0dHJpYnV0ZU5hbWVdOwotICAgICAgICBpZiAoZm9udCkgewotICAgICAgICAgICAgZm9u dCA9IFtmb250TWFuYWdlciBjb252ZXJ0Rm9udDpmb250IHRvU2l6ZTpbZm9udCBwb2ludFNpemVd ICogcGFnZVNjYWxlRmFjdG9yKCldOworICAgICAgICBpZiAoZm9udCkKKyAgICAgICAgICAgIGZv bnQgPSBbZm9udE1hbmFnZXIgY29udmVydEZvbnQ6Zm9udCB0b1NpemU6Zm9udC5wb2ludFNpemUg KiBwYWdlU2NhbGVGYWN0b3IoKV07CisgICAgICAgIGlmIChmb250KQogICAgICAgICAgICAgW3Nj YWxlZEF0dHJpYnV0ZXMgc2V0T2JqZWN0OmZvbnQgZm9yS2V5Ok5TRm9udEF0dHJpYnV0ZU5hbWVd OwotICAgICAgICB9CiAKICAgICAgICAgW3NjYWxlZE5TQXR0cmlidXRlZFN0cmluZyBhZGRBdHRy aWJ1dGVzOnNjYWxlZEF0dHJpYnV0ZXMuZ2V0KCkgcmFuZ2U6cmFuZ2VdOwogICAgIH1dOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvV2ViVmlldy9XZWJJbW1lZGlhdGVBY3Rp b25Db250cm9sbGVyLm1tIGIvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvV2ViVmlldy9XZWJJbW1l ZGlhdGVBY3Rpb25Db250cm9sbGVyLm1tCmluZGV4IDU1MTU4OWEyNGMzZGU3YzEwOWU1ZTE1M2Y1 ODU1MTJlN2M1YjU1NWMuLjc1NGNjY2MxYWYyODA2NTU4Y2VmOTZiODhjYzZlNjg3MzNjYTIyYTYg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL1dlYlZpZXcvV2ViSW1tZWRpYXRl QWN0aW9uQ29udHJvbGxlci5tbQorKysgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9XZWJWaWV3 L1dlYkltbWVkaWF0ZUFjdGlvbkNvbnRyb2xsZXIubW0KQEAgLTUyOCwxMCArNTI4LDEwIEBAICsg KERpY3Rpb25hcnlQb3B1cEluZm8pX2RpY3Rpb25hcnlQb3B1cEluZm9Gb3JSYW5nZTooUmFuZ2Um KXJhbmdlIGluRnJhbWU6KEZyYW1lCiAgICAgICAgIFJldGFpblB0cjxOU011dGFibGVEaWN0aW9u YXJ5PiBzY2FsZWRBdHRyaWJ1dGVzID0gYWRvcHROUyhbYXR0cmlidXRlcyBtdXRhYmxlQ29weV0p OwogCiAgICAgICAgIE5TRm9udCAqZm9udCA9IFtzY2FsZWRBdHRyaWJ1dGVzIG9iamVjdEZvcktl eTpOU0ZvbnRBdHRyaWJ1dGVOYW1lXTsKLSAgICAgICAgaWYgKGZvbnQpIHsKLSAgICAgICAgICAg IGZvbnQgPSBbZm9udE1hbmFnZXIgY29udmVydEZvbnQ6Zm9udCB0b1NpemU6W2ZvbnQgcG9pbnRT aXplXSAqIGZyYW1lLT5wYWdlKCktPnBhZ2VTY2FsZUZhY3RvcigpXTsKKyAgICAgICAgaWYgKGZv bnQpCisgICAgICAgICAgICBmb250ID0gW2ZvbnRNYW5hZ2VyIGNvbnZlcnRGb250OmZvbnQgdG9T aXplOmZvbnQucG9pbnRTaXplICogZnJhbWUtPnBhZ2UoKS0+cGFnZVNjYWxlRmFjdG9yKCldOwor ICAgICAgICBpZiAoZm9udCkKICAgICAgICAgICAgIFtzY2FsZWRBdHRyaWJ1dGVzIHNldE9iamVj dDpmb250IGZvcktleTpOU0ZvbnRBdHRyaWJ1dGVOYW1lXTsKLSAgICAgICAgfQogCiAgICAgICAg IFtzY2FsZWROU0F0dHJpYnV0ZWRTdHJpbmcgYWRkQXR0cmlidXRlczpzY2FsZWRBdHRyaWJ1dGVz LmdldCgpIHJhbmdlOmF0dHJpYnV0ZVJhbmdlXTsKICAgICB9XTsK