188560 2018-08-14 10:35:41 -0700 [JSC] GetByIdStatus::m_wasSeenInJIT is touched in GetByIdStatus::slowVersion 2018-08-14 10:47:26 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki don.olmstead ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1449996 0 ysuzuki 2018-08-14 10:35:41 -0700 [JSC] GetByIdStatus::m_wasSeenInJIT is touched in GetByIdStatus::slowVersion 1449997 1 347089 ysuzuki 2018-08-14 10:37:07 -0700 Created attachment 347089 Patch 1449998 2 don.olmstead 2018-08-14 10:39:33 -0700 Informal review r+. This was also detected with a UBSan run of ARES6. This one looks like it might've been caught with clang's linter if we ran that as well. 1450001 3 347089 keith_miller 2018-08-14 10:43:14 -0700 Comment on attachment 347089 Patch Ugh, I wish there was a way we could get a compiler warning about members without default constructors not being initialized... 1450005 4 ysuzuki 2018-08-14 10:46:08 -0700 (In reply to Keith Miller from comment #3) > Comment on attachment 347089 [details] > Patch > > Ugh, I wish there was a way we could get a compiler warning about members > without default constructors not being initialized... Yeah, this case is a bit complicated. And it is awesome that UBSan catches this. (In reply to Don Olmstead from comment #2) > Informal review r+. This was also detected with a UBSan run of ARES6. > > This one looks like it might've been caught with clang's linter if we ran > that as well. Nice! 1450007 5 ysuzuki 2018-08-14 10:46:41 -0700 Committed r234855: <https://trac.webkit.org/changeset/234855> 1450008 6 webkit-bug-importer 2018-08-14 10:47:26 -0700 <rdar://problem/43293111> 347089 2018-08-14 10:37:07 -0700 2018-08-14 10:43:14 -0700 Patch bug-188560-20180815023705.patch text/plain 1695 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0ODUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw NDRkMjY0MDFmMmNkN2Q4ZmE1YTRhMzc1NmNhYjk5M2FlODVjZGZmLi4yN2ZjYTQ3YzBmOWRjZjUx ODYzODUzMzYzZDdiNzhkMzJkNGE0ZTZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxOC0wOC0xNCAgWXVzdWtlIFN1enVraSAgPHl1c3VrZXN1enVraUBzbG93 c3RhcnQub3JnPgorCisgICAgICAgIFtKU0NdIEdldEJ5SWRTdGF0dXM6Om1fd2FzU2VlbkluSklU IGlzIHRvdWNoZWQgaW4gR2V0QnlJZFN0YXR1czo6c2xvd1ZlcnNpb24KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4ODU2MAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoaWxlIEdldEJ5SWRTdGF0dXMoKSAv IEdldEJ5SWRTdGF0dXMoc3RhdHVzKSBjb25zdHJ1Y3RvcnMgZG8gbm90IHNldCBtX3dhc1NlZW5J bkpJVCwKKyAgICAgICAgaXQgaXMgbG9hZGVkIHVuY29uZGl0aW9uYWxseSBpbiBHZXRCeUlkU3Rh dHVzOjpzbG93VmVyc2lvbi4gVGhpcyBhY2Nlc3MgdG8gdGhlCisgICAgICAgIHVuaW5pdGlhbGl6 ZWQgbWVtYmVyIGZpZWxkIGlzIGNhdWdodCBpbiBVQlNhbi4gVGhpcyBwYXRjaCBmaXhlcyBpdCBi eSBhZGRpbmcgYW4gaW5pdGlhbGl6ZXIKKyAgICAgICAgYG1fd2FzU2VlbkluSklUIHsgZmFsc2Ug fWAuCisKKyAgICAgICAgKiBieXRlY29kZS9HZXRCeUlkU3RhdHVzLmg6CisKIDIwMTgtMDgtMTQg IFl1c3VrZSBTdXp1a2kgIDx5dXN1a2VzdXp1a2lAc2xvd3N0YXJ0Lm9yZz4KIAogICAgICAgICBb REZHXSBERkdQcmVkaWN0aW9uUHJvcGFnYXRpb24gc2hvdWxkIHNldCBQcmltYXJ5UGFzcyB3aGVu IHByb2Nlc3NpbmcgaW52YXJpYW50cwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L2J5dGVjb2RlL0dldEJ5SWRTdGF0dXMuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29k ZS9HZXRCeUlkU3RhdHVzLmgKaW5kZXggZTA1N2ZiMzRjYWExNmUwZWY2NjNjZDNjMDk2YTExY2Iw N2ZkZTBmOS4uNTZmZjQwZTVjODJmZTk4OWFiYmJmNjk3MmY0ZGI1YTE1M2Q0ZjBmMCAxMDA2NDQK LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0dldEJ5SWRTdGF0dXMuaAorKysg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvR2V0QnlJZFN0YXR1cy5oCkBAIC0xNTgs NyArMTU4LDcgQEAgY2xhc3MgR2V0QnlJZFN0YXR1cyB7CiAgICAgCiAgICAgU3RhdGUgbV9zdGF0 ZTsKICAgICBWZWN0b3I8R2V0QnlJZFZhcmlhbnQsIDE+IG1fdmFyaWFudHM7Ci0gICAgYm9vbCBt X3dhc1NlZW5JbkpJVDsKKyAgICBib29sIG1fd2FzU2VlbkluSklUIHsgZmFsc2UgfTsKICAgICBK U01vZHVsZU5hbWVzcGFjZU9iamVjdCogbV9tb2R1bGVOYW1lc3BhY2VPYmplY3QgeyBudWxscHRy IH07CiAgICAgSlNNb2R1bGVFbnZpcm9ubWVudCogbV9tb2R1bGVFbnZpcm9ubWVudCB7IG51bGxw dHIgfTsKICAgICBTY29wZU9mZnNldCBtX3Njb3BlT2Zmc2V0IHsgfTsK