188552 2018-08-14 06:11:17 -0700 [GStreamer][GL] useless ifdef in pushTextureToCompositor 2018-08-31 03:25:25 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pnormand pnormand calvaris magomez webkit-bug-importer oldest_to_newest 1449920 0 pnormand 2018-08-14 06:11:17 -0700 . 1449922 1 347070 pnormand 2018-08-14 06:15:10 -0700 Created attachment 347070 Patch 1450241 2 347070 calvaris 2018-08-14 22:46:55 -0700 Comment on attachment 347070 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347070&action=review I think it is ok. Anyway, I'd wait until somebody like Miguel has a look at it as well. > Source/WebCore/ChangeLog:10 > + There's no need for a ifdef because the frame holder already Nit: I think it is aN ifdef > Source/WebCore/ChangeLog:11 > + ensures a valid texture ID will set if it maps a GL video frame. will BE set? 1455182 3 magomez 2018-08-30 00:56:00 -0700 Looks good to me. 1455634 4 pnormand 2018-08-31 03:23:18 -0700 Committed r235543: <https://trac.webkit.org/changeset/235543> 1455635 5 webkit-bug-importer 2018-08-31 03:25:25 -0700 <rdar://problem/43933497> 347070 2018-08-14 06:15:10 -0700 2018-08-14 22:46:55 -0700 Patch bug-188552-20180814141509.patch text/plain 3809 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0ODQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTljNDE2YWM5MDAwZTFh MjQ0NzIzNmMwOTIwYmEzODUzYWIyYzRjOC4uZDlmZDY4NWQwYTRjOTdmNDViY2QwOTcyMzViMDg0 ZjNhZGMxMGI4YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE4LTA4LTE0ICBQaGls aXBwZSBOb3JtYW5kICA8cGhpbG5AaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVyXVtH TF0gdXNlbGVzcyBpZmRlZiBpbiBwdXNoVGV4dHVyZVRvQ29tcG9zaXRvcgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg4NTUyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9n c3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlOjpwdXNoVGV4dHVyZVRvQ29t cG9zaXRvcik6CisgICAgICAgIFRoZXJlJ3Mgbm8gbmVlZCBmb3IgYSBpZmRlZiBiZWNhdXNlIHRo ZSBmcmFtZSBob2xkZXIgYWxyZWFkeQorICAgICAgICBlbnN1cmVzIGEgdmFsaWQgdGV4dHVyZSBJ RCB3aWxsIHNldCBpZiBpdCBtYXBzIGEgR0wgdmlkZW8gZnJhbWUuCisKIDIwMTgtMDgtMTQgIFJv YiBCdWlzICA8cmJ1aXNAaWdhbGlhLmNvbT4KIAogICAgICAgICBGZXRjaDogY29udGVudC1sZW5n dGggaGVhZGVyIGlzIGJlaW5nIGFkZGVkIHRvIHRoZSBzYWZlLWxpc3QKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZh dGVHU3RyZWFtZXJCYXNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dz dHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmNwcAppbmRleCA0OWNjZjg2 NDQ1ZjQ5ZjU4NTEyMmExYWNkN2EzMWE0Y2YyZDNjZTM3Li4wYjZmNDc3MjJmOWQ5MDY0NjZlYzc0 ZjVjMzY3OGFhOWRmMTk0MmFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZS5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVy UHJpdmF0ZUdTdHJlYW1lckJhc2UuY3BwCkBAIC03ODMsMjUgKzc4MywyMiBAQCB2b2lkIE1lZGlh UGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2U6OnB1c2hUZXh0dXJlVG9Db21wb3NpdG9yKCkKIAog ICAgICAgICAgICAgc3RkOjp1bmlxdWVfcHRyPEdzdFZpZGVvRnJhbWVIb2xkZXI+IGZyYW1lSG9s ZGVyID0gc3RkOjptYWtlX3VuaXF1ZTxHc3RWaWRlb0ZyYW1lSG9sZGVyPihtX3NhbXBsZS5nZXQo KSwgdGV4TWFwRmxhZ0Zyb21PcmllbnRhdGlvbihtX3ZpZGVvU291cmNlT3JpZW50YXRpb24pLCAh bV91c2luZ0ZhbGxiYWNrVmlkZW9TaW5rKTsKIAotI2lmIFVTRShHU1RSRUFNRVJfR0wpCiAgICAg ICAgICAgICBHTHVpbnQgdGV4dHVyZUlEID0gZnJhbWVIb2xkZXItPnRleHR1cmVJRCgpOworICAg ICAgICAgICAgc3RkOjp1bmlxdWVfcHRyPFRleHR1cmVNYXBwZXJQbGF0Zm9ybUxheWVyQnVmZmVy PiBsYXllckJ1ZmZlcjsKICAgICAgICAgICAgIGlmICh0ZXh0dXJlSUQpIHsKLSAgICAgICAgICAg ICAgICBzdGQ6OnVuaXF1ZV9wdHI8VGV4dHVyZU1hcHBlclBsYXRmb3JtTGF5ZXJCdWZmZXI+IGxh eWVyQnVmZmVyID0gc3RkOjptYWtlX3VuaXF1ZTxUZXh0dXJlTWFwcGVyUGxhdGZvcm1MYXllckJ1 ZmZlcj4odGV4dHVyZUlELCBmcmFtZUhvbGRlci0+c2l6ZSgpLCBmcmFtZUhvbGRlci0+ZmxhZ3Mo KSwgR3JhcGhpY3NDb250ZXh0M0Q6OlJHQkEpOworICAgICAgICAgICAgICAgIGxheWVyQnVmZmVy ID0gc3RkOjptYWtlX3VuaXF1ZTxUZXh0dXJlTWFwcGVyUGxhdGZvcm1MYXllckJ1ZmZlcj4odGV4 dHVyZUlELCBmcmFtZUhvbGRlci0+c2l6ZSgpLCBmcmFtZUhvbGRlci0+ZmxhZ3MoKSwgR3JhcGhp Y3NDb250ZXh0M0Q6OlJHQkEpOwogICAgICAgICAgICAgICAgIGxheWVyQnVmZmVyLT5zZXRVbm1h bmFnZWRCdWZmZXJEYXRhSG9sZGVyKFdURk1vdmUoZnJhbWVIb2xkZXIpKTsKLSAgICAgICAgICAg ICAgICBwcm94eS5wdXNoTmV4dEJ1ZmZlcihXVEZNb3ZlKGxheWVyQnVmZmVyKSk7Ci0gICAgICAg ICAgICB9IGVsc2UKLSNlbmRpZgotICAgICAgICAgICAgewotICAgICAgICAgICAgICAgIHN0ZDo6 dW5pcXVlX3B0cjxUZXh0dXJlTWFwcGVyUGxhdGZvcm1MYXllckJ1ZmZlcj4gYnVmZmVyID0gcHJv eHkuZ2V0QXZhaWxhYmxlQnVmZmVyKGZyYW1lSG9sZGVyLT5zaXplKCksIEdMX0RPTlRfQ0FSRSk7 Ci0gICAgICAgICAgICAgICAgaWYgKFVOTElLRUxZKCFidWZmZXIpKSB7CisgICAgICAgICAgICB9 IGVsc2UgeworICAgICAgICAgICAgICAgIGxheWVyQnVmZmVyID0gcHJveHkuZ2V0QXZhaWxhYmxl QnVmZmVyKGZyYW1lSG9sZGVyLT5zaXplKCksIEdMX0RPTlRfQ0FSRSk7CisgICAgICAgICAgICAg ICAgaWYgKFVOTElLRUxZKCFsYXllckJ1ZmZlcikpIHsKICAgICAgICAgICAgICAgICAgICAgYXV0 byB0ZXh0dXJlID0gQml0bWFwVGV4dHVyZUdMOjpjcmVhdGUoVGV4dHVyZU1hcHBlckNvbnRleHRB dHRyaWJ1dGVzOjpnZXQoKSk7CiAgICAgICAgICAgICAgICAgICAgIHRleHR1cmUtPnJlc2V0KGZy YW1lSG9sZGVyLT5zaXplKCksIGZyYW1lSG9sZGVyLT5oYXNBbHBoYUNoYW5uZWwoKSA/IEJpdG1h cFRleHR1cmU6OlN1cHBvcnRzQWxwaGEgOiBCaXRtYXBUZXh0dXJlOjpOb0ZsYWcpOwotICAgICAg ICAgICAgICAgICAgICBidWZmZXIgPSBzdGQ6Om1ha2VfdW5pcXVlPFRleHR1cmVNYXBwZXJQbGF0 Zm9ybUxheWVyQnVmZmVyPihXVEZNb3ZlKHRleHR1cmUpKTsKKyAgICAgICAgICAgICAgICAgICAg bGF5ZXJCdWZmZXIgPSBzdGQ6Om1ha2VfdW5pcXVlPFRleHR1cmVNYXBwZXJQbGF0Zm9ybUxheWVy QnVmZmVyPihXVEZNb3ZlKHRleHR1cmUpKTsKICAgICAgICAgICAgICAgICB9Ci0gICAgICAgICAg ICAgICAgZnJhbWVIb2xkZXItPnVwZGF0ZVRleHR1cmUoYnVmZmVyLT50ZXh0dXJlR0woKSk7Ci0g ICAgICAgICAgICAgICAgYnVmZmVyLT5zZXRFeHRyYUZsYWdzKHRleE1hcEZsYWdGcm9tT3JpZW50 YXRpb24obV92aWRlb1NvdXJjZU9yaWVudGF0aW9uKSB8IChmcmFtZUhvbGRlci0+aGFzQWxwaGFD aGFubmVsKCkgPyBUZXh0dXJlTWFwcGVyR0w6OlNob3VsZEJsZW5kIDogMCkpOwotICAgICAgICAg ICAgICAgIHByb3h5LnB1c2hOZXh0QnVmZmVyKFdURk1vdmUoYnVmZmVyKSk7CisgICAgICAgICAg ICAgICAgZnJhbWVIb2xkZXItPnVwZGF0ZVRleHR1cmUobGF5ZXJCdWZmZXItPnRleHR1cmVHTCgp KTsKKyAgICAgICAgICAgICAgICBsYXllckJ1ZmZlci0+c2V0RXh0cmFGbGFncyh0ZXhNYXBGbGFn RnJvbU9yaWVudGF0aW9uKG1fdmlkZW9Tb3VyY2VPcmllbnRhdGlvbikgfCAoZnJhbWVIb2xkZXIt Pmhhc0FscGhhQ2hhbm5lbCgpID8gVGV4dHVyZU1hcHBlckdMOjpTaG91bGRCbGVuZCA6IDApKTsK ICAgICAgICAgICAgIH0KKyAgICAgICAgICAgIHByb3h5LnB1c2hOZXh0QnVmZmVyKFdURk1vdmUo bGF5ZXJCdWZmZXIpKTsKICAgICAgICAgfTsKIAogI2lmIFVTRShOSUNPU0lBKQo=