188541 2018-08-13 18:24:28 -0700 [LFC][Floating] Do not confuse clear with clearance. 2018-08-13 18:48:18 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham simon.fraser webkit-bug-importer zalan oldest_to_newest 1449865 0 zalan 2018-08-13 18:24:28 -0700 clear -> clear property clearance -> the offset required to avoid floats when clear is present. 1449868 1 347060 zalan 2018-08-13 18:28:51 -0700 Created attachment 347060 Patch 1449869 2 347060 simon.fraser 2018-08-13 18:37:37 -0700 Comment on attachment 347060 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347060&action=review > Source/WebCore/layout/blockformatting/BlockFormattingContext.h:60 > + void computeVerticalPositionForClear(const FloatingContext&, const Box&, Display::Box&) const; I would like to see the word "float" somewhere in the function name. > Source/WebCore/layout/layouttree/LayoutBox.h:65 > + bool hasClear() const; This name sounds a bit too generic. Maybe hasFloatClear, or clearsFloats? 1449870 3 zalan 2018-08-13 18:47:43 -0700 Committed r234834: <https://trac.webkit.org/changeset/234834> 1449871 4 webkit-bug-importer 2018-08-13 18:48:18 -0700 <rdar://problem/43264418> 347060 2018-08-13 18:28:51 -0700 2018-08-13 18:37:37 -0700 Patch bug-188541-20180813182850.patch text/plain 6069 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0ODAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTNiNjgyNWM0NjhkYzdk MzM5ODU2YTYxODczM2ZjYzhkNzFhZjEyMy4uNzVmYTg0MWRiMDE4ODU3Mzc1Zjk0Mjk3NTc2NWJj YjkyZWU4ZTBmYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE4LTA4LTEzICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bRmxvYXRpbmddIERv IG5vdCBjb25mdXNlIGNsZWFyIHdpdGggY2xlYXJhbmNlLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg4NTQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgY2xlYXIgLT4gQ1NTIHByb3BlcnR5LgorICAgICAg ICBjbGVhcmFuY2UgLT4gdGhlIG9mZnNldCByZXF1aXJlZCB0byBhdm9pZCBmbG9hdHMgd2hlbiBj bGVhciBpcyBwcmVzZW50LgorCisgICAgICAgICogbGF5b3V0L0Zsb2F0aW5nQ29udGV4dC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OkZsb2F0aW5nQ29udGV4dDo6dmVydGljYWxQb3Np dGlvbldpdGhDbGVhcmFuY2UgY29uc3QpOgorICAgICAgICAqIGxheW91dC9ibG9ja2Zvcm1hdHRp bmcvQmxvY2tGb3JtYXR0aW5nQ29udGV4dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6 OkJsb2NrRm9ybWF0dGluZ0NvbnRleHQ6OmxheW91dCBjb25zdCk6CisgICAgICAgIChXZWJDb3Jl OjpMYXlvdXQ6OkJsb2NrRm9ybWF0dGluZ0NvbnRleHQ6OmNvbXB1dGVWZXJ0aWNhbFBvc2l0aW9u Rm9yQ2xlYXIgY29uc3QpOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpCbG9ja0Zvcm1hdHRp bmdDb250ZXh0Ojpjb21wdXRlVmVydGljYWxQb3NpdGlvbldpdGhDbGVhcmFuY2UgY29uc3QpOiBE ZWxldGVkLgorICAgICAgICAqIGxheW91dC9ibG9ja2Zvcm1hdHRpbmcvQmxvY2tGb3JtYXR0aW5n Q29udGV4dC5oOgorICAgICAgICAqIGxheW91dC9sYXlvdXR0cmVlL0xheW91dEJveC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OkJveDo6aGFzQ2xlYXIgY29uc3QpOgorICAgICAgICAo V2ViQ29yZTo6TGF5b3V0OjpCb3g6Omhhc0NsZWFyYW5jZSBjb25zdCk6IERlbGV0ZWQuCisgICAg ICAgICogbGF5b3V0L2xheW91dHRyZWUvTGF5b3V0Qm94Lmg6CisKIDIwMTgtMDgtMTMgIFphbGFu IEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbTEZDXVtGbG9hdGluZ10gQWRk IGJhc2ljIGNsZWFyYW5jZSBzdXBwb3J0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlv dXQvRmxvYXRpbmdDb250ZXh0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9GbG9hdGluZ0Nv bnRleHQuY3BwCmluZGV4IDM5MGI4NThkZjEyZTJiNWU4M2M3ZDM3MjZkZDMzMmNkMWM4YmNjMTIu LjUxMjZjYzI1OTQyODkwMmEyZDg1OTkzOTlhYjFmZGM3MGI1ZGZlZjMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2xheW91dC9GbG9hdGluZ0NvbnRleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL2xheW91dC9GbG9hdGluZ0NvbnRleHQuY3BwCkBAIC0xMzMsNyArMTMzLDcgQEAgUG9zaXRp b24gRmxvYXRpbmdDb250ZXh0Ojpwb3NpdGlvbkZvckZsb2F0KGNvbnN0IEJveCYgbGF5b3V0Qm94 KSBjb25zdAogCiBzdGQ6Om9wdGlvbmFsPExheW91dFVuaXQ+IEZsb2F0aW5nQ29udGV4dDo6dmVy dGljYWxQb3NpdGlvbldpdGhDbGVhcmFuY2UoY29uc3QgQm94JiBsYXlvdXRCb3gpIGNvbnN0CiB7 Ci0gICAgQVNTRVJUKGxheW91dEJveC5oYXNDbGVhcmFuY2UoKSk7CisgICAgQVNTRVJUKGxheW91 dEJveC5oYXNDbGVhcigpKTsKICAgICBBU1NFUlQobGF5b3V0Qm94LmlzQmxvY2tMZXZlbEJveCgp KTsKIAogICAgIGlmIChtX2Zsb2F0aW5nU3RhdGUuaXNFbXB0eSgpKQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvbGF5b3V0L2Jsb2NrZm9ybWF0dGluZy9CbG9ja0Zvcm1hdHRpbmdDb250ZXh0 LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9ibG9ja2Zvcm1hdHRpbmcvQmxvY2tGb3JtYXR0 aW5nQ29udGV4dC5jcHAKaW5kZXggYjgyZWMwNTg2MjlhM2U3OTdiZDQxMmYyMjE1MjRiMzYwODRm MGNlOS4uMTBjYmRkYjg2NzYyZDBmNzM3NTExMWEyNzJkZjAzODE3MDkxNGYzMCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Jsb2NrZm9ybWF0dGluZy9CbG9ja0Zvcm1hdHRpbmdD b250ZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvYmxvY2tmb3JtYXR0aW5nL0Js b2NrRm9ybWF0dGluZ0NvbnRleHQuY3BwCkBAIC0xMTIsOCArMTEyLDggQEAgdm9pZCBCbG9ja0Zv cm1hdHRpbmdDb250ZXh0OjpsYXlvdXQoTGF5b3V0Q29udGV4dCYgbGF5b3V0Q29udGV4dCwgRm9y bWF0dGluZ1N0YXQKICAgICAgICAgICAgIEFTU0VSVCghbGF5b3V0Qm94LmVzdGFibGlzaGVzRm9y bWF0dGluZ0NvbnRleHQoKSk7CiAgICAgICAgICAgICBjb21wdXRlSGVpZ2h0QW5kTWFyZ2luKGxh eW91dENvbnRleHQsIGxheW91dEJveCwgZGlzcGxheUJveCk7CiAgICAgICAgICAgICAvLyBGaW5h bGl6ZSBwb3NpdGlvbiB3aXRoIGNsZWFyYW5jZS4KLSAgICAgICAgICAgIGlmIChsYXlvdXRCb3gu aGFzQ2xlYXJhbmNlKCkpCi0gICAgICAgICAgICAgICAgY29tcHV0ZVZlcnRpY2FsUG9zaXRpb25X aXRoQ2xlYXJhbmNlKGZsb2F0aW5nQ29udGV4dCwgbGF5b3V0Qm94LCBkaXNwbGF5Qm94KTsKKyAg ICAgICAgICAgIGlmIChsYXlvdXRCb3guaGFzQ2xlYXIoKSkKKyAgICAgICAgICAgICAgICBjb21w dXRlVmVydGljYWxQb3NpdGlvbkZvckNsZWFyKGZsb2F0aW5nQ29udGV4dCwgbGF5b3V0Qm94LCBk aXNwbGF5Qm94KTsKICAgICAgICAgICAgIGlmICghaXM8Q29udGFpbmVyPihsYXlvdXRCb3gpKQog ICAgICAgICAgICAgICAgIGNvbnRpbnVlOwogICAgICAgICAgICAgYXV0byYgY29udGFpbmVyID0g ZG93bmNhc3Q8Q29udGFpbmVyPihsYXlvdXRCb3gpOwpAQCAtMTYzLDkgKzE2Myw5IEBAIHZvaWQg QmxvY2tGb3JtYXR0aW5nQ29udGV4dDo6Y29tcHV0ZUZsb2F0aW5nUG9zaXRpb24oRmxvYXRpbmdD b250ZXh0JiBmbG9hdGluZ0NvCiAgICAgZmxvYXRpbmdDb250ZXh0LmZsb2F0aW5nU3RhdGUoKS5h cHBlbmQobGF5b3V0Qm94KTsKIH0KIAotdm9pZCBCbG9ja0Zvcm1hdHRpbmdDb250ZXh0Ojpjb21w dXRlVmVydGljYWxQb3NpdGlvbldpdGhDbGVhcmFuY2UoY29uc3QgRmxvYXRpbmdDb250ZXh0JiBm bG9hdGluZ0NvbnRleHQsIGNvbnN0IEJveCYgbGF5b3V0Qm94LCBEaXNwbGF5OjpCb3gmIGRpc3Bs YXlCb3gpIGNvbnN0Cit2b2lkIEJsb2NrRm9ybWF0dGluZ0NvbnRleHQ6OmNvbXB1dGVWZXJ0aWNh bFBvc2l0aW9uRm9yQ2xlYXIoY29uc3QgRmxvYXRpbmdDb250ZXh0JiBmbG9hdGluZ0NvbnRleHQs IGNvbnN0IEJveCYgbGF5b3V0Qm94LCBEaXNwbGF5OjpCb3gmIGRpc3BsYXlCb3gpIGNvbnN0CiB7 Ci0gICAgQVNTRVJUKGxheW91dEJveC5oYXNDbGVhcmFuY2UoKSk7CisgICAgQVNTRVJUKGxheW91 dEJveC5oYXNDbGVhcigpKTsKICAgICBpZiAoYXV0byB2ZXJ0aWNhbFBvc2l0aW9uV2l0aENsZWFy YW5jZSA9IGZsb2F0aW5nQ29udGV4dC52ZXJ0aWNhbFBvc2l0aW9uV2l0aENsZWFyYW5jZShsYXlv dXRCb3gpKQogICAgICAgICBkaXNwbGF5Qm94LnNldFRvcCgqdmVydGljYWxQb3NpdGlvbldpdGhD bGVhcmFuY2UpOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Jsb2NrZm9y bWF0dGluZy9CbG9ja0Zvcm1hdHRpbmdDb250ZXh0LmggYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQv YmxvY2tmb3JtYXR0aW5nL0Jsb2NrRm9ybWF0dGluZ0NvbnRleHQuaAppbmRleCA0MWFmMTE4Nzhl NDAwYzJiMjAzYjc2NzYwOGQ2NjA4MWJhOGM4MTk5Li4yODljNzMyYmEzYzY0YjUxZjM5MzdmODA5 YTk2ZjRkNjIyZTVkNjliIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvYmxvY2tm b3JtYXR0aW5nL0Jsb2NrRm9ybWF0dGluZ0NvbnRleHQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9s YXlvdXQvYmxvY2tmb3JtYXR0aW5nL0Jsb2NrRm9ybWF0dGluZ0NvbnRleHQuaApAQCAtNTcsNyAr NTcsNyBAQCBwcml2YXRlOgogCiAgICAgdm9pZCBjb21wdXRlU3RhdGljUG9zaXRpb24oTGF5b3V0 Q29udGV4dCYsIGNvbnN0IEJveCYsIERpc3BsYXk6OkJveCYpIGNvbnN0IG92ZXJyaWRlOwogICAg IHZvaWQgY29tcHV0ZUZsb2F0aW5nUG9zaXRpb24oRmxvYXRpbmdDb250ZXh0JiwgY29uc3QgQm94 JiwgRGlzcGxheTo6Qm94JikgY29uc3Q7Ci0gICAgdm9pZCBjb21wdXRlVmVydGljYWxQb3NpdGlv bldpdGhDbGVhcmFuY2UoY29uc3QgRmxvYXRpbmdDb250ZXh0JiwgY29uc3QgQm94JiwgRGlzcGxh eTo6Qm94JikgY29uc3Q7CisgICAgdm9pZCBjb21wdXRlVmVydGljYWxQb3NpdGlvbkZvckNsZWFy KGNvbnN0IEZsb2F0aW5nQ29udGV4dCYsIGNvbnN0IEJveCYsIERpc3BsYXk6OkJveCYpIGNvbnN0 OwogICAgIHZvaWQgY29tcHV0ZUluRmxvd1Bvc2l0aW9uZWRQb3NpdGlvbihMYXlvdXRDb250ZXh0 JiwgY29uc3QgQm94JiwgRGlzcGxheTo6Qm94JikgY29uc3Qgb3ZlcnJpZGU7CiAgICAgdm9pZCBj b21wdXRlSW5GbG93V2lkdGhBbmRNYXJnaW4oTGF5b3V0Q29udGV4dCYsIGNvbnN0IEJveCYsIERp c3BsYXk6OkJveCYpIGNvbnN0OwogICAgIHZvaWQgY29tcHV0ZUluRmxvd0hlaWdodEFuZE1hcmdp bihMYXlvdXRDb250ZXh0JiwgY29uc3QgQm94JiwgRGlzcGxheTo6Qm94JikgY29uc3Q7CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvbGF5b3V0dHJlZS9MYXlvdXRCb3guY3BwIGIv U291cmNlL1dlYkNvcmUvbGF5b3V0L2xheW91dHRyZWUvTGF5b3V0Qm94LmNwcAppbmRleCAzYmQw MzI4YzNkZmNmNTIxNDU1M2JlMGFjYzNjY2EzYWQ5ZWFhNTQ2Li5hYmUwY2VkMmM4YzQ3ZWY4ZDk0 Nzc5NmJmYzdkMGM4NmNkYzdkNGRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQv bGF5b3V0dHJlZS9MYXlvdXRCb3guY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9sYXlv dXR0cmVlL0xheW91dEJveC5jcHAKQEAgLTExNCw3ICsxMTQsNyBAQCBib29sIEJveDo6aXNSaWdo dEZsb2F0aW5nUG9zaXRpb25lZCgpIGNvbnN0CiAgICAgcmV0dXJuIG1fc3R5bGUuZmxvYXRpbmco KSA9PSBGbG9hdDo6UmlnaHQ7CiB9CiAKLWJvb2wgQm94OjpoYXNDbGVhcmFuY2UoKSBjb25zdAor Ym9vbCBCb3g6Omhhc0NsZWFyKCkgY29uc3QKIHsKICAgICByZXR1cm4gbV9zdHlsZS5jbGVhcigp ICE9IENsZWFyOjpOb25lOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2xh eW91dHRyZWUvTGF5b3V0Qm94LmggYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvbGF5b3V0dHJlZS9M YXlvdXRCb3guaAppbmRleCAyMWRjNjU3YzY5Y2U3NjhjNTU0ZDVjYzEzYjc3NTljYzc2ZjcwMDJi Li44MDdhYmI4ZWMwNTM4MWU1N2Y3NWZkOTJhYTZhZmQ5MDEwNjEzZDEzIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9sYXlvdXQvbGF5b3V0dHJlZS9MYXlvdXRCb3guaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9sYXlvdXQvbGF5b3V0dHJlZS9MYXlvdXRCb3guaApAQCAtNjIsNyArNjIsNyBAQCBw dWJsaWM6CiAgICAgYm9vbCBpc0Zsb2F0aW5nUG9zaXRpb25lZCgpIGNvbnN0OwogICAgIGJvb2wg aXNMZWZ0RmxvYXRpbmdQb3NpdGlvbmVkKCkgY29uc3Q7CiAgICAgYm9vbCBpc1JpZ2h0RmxvYXRp bmdQb3NpdGlvbmVkKCkgY29uc3Q7Ci0gICAgYm9vbCBoYXNDbGVhcmFuY2UoKSBjb25zdDsKKyAg ICBib29sIGhhc0NsZWFyKCkgY29uc3Q7CiAKICAgICBib29sIGlzRmxvYXRpbmdPck91dE9mRmxv d1Bvc2l0aW9uZWQoKSBjb25zdCB7IHJldHVybiBpc0Zsb2F0aW5nUG9zaXRpb25lZCgpIHx8IGlz T3V0T2ZGbG93UG9zaXRpb25lZCgpOyB9CiAK