<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>188531</bug_id>
          
          <creation_ts>2018-08-13 14:27:11 -0700</creation_ts>
          <short_desc>[ews-build] Add support for max_builds parameter for workers</short_desc>
          <delta_ts>2018-08-14 09:54:21 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>Other</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Aakash Jain">aakash_jain</reporter>
          <assigned_to name="Aakash Jain">aakash_jain</assigned_to>
          <cc>aakash_jain</cc>
    
    <cc>ap</cc>
    
    <cc>commit-queue</cc>
    
    <cc>lforschler</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1449769</commentid>
    <comment_count>0</comment_count>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2018-08-13 14:27:11 -0700</bug_when>
    <thetext>In the current EWS configuration, one worker can be configured on multiple queues (e.g.: webkit-misc). Buildbot provides a config parameter named max_builds which indicates the max number of builds which a bot can do in parallel. 

We should add support for max_builds parameter in loadConfig.py. The default value of this parameter should be 1 so that the bots do not unintentionally starts multiple builds in parallel. For the bots which are expected to run multiple builds, max_builds parameter should be specified in config.json</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1449774</commentid>
    <comment_count>1</comment_count>
      <attachid>347038</attachid>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2018-08-13 14:31:58 -0700</bug_when>
    <thetext>Created attachment 347038
Proposed patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1449970</commentid>
    <comment_count>2</comment_count>
      <attachid>347038</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-08-14 09:53:15 -0700</bug_when>
    <thetext>Comment on attachment 347038
Proposed patch

Clearing flags on attachment: 347038

Committed r234850: &lt;https://trac.webkit.org/changeset/234850&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1449971</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-08-14 09:53:17 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1449972</commentid>
    <comment_count>4</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-08-14 09:54:21 -0700</bug_when>
    <thetext>&lt;rdar://problem/43291069&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>347038</attachid>
            <date>2018-08-13 14:31:58 -0700</date>
            <delta_ts>2018-08-14 09:53:15 -0700</delta_ts>
            <desc>Proposed patch</desc>
            <filename>ews_max_builds.patch</filename>
            <type>text/plain</type>
            <size>1495</size>
            <attacher name="Aakash Jain">aakash_jain</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDIzNDgxNykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDEzIEBACisyMDE4LTA4LTEzICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv
bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBBZGQgc3VwcG9ydCBmb3IgbWF4X2J1aWxkcyBwYXJh
bWV0ZXIgZm9yIHdvcmtlcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i
dWcuY2dpP2lkPTE4ODUzMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor
CisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2xvYWRDb25maWcucHk6Cisg
ICAgICAgIChsb2FkQnVpbGRlckNvbmZpZyk6IEFkZGVkIHN1cHBvcnQgZm9yIG1heF9idWlsZHMu
CisKIDIwMTgtMDgtMTMgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAK
ICAgICAgICAgW1dLMl0gW21hY09TXSBJbXBsZW1lbnQgYSBtZWNoYW5pc20gdG8gdGVzdCBkcmFn
IGFuZCBkcm9wCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvbG9hZENv
bmZpZy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQv
bG9hZENvbmZpZy5weQkocmV2aXNpb24gMjM0NzkwKQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBv
cnQvZXdzLWJ1aWxkL2xvYWRDb25maWcucHkJKHdvcmtpbmcgY29weSkKQEAgLTQzLDcgKzQzLDcg
QEAgZGVmIGxvYWRCdWlsZGVyQ29uZmlnKGMsIHVzZV9sb2NhbGhvc3RfdwogICAgIGNoZWNrV29y
a2Vyc0FuZEJ1aWxkZXJzRm9yQ29uc2lzdGVuY3koY29uZmlnLCBjb25maWdbJ3dvcmtlcnMnXSwg
Y29uZmlnWydidWlsZGVycyddKQogICAgIGNoZWNrVmFsaWRTY2hlZHVsZXJzKGNvbmZpZywgY29u
ZmlnWydzY2hlZHVsZXJzJ10pCiAKLSAgICBjWyd3b3JrZXJzJ10gPSBbV29ya2VyKHdvcmtlclsn
bmFtZSddLCBwYXNzd29yZHMuZ2V0KHdvcmtlclsnbmFtZSddLCAncGFzc3dvcmQnKSkgZm9yIHdv
cmtlciBpbiBjb25maWdbJ3dvcmtlcnMnXV0KKyAgICBjWyd3b3JrZXJzJ10gPSBbV29ya2VyKHdv
cmtlclsnbmFtZSddLCBwYXNzd29yZHMuZ2V0KHdvcmtlclsnbmFtZSddLCAncGFzc3dvcmQnKSwg
bWF4X2J1aWxkcz13b3JrZXIuZ2V0KCdtYXhfYnVpbGRzJywgMSkpIGZvciB3b3JrZXIgaW4gY29u
ZmlnWyd3b3JrZXJzJ11dCiAgICAgaWYgdXNlX2xvY2FsaG9zdF93b3JrZXI6CiAgICAgICAgIGNb
J3dvcmtlcnMnXS5hcHBlbmQoV29ya2VyKCdsb2NhbC13b3JrZXInLCAncGFzc3dvcmQnLCBtYXhf
YnVpbGRzPTIpKQogCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>