<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>188517</bug_id>
          
          <creation_ts>2018-08-13 08:50:45 -0700</creation_ts>
          <short_desc>[WHLSL] Verify the parser uses the same grammar as the language</short_desc>
          <delta_ts>2018-10-13 15:35:46 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebGPU</component>
          <version>Other</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>MOVED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>176199</blocked>
    
    <blocked>189202</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Thomas Denney">tdenney</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>dino</cc>
    
    <cc>jonlee</cc>
    
    <cc>mmaxfield</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1449643</commentid>
    <comment_count>0</comment_count>
    <who name="Thomas Denney">tdenney</who>
    <bug_when>2018-08-13 08:50:45 -0700</bug_when>
    <thetext>The current hand-written recursive-descent parser is relatively slow and is the main bottleneck of the `prepare` function. The parser should be rewritten using a tool that produces more efficient code, such as https://github.com/antlr/antlr4.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1454128</commentid>
    <comment_count>1</comment_count>
    <who name="Myles C. Maxfield">mmaxfield</who>
    <bug_when>2018-08-27 15:21:28 -0700</bug_when>
    <thetext>*** Bug 189014 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1454129</commentid>
    <comment_count>2</comment_count>
    <who name="Myles C. Maxfield">mmaxfield</who>
    <bug_when>2018-08-27 15:22:11 -0700</bug_when>
    <thetext>It takes 2.5 hours to compile the standard library. 95% of the time is spent parsing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1454602</commentid>
    <comment_count>3</comment_count>
    <who name="Myles C. Maxfield">mmaxfield</who>
    <bug_when>2018-08-28 15:55:01 -0700</bug_when>
    <thetext>One way to do this is by using a parser generator. Another way of doing this is with testing. Another way is via inspection.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1459219</commentid>
    <comment_count>4</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-09-12 18:51:31 -0700</bug_when>
    <thetext>&lt;rdar://problem/44403020&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1468900</commentid>
    <comment_count>5</comment_count>
    <who name="Myles C. Maxfield">mmaxfield</who>
    <bug_when>2018-10-13 15:35:46 -0700</bug_when>
    <thetext>Migrated to https://github.com/gpuweb/WHLSL/issues/101</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>