188511 2018-08-13 05:18:22 -0700 WebDriver: include all capabilities in the new session response 2018-08-13 23:53:14 -0700 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cgarcia webkit-unassigned aperez bburg bugs-noreply webkit-bug-importer oldest_to_newest 1449618 0 cgarcia 2018-08-13 05:18:22 -0700 As expected by the tests, using the default values when the capability is not provided by the user. 1449619 1 347011 cgarcia 2018-08-13 05:20:23 -0700 Created attachment 347011 Patch 1449691 2 347011 aperez 2018-08-13 11:24:21 -0700 Comment on attachment 347011 Patch Informal r+, LGTM. 1449759 3 347011 bburg 2018-08-13 14:01:30 -0700 Comment on attachment 347011 Patch r=me, although I don't know if emptyString() as a default value may confuse some downstream software like Selenium or Grid. 1449890 4 cgarcia 2018-08-13 23:51:55 -0700 Committed r234837: <https://trac.webkit.org/changeset/234837> 1449891 5 webkit-bug-importer 2018-08-13 23:53:14 -0700 <rdar://problem/43272816> 347011 2018-08-13 05:20:23 -0700 2018-08-13 14:01:30 -0700 Patch wd-capabilities-default.diff text/plain 4787 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkRyaXZl ci9DaGFuZ2VMb2cKaW5kZXggYmY1OThlOTBlODguLmFlNmZlMDc2MzJiIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE1IEBACisyMDE4LTA4LTEzICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNn YXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBXZWJEcml2ZXI6IGluY2x1ZGUgYWxsIGNhcGFi aWxpdGllcyBpbiB0aGUgbmV3IHNlc3Npb24gcmVzcG9uc2UKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4ODUxMQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFzIGV4cGVjdGVkIGJ5IHRoZSB0ZXN0cywgdXNp bmcgdGhlIGRlZmF1bHQgdmFsdWVzIHdoZW4gdGhlIGNhcGFiaWxpdHkgaXMgbm90IHByb3ZpZGVk IGJ5IHRoZSB1c2VyLgorCisgICAgICAgICogV2ViRHJpdmVyU2VydmljZS5jcHA6CisgICAgICAg IChXZWJEcml2ZXI6OldlYkRyaXZlclNlcnZpY2U6OmNyZWF0ZVNlc3Npb24pOgorCiAyMDE4LTA4 LTEzICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAg ICBXZWJEcml2ZXI6IHNldmVyYWwgZWxlbWVudF9zZW5kX2tleXMgdGVzdHMgYXJlIGZhaWxpbmcg c2luY2UgYWRkZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJEcml2ZXIvV2ViRHJpdmVyU2Vydmlj ZS5jcHAgYi9Tb3VyY2UvV2ViRHJpdmVyL1dlYkRyaXZlclNlcnZpY2UuY3BwCmluZGV4IDA3NmNh MDA0MGQ4Li5kYWIwZmE4NGNlMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkRyaXZlci9XZWJEcml2 ZXJTZXJ2aWNlLmNwcAorKysgYi9Tb3VyY2UvV2ViRHJpdmVyL1dlYkRyaXZlclNlcnZpY2UuY3Bw CkBAIC02OTUsMzQgKzY5NSwyNyBAQCB2b2lkIFdlYkRyaXZlclNlcnZpY2U6OmNyZWF0ZVNlc3Np b24oVmVjdG9yPENhcGFiaWxpdGllcz4mJiBjYXBhYmlsaXRpZXNMaXN0LCBzdAogICAgICAgICAg ICAgcmVzdWx0T2JqZWN0LT5zZXRTdHJpbmcoInNlc3Npb25JZCJfcywgbV9zZXNzaW9uLT5pZCgp KTsKICAgICAgICAgICAgIFJlZlB0cjxKU09OOjpPYmplY3Q+IGNhcGFiaWxpdGllc09iamVjdCA9 IEpTT046Ok9iamVjdDo6Y3JlYXRlKCk7CiAgICAgICAgICAgICBjb25zdCBhdXRvJiBjYXBhYmls aXRpZXMgPSBtX3Nlc3Npb24tPmNhcGFiaWxpdGllcygpOwotICAgICAgICAgICAgaWYgKGNhcGFi aWxpdGllcy5icm93c2VyTmFtZSkKLSAgICAgICAgICAgICAgICBjYXBhYmlsaXRpZXNPYmplY3Qt PnNldFN0cmluZygiYnJvd3Nlck5hbWUiX3MsIGNhcGFiaWxpdGllcy5icm93c2VyTmFtZS52YWx1 ZSgpKTsKLSAgICAgICAgICAgIGlmIChjYXBhYmlsaXRpZXMuYnJvd3NlclZlcnNpb24pCi0gICAg ICAgICAgICAgICAgY2FwYWJpbGl0aWVzT2JqZWN0LT5zZXRTdHJpbmcoImJyb3dzZXJWZXJzaW9u Il9zLCBjYXBhYmlsaXRpZXMuYnJvd3NlclZlcnNpb24udmFsdWUoKSk7Ci0gICAgICAgICAgICBp ZiAoY2FwYWJpbGl0aWVzLnBsYXRmb3JtTmFtZSkKLSAgICAgICAgICAgICAgICBjYXBhYmlsaXRp ZXNPYmplY3QtPnNldFN0cmluZygicGxhdGZvcm1OYW1lIl9zLCBjYXBhYmlsaXRpZXMucGxhdGZv cm1OYW1lLnZhbHVlKCkpOwotICAgICAgICAgICAgaWYgKGNhcGFiaWxpdGllcy5hY2NlcHRJbnNl Y3VyZUNlcnRzKQotICAgICAgICAgICAgICAgIGNhcGFiaWxpdGllc09iamVjdC0+c2V0Qm9vbGVh bigiYWNjZXB0SW5zZWN1cmVDZXJ0cyJfcywgY2FwYWJpbGl0aWVzLmFjY2VwdEluc2VjdXJlQ2Vy dHMudmFsdWUoKSk7Ci0gICAgICAgICAgICBpZiAoY2FwYWJpbGl0aWVzLnNldFdpbmRvd1JlY3Qp Ci0gICAgICAgICAgICAgICAgY2FwYWJpbGl0aWVzT2JqZWN0LT5zZXRCb29sZWFuKCJzZXRXaW5k b3dSZWN0Il9zLCBjYXBhYmlsaXRpZXMuc2V0V2luZG93UmVjdC52YWx1ZSgpKTsKLSAgICAgICAg ICAgIGlmIChjYXBhYmlsaXRpZXMudW5oYW5kbGVkUHJvbXB0QmVoYXZpb3IpIHsKLSAgICAgICAg ICAgICAgICBzd2l0Y2ggKGNhcGFiaWxpdGllcy51bmhhbmRsZWRQcm9tcHRCZWhhdmlvci52YWx1 ZSgpKSB7Ci0gICAgICAgICAgICAgICAgY2FzZSBVbmhhbmRsZWRQcm9tcHRCZWhhdmlvcjo6RGlz bWlzczoKLSAgICAgICAgICAgICAgICAgICAgY2FwYWJpbGl0aWVzT2JqZWN0LT5zZXRTdHJpbmco InVuaGFuZGxlZFByb21wdEJlaGF2aW9yIl9zLCAiZGlzbWlzcyIpOwotICAgICAgICAgICAgICAg ICAgICBicmVhazsKLSAgICAgICAgICAgICAgICBjYXNlIFVuaGFuZGxlZFByb21wdEJlaGF2aW9y OjpBY2NlcHQ6Ci0gICAgICAgICAgICAgICAgICAgIGNhcGFiaWxpdGllc09iamVjdC0+c2V0U3Ry aW5nKCJ1bmhhbmRsZWRQcm9tcHRCZWhhdmlvciJfcywgImFjY2VwdCIpOwotICAgICAgICAgICAg ICAgICAgICBicmVhazsKLSAgICAgICAgICAgICAgICBjYXNlIFVuaGFuZGxlZFByb21wdEJlaGF2 aW9yOjpEaXNtaXNzQW5kTm90aWZ5OgotICAgICAgICAgICAgICAgICAgICBjYXBhYmlsaXRpZXNP YmplY3QtPnNldFN0cmluZygidW5oYW5kbGVkUHJvbXB0QmVoYXZpb3IiX3MsICJkaXNtaXNzIGFu ZCBub3RpZnkiKTsKLSAgICAgICAgICAgICAgICAgICAgYnJlYWs7Ci0gICAgICAgICAgICAgICAg Y2FzZSBVbmhhbmRsZWRQcm9tcHRCZWhhdmlvcjo6QWNjZXB0QW5kTm90aWZ5OgotICAgICAgICAg ICAgICAgICAgICBjYXBhYmlsaXRpZXNPYmplY3QtPnNldFN0cmluZygidW5oYW5kbGVkUHJvbXB0 QmVoYXZpb3IiX3MsICJhY2NlcHQgYW5kIG5vdGlmeSIpOwotICAgICAgICAgICAgICAgICAgICBi cmVhazsKLSAgICAgICAgICAgICAgICBjYXNlIFVuaGFuZGxlZFByb21wdEJlaGF2aW9yOjpJZ25v cmU6Ci0gICAgICAgICAgICAgICAgICAgIGNhcGFiaWxpdGllc09iamVjdC0+c2V0U3RyaW5nKCJ1 bmhhbmRsZWRQcm9tcHRCZWhhdmlvciJfcywgImlnbm9yZSIpOwotICAgICAgICAgICAgICAgICAg ICBicmVhazsKLSAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICBjYXBhYmlsaXRpZXNPYmpl Y3QtPnNldFN0cmluZygiYnJvd3Nlck5hbWUiX3MsIGNhcGFiaWxpdGllcy5icm93c2VyTmFtZS52 YWx1ZV9vcihlbXB0eVN0cmluZygpKSk7CisgICAgICAgICAgICBjYXBhYmlsaXRpZXNPYmplY3Qt PnNldFN0cmluZygiYnJvd3NlclZlcnNpb24iX3MsIGNhcGFiaWxpdGllcy5icm93c2VyVmVyc2lv bi52YWx1ZV9vcihlbXB0eVN0cmluZygpKSk7CisgICAgICAgICAgICBjYXBhYmlsaXRpZXNPYmpl Y3QtPnNldFN0cmluZygicGxhdGZvcm1OYW1lIl9zLCBjYXBhYmlsaXRpZXMucGxhdGZvcm1OYW1l LnZhbHVlX29yKGVtcHR5U3RyaW5nKCkpKTsKKyAgICAgICAgICAgIGNhcGFiaWxpdGllc09iamVj dC0+c2V0Qm9vbGVhbigiYWNjZXB0SW5zZWN1cmVDZXJ0cyJfcywgY2FwYWJpbGl0aWVzLmFjY2Vw dEluc2VjdXJlQ2VydHMudmFsdWVfb3IoZmFsc2UpKTsKKyAgICAgICAgICAgIGNhcGFiaWxpdGll c09iamVjdC0+c2V0Qm9vbGVhbigic2V0V2luZG93UmVjdCJfcywgY2FwYWJpbGl0aWVzLnNldFdp bmRvd1JlY3QudmFsdWVfb3IodHJ1ZSkpOworICAgICAgICAgICAgc3dpdGNoIChjYXBhYmlsaXRp ZXMudW5oYW5kbGVkUHJvbXB0QmVoYXZpb3IudmFsdWVfb3IoVW5oYW5kbGVkUHJvbXB0QmVoYXZp b3I6OkRpc21pc3NBbmROb3RpZnkpKSB7CisgICAgICAgICAgICBjYXNlIFVuaGFuZGxlZFByb21w dEJlaGF2aW9yOjpEaXNtaXNzOgorICAgICAgICAgICAgICAgIGNhcGFiaWxpdGllc09iamVjdC0+ c2V0U3RyaW5nKCJ1bmhhbmRsZWRQcm9tcHRCZWhhdmlvciJfcywgImRpc21pc3MiKTsKKyAgICAg ICAgICAgICAgICBicmVhazsKKyAgICAgICAgICAgIGNhc2UgVW5oYW5kbGVkUHJvbXB0QmVoYXZp b3I6OkFjY2VwdDoKKyAgICAgICAgICAgICAgICBjYXBhYmlsaXRpZXNPYmplY3QtPnNldFN0cmlu ZygidW5oYW5kbGVkUHJvbXB0QmVoYXZpb3IiX3MsICJhY2NlcHQiKTsKKyAgICAgICAgICAgICAg ICBicmVhazsKKyAgICAgICAgICAgIGNhc2UgVW5oYW5kbGVkUHJvbXB0QmVoYXZpb3I6OkRpc21p c3NBbmROb3RpZnk6CisgICAgICAgICAgICAgICAgY2FwYWJpbGl0aWVzT2JqZWN0LT5zZXRTdHJp bmcoInVuaGFuZGxlZFByb21wdEJlaGF2aW9yIl9zLCAiZGlzbWlzcyBhbmQgbm90aWZ5Iik7Cisg ICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICBjYXNlIFVuaGFuZGxlZFByb21wdEJl aGF2aW9yOjpBY2NlcHRBbmROb3RpZnk6CisgICAgICAgICAgICAgICAgY2FwYWJpbGl0aWVzT2Jq ZWN0LT5zZXRTdHJpbmcoInVuaGFuZGxlZFByb21wdEJlaGF2aW9yIl9zLCAiYWNjZXB0IGFuZCBu b3RpZnkiKTsKKyAgICAgICAgICAgICAgICBicmVhazsKKyAgICAgICAgICAgIGNhc2UgVW5oYW5k bGVkUHJvbXB0QmVoYXZpb3I6Oklnbm9yZToKKyAgICAgICAgICAgICAgICBjYXBhYmlsaXRpZXNP YmplY3QtPnNldFN0cmluZygidW5oYW5kbGVkUHJvbXB0QmVoYXZpb3IiX3MsICJpZ25vcmUiKTsK KyAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgIH0KICAgICAgICAgICAgIHN3aXRj aCAoY2FwYWJpbGl0aWVzLnBhZ2VMb2FkU3RyYXRlZ3kudmFsdWVfb3IoUGFnZUxvYWRTdHJhdGVn eTo6Tm9ybWFsKSkgewogICAgICAgICAgICAgY2FzZSBQYWdlTG9hZFN0cmF0ZWd5OjpOb25lOgo=