188473 2018-08-10 10:01:38 -0700 webkit-patch setup-git-clone should set Git core editor to commit-log-editor 2018-08-10 14:49:17 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dbates dbates annulen ews-watchlist glenn lforschler rniwa webkit-bug-importer oldest_to_newest 1449295 0 dbates 2018-08-10 10:01:38 -0700 We should have "webkit-patch setup-git-clone" configure the Git core editor to use Tools/Scripts/commit-log-editor. This will ensure that the Git commit message will have the proper format for developers that choose to manually generate their ChangeLog using prepare-ChangeLog. 1449297 1 346907 dbates 2018-08-10 10:05:22 -0700 Created attachment 346907 Patch 1449381 2 346907 dbates 2018-08-10 14:48:45 -0700 Comment on attachment 346907 Patch Clearing flags on attachment: 346907 Committed r234770: <https://trac.webkit.org/changeset/234770> 1449382 3 dbates 2018-08-10 14:48:47 -0700 All reviewed patches have been landed. Closing bug. 1449383 4 webkit-bug-importer 2018-08-10 14:49:17 -0700 <rdar://problem/43157814> 346907 2018-08-10 10:05:22 -0700 2018-08-10 14:48:45 -0700 Patch bug-188473-20180810100522.patch text/plain 2245 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0NzAzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNWJlYWUyYTMxYmQzN2YyY2ZkZGY1MThlYjg2ODRiYWUx YjMwNjEyOC4uNDBkMDMyZDk3ZjJiNDJhNDFlNWJkMzdkMmFlYzI5NmE1ZjFhYjQ5OSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE4LTA4LTEwICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAg ICAgICB3ZWJraXQtcGF0Y2ggc2V0dXAtZ2l0LWNsb25lIHNob3VsZCBzZXQgR2l0IGNvcmUgZWRp dG9yIHRvIGNvbW1pdC1sb2ctZWRpdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xODg0NzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBIYXZlICJ3ZWJraXQtcGF0Y2ggc2V0dXAtZ2l0LWNsb25lIiBzZXQg dGhlIEdpdCBjb3JlIGVkaXRvciB0byAicGVybCBUb29scy9TY3JpcHRzL2NvbW1pdC1sb2ctZWRp dG9yIC0tcmVnZW5lcmF0ZS1sb2ciCisgICAgICAgIHNvIHRoYXQgdGhlIEdpdCBjb21taXQgbWVz c2FnZSBpcyBnZW5lcmF0ZWQgZnJvbSB0aGUgQ2hhbmdlTG9nIGZvciBkZXZlbG9wZXJzIHRoYXQg bWFudWFsbHkKKyAgICAgICAgZ2VuZXJhdGUgdGhlaXIgQ2hhbmdlTG9nIHVzaW5nIHByZXBhcmUt Q2hhbmdlTG9nLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3Nl dHVwZ2l0Y2xvbmUucHk6CisgICAgICAgIChTZXR1cEdpdENsb25lLmV4ZWN1dGUpOgorCiAyMDE4 LTA4LTA4ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAgICAgICAg IFtpT1NdIGZhc3QvZXZlbnRzL2lvcy9jb250ZW50ZWRpdGFibGUtYXV0b2NhcGl0YWxpemUuaHRt bCBpcyBhIGZsYWt5IGZhaWx1cmUKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv dG9vbC9jb21tYW5kcy9zZXR1cGdpdGNsb25lLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90 b29sL2NvbW1hbmRzL3NldHVwZ2l0Y2xvbmUucHkKaW5kZXggNTFmOGUxM2E0YmZhY2M0MjUzMGVj MjFhMmQ1MDQzZDBkYjIyZjYyYy4uODFiYjQ5OGJmNjAxNTU0NmVhNTRjZjIzZjdiODZhMzhjM2E2 MTE5OCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3Nl dHVwZ2l0Y2xvbmUucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRz L3NldHVwZ2l0Y2xvbmUucHkKQEAgLTQ2LDcgKzQ2LDcgQEAgY2xhc3MgU2V0dXBHaXRDbG9uZShD b21tYW5kKToKIAogICAgICAgICB1c2VybmFtZSwgZW1haWwgPSBzZWxmLl9nZXRfdXNlcm5hbWVf YW5kX2VtYWlsKHRvb2wpCiAKLSAgICAgICAgIyBGSVhNRTogV2Ugc2hvdWxkbid0IGJlIHVzaW5n IGEgcHJpdmF0ZCBtZXRob2QKKyAgICAgICAgIyBGSVhNRTogV2Ugc2hvdWxkbid0IGJlIHVzaW5n IGEgcHJpdmF0ZSBtZXRob2QuCiAgICAgICAgIHJ1bl9naXQgPSB0b29sLnNjbSgpLl9ydW5fZ2l0 CiAgICAgICAgIHJ1bl9naXQoWyJwdWxsIl0pCiAgICAgICAgIHJ1bl9naXQoWyJzdm4iLCAiaW5p dCIsICItLXByZWZpeD1vcmlnaW4vIiwgIi1UIiwgInRydW5rIiwgImh0dHA6Ly9zdm4ud2Via2l0 Lm9yZy9yZXBvc2l0b3J5L3dlYmtpdCJdKQpAQCAtNjAsNiArNjAsOCBAQCBjbGFzcyBTZXR1cEdp dENsb25lKENvbW1hbmQpOgogICAgICAgICBydW5fZ2l0KFsiY29uZmlnIiwgImRpZmYub2JqY3Bw LnhmdW5jbmFtZSIsICJeWy0rQGEtekEtWl9dLiokIl0pCiAgICAgICAgIHJ1bl9naXQoWyJjb25m aWciLCAiZGlmZi5vYmpjcHBoZWFkZXIueGZ1bmNuYW1lIiwgIl5bQGEtekEtWl9dLiokIl0pCiAK KyAgICAgICAgcnVuX2dpdChbImNvbmZpZyIsICJjb3JlLmVkaXRvciIsICJwZXJsIFRvb2xzL1Nj cmlwdHMvY29tbWl0LWxvZy1lZGl0b3IgLS1yZWdlbmVyYXRlLWxvZyJdKQorCiAgICAgICAgIGlm IHRvb2wudXNlci5jb25maXJtKCJEbyB5b3Ugd2FudCB0byBhdXRvLWNvbG9yIHN0YXR1cywgZGlm ZiwgYW5kIGJyYW5jaD8gKHkvbikiKToKICAgICAgICAgICAgIHJ1bl9naXQoWyJjb25maWciLCAi Y29sb3Iuc3RhdHVzIiwgImF1dG8iXSkKICAgICAgICAgICAgIHJ1bl9naXQoWyJjb25maWciLCAi Y29sb3IuZGlmZiIsICJhdXRvIl0pCg==