188468 2018-08-10 05:35:32 -0700 WebDriver: do not handle prompts that appear while running scripts 2018-08-12 23:48:28 -0700 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk, InRadar P2 Normal --- 1 cgarcia webkit-unassigned bburg webkit-bug-importer zan oldest_to_newest 1449258 0 cgarcia 2018-08-10 05:35:32 -0700 This changed in the spec, we should just finish the script without handling the alert at all. https://w3c.github.io/webdriver/#dfn-execute-a-function-body https://github.com/w3c/webdriver/commit/afb578090bc95718debeab6a6821da8d12b952c8 1449259 1 346902 cgarcia 2018-08-10 05:38:16 -0700 Created attachment 346902 Patch 1449577 2 cgarcia 2018-08-12 23:47:29 -0700 Committed r234792: <https://trac.webkit.org/changeset/234792> 1449578 3 webkit-bug-importer 2018-08-12 23:48:28 -0700 <rdar://problem/43219041> 346902 2018-08-10 05:38:16 -0700 2018-08-10 05:57:58 -0700 Patch wd-alerts-on-script.diff text/plain 1859 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkRyaXZl ci9DaGFuZ2VMb2cKaW5kZXggODI1ODQwYzljZWIuLmJkNDFkMmZhZjM2IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDIwIEBACisyMDE4LTA4LTEwICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNn YXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBXZWJEcml2ZXI6IGRvIG5vdCBoYW5kbGUgcHJv bXB0cyB0aGF0IGFwcGVhciB3aGlsZSBydW5uaW5nIHNjcmlwdHMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4ODQ2OAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgY2hhbmdlZCBpbiB0aGUgc3BlYywg d2Ugc2hvdWxkIGp1c3QgZmluaXNoIHRoZSBzY3JpcHQgd2l0aG91dCBoYW5kbGluZyB0aGUgYWxl cnQgYXQgYWxsLgorICAgICAgICBodHRwczovL2dpdGh1Yi5jb20vdzNjL3dlYmRyaXZlci9jb21t aXQvYWZiNTc4MDkwYmM5NTcxOGRlYmVhYjZhNjgyMWRhOGQxMmI5NTJjOAorCisgICAgICAgICJJ ZiBhdCBhbnkgcG9pbnQgZHVyaW5nIHRoZSBhbGdvcml0aG0gYSB1c2VyIHByb21wdCBhcHBlYXJz LCBhYm9ydCBhbGwgc3Vic2VxdWVudCBzdWJzdGVwcyBvZiB0aGlzIGFsZ29yaXRobSwKKyAgICAg ICAgYW5kIHJldHVybiBzdWNjZXNzIHdpdGggZGF0YSBudWxsLiIKKyAgICAgICAgaHR0cHM6Ly93 M2MuZ2l0aHViLmlvL3dlYmRyaXZlci8jZGZuLWV4ZWN1dGUtYS1mdW5jdGlvbi1ib2R5CisKKyAg ICAgICAgKiBTZXNzaW9uLmNwcDoKKyAgICAgICAgKFdlYkRyaXZlcjo6U2Vzc2lvbjo6ZXhlY3V0 ZVNjcmlwdCk6CisKIDIwMTgtMDgtMTAgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBp Z2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdW1dQRV0gV2ViRHJpdmVyOiBkbyBub3QgdXNlIGRl ZmF1bHQgYnJvd3NlciBhcmd1bWVudHMgd2hlbiBicm93c2VyIGJpbmFyeSBoYXMgYmVlbiBwcm92 aWRlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkRyaXZlci9TZXNzaW9uLmNwcCBiL1NvdXJjZS9X ZWJEcml2ZXIvU2Vzc2lvbi5jcHAKaW5kZXggYmZjNzM4MDFlZWQuLmU3NjY1ODViZDBhIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViRHJpdmVyL1Nlc3Npb24uY3BwCisrKyBiL1NvdXJjZS9XZWJEcml2 ZXIvU2Vzc2lvbi5jcHAKQEAgLTE4NTksNyArMTg1OSw3IEBAIHZvaWQgU2Vzc2lvbjo6ZXhlY3V0 ZVNjcmlwdChjb25zdCBTdHJpbmcmIHNjcmlwdCwgUmVmUHRyPEpTT046OkFycmF5PiYmIGFyZ3Vt ZW50CiAgICAgICAgICAgICBpZiAocmVzcG9uc2UuaXNFcnJvciB8fCAhcmVzcG9uc2UucmVzcG9u c2VPYmplY3QpIHsKICAgICAgICAgICAgICAgICBhdXRvIHJlc3VsdCA9IENvbW1hbmRSZXN1bHQ6 OmZhaWwoV1RGTW92ZShyZXNwb25zZS5yZXNwb25zZU9iamVjdCkpOwogICAgICAgICAgICAgICAg IGlmIChyZXN1bHQuZXJyb3JDb2RlKCkgPT0gQ29tbWFuZFJlc3VsdDo6RXJyb3JDb2RlOjpVbmV4 cGVjdGVkQWxlcnRPcGVuKQotICAgICAgICAgICAgICAgICAgICBoYW5kbGVVbmV4cGVjdGVkQWxl cnRPcGVuKFdURk1vdmUoY29tcGxldGlvbkhhbmRsZXIpKTsKKyAgICAgICAgICAgICAgICAgICAg Y29tcGxldGlvbkhhbmRsZXIoQ29tbWFuZFJlc3VsdDo6c3VjY2VzcygpKTsKICAgICAgICAgICAg ICAgICBlbHNlCiAgICAgICAgICAgICAgICAgICAgIGNvbXBsZXRpb25IYW5kbGVyKFdURk1vdmUo cmVzdWx0KSk7CiAgICAgICAgICAgICAgICAgcmV0dXJuOwo=